date:20110707

[jira] [Created] (HIVE-2270) Hive should not call methods from org.apache.hadoop.mapred.JobTracker

2011-07-07 Thread Amareshwari Sriramadasu (JIRA)

Hive should not call methods from org.apache.hadoop.mapred.JobTracker
-

 Key: HIVE-2270
 URL: https://issues.apache.org/jira/browse/HIVE-2270
 Project: Hive
  Issue Type: Bug
Reporter: Amareshwari Sriramadasu
Assignee: Amareshwari Sriramadasu


Currently Hive calls getAddress() and getState() api from 
org.apache.hadoop.mapred.JobTracker. These should be replaced with client-side 
ones if any, since the class is private(annotated) to hadoop.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HIVE-2271) InConsistency between Infomation Document and Actual Behavior for Built In Aggregate Functions(UDAF) Return Type.

2011-07-07 Thread rohithsharma (JIRA)

InConsistency between Infomation Document and Actual Behavior for Built In 
Aggregate Functions(UDAF) Return Type. 
--

 Key: HIVE-2271
 URL: https://issues.apache.org/jira/browse/HIVE-2271
 Project: Hive
  Issue Type: Bug
  Components: Documentation, Query Processor
Affects Versions: 0.7.1, 0.7.0, 0.6.0, 0.5.0
 Environment: SuSE-Linux-11
Reporter: rohithsharma


I followed the Information Document for executing UDAF like 
MIN(),MAX(),SUM(),AVG() and COUNT() below link.

[https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF#LanguageManualUDF-BuiltinAggregateFunctions%28UDAF%29]
 

Observed mismatch for RETURN TYPE mentioned in Information Document and Actual 
Behavior.

1.) Return Type for min(colName),max(colName) is mentioned as DOUBLE,but while 
retrieving it is returning colName DataType passed to Min()/Max().


Ex:
1).create table test(a int,b smallint,c string);
2).select min(a) from test;
3).ResultSet.getMetaData ().getColumnTypeName ( 1 )
  Output : int
  Expected : double(According to InformationDoc)


2.) Return Type for sum(colName) is mentioned as DOUBLE,but while retrieving it 
is always returning as BIGINT

Ex:
1).create table test(a int,b smallint,c string);
2).select sum(a) from test;
3).ResultSet.getMetaData ().getColumnTypeName ( 1 )
  Output : BIGINT
  Expected : double(According to InformationDoc)









--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2269) Hive --auxpath option can't handle multiple colon separated values

2011-07-07 Thread Edward Capriolo (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061295#comment-13061295
 ] 

Edward Capriolo commented on HIVE-2269:
---

I am someone confused by the title, auxpath is 'comma' separate but the title 
says 'colon'.

> Hive --auxpath option can't handle multiple colon separated values
> --
>
> Key: HIVE-2269
> URL: https://issues.apache.org/jira/browse/HIVE-2269
> Project: Hive
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 0.7.0, 0.7.1
>Reporter: Carl Steinbach
>Assignee: Carl Steinbach
> Attachments: HIVE-2269-auxpath.1.patch.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Build failed in Jenkins: Hive-trunk-h0.21 #814

2011-07-07 Thread Apache Jenkins Server

See 

--
[...truncated 4740 lines...]
create-dirs:

init:

compile:
 [echo] Compiling: anttasks
[javac] 
:40: 
warning: 'includeantruntime' was not set, defaulting to 
build.sysclasspath=last; set to false for repeatable builds

deploy-ant-tasks:

create-dirs:

init:

compile:
 [echo] Compiling: anttasks
[javac] 
:40: 
warning: 'includeantruntime' was not set, defaulting to 
build.sysclasspath=last; set to false for repeatable builds

jar:

init:

dynamic-serde:

ivy-init-dirs:

ivy-download:
  [get] Getting: 
http://repo2.maven.org/maven2/org/apache/ivy/ivy/2.1.0/ivy-2.1.0.jar
  [get] To: 

  [get] Not modified - so not downloaded

ivy-probe-antlib:

ivy-init-antlib:

ivy-init:

ivy-resolve:
[ivy:resolve] :: loading settings :: file = 


ivy-retrieve:

compile:
 [echo] Compiling: hive
[javac] 
:52: 
warning: 'includeantruntime' was not set, defaulting to 
build.sysclasspath=last; set to false for repeatable builds
[javac] Compiling 236 source files to 

[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] Creating empty 


jar:
 [echo] Jar: serde
  [jar] Building jar: 


create-dirs:
[mkdir] Created dir: 

[mkdir] Created dir: 

[mkdir] Created dir: 

[mkdir] Created dir: 

[mkdir] Created dir: 


compile-ant-tasks:

create-dirs:

init:

compile:
 [echo] Compiling: anttasks
[javac] 
:40: 
warning: 'includeantruntime' was not set, defaulting to 
build.sysclasspath=last; set to false for repeatable builds

deploy-ant-tasks:

create-dirs:

init:

compile:
 [echo] Compiling: anttasks
[javac] 
:40: 
warning: 'includeantruntime' was not set, defaulting to 
build.sysclasspath=last; set to false for repeatable builds

jar:

init:

metastore-init:
[mkdir] Created dir: 


build-grammar:
 [echo] Building Grammar 

  
 [java] ANTLR Parser Generator  Version 3.0.1 (August 13, 2007)  1989-2007

model-compile:
[javac] 
:69:
 warning: 'includeantruntime' was not set, defaulting to 
build.sysclasspath=last; set to false for repeatable builds
[javac] Compiling 18 source files to 

 [copy] Copying 1 file to 


ivy-init-dirs:

ivy-download:
  [get] Getting: 
http://repo2.maven.org/maven2/org/apache/ivy/ivy/2.1.0/ivy-2.1.0.jar
  [get] To: 

  [get] Not modified - so not downloaded

ivy-probe-antlib:

ivy-init-antlib:

ivy-init:

ivy-resolve:
[ivy:resolve] :: loading settings :: file = 


ivy-retrieve:

core-compile:
 [echo] Compiling: 
[javac] 
:60:
 warning: 'includeantruntime' was not set, defaulting to 
build.sysclasspath=last; set to false for repeatable builds
[javac] Compiling 65 source files to

[jira] [Commented] (HIVE-2269) Hive --auxpath option can't handle multiple colon separated values

2011-07-07 Thread Carl Steinbach (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061455#comment-13061455
 ] 

Carl Steinbach commented on HIVE-2269:
--

bq. auxpath is 'comma' separate but the title says 'colon'

@Ed: Where is this documented? Regardless, with this patch the value supplied 
to --auxpath can be either comma or colon separated.

> Hive --auxpath option can't handle multiple colon separated values
> --
>
> Key: HIVE-2269
> URL: https://issues.apache.org/jira/browse/HIVE-2269
> Project: Hive
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 0.7.0, 0.7.1
>Reporter: Carl Steinbach
>Assignee: Carl Steinbach
> Attachments: HIVE-2269-auxpath.1.patch.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2224) Ability to add_partitions, and atomically

2011-07-07 Thread John Sichi (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061471#comment-13061471
 ] 

John Sichi commented on HIVE-2224:
--

When you create the review board entry, be sure to specify the JIRA issue 
number so that it will populate the comments here with links and other info.

> Ability to add_partitions, and atomically
> -
>
> Key: HIVE-2224
> URL: https://issues.apache.org/jira/browse/HIVE-2224
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Reporter: Sushanth Sowmyan
>Assignee: Sushanth Sowmyan
> Attachments: HIVE-2224.patch
>
>
> I'd like to see an atomic version of the add_partitions() call.
> Whether this is to be done by config to affect add_partitions() behaviour 
> (not my preference) or just changing add_partitions() default behaviour (my 
> preference, but likely to affect current behaviour, so will need others' 
> input) or by making a new add_partitions_atomic() call depends on discussion.
> This looks relatively doable to implement (will need a dependent 
> add_partition_core to not do a ms.commit_partition() early, and to cache list 
> of directories created to remove on rollback, and a list of AddPartitionEvent 
> to trigger in one shot later)
> Thoughts? This also seems like something to implement for allowing HIVE-1805.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2224) Ability to add_partitions, and atomically

2011-07-07 Thread John Sichi (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061472#comment-13061472
 ] 

John Sichi commented on HIVE-2224:
--

Sushanth, please fill in the "Bugs" field to make the link.

https://reviews.apache.org/r/999/

> Ability to add_partitions, and atomically
> -
>
> Key: HIVE-2224
> URL: https://issues.apache.org/jira/browse/HIVE-2224
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Reporter: Sushanth Sowmyan
>Assignee: Sushanth Sowmyan
> Attachments: HIVE-2224.patch
>
>
> I'd like to see an atomic version of the add_partitions() call.
> Whether this is to be done by config to affect add_partitions() behaviour 
> (not my preference) or just changing add_partitions() default behaviour (my 
> preference, but likely to affect current behaviour, so will need others' 
> input) or by making a new add_partitions_atomic() call depends on discussion.
> This looks relatively doable to implement (will need a dependent 
> add_partition_core to not do a ms.commit_partition() early, and to cache list 
> of directories created to remove on rollback, and a list of AddPartitionEvent 
> to trigger in one shot later)
> Thoughts? This also seems like something to implement for allowing HIVE-1805.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2261) Add cleanup stages for UDFs

2011-07-07 Thread John Sichi (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061473#comment-13061473
 ] 

John Sichi commented on HIVE-2261:
--

I think we should put in some of the common base class changes from HIVE-1016 
before implementing this.


> Add cleanup stages for UDFs
> ---
>
> Key: HIVE-2261
> URL: https://issues.apache.org/jira/browse/HIVE-2261
> Project: Hive
>  Issue Type: Wish
>  Components: Query Processor
>Reporter: Navis
>Priority: Trivial
>
> In some cases, we bind values at last stage of big SQL from other sources, 
> especially from memcached. I made that kind of UDFs for internal-use.
> I found 'initialize' method of GenericUDF class is good place for making 
> connections to memcached cluster, but failed to find  somewhere to 
> close/cleanup the connections. If there is cleaup method in GenericUDF class, 
> things can be more neat. If initializing entity like map/reduce/fetch could 
> be also providable to life-cycles(init/close), that makes perfect.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HIVE-2272) add TIMESTAMP data type

2011-07-07 Thread Franklin Hu (JIRA)

add TIMESTAMP data type
---

 Key: HIVE-2272
 URL: https://issues.apache.org/jira/browse/HIVE-2272
 Project: Hive
  Issue Type: New Feature
Reporter: Franklin Hu
Assignee: Franklin Hu


Add TIMESTAMP type to serde2 that supports unix timestamp (1970-01-01 00:00:01 
UTC to 2038-01-19 03:14:07 UTC) with optional nanosecond precision using both 
LazyBinary and LazySimple SerDes. 
For LazySimpleSerDe, the data is stored in jdbc compliant java.sql.Timestamp 
parsable strings.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-2272) add TIMESTAMP data type

2011-07-07 Thread Franklin Hu (JIRA)


 [ 
https://issues.apache.org/jira/browse/HIVE-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Franklin Hu updated HIVE-2272:
--

Attachment: hive-2272.1.patch

> add TIMESTAMP data type
> ---
>
> Key: HIVE-2272
> URL: https://issues.apache.org/jira/browse/HIVE-2272
> Project: Hive
>  Issue Type: New Feature
>Reporter: Franklin Hu
>Assignee: Franklin Hu
> Attachments: hive-2272.1.patch
>
>
> Add TIMESTAMP type to serde2 that supports unix timestamp (1970-01-01 
> 00:00:01 UTC to 2038-01-19 03:14:07 UTC) with optional nanosecond precision 
> using both LazyBinary and LazySimple SerDes. 
> For LazySimpleSerDe, the data is stored in jdbc compliant java.sql.Timestamp 
> parsable strings.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2253) Merge failing of join tree in exceptional case

2011-07-07 Thread John Sichi (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061479#comment-13061479
 ] 

John Sichi commented on HIVE-2253:
--

If this patch is ready for review, click the Submit Patch button.

> Merge failing of join tree in exceptional case
> --
>
> Key: HIVE-2253
> URL: https://issues.apache.org/jira/browse/HIVE-2253
> Project: Hive
>  Issue Type: Bug
>  Components: Query Processor
>Affects Versions: 0.7.0
> Environment: hadoop 0.20.2, hive 0.7.0
>Reporter: Navis
>Priority: Minor
> Attachments: HIVE-2253.2.patch, HIVE-2253.patch
>
>
> In some very exceptional cases, SemanticAnayzer fails to merge join tree. 
> Example is below.
> create table a (val1 int, val2 int)
> create table b (val1 int, val2 int)
> create table c (val1 int, val2 int)
> create table d (val1 int, val2 int)
> create table e (val1 int, val2 int)
> 1. all same(single) join key --> one MR, good
> select * from a join b on a.val1=b.val1 join c on a.val1=c.val1 join d on 
> a.val1=d.val1 join e on a.val1=e.val1
> 2. two join keys --> expected to have two MR, but resulted to three MR
> select * from a join b on a.val1=b.val1 join c on a.val1=c.val1 join d on 
> a.val1=d.val1 join e on a.val2=e.val2
> 3. by changing the join order, we could attain two MR as first-expectation.
> select * from a join e on a.val2=e.val2 join c on a.val1=c.val1 join d on 
> a.val1=d.val1 join b on a.val1=b.val1

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-1884) Potential risk of resource leaks in Hive

2011-07-07 Thread John Sichi (JIRA)


 [ 
https://issues.apache.org/jira/browse/HIVE-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Sichi updated HIVE-1884:
-

Status: Open  (was: Patch Available)

Sorry, this one has gone stale again...could you rebase against trunk?


> Potential risk of resource leaks in Hive
> 
>
> Key: HIVE-1884
> URL: https://issues.apache.org/jira/browse/HIVE-1884
> Project: Hive
>  Issue Type: Bug
>  Components: CLI, Metastore, Query Processor, Server Infrastructure
>Affects Versions: 0.6.0, 0.5.0, 0.4.1, 0.4.0, 0.3.0
> Environment: Hive 0.6.0, Hadoop 0.20.1
> SUSE Linux Enterprise Server 11 (i586)
>Reporter: Mohit Sikri
>Assignee: Chinna Rao Lalam
> Attachments: HIVE-1884.1.PATCH, HIVE-1884.2.patch
>
>
> h3.There are couple of resource leaks.
> h4.For example,
> In CliDriver.java, Method :- processReader() the buffered reader is not 
> closed.
> h3.Also there are risk(s) of  resource(s) getting leaked , in such cases we 
> need to re factor the code to move closing of resources in finally block.
> h4. For Example :- 
> In Throttle.java   Method:- checkJobTracker() , the following code snippet 
> might cause resource leak.
> {code}
> InputStream in = url.openStream();
> in.read(buffer);
> in.close();
> {code}
> Ideally and as per the best coding practices it should be like below
> {code}
> InputStream in=null;
> try   {
> in = url.openStream();
> int numRead = in.read(buffer);
> }
> finally {
>IOUtils.closeStream(in);
> }
> {code}
> Similar cases, were found in ExplainTask.java, DDLTask.java etc.Need to re 
> factor all such occurrences.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-2111) NullPointerException on select * with table using RegexSerDe and partitions

2011-07-07 Thread John Sichi (JIRA)


 [ 
https://issues.apache.org/jira/browse/HIVE-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Sichi updated HIVE-2111:
-

Status: Open  (was: Patch Available)

Sorry, this one has gone stale...could you rebase against trunk?

> NullPointerException on select * with table using RegexSerDe and partitions
> ---
>
> Key: HIVE-2111
> URL: https://issues.apache.org/jira/browse/HIVE-2111
> Project: Hive
>  Issue Type: Bug
>  Components: Serializers/Deserializers
>Affects Versions: 0.7.0
> Environment: Amazon Elastic Mapreduce
>Reporter: Marc Harris
>Assignee: Chinna Rao Lalam
> Attachments: HIVE-2111.patch
>
>
> When querying against a table that is partitioned, and uses RegexSerde, 
> select with explicit columns works, but "select *" results in a 
> NullPointerException
> To reproduce:
> 1) create a table containing the following text (notice the blank line):
> start
> fillerdatafillerdatafiller
> fillerdata2fillerdata2filler
> =end=
> 2) copy the file to hdfs:
> hadoop dfs -put foo.txt test/part1=x/foo.txt
> 3) run the following hive commands to create a table:
> add jar s3://elasticmapreduce/samples/hive/jars/hive_contrib.jar;
> drop table test;
> create external table test(col1 STRING, col2 STRING) 
> partitioned by (part1 STRING) 
> row format serde 'org.apache.hadoop.hive.contrib.serde2.RegexSerDe' 
> with serdeproperties ( "input.regex" = "^\(.*data\)\(.*data\).*$") 
> stored as textfile 
> location 'hdfs:///user/hadoop/test';
> alter table test add partition (part1='x');
> (Note that the text processor seems to have mangled the regex a bit. Inside 
> each pair of parentheses should be dot star data. After the second pair of 
> parentheses should be dot start dollar).
> 4) select from it with explicit columns:
> select part1, col1, col2 from test;
> outputs:
> OK
> x fillerdata  fillerdata
> x NULLNULL
> x fillerdata  2fillerdata
> 5) select from it with * columns
> select * from test;
> outputs:
> Failed with exception java.io.IOException:java.lang.NullPointerException
> 11/04/12 14:28:27 ERROR CliDriver: Failed with exception 
> java.io.IOException:java.lang.NullPointerException
> java.io.IOException: java.lang.NullPointerException
>   at org.apache.hadoop.hive.ql.exec.FetchTask.fetch(FetchTask.java:149)
>   at org.apache.hadoop.hive.ql.Driver.getResults(Driver.java:1039)
>   at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:172)
>   at 
> org.apache.hadoop.hive.cli.CliDriver.processLineInternal(CliDriver.java:228)
>   at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:209)
>   at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:398)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>   at java.lang.reflect.Method.invoke(Method.java:597)
>   at org.apache.hadoop.util.RunJar.main(RunJar.java:156)
> Caused by: java.lang.NullPointerException
>   at java.util.ArrayList.addAll(ArrayList.java:472)
>   at 
> org.apache.hadoop.hive.serde2.objectinspector.UnionStructObjectInspector.getStructFieldsDataAsList(UnionStructObjectInspector.java:144)
>   at 
> org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe.serialize(LazySimpleSerDe.java:357)
>   at org.apache.hadoop.hive.ql.exec.FetchTask.fetch(FetchTask.java:141)
>   ... 10 more

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2269) Hive --auxpath option can't handle multiple colon separated values

2011-07-07 Thread Edward Capriolo (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061513#comment-13061513
 ] 

Edward Capriolo commented on HIVE-2269:
---

I am not sure this is documented anywhere. As a hadoop historian, I am guessing 
',' was chosen to avoid the separator/path separator differences on different 
OS's. I do not see a problem supporting columns other then how it might effect 
the dedicated cygwin/hive users.   

> Hive --auxpath option can't handle multiple colon separated values
> --
>
> Key: HIVE-2269
> URL: https://issues.apache.org/jira/browse/HIVE-2269
> Project: Hive
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 0.7.0, 0.7.1
>Reporter: Carl Steinbach
>Assignee: Carl Steinbach
> Attachments: HIVE-2269-auxpath.1.patch.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-2184) Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()

2011-07-07 Thread John Sichi (JIRA)


 [ 
https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Sichi updated HIVE-2184:
-

Status: Open  (was: Patch Available)

Sorry, this one has gone stale...could you rebase against trunk?


> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> ---
>
> Key: HIVE-2184
> URL: https://issues.apache.org/jira/browse/HIVE-2184
> Project: Hive
>  Issue Type: Bug
>  Components: Metastore
>Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise 
> Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
>Reporter: Chinna Rao Lalam
>Assignee: Chinna Rao Lalam
> Attachments: HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the 
> variable "standAloneClient" is never become true then client.shutdown() never 
> call.
> 2)Hive.close() After calling metaStoreClient.close() need to make 
> metaStoreClient=null

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-2183) In Task class and its subclasses logger is initialized in constructor

2011-07-07 Thread John Sichi (JIRA)


 [ 
https://issues.apache.org/jira/browse/HIVE-2183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Sichi updated HIVE-2183:
-

Status: Open  (was: Patch Available)

Sorry, this one has gone stale...could you rebase against trunk?

> In Task class and its subclasses logger is initialized in constructor
> -
>
> Key: HIVE-2183
> URL: https://issues.apache.org/jira/browse/HIVE-2183
> Project: Hive
>  Issue Type: Bug
>  Components: Query Processor
>Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise 
> Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
>Reporter: Chinna Rao Lalam
>Assignee: Chinna Rao Lalam
>Priority: Minor
> Attachments: HIVE-2183.patch
>
>
> In Task class and its subclasses logger is initialized in constructor. Log 
> object no need to initialize every time in the constructor, Log object can 
> make it as static object.
> {noformat}
> Ex:
>   public ExecDriver() {
> super();
> LOG = LogFactory.getLog(this.getClass().getName());
> console = new LogHelper(LOG);
> this.jobExecHelper = new HadoopJobExecHelper(job, console, this, this);
>   }
> {noformat}
> Need to change like this
> {noformat}
> private static final Log LOG = LogFactory.getLog(ExecDriver.class);
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2269) Hive --auxpath option can't handle multiple colon separated values

2011-07-07 Thread Edward Capriolo (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061520#comment-13061520
 ] 

Edward Capriolo commented on HIVE-2269:
---

Also it seems that the AUX_PATH is being specified as URI's. 

{noformat}
https://github.com/riptano/hive/wiki/Cassandra-Handler-usage-in-Hive-0.7-with-Cassandra-0.7
{noformat}


{noformat}
 hive.aux.jars.path 
file:///path/to/guava-r05.jar,file:///path/to/commons-lang-2.4.jar,file:///path/to/apache-cassandra-0.7.6.jar,file:///path/to/hive-cassandra-handler-0.7.0-beta1.jar
 
{noformat}

So splitting on ':' could break URI's?

> Hive --auxpath option can't handle multiple colon separated values
> --
>
> Key: HIVE-2269
> URL: https://issues.apache.org/jira/browse/HIVE-2269
> Project: Hive
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 0.7.0, 0.7.1
>Reporter: Carl Steinbach
>Assignee: Carl Steinbach
> Attachments: HIVE-2269-auxpath.1.patch.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-2080) Few code improvements in the ql and serde packages.

2011-07-07 Thread John Sichi (JIRA)


 [ 
https://issues.apache.org/jira/browse/HIVE-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Sichi updated HIVE-2080:
-

Status: Open  (was: Patch Available)

Sorry, this one has gone stale...could you rebase against trunk?


> Few code improvements in the ql and serde packages.
> ---
>
> Key: HIVE-2080
> URL: https://issues.apache.org/jira/browse/HIVE-2080
> Project: Hive
>  Issue Type: Bug
>  Components: Query Processor, Serializers/Deserializers
>Affects Versions: 0.7.0
> Environment: Hadoop 0.20.1, Hive0.7.0 and SUSE Linux Enterprise 
> Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5).
>Reporter: Chinna Rao Lalam
>Assignee: Chinna Rao Lalam
> Attachments: HIVE-2080.Patch
>
>
> Few code improvements in the ql and serde packages.
> 1) Little performance Improvements 
> 2) Null checks to avoid NPEs
> 3) Effective varaible management.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Review Request: HIVE-2256: Better error message in CLI on invalid column name

2011-07-07 Thread Sohan Jain


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1031/
---

Review request for hive.


Summary
---

In the CLI, if a user inputs an incorrect column name, we currently just print 
the bad column name in the query. Typically, the user needs to "describe" the 
table to figure out the correct column.

This patch prints out a list of valid column and partition names in the table 
when a user inputs an incorrect column name.

e.g., 
Error in semantic analysis: Invalid table alias or column reference 
'col_does_not_exist' (possible column names are: col1, col2)


This addresses bug HIVE-2256.
https://issues.apache.org/jira/browse/HIVE-2256


Diffs
-

  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 1140399 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 
1140399 
  trunk/ql/src/test/results/clientnegative/clustern4.q.out 1140399 
  trunk/ql/src/test/results/clientnegative/input2.q.out 1140399 
  trunk/ql/src/test/results/clientnegative/regex_col_groupby.q.out 1140399 
  trunk/ql/src/test/results/clientnegative/semijoin1.q.out 1140399 
  trunk/ql/src/test/results/clientnegative/semijoin2.q.out 1140399 
  trunk/ql/src/test/results/clientnegative/semijoin3.q.out 1140399 
  trunk/ql/src/test/results/clientnegative/semijoin4.q.out 1140399 
  trunk/ql/src/test/results/compiler/errors/unknown_column4.q.out 1140399 
  trunk/ql/src/test/results/compiler/errors/unknown_column5.q.out 1140399 

Diff: https://reviews.apache.org/r/1031/diff


Testing
---

Checked the outputs of relevant unit tests, and they looks good.


Thanks,

Sohan

[jira] [Commented] (HIVE-2256) Better error message in CLI on invalid column name

2011-07-07 Thread jirapos...@reviews.apache.org (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061586#comment-13061586
 ] 

jirapos...@reviews.apache.org commented on HIVE-2256:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1031/
---

Review request for hive.


Summary
---

In the CLI, if a user inputs an incorrect column name, we currently just print 
the bad column name in the query. Typically, the user needs to "describe" the 
table to figure out the correct column.

This patch prints out a list of valid column and partition names in the table 
when a user inputs an incorrect column name.

e.g., 
Error in semantic analysis: Invalid table alias or column reference 
'col_does_not_exist' (possible column names are: col1, col2)


This addresses bug HIVE-2256.
https://issues.apache.org/jira/browse/HIVE-2256


Diffs
-

  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 1140399 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 
1140399 
  trunk/ql/src/test/results/clientnegative/clustern4.q.out 1140399 
  trunk/ql/src/test/results/clientnegative/input2.q.out 1140399 
  trunk/ql/src/test/results/clientnegative/regex_col_groupby.q.out 1140399 
  trunk/ql/src/test/results/clientnegative/semijoin1.q.out 1140399 
  trunk/ql/src/test/results/clientnegative/semijoin2.q.out 1140399 
  trunk/ql/src/test/results/clientnegative/semijoin3.q.out 1140399 
  trunk/ql/src/test/results/clientnegative/semijoin4.q.out 1140399 
  trunk/ql/src/test/results/compiler/errors/unknown_column4.q.out 1140399 
  trunk/ql/src/test/results/compiler/errors/unknown_column5.q.out 1140399 

Diff: https://reviews.apache.org/r/1031/diff


Testing
---

Checked the outputs of relevant unit tests, and they looks good.


Thanks,

Sohan



> Better error message in CLI on invalid column name
> --
>
> Key: HIVE-2256
> URL: https://issues.apache.org/jira/browse/HIVE-2256
> Project: Hive
>  Issue Type: Improvement
>  Components: CLI, Query Processor
>Reporter: Sohan Jain
>Assignee: Sohan Jain
> Attachments: HIVE-2256.1.patch, HIVE-2256.2.patch
>
>
> In the CLI, if a user inputs an incorrect column name, we currently just 
> print the bad column name in the query.  Typically, the user needs to 
> "describe" the table to figure out the correct column.
> This patch prints out a list of valid column and partition names in the table 
> when a user inputs an incorrect column name.
> e.g., 
> {{Error in semantic analysis: Invalid table alias or column reference 
> 'col_does_not_exist' (possible column names are: col1, col2)}}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-2256) Better error message in CLI on invalid column name

2011-07-07 Thread Sohan Jain (JIRA)


 [ 
https://issues.apache.org/jira/browse/HIVE-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sohan Jain updated HIVE-2256:
-

Status: Patch Available  (was: Open)

> Better error message in CLI on invalid column name
> --
>
> Key: HIVE-2256
> URL: https://issues.apache.org/jira/browse/HIVE-2256
> Project: Hive
>  Issue Type: Improvement
>  Components: CLI, Query Processor
>Reporter: Sohan Jain
>Assignee: Sohan Jain
> Attachments: HIVE-2256.1.patch, HIVE-2256.2.patch
>
>
> In the CLI, if a user inputs an incorrect column name, we currently just 
> print the bad column name in the query.  Typically, the user needs to 
> "describe" the table to figure out the correct column.
> This patch prints out a list of valid column and partition names in the table 
> when a user inputs an incorrect column name.
> e.g., 
> {{Error in semantic analysis: Invalid table alias or column reference 
> 'col_does_not_exist' (possible column names are: col1, col2)}}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-2210) ALTER VIEW RENAME

2011-07-07 Thread Charles Chen (JIRA)


 [ 
https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles Chen updated HIVE-2210:
---

Status: Patch Available  (was: Open)

Adds ALTER TABLE RENAME

> ALTER VIEW RENAME
> -
>
> Key: HIVE-2210
> URL: https://issues.apache.org/jira/browse/HIVE-2210
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Affects Versions: 0.6.0
>Reporter: John Sichi
>Assignee: John Sichi
> Attachments: altertablediff3.txt
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW 
> RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-2210) ALTER VIEW RENAME

2011-07-07 Thread Charles Chen (JIRA)


 [ 
https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles Chen updated HIVE-2210:
---

Attachment: altertablediff3.txt

> ALTER VIEW RENAME
> -
>
> Key: HIVE-2210
> URL: https://issues.apache.org/jira/browse/HIVE-2210
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Affects Versions: 0.6.0
>Reporter: John Sichi
>Assignee: John Sichi
> Attachments: altertablediff3.txt
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW 
> RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-2210) ALTER VIEW RENAME

2011-07-07 Thread Charles Chen (JIRA)


 [ 
https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles Chen updated HIVE-2210:
---

Attachment: (was: altertablediff3.txt)

> ALTER VIEW RENAME
> -
>
> Key: HIVE-2210
> URL: https://issues.apache.org/jira/browse/HIVE-2210
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Affects Versions: 0.6.0
>Reporter: John Sichi
>Assignee: John Sichi
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW 
> RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-2210) ALTER VIEW RENAME

2011-07-07 Thread Charles Chen (JIRA)


 [ 
https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles Chen updated HIVE-2210:
---

Attachment: HIVE-2210v0.patch

> ALTER VIEW RENAME
> -
>
> Key: HIVE-2210
> URL: https://issues.apache.org/jira/browse/HIVE-2210
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Affects Versions: 0.6.0
>Reporter: John Sichi
>Assignee: John Sichi
> Attachments: HIVE-2210v0.patch
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW 
> RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (HIVE-2210) ALTER VIEW RENAME

2011-07-07 Thread Charles Chen (JIRA)


 [ 
https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles Chen reassigned HIVE-2210:
--

Assignee: Charles Chen  (was: John Sichi)

> ALTER VIEW RENAME
> -
>
> Key: HIVE-2210
> URL: https://issues.apache.org/jira/browse/HIVE-2210
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Affects Versions: 0.6.0
>Reporter: John Sichi
>Assignee: Charles Chen
> Attachments: HIVE-2210v0.patch
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW 
> RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-1996) "LOAD DATA INPATH" fails when the table already contains a file of the same name

2011-07-07 Thread John Sichi (JIRA)


 [ 
https://issues.apache.org/jira/browse/HIVE-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Sichi updated HIVE-1996:
-

Status: Open  (was: Patch Available)

I tried running the test, but it fails for me.  I looked in hive.log and found

{noformat}
2011-07-07 14:45:34,359 ERROR hive.log 
(MetaStoreUtils.java:logAndThrowMetaException(778)) - 
java.io.FileNotFoundException: File file:/tmp1/load2_overwrite2 does not exist.
{noformat}


> "LOAD DATA INPATH" fails when the table already contains a file of the same 
> name
> 
>
> Key: HIVE-1996
> URL: https://issues.apache.org/jira/browse/HIVE-1996
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 0.7.0
>Reporter: Kirk True
>Assignee: Chinna Rao Lalam
> Attachments: HIVE-1996.Patch
>
>
> Steps:
> 1. From the command line copy the kv2.txt data file into the current user's 
> HDFS directory:
> {{$ hadoop fs -copyFromLocal /path/to/hive/sources/data/files/kv2.txt 
> kv2.txt}}
> 2. In Hive, create the table:
> {{create table tst_src1 (key_ int, value_ string);}}
> 3. Load the data into the table from HDFS:
> {{load data inpath './kv2.txt' into table tst_src1;}}
> 4. Repeat step 1
> 5. Repeat step 3
> Expected:
> To have kv2.txt renamed in HDFS and then copied to the destination as per 
> HIVE-307.
> Actual:
> File is renamed, but {{Hive.copyFiles}} doesn't "see" the change in {{srcs}} 
> as it continues to use the same array elements (with the un-renamed, old file 
> names). It crashes with this error:
> {noformat}
> java.lang.NullPointerException
> at org.apache.hadoop.hive.ql.metadata.Hive.copyFiles(Hive.java:1725)
> at org.apache.hadoop.hive.ql.metadata.Table.copyFiles(Table.java:541)
> at org.apache.hadoop.hive.ql.metadata.Hive.loadTable(Hive.java:1173)
> at org.apache.hadoop.hive.ql.exec.MoveTask.execute(MoveTask.java:197)
> at org.apache.hadoop.hive.ql.exec.Task.executeTask(Task.java:130)
> at 
> org.apache.hadoop.hive.ql.exec.TaskRunner.runSequential(TaskRunner.java:57)
> at org.apache.hadoop.hive.ql.Driver.launchTask(Driver.java:1060)
> at org.apache.hadoop.hive.ql.Driver.execute(Driver.java:897)
> at org.apache.hadoop.hive.ql.Driver.run(Driver.java:745)
> at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:164)
> at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:241)
> at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:456)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.hadoop.util.RunJar.main(RunJar.java:156)
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Review Request: HIVE-2045

2011-07-07 Thread John Sichi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1035/
---

Review request for hive.


Summary
---

review by jvs


This addresses bug HIVE-2045.
https://issues.apache.org/jira/browse/HIVE-2045


Diffs
-

  
http://svn.apache.org/repos/asf/hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/thrift/TCTLSeparatedProtocol.java
 1127457 
  
http://svn.apache.org/repos/asf/hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/TestTCTLSeparatedProtocol.java
 1127457 

Diff: https://reviews.apache.org/r/1035/diff


Testing
---


Thanks,

John

[jira] [Updated] (HIVE-2272) add TIMESTAMP data type

2011-07-07 Thread Franklin Hu (JIRA)


 [ 
https://issues.apache.org/jira/browse/HIVE-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Franklin Hu updated HIVE-2272:
--

Attachment: hive-2272.2.patch

fix fractional timestamp bug

> add TIMESTAMP data type
> ---
>
> Key: HIVE-2272
> URL: https://issues.apache.org/jira/browse/HIVE-2272
> Project: Hive
>  Issue Type: New Feature
>Reporter: Franklin Hu
>Assignee: Franklin Hu
> Attachments: hive-2272.1.patch, hive-2272.2.patch
>
>
> Add TIMESTAMP type to serde2 that supports unix timestamp (1970-01-01 
> 00:00:01 UTC to 2038-01-19 03:14:07 UTC) with optional nanosecond precision 
> using both LazyBinary and LazySimple SerDes. 
> For LazySimpleSerDe, the data is stored in jdbc compliant java.sql.Timestamp 
> parsable strings.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2045) TCTLSeparatedProtocol.SimpleTransportTokenizer.nextToken() throws Null Pointer Exception in some cases

2011-07-07 Thread jirapos...@reviews.apache.org (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061628#comment-13061628
 ] 

jirapos...@reviews.apache.org commented on HIVE-2045:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1035/
---

Review request for hive.


Summary
---

review by jvs


This addresses bug HIVE-2045.
https://issues.apache.org/jira/browse/HIVE-2045


Diffs
-

  
http://svn.apache.org/repos/asf/hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/thrift/TCTLSeparatedProtocol.java
 1127457 
  
http://svn.apache.org/repos/asf/hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/TestTCTLSeparatedProtocol.java
 1127457 

Diff: https://reviews.apache.org/r/1035/diff


Testing
---


Thanks,

John



> TCTLSeparatedProtocol.SimpleTransportTokenizer.nextToken() throws Null 
> Pointer Exception in some cases
> --
>
> Key: HIVE-2045
> URL: https://issues.apache.org/jira/browse/HIVE-2045
> Project: Hive
>  Issue Type: Bug
>  Components: Serializers/Deserializers
>Affects Versions: 0.7.0
> Environment: Hadoop 0.20.1, Hive0.7.0 and SUSE Linux Enterprise 
> Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5).
>Reporter: Chinna Rao Lalam
>Assignee: Chinna Rao Lalam
> Attachments: HIVE-2045.patch
>
>
> 1) In TCTLSeparatedProtocol.SimpleTransportTokenizer.nextToken() is doing 
> null check for the tokenizer.
> If tokenizer is null, fillTokenizer() method is called to get the tokenizer 
> object. But fillTokenizer() method also can update the tokenizer with NULL , 
> so NULL check should be done before using the tokenizer.
> 2) Also improved some logging in TCTLSeparatedProtocol.java

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2045) TCTLSeparatedProtocol.SimpleTransportTokenizer.nextToken() throws Null Pointer Exception in some cases

2011-07-07 Thread John Sichi (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061631#comment-13061631
 ] 

John Sichi commented on HIVE-2045:
--

+1.  Will commit when tests pass.


> TCTLSeparatedProtocol.SimpleTransportTokenizer.nextToken() throws Null 
> Pointer Exception in some cases
> --
>
> Key: HIVE-2045
> URL: https://issues.apache.org/jira/browse/HIVE-2045
> Project: Hive
>  Issue Type: Bug
>  Components: Serializers/Deserializers
>Affects Versions: 0.7.0
> Environment: Hadoop 0.20.1, Hive0.7.0 and SUSE Linux Enterprise 
> Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5).
>Reporter: Chinna Rao Lalam
>Assignee: Chinna Rao Lalam
> Attachments: HIVE-2045.patch
>
>
> 1) In TCTLSeparatedProtocol.SimpleTransportTokenizer.nextToken() is doing 
> null check for the tokenizer.
> If tokenizer is null, fillTokenizer() method is called to get the tokenizer 
> object. But fillTokenizer() method also can update the tokenizer with NULL , 
> so NULL check should be done before using the tokenizer.
> 2) Also improved some logging in TCTLSeparatedProtocol.java

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2210) ALTER VIEW RENAME

2011-07-07 Thread jirapos...@reviews.apache.org (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061635#comment-13061635
 ] 

jirapos...@reviews.apache.org commented on HIVE-2210:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1039/
---

Review request for hive.


Summary
---

https://issues.apache.org/jira/browse/HIVE-2210


This addresses bug HIVE-2210.
https://issues.apache.org/jira/browse/HIVE-2210


Diffs
-

  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure8.q
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure9.q
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/alter_view_rename.q
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure8.q.out
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure9.q.out
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/alter_view_rename.q.out
 PRE-CREATION 

Diff: https://reviews.apache.org/r/1039/diff


Testing
---

Relevant unit tests looked ok


Thanks,

Charles



> ALTER VIEW RENAME
> -
>
> Key: HIVE-2210
> URL: https://issues.apache.org/jira/browse/HIVE-2210
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Affects Versions: 0.6.0
>Reporter: John Sichi
>Assignee: Charles Chen
> Attachments: HIVE-2210v0.patch
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW 
> RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2210) ALTER VIEW RENAME

2011-07-07 Thread jirapos...@reviews.apache.org (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061634#comment-13061634
 ] 

jirapos...@reviews.apache.org commented on HIVE-2210:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1039/
---

(Updated 2011-07-07 22:35:58.987287)


Review request for hive.


Summary (updated)
---

https://issues.apache.org/jira/browse/HIVE-2210


This addresses bug HIVE-2210.
https://issues.apache.org/jira/browse/HIVE-2210


Diffs
-

  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure8.q
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure9.q
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/alter_view_rename.q
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure8.q.out
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure9.q.out
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/alter_view_rename.q.out
 PRE-CREATION 

Diff: https://reviews.apache.org/r/1039/diff


Testing
---

Relevant unit tests looked ok


Thanks,

Charles



> ALTER VIEW RENAME
> -
>
> Key: HIVE-2210
> URL: https://issues.apache.org/jira/browse/HIVE-2210
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Affects Versions: 0.6.0
>Reporter: John Sichi
>Assignee: Charles Chen
> Attachments: HIVE-2210v0.patch
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW 
> RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Review Request: Add ALTER VIEW RENAME support

2011-07-07 Thread Charles Chen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1039/
---

Review request for hive.


Summary
---

https://issues.apache.org/jira/browse/HIVE-2210


This addresses bug HIVE-2210.
https://issues.apache.org/jira/browse/HIVE-2210


Diffs
-

  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure8.q
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure9.q
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/alter_view_rename.q
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure8.q.out
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure9.q.out
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/alter_view_rename.q.out
 PRE-CREATION 

Diff: https://reviews.apache.org/r/1039/diff


Testing
---

Relevant unit tests looked ok


Thanks,

Charles

Re: Review Request: HIVE-2210: Add ALTER VIEW RENAME support

2011-07-07 Thread Charles Chen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1039/
---

(Updated 2011-07-07 22:35:58.987287)


Review request for hive.


Summary (updated)
---

https://issues.apache.org/jira/browse/HIVE-2210


This addresses bug HIVE-2210.
https://issues.apache.org/jira/browse/HIVE-2210


Diffs
-

  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java
 1143958 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure8.q
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure9.q
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/alter_view_rename.q
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure8.q.out
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure9.q.out
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/alter_view_rename.q.out
 PRE-CREATION 

Diff: https://reviews.apache.org/r/1039/diff


Testing
---

Relevant unit tests looked ok


Thanks,

Charles

[jira] [Commented] (HIVE-2269) Hive --auxpath option can't handle multiple colon separated values

2011-07-07 Thread Patrick Hunt (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061636#comment-13061636
 ] 

Patrick Hunt commented on HIVE-2269:


Hi. It looks like HIVE_AUX_JARS_PATH (hive --auxpath ...) can be either a 
directory (if so it considers all *.jar in the directory) or a list. In the 
case it's a list, can the entries be only jars or mixed jars & directories?

I can't find any documentation on this, perhaps a JIRA should be opened to 
document the semantics of this parameter?


> Hive --auxpath option can't handle multiple colon separated values
> --
>
> Key: HIVE-2269
> URL: https://issues.apache.org/jira/browse/HIVE-2269
> Project: Hive
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 0.7.0, 0.7.1
>Reporter: Carl Steinbach
>Assignee: Carl Steinbach
> Attachments: HIVE-2269-auxpath.1.patch.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-2196) Ensure HiveConf includes all properties defined in hive-default.xml

2011-07-07 Thread John Sichi (JIRA)


 [ 
https://issues.apache.org/jira/browse/HIVE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Sichi updated HIVE-2196:
-

Status: Open  (was: Patch Available)

For each one of these, we need to verify that the parameter is actually used.  
For example, I searched the code for references to hive.optimize.pruner, and 
could not find any.  In such cases, we should delete from xml rather than add 
to HiveConf.

For cases where the parameter is still used (e.g. hive.io.exception.handlers), 
we should change the points of reference to go through the HiveConf symbol.


> Ensure HiveConf includes all properties defined in hive-default.xml
> ---
>
> Key: HIVE-2196
> URL: https://issues.apache.org/jira/browse/HIVE-2196
> Project: Hive
>  Issue Type: Bug
>  Components: Configuration
>Reporter: Carl Steinbach
>Assignee: Chinna Rao Lalam
> Attachments: HIVE-2196.patch
>
>
> There are a bunch of properties that are defined in hive-default.xml but not 
> in HiveConf.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-1538) FilterOperator is applied twice with ppd on.

2011-07-07 Thread John Sichi (JIRA)


 [ 
https://issues.apache.org/jira/browse/HIVE-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Sichi updated HIVE-1538:
-

Status: Open  (was: Patch Available)

Sorry, this one has gone stale.  Can you rebase against trunk?

> FilterOperator is applied twice with ppd on.
> 
>
> Key: HIVE-1538
> URL: https://issues.apache.org/jira/browse/HIVE-1538
> Project: Hive
>  Issue Type: Bug
>  Components: Query Processor
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Attachments: patch-1538-1.txt, patch-1538-2.txt, patch-1538-3.txt, 
> patch-1538.txt
>
>
> With hive.optimize.ppd set to true, FilterOperator is applied twice. And it 
> seems second operator is always filtering zero rows.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-1538) FilterOperator is applied twice with ppd on.

2011-07-07 Thread John Sichi (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061648#comment-13061648
 ] 

John Sichi commented on HIVE-1538:
--

Sorry for the repeated rebase requests; we'll make sure the next attempt gets 
committed!

> FilterOperator is applied twice with ppd on.
> 
>
> Key: HIVE-1538
> URL: https://issues.apache.org/jira/browse/HIVE-1538
> Project: Hive
>  Issue Type: Bug
>  Components: Query Processor
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Attachments: patch-1538-1.txt, patch-1538-2.txt, patch-1538-3.txt, 
> patch-1538.txt
>
>
> With hive.optimize.ppd set to true, FilterOperator is applied twice. And it 
> seems second operator is always filtering zero rows.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Review Request: HIVE-2224 : Exposing add_partitions() from hive metastore, making it atomic

2011-07-07 Thread Sushanth Sowmyan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/999/
---

(Updated 2011-07-07 23:20:22.001216)


Review request for hive.


Summary
---

As per HIVE-2224 ( https://issues.apache.org/jira/browse/HIVE-2224 ), this 
patch does the following:

+ Exposing add_partitions() from the thrift metastore api
+ Making add_partitions() atomic


This addresses bug HIVE-2224.
https://issues.apache.org/jira/browse/HIVE-2224


Diffs
-

  http://svn.apache.org/repos/asf/hive/trunk/metastore/if/hive_metastore.thrift 
1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
 1142116 

Diff: https://reviews.apache.org/r/999/diff


Testing
---

Modified TestHiveMetaStore.partitionTester() to add tests for the following 
scenarios:

+ add_partition(empty list) : no exceptions thrown : works
+ add_partitions(list containing 3 partitions) : works, verified that 
partitions exist
+ add_partitions(list containing 2 partitions, where one of them has keyvalues 
identical to original partition, and another partition has a directory already 
created, verified that the call causes an exception, and directories are 
unchanged(the one with the dir pre-existing continues to exist), and no 
additional partition was published.
+ add_partitions(list with a single partition) : works, does not fault on 
duplicate as a result of a partial publish above.
+ verified that all above created partitions exist : works

All of the above is called from both TestEmbeddedHiveMetaStore and 
TestRemoteHiveMetaStore


Thanks,

Sushanth

[jira] [Commented] (HIVE-2224) Ability to add_partitions, and atomically

2011-07-07 Thread Sushanth Sowmyan (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061660#comment-13061660
 ] 

Sushanth Sowmyan commented on HIVE-2224:


Thanks, done, will take note to do so in the future. :)

> Ability to add_partitions, and atomically
> -
>
> Key: HIVE-2224
> URL: https://issues.apache.org/jira/browse/HIVE-2224
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Reporter: Sushanth Sowmyan
>Assignee: Sushanth Sowmyan
> Attachments: HIVE-2224.patch
>
>
> I'd like to see an atomic version of the add_partitions() call.
> Whether this is to be done by config to affect add_partitions() behaviour 
> (not my preference) or just changing add_partitions() default behaviour (my 
> preference, but likely to affect current behaviour, so will need others' 
> input) or by making a new add_partitions_atomic() call depends on discussion.
> This looks relatively doable to implement (will need a dependent 
> add_partition_core to not do a ms.commit_partition() early, and to cache list 
> of directories created to remove on rollback, and a list of AddPartitionEvent 
> to trigger in one shot later)
> Thoughts? This also seems like something to implement for allowing HIVE-1805.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2224) Ability to add_partitions, and atomically

2011-07-07 Thread jirapos...@reviews.apache.org (JIRA)


[ 
https://issues.apache.org/jira/browse/HIVE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061661#comment-13061661
 ] 

jirapos...@reviews.apache.org commented on HIVE-2224:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/999/
---

(Updated 2011-07-07 23:20:22.001216)


Review request for hive.


Summary
---

As per HIVE-2224 ( https://issues.apache.org/jira/browse/HIVE-2224 ), this 
patch does the following:

+ Exposing add_partitions() from the thrift metastore api
+ Making add_partitions() atomic


This addresses bug HIVE-2224.
https://issues.apache.org/jira/browse/HIVE-2224


Diffs
-

  http://svn.apache.org/repos/asf/hive/trunk/metastore/if/hive_metastore.thrift 
1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
 1142116 
  
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
 1142116 

Diff: https://reviews.apache.org/r/999/diff


Testing
---

Modified TestHiveMetaStore.partitionTester() to add tests for the following 
scenarios:

+ add_partition(empty list) : no exceptions thrown : works
+ add_partitions(list containing 3 partitions) : works, verified that 
partitions exist
+ add_partitions(list containing 2 partitions, where one of them has keyvalues 
identical to original partition, and another partition has a directory already 
created, verified that the call causes an exception, and directories are 
unchanged(the one with the dir pre-existing continues to exist), and no 
additional partition was published.
+ add_partitions(list with a single partition) : works, does not fault on 
duplicate as a result of a partial publish above.
+ verified that all above created partitions exist : works

All of the above is called from both TestEmbeddedHiveMetaStore and 
TestRemoteHiveMetaStore


Thanks,

Sushanth



> Ability to add_partitions, and atomically
> -
>
> Key: HIVE-2224
> URL: https://issues.apache.org/jira/browse/HIVE-2224
> Project: Hive
>  Issue Type: Improvement
>  Components: Metastore
>Reporter: Sushanth Sowmyan
>Assignee: Sushanth Sowmyan
> Attachments: HIVE-2224.patch
>
>
> I'd like to see an atomic version of the add_partitions() call.
> Whether this is to be done by config to affect add_partitions() behaviour 
> (not my preference) or just changing add_partitions() default behaviour (my 
> preference, but likely to affect current behaviour, so will need others' 
> input) or by making a new add_partitions_atomic() call depends on discussion.
> This looks relatively doable to implement (will need a dependent 
> add_partition_core to not do a ms.commit_partition() early, and to cache list 
> of directories created to remove on rollback, and a list of AddPartitionEvent 
> to trigger in one shot later)
> Thoughts? This also seems like something to implement for allowing HIVE-1805.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HIVE-2273) IP data type

2011-07-07 Thread Franklin Hu (JIRA)

IP data type


 Key: HIVE-2273
 URL: https://issues.apache.org/jira/browse/HIVE-2273
 Project: Hive
  Issue Type: New Feature
Reporter: Franklin Hu
Assignee: Franklin Hu
Priority: Minor


new data type that supports both IPv4 and IPv6 in String and binary serialized 
formats

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-2273) IP data type

2011-07-07 Thread Franklin Hu (JIRA)


 [ 
https://issues.apache.org/jira/browse/HIVE-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Franklin Hu updated HIVE-2273:
--

Attachment: hive-2273.1.patch

initial patch

> IP data type
> 
>
> Key: HIVE-2273
> URL: https://issues.apache.org/jira/browse/HIVE-2273
> Project: Hive
>  Issue Type: New Feature
>Reporter: Franklin Hu
>Assignee: Franklin Hu
>Priority: Minor
> Attachments: hive-2273.1.patch
>
>
> new data type that supports both IPv4 and IPv6 in String and binary 
> serialized formats

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Review Request: HIVE-2210: Add ALTER VIEW RENAME support

2011-07-07 Thread John Sichi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1039/#review997
---



http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java


update comment



http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java


Use TableType.VIRTUAL_VIEW.toString() instead of literal.



http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java


comment says DROP



http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/alter_view_rename.q


For completeness, can you add a SELECT statement to make sure it's still 
possible to query the renamed view?  It's OK if it returns no results, just 
that semantic analysis passes.



- John


On 2011-07-07 22:35:58, Charles Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1039/
> ---
> 
> (Updated 2011-07-07 22:35:58)
> 
> 
> Review request for hive.
> 
> 
> Summary
> ---
> 
> https://issues.apache.org/jira/browse/HIVE-2210
> 
> 
> This addresses bug HIVE-2210.
> https://issues.apache.org/jira/browse/HIVE-2210
> 
> 
> Diffs
> -
> 
>   
> http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
>  1143958 
>   
> http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
>  1143958 
>   
> http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
>  1143958 
>   
> http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
>  1143958 
>   
> http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java
>  1143958 
>   
> http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java
>  1143958 
>   
> http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure8.q
>  PRE-CREATION 
>   
> http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure9.q
>  PRE-CREATION 
>   
> http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/alter_view_rename.q
>  PRE-CREATION 
>   
> http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure8.q.out
>  PRE-CREATION 
>   
> http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure9.q.out
>  PRE-CREATION 
>   
> http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/alter_view_rename.q.out
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/1039/diff
> 
> 
> Testing
> ---
> 
> Relevant unit tests looked ok
> 
> 
> Thanks,
> 
> Charles
> 
>

[jira] [Commented] (HIVE-2210) ALTER VIEW RENAME

2011-07-07 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061702#comment-13061702
 ] 

jirapos...@reviews.apache.org commented on HIVE-2210:
-

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1039/#review997
---

http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java

update comment

http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java

Use TableType.VIRTUAL_VIEW.toString() instead of literal.

http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java

comment says DROP

http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/alter_view_rename.q

For completeness, can you add a SELECT statement to make sure it's still 
possible to query the renamed view?  It's OK if it returns no results, just 
that semantic analysis passes.

- John

On 2011-07-07 22:35:58, Charles Chen wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1039/
bq.  ---
bq.  
bq.  (Updated 2011-07-07 22:35:58)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  https://issues.apache.org/jira/browse/HIVE-2210
bq.  
bq.  
bq.  This addresses bug HIVE-2210.
bq.  https://issues.apache.org/jira/browse/HIVE-2210
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
 1143958 
bq.
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
 1143958 
bq.
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
 1143958 
bq.
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
 1143958 
bq.
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java
 1143958 
bq.
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java
 1143958 
bq.
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure8.q
 PRE-CREATION 
bq.
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure9.q
 PRE-CREATION 
bq.
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/alter_view_rename.q
 PRE-CREATION 
bq.
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure8.q.out
 PRE-CREATION 
bq.
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure9.q.out
 PRE-CREATION 
bq.
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/alter_view_rename.q.out
 PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/1039/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  Relevant unit tests looked ok
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Charles
bq.  
bq.

> ALTER VIEW RENAME
> -
>
> Key: HIVE-2210
> URL: https://issues.apache.org/jira/browse/HIVE-2210
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Affects Versions: 0.6.0
>Reporter: John Sichi
>Assignee: Charles Chen
> Attachments: HIVE-2210v0.patch
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW 
> RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-2210) ALTER VIEW RENAME

2011-07-07 Thread John Sichi (JIRA)


 [ 
https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Sichi updated HIVE-2210:
-

Status: Open  (was: Patch Available)

Resubmit patch after review comments addressed.

> ALTER VIEW RENAME
> -
>
> Key: HIVE-2210
> URL: https://issues.apache.org/jira/browse/HIVE-2210
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Affects Versions: 0.6.0
>Reporter: John Sichi
>Assignee: Charles Chen
> Attachments: HIVE-2210v0.patch
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW 
> RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

47 matches

Mail list logo