[jira] [Commented] (HIVE-4810) Refactor exec package
[ https://issues.apache.org/jira/browse/HIVE-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704260#comment-13704260 ] Gunther Hagleitner commented on HIVE-4810: -- [~appodictic] This jira doesn't seem the right forum for your the points you make. You don't object to this refactor directly, but have concerns around process, priority etc. Don't you think the mailing list would be a better place for those? And for the record: Accusing me of not caring about quality is unfair and a cheap shot, I've never argued that we shouldn't fix things and have spent a good amount of time on fixing unit tests, build issues, performance isuses and bugs too. And I've had my fair share of rebasing stuff. > Refactor exec package > - > > Key: HIVE-4810 > URL: https://issues.apache.org/jira/browse/HIVE-4810 > Project: Hive > Issue Type: Bug >Reporter: Gunther Hagleitner >Assignee: Gunther Hagleitner > Fix For: 0.12.0 > > Attachments: HIVE-4810.1.patch, HIVE-4810.2.patch, HIVE-4810.3.patch, > HIVE-4810.4.patch, HIVE-4810.5.patch, HIVE-4810.6.patch, HIVE-4810.7.patch > > > The exec package contains both operators and classes used to execute the job. > Moving the latter into a sub package makes the package slightly more > manageable and will make it easier to provide a tez-based implementation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4658) Make KW_OUTER optional in outer joins
[ https://issues.apache.org/jira/browse/HIVE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704249#comment-13704249 ] Edward Capriolo commented on HIVE-4658: --- Test randomly fail often. The chances of this change effecting those tests is very small. > Make KW_OUTER optional in outer joins > - > > Key: HIVE-4658 > URL: https://issues.apache.org/jira/browse/HIVE-4658 > Project: Hive > Issue Type: Improvement > Components: Query Processor >Reporter: Navis >Assignee: Edward Capriolo >Priority: Trivial > Attachments: hive-4658.2.patch.txt, HIVE-4658.D11091.1.patch > > > For really trivial migration issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4810) Refactor exec package
[ https://issues.apache.org/jira/browse/HIVE-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704245#comment-13704245 ] Edward Capriolo commented on HIVE-4810: --- [~hagleitn] I am sure your refactor is great and makes sense...but... Others have patches, that add features, that have been waiting for review for months. Why should those people now have to rebase? Why should this issue get fast tracked when it does nothing? Vectorization-branch, Tez branch, this project is going all over the place. Who cares that https://issues.apache.org/jira/browse/HIVE-3926 does not work? Let's focus on re factoring things so we can add new things. All those people with their annoying bug fixes can just keep re-basing everything. Hive just does not move 5 day fast, if your talking about re factoring a key piece of hive, 5 days is not enough slack time to let anyone review it. > Refactor exec package > - > > Key: HIVE-4810 > URL: https://issues.apache.org/jira/browse/HIVE-4810 > Project: Hive > Issue Type: Bug >Reporter: Gunther Hagleitner >Assignee: Gunther Hagleitner > Fix For: 0.12.0 > > Attachments: HIVE-4810.1.patch, HIVE-4810.2.patch, HIVE-4810.3.patch, > HIVE-4810.4.patch, HIVE-4810.5.patch, HIVE-4810.6.patch, HIVE-4810.7.patch > > > The exec package contains both operators and classes used to execute the job. > Moving the latter into a sub package makes the package slightly more > manageable and will make it easier to provide a tez-based implementation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4812) Logical explain plan
[ https://issues.apache.org/jira/browse/HIVE-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704227#comment-13704227 ] Hudson commented on HIVE-4812: -- Integrated in Hive-trunk-hadoop2 #280 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/280/]) HIVE-4812 : Logical explain plan (Gunther Hagleitner V via Navis) (Revision 1501036) Result = ABORTED navis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501036 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Context.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExplainWork.java * /hive/trunk/ql/src/test/queries/clientpositive/explain_logical.q * /hive/trunk/ql/src/test/results/clientpositive/explain_logical.q.out > Logical explain plan > > > Key: HIVE-4812 > URL: https://issues.apache.org/jira/browse/HIVE-4812 > Project: Hive > Issue Type: Bug > Components: Diagnosability >Reporter: Gunther Hagleitner >Assignee: Gunther Hagleitner > Fix For: 0.12.0 > > Attachments: HIVE-4812.1.patch, HIVE-4812.2.patch, HIVE-4812.3.patch > > > In various situations it would have been useful to me to glance at the > operator plan before we break it into tasks and apply join, total order sort, > etc optimizations. > I've added this as an options to explain. "Explain logical " will > output the full operator tree (not the stage plans, tasks, AST etc). > Again, I don't think this has to even be documented for users, but might be > useful to developers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4819) Comments in CommonJoinOperator for aliasTag is not valid
[ https://issues.apache.org/jira/browse/HIVE-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704226#comment-13704226 ] Hudson commented on HIVE-4819: -- Integrated in Hive-trunk-hadoop2 #280 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/280/]) HIVE-4819 : Comments in CommonJoinOperator for aliasTag is not valid (Navis via Ashutosh Chauhan) (Revision 1501129) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501129 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java > Comments in CommonJoinOperator for aliasTag is not valid > > > Key: HIVE-4819 > URL: https://issues.apache.org/jira/browse/HIVE-4819 > Project: Hive > Issue Type: Task > Components: Documentation >Reporter: Navis >Assignee: Navis >Priority: Trivial > Fix For: 0.12.0 > > Attachments: HIVE-4819.D11619.1.patch > > > I've written that but it's does not make sense even to me. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4813) Improve test coverage of package org.apache.hadoop.hive.ql.optimizer.pcr
[ https://issues.apache.org/jira/browse/HIVE-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704228#comment-13704228 ] Hudson commented on HIVE-4813: -- Integrated in Hive-trunk-hadoop2 #280 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/280/]) HIVE-4813 : Improve test coverage of package org.apache.hadoop.hive.ql.optimizer.pcr (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1501099) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501099 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/lib/DefaultRuleDispatcher.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/lib/RuleRegExp.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcCtx.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java * /hive/trunk/ql/src/test/queries/clientpositive/pcr.q * /hive/trunk/ql/src/test/results/clientpositive/pcr.q.out > Improve test coverage of package org.apache.hadoop.hive.ql.optimizer.pcr > > > Key: HIVE-4813 > URL: https://issues.apache.org/jira/browse/HIVE-4813 > Project: Hive > Issue Type: Test >Affects Versions: 0.12.0 >Reporter: Ivan A. Veselovsky >Assignee: Ivan A. Veselovsky > Fix For: 0.12.0 > > Attachments: HIVE-4813-trunk--N1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4796) Increase coverage of package org.apache.hadoop.hive.common.metrics
[ https://issues.apache.org/jira/browse/HIVE-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704229#comment-13704229 ] Hudson commented on HIVE-4796: -- Integrated in Hive-trunk-hadoop2 #280 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/280/]) HIVE-4796 : Increase coverage of package org.apache.hadoop.hive.common.metrics (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1501052) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501052 Files : * /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java * /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java * /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java * /hive/trunk/common/src/test/org/apache/hadoop/hive/common * /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics * /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java > Increase coverage of package org.apache.hadoop.hive.common.metrics > -- > > Key: HIVE-4796 > URL: https://issues.apache.org/jira/browse/HIVE-4796 > Project: Hive > Issue Type: Test >Affects Versions: 0.12.0 >Reporter: Ivan A. Veselovsky >Assignee: Ivan A. Veselovsky > Fix For: 0.12.0 > > Attachments: HIVE-4796-trunk--N1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704225#comment-13704225 ] Hudson commented on HIVE-4580: -- Integrated in Hive-trunk-hadoop2 #280 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/280/]) HIVE-4580 : Change DDLTask to report errors using canonical error messages rather than http status codes (Eugene Koifman via Ashutosh Chauhan) (Revision 1501053) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501053 Files : * /hive/trunk/contrib/src/test/results/clientnegative/serde_regex.q.out * /hive/trunk/contrib/src/test/results/clientnegative/url_hook.q.out * /hive/trunk/hcatalog/src/test/e2e/templeton/tests/ddl.conf * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/AppConfig.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/BadParam.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/BusyException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/CallbackFailedException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/CatchallExceptionMapper.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/HcatDelegator.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/HcatException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/JsonBuilder.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/Main.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/NotAuthorizedException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/QueueException.java * /hive/trunk/hcatalog/webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestWebHCatE2e.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskResult.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveException.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/InvalidTableException.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java * /hive/trunk/ql/src/test/results/clientnegative/add_partition_with_whitelist.q.out * /hive/trunk/ql/src/test/results/clientnegative/addpart1.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_partition_nodrop_table.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_partition_with_whitelist.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure2.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure3.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_table_wrong_regex.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_view_failure4.q.out * /hive/trunk/ql/src/test/results/clientnegative/altern1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive2.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi2.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi3.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi4.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi5.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi6.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi7.q.out * /hive/trunk/ql/src/test/results/clientnegative/authorization_fail_1.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename1.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename2.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename4.q.out * /hive/trunk/ql/src/test/results/clientnegative/create_table_failure3.q.out * /hive/trunk/ql/src/test/results/clientnegative/create_table_failure4.q.out *
[jira] [Commented] (HIVE-4810) Refactor exec package
[ https://issues.apache.org/jira/browse/HIVE-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704204#comment-13704204 ] Gunther Hagleitner commented on HIVE-4810: -- [~appodictic] have you looked at the changes? I know there's quite a few files that are being touched, but the changes are rather simple and straight forward in my opinion. The reason so many files have changed is simply because the full path names of some classes is recorded in some golden files. No core logic has changed. Even if you have to rebase against it that shouldn't be hard. As I pointed out in the description, I think grouping some logically cohesive units into its own package has value in itself, which is why I pitched it for inclusion into the trunk as opposed to the branch. > Refactor exec package > - > > Key: HIVE-4810 > URL: https://issues.apache.org/jira/browse/HIVE-4810 > Project: Hive > Issue Type: Bug >Reporter: Gunther Hagleitner >Assignee: Gunther Hagleitner > Fix For: 0.12.0 > > Attachments: HIVE-4810.1.patch, HIVE-4810.2.patch, HIVE-4810.3.patch, > HIVE-4810.4.patch, HIVE-4810.5.patch, HIVE-4810.6.patch, HIVE-4810.7.patch > > > The exec package contains both operators and classes used to execute the job. > Moving the latter into a sub package makes the package slightly more > manageable and will make it easier to provide a tez-based implementation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4833) Fix eclipse template classpath to include the correct jdo lib
[ https://issues.apache.org/jira/browse/HIVE-4833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704195#comment-13704195 ] Hudson commented on HIVE-4833: -- Integrated in Hive-trunk-hadoop1-ptest #59 (See [https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/59/]) HIVE-4833 : Fix eclipse template classpath to include the correct jdo lib (Yin Huai via Ashutosh Chauhan) (Revision 1501618) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501618 Files : * /hive/trunk/eclipse-templates/.classpath * /hive/trunk/eclipse-templates/.classpath._hbase > Fix eclipse template classpath to include the correct jdo lib > - > > Key: HIVE-4833 > URL: https://issues.apache.org/jira/browse/HIVE-4833 > Project: Hive > Issue Type: Bug >Reporter: Yin Huai >Assignee: Yin Huai >Priority: Trivial > Fix For: 0.12.0 > > Attachments: HIVE-4833.patch.txt > > > HIVE-4089 upgraded jdo to 3.0.1, but .classpath and classpath._hbase in > eclipse tempalte has not been changed accordingly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4830) Test clientnegative/nested_complex_neg.q got broken due to 4580
[ https://issues.apache.org/jira/browse/HIVE-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704194#comment-13704194 ] Hudson commented on HIVE-4830: -- Integrated in Hive-trunk-hadoop1-ptest #59 (See [https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/59/]) HIVE-4830 : Test clientnegative/nested_complex_neg.q got broken due to 4580 (Vikram Dixit via Ashutosh Chauhan) (Revision 1501616) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501616 Files : * /hive/trunk/ql/src/test/results/clientnegative/nested_complex_neg.q.out > Test clientnegative/nested_complex_neg.q got broken due to 4580 > --- > > Key: HIVE-4830 > URL: https://issues.apache.org/jira/browse/HIVE-4830 > Project: Hive > Issue Type: Bug > Components: Tests >Affects Versions: 0.12.0 >Reporter: Ashutosh Chauhan >Assignee: Vikram Dixit K > Fix For: 0.12.0 > > Attachments: HIVE-4830.patch > > > Both HIVE-3253 and HIVE-4580 were racing to modify .q.out files for this > test. Eventually, one patch lost. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4837) Union on void type fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HIVE-4837: -- Attachment: HIVE-4837.D11649.1.patch navis requested code review of "HIVE-4837 [jira] Union on void type fails with NPE". Reviewers: JIRA HIVE-4837 Union on void type fails with NPE >From mailing list, >http://www.mail-archive.com/user@hive.apache.org/msg08683.html java.lang.RuntimeException: Error in configuring object at org.apache.hadoop.util.ReflectionUtils.setJobConf(ReflectionUtils.java:93) at org.apache.hadoop.util.ReflectionUtils.setConf(ReflectionUtils.java:64) at org.apache.hadoop.util.ReflectionUtils.newInstance(ReflectionUtils.java:117) at org.apache.hadoop.mapred.MapTask.runOldMapper(MapTask.java:432) at org.apache.hadoop.mapred.MapTask.run(MapTask.java:372) at org.apache.hadoop.mapred.Child$4.run(Child.java:255) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:396) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1149) at org.apache.hadoop.mapred.Child.main(Child.java:249) Caused by: java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.hadoop.util.ReflectionUtils.setJobConf(ReflectionUtils.java:88) ... 9 more Caused by: java.lang.RuntimeException: Error in configuring object at org.apache.hadoop.util.ReflectionUtils.setJobConf(ReflectionUtils.java:93) at org.apache.hadoop.util.ReflectionUtils.setConf(ReflectionUtils.java:64) at org.apache.hadoop.util.ReflectionUtils.newInstance(ReflectionUtils.java:117) at org.apache.hadoop.mapred.MapRunner.configure(MapRunner.java:34) ... 14 more Caused by: java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.hadoop.util.ReflectionUtils.setJobConf(ReflectionUtils.java:88) ... 17 more Caused by: java.lang.RuntimeException: Map operator initialization failed at org.apache.hadoop.hive.ql.exec.ExecMapper.configure(ExecMapper.java:121) ... 22 more Caused by: java.lang.NullPointerException at org.apache.hadoop.hive.serde2.objectinspector.StructObjectInspector.toString(StructObjectInspector.java:64) at java.lang.String.valueOf(String.java:2826) at java.lang.StringBuilder.append(StringBuilder.java:115) at org.apache.hadoop.hive.ql.exec.UnionOperator.initializeOp(UnionOperator.java:110) at org.apache.hadoop.hive.ql.exec.Operator.initialize(Operator.java:375) at org.apache.hadoop.hive.ql.exec.Operator.initialize(Operator.java:451) at org.apache.hadoop.hive.ql.exec.Operator.initializeChildren(Operator.java:407) at org.apache.hadoop.hive.ql.exec.TableScanOperator.initializeOp(TableScanOperator.java:186) at org.apache.hadoop.hive.ql.exec.Operator.initialize(Operator.java:375) at org.apache.hadoop.hive.ql.exec.MapOperator.initializeOp(MapOperator.java:563) at org.apache.hadoop.hive.ql.exec.Operator.initialize(Operator.java:375) at org.apache.hadoop.hive.ql.exec.ExecMapper.configure(ExecMapper.java:100) ... 22 more TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D11649 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java ql/src/test/queries/clientpositive/union_null.q ql/src/test/results/beelinepositive/union_null.q.out ql/src/test/results/clientpositive/union_null.q.out MANAGE HERALD RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/27561/ To: JIRA, navis > Union on void type fails with NPE > - > > Key: HIVE-4837 > URL: https://issues.apache.org/jira/browse/HIVE-4837 > Project: Hive > Issue Type: Bug > Components: Query Processor >Reporter: Navis >Assignee: Navis >Priority: Minor > Attachments: HIVE-4837.D11649.1.patch > > > From mailing list, > http://www.mail-archive.com/user@hive.apache.org/msg08683.html > {noformat} > java.lang.RuntimeException: Error in configuring object > at > org.apache.hadoop.util.ReflectionUtils.setJobConf(ReflectionUtils.java:93) > at org.apache.hadoop.util.ReflectionUtils.setConf(ReflectionUtils.java:
[jira] [Updated] (HIVE-4837) Union on void type fails with NPE
[ https://issues.apache.org/jira/browse/HIVE-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Navis updated HIVE-4837: Status: Patch Available (was: Open) > Union on void type fails with NPE > - > > Key: HIVE-4837 > URL: https://issues.apache.org/jira/browse/HIVE-4837 > Project: Hive > Issue Type: Bug > Components: Query Processor >Reporter: Navis >Assignee: Navis >Priority: Minor > Attachments: HIVE-4837.D11649.1.patch > > > From mailing list, > http://www.mail-archive.com/user@hive.apache.org/msg08683.html > {noformat} > java.lang.RuntimeException: Error in configuring object > at > org.apache.hadoop.util.ReflectionUtils.setJobConf(ReflectionUtils.java:93) > at org.apache.hadoop.util.ReflectionUtils.setConf(ReflectionUtils.java:64) > at > org.apache.hadoop.util.ReflectionUtils.newInstance(ReflectionUtils.java:117) > at org.apache.hadoop.mapred.MapTask.runOldMapper(MapTask.java:432) > at org.apache.hadoop.mapred.MapTask.run(MapTask.java:372) > at org.apache.hadoop.mapred.Child$4.run(Child.java:255) > at java.security.AccessController.doPrivileged(Native Method) > at javax.security.auth.Subject.doAs(Subject.java:396) > at > org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1149) > at org.apache.hadoop.mapred.Child.main(Child.java:249) > Caused by: java.lang.reflect.InvocationTargetException > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:597) > at > org.apache.hadoop.util.ReflectionUtils.setJobConf(ReflectionUtils.java:88) > ... 9 more > Caused by: java.lang.RuntimeException: Error in configuring object > at > org.apache.hadoop.util.ReflectionUtils.setJobConf(ReflectionUtils.java:93) > at org.apache.hadoop.util.ReflectionUtils.setConf(ReflectionUtils.java:64) > at > org.apache.hadoop.util.ReflectionUtils.newInstance(ReflectionUtils.java:117) > at org.apache.hadoop.mapred.MapRunner.configure(MapRunner.java:34) > ... 14 more > Caused by: java.lang.reflect.InvocationTargetException > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:597) > at > org.apache.hadoop.util.ReflectionUtils.setJobConf(ReflectionUtils.java:88) > ... 17 more > Caused by: java.lang.RuntimeException: Map operator initialization failed > at > org.apache.hadoop.hive.ql.exec.ExecMapper.configure(ExecMapper.java:121) > ... 22 more > Caused by: java.lang.NullPointerException > at > org.apache.hadoop.hive.serde2.objectinspector.StructObjectInspector.toString(StructObjectInspector.java:64) > at java.lang.String.valueOf(String.java:2826) > at java.lang.StringBuilder.append(StringBuilder.java:115) > at > org.apache.hadoop.hive.ql.exec.UnionOperator.initializeOp(UnionOperator.java:110) > at org.apache.hadoop.hive.ql.exec.Operator.initialize(Operator.java:375) > at org.apache.hadoop.hive.ql.exec.Operator.initialize(Operator.java:451) > at > org.apache.hadoop.hive.ql.exec.Operator.initializeChildren(Operator.java:407) > at > org.apache.hadoop.hive.ql.exec.TableScanOperator.initializeOp(TableScanOperator.java:186) > at org.apache.hadoop.hive.ql.exec.Operator.initialize(Operator.java:375) > at > org.apache.hadoop.hive.ql.exec.MapOperator.initializeOp(MapOperator.java:563) > at org.apache.hadoop.hive.ql.exec.Operator.initialize(Operator.java:375) > at > org.apache.hadoop.hive.ql.exec.ExecMapper.configure(ExecMapper.java:100) > ... 22 more > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-4837) Union on void type fails with NPE
Navis created HIVE-4837: --- Summary: Union on void type fails with NPE Key: HIVE-4837 URL: https://issues.apache.org/jira/browse/HIVE-4837 Project: Hive Issue Type: Bug Components: Query Processor Reporter: Navis Assignee: Navis Priority: Minor >From mailing list, >http://www.mail-archive.com/user@hive.apache.org/msg08683.html {noformat} java.lang.RuntimeException: Error in configuring object at org.apache.hadoop.util.ReflectionUtils.setJobConf(ReflectionUtils.java:93) at org.apache.hadoop.util.ReflectionUtils.setConf(ReflectionUtils.java:64) at org.apache.hadoop.util.ReflectionUtils.newInstance(ReflectionUtils.java:117) at org.apache.hadoop.mapred.MapTask.runOldMapper(MapTask.java:432) at org.apache.hadoop.mapred.MapTask.run(MapTask.java:372) at org.apache.hadoop.mapred.Child$4.run(Child.java:255) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:396) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1149) at org.apache.hadoop.mapred.Child.main(Child.java:249) Caused by: java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.hadoop.util.ReflectionUtils.setJobConf(ReflectionUtils.java:88) ... 9 more Caused by: java.lang.RuntimeException: Error in configuring object at org.apache.hadoop.util.ReflectionUtils.setJobConf(ReflectionUtils.java:93) at org.apache.hadoop.util.ReflectionUtils.setConf(ReflectionUtils.java:64) at org.apache.hadoop.util.ReflectionUtils.newInstance(ReflectionUtils.java:117) at org.apache.hadoop.mapred.MapRunner.configure(MapRunner.java:34) ... 14 more Caused by: java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.hadoop.util.ReflectionUtils.setJobConf(ReflectionUtils.java:88) ... 17 more Caused by: java.lang.RuntimeException: Map operator initialization failed at org.apache.hadoop.hive.ql.exec.ExecMapper.configure(ExecMapper.java:121) ... 22 more Caused by: java.lang.NullPointerException at org.apache.hadoop.hive.serde2.objectinspector.StructObjectInspector.toString(StructObjectInspector.java:64) at java.lang.String.valueOf(String.java:2826) at java.lang.StringBuilder.append(StringBuilder.java:115) at org.apache.hadoop.hive.ql.exec.UnionOperator.initializeOp(UnionOperator.java:110) at org.apache.hadoop.hive.ql.exec.Operator.initialize(Operator.java:375) at org.apache.hadoop.hive.ql.exec.Operator.initialize(Operator.java:451) at org.apache.hadoop.hive.ql.exec.Operator.initializeChildren(Operator.java:407) at org.apache.hadoop.hive.ql.exec.TableScanOperator.initializeOp(TableScanOperator.java:186) at org.apache.hadoop.hive.ql.exec.Operator.initialize(Operator.java:375) at org.apache.hadoop.hive.ql.exec.MapOperator.initializeOp(MapOperator.java:563) at org.apache.hadoop.hive.ql.exec.Operator.initialize(Operator.java:375) at org.apache.hadoop.hive.ql.exec.ExecMapper.configure(ExecMapper.java:100) ... 22 more {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-4837) Union on void type fails with NPE
Navis created HIVE-4837: --- Summary: Union on void type fails with NPE Key: HIVE-4837 URL: https://issues.apache.org/jira/browse/HIVE-4837 Project: Hive Issue Type: Bug Components: Query Processor Reporter: Navis Assignee: Navis Priority: Minor >From mailing list, >http://www.mail-archive.com/user@hive.apache.org/msg08683.html {noformat} java.lang.RuntimeException: Error in configuring object at org.apache.hadoop.util.ReflectionUtils.setJobConf(ReflectionUtils.java:93) at org.apache.hadoop.util.ReflectionUtils.setConf(ReflectionUtils.java:64) at org.apache.hadoop.util.ReflectionUtils.newInstance(ReflectionUtils.java:117) at org.apache.hadoop.mapred.MapTask.runOldMapper(MapTask.java:432) at org.apache.hadoop.mapred.MapTask.run(MapTask.java:372) at org.apache.hadoop.mapred.Child$4.run(Child.java:255) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:396) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1149) at org.apache.hadoop.mapred.Child.main(Child.java:249) Caused by: java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.hadoop.util.ReflectionUtils.setJobConf(ReflectionUtils.java:88) ... 9 more Caused by: java.lang.RuntimeException: Error in configuring object at org.apache.hadoop.util.ReflectionUtils.setJobConf(ReflectionUtils.java:93) at org.apache.hadoop.util.ReflectionUtils.setConf(ReflectionUtils.java:64) at org.apache.hadoop.util.ReflectionUtils.newInstance(ReflectionUtils.java:117) at org.apache.hadoop.mapred.MapRunner.configure(MapRunner.java:34) ... 14 more Caused by: java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.hadoop.util.ReflectionUtils.setJobConf(ReflectionUtils.java:88) ... 17 more Caused by: java.lang.RuntimeException: Map operator initialization failed at org.apache.hadoop.hive.ql.exec.ExecMapper.configure(ExecMapper.java:121) ... 22 more Caused by: java.lang.NullPointerException at org.apache.hadoop.hive.serde2.objectinspector.StructObjectInspector.toString(StructObjectInspector.java:64) at java.lang.String.valueOf(String.java:2826) at java.lang.StringBuilder.append(StringBuilder.java:115) at org.apache.hadoop.hive.ql.exec.UnionOperator.initializeOp(UnionOperator.java:110) at org.apache.hadoop.hive.ql.exec.Operator.initialize(Operator.java:375) at org.apache.hadoop.hive.ql.exec.Operator.initialize(Operator.java:451) at org.apache.hadoop.hive.ql.exec.Operator.initializeChildren(Operator.java:407) at org.apache.hadoop.hive.ql.exec.TableScanOperator.initializeOp(TableScanOperator.java:186) at org.apache.hadoop.hive.ql.exec.Operator.initialize(Operator.java:375) at org.apache.hadoop.hive.ql.exec.MapOperator.initializeOp(MapOperator.java:563) at org.apache.hadoop.hive.ql.exec.Operator.initialize(Operator.java:375) at org.apache.hadoop.hive.ql.exec.ExecMapper.configure(ExecMapper.java:100) ... 22 more {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4658) Make KW_OUTER optional in outer joins
[ https://issues.apache.org/jira/browse/HIVE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704101#comment-13704101 ] Brock Noland commented on HIVE-4658: Navis, sorry I was unclear. My comment "Both appear to be flaky and unrelated to the change." meant that I think those two failures were unrelated. I have seen both fail before. > Make KW_OUTER optional in outer joins > - > > Key: HIVE-4658 > URL: https://issues.apache.org/jira/browse/HIVE-4658 > Project: Hive > Issue Type: Improvement > Components: Query Processor >Reporter: Navis >Assignee: Edward Capriolo >Priority: Trivial > Attachments: hive-4658.2.patch.txt, HIVE-4658.D11091.1.patch > > > For really trivial migration issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HIVE-4832) script_pipe.q test fails on windows as streaming shell cmd requires 'cmd /c'
[ https://issues.apache.org/jira/browse/HIVE-4832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair resolved HIVE-4832. - Resolution: Invalid I was able to get it working with cygwin in path, this is not an issue. [~appodictic] I agree that we need to setup some public builds infrastructure on windows. I will talk to people here at Hortonworks and figure out what can be done. I also agree that we should try and write platform independent tests where possible. Right now, we workaround this issue on windows for many streaming tests by having cygwin on the machines. > script_pipe.q test fails on windows as streaming shell cmd requires 'cmd /c' > > > Key: HIVE-4832 > URL: https://issues.apache.org/jira/browse/HIVE-4832 > Project: Hive > Issue Type: Test > Components: Tests >Affects Versions: 0.11.0 >Reporter: Thejas M Nair >Assignee: Thejas M Nair > Labels: windows > Attachments: HIVE-4832.1.patch > > > script_pipe.q is a streaming test case that uses 'head -n 1' shell command. > On windows, for streaming, the command needs to be replaced with 'cmd /c head > -n 1' . > The wiki doc has been updated - > https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=27362047&selectedPageVersions=6&selectedPageVersions=5 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4658) Make KW_OUTER optional in outer joins
[ https://issues.apache.org/jira/browse/HIVE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704082#comment-13704082 ] Navis commented on HIVE-4658: - Brock commented two test failed. org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_mapreduce_stack_trace_hadoop20 org.apache.hcatalog.fileformats.TestOrcDynamicPartitioned.testHCatDynamicPartitionedTable Can you assert that? I cannot reproduce. > Make KW_OUTER optional in outer joins > - > > Key: HIVE-4658 > URL: https://issues.apache.org/jira/browse/HIVE-4658 > Project: Hive > Issue Type: Improvement > Components: Query Processor >Reporter: Navis >Assignee: Edward Capriolo >Priority: Trivial > Attachments: hive-4658.2.patch.txt, HIVE-4658.D11091.1.patch > > > For really trivial migration issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-556) let hive support theta join
[ https://issues.apache.org/jira/browse/HIVE-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704064#comment-13704064 ] Brock Noland commented on HIVE-556: --- Hi, I have created a design document for this JIRA on the wiki: https://cwiki.apache.org/confluence/display/Hive/Theta+Join Brock > let hive support theta join > --- > > Key: HIVE-556 > URL: https://issues.apache.org/jira/browse/HIVE-556 > Project: Hive > Issue Type: New Feature >Affects Versions: 0.4.0 >Reporter: Min Zhou >Assignee: Brock Noland > > Right now , hive only support equal joins . Sometimes it's not enough, we > must consider implementing theta joins like > {code:sql} > SELECT > a.subid, a.id, t.url > FROM > tbl t JOIN aux_tbl a ON t.url rlike a.url_pattern > WHERE > t.dt='20090609' > AND a.dt='20090609'; > {code} > any condition expression following 'ON' is appropriate. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4827) Merge a Map-only job to its following MapReduce job with multiple inputs
[ https://issues.apache.org/jira/browse/HIVE-4827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704063#comment-13704063 ] Yin Huai commented on HIVE-4827: I have been studying the code related to MapJoinOperator and CommonJoinResolver. Besides CommonJoinResolver, seems that we also need to change MapJoinOperator to load correct hash tables because some hash tables may not be needed by a MapJoinOperator. > Merge a Map-only job to its following MapReduce job with multiple inputs > > > Key: HIVE-4827 > URL: https://issues.apache.org/jira/browse/HIVE-4827 > Project: Hive > Issue Type: Improvement >Reporter: Yin Huai >Assignee: Yin Huai > > When hive.optimize.mapjoin.mapreduce is on, CommonJoinResolver can attach a > Map-only job (MapJoin) to its following MapReduce job. But this merge only > happens when the MapReduce job has a single input. With Correlation Optimizer > (HIVE-2206), it is possible that the MapReduce job can have multiple inputs > (for multiple operation paths). It is desired to improve CommonJoinResolver > to merge a Map-only job to the corresponding Map task of the MapReduce job. > Example: > {code:sql} > SELECT tmp1.key, count(*) > FROM (SELECT x1.key2 AS key > FROM bigTable1 x1 JOIN smallTable1 y1 ON (x1.key1 = y1.key1) > GROUP BY x1.key2) tmp1 > JOIN (SELECT x2.key2 AS key > FROM bigTable2 x2 JOIN smallTable2 y2 ON (x2.key1 = y2.key1) > GROUP BY x2.key2) tmp2 > ON (tmp1.key = tmp2.key) > GROUP BY tmp1.key; > {\code} > In this query, join operations inside tmp1 and tmp2 will be converted to two > MapJoins. With Correlation Optimizer, aggregations in tmp1, tmp2, and join of > tmp1 and tmp2, and the last aggregation will be executed in the same > MapReduce job (Reduce side). Since this MapReduce job has two inputs, right > now, CommonJoinResolver cannot attach two MapJoins to the Map side of a > MapReduce job. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2608) Do not require AS a,b,c part in LATERAL VIEW
[ https://issues.apache.org/jira/browse/HIVE-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HIVE-2608: -- Attachment: HIVE-2608.D4317.5.patch navis updated the revision "HIVE-2608 [jira] Do not require AS a,b,c part in LATERAL VIEW". Rebased to trunk Reviewers: JIRA REVISION DETAIL https://reviews.facebook.net/D4317 CHANGE SINCE LAST DIFF https://reviews.facebook.net/D4317?vs=14751&id=35535#toc AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/parse/FromClauseParser.g ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java ql/src/test/queries/clientpositive/lateral_view_noalias.q ql/src/test/results/clientpositive/lateral_view_noalias.q.out To: JIRA, navis Cc: ikabiljo > Do not require AS a,b,c part in LATERAL VIEW > > > Key: HIVE-2608 > URL: https://issues.apache.org/jira/browse/HIVE-2608 > Project: Hive > Issue Type: Improvement > Components: Query Processor, UDF >Affects Versions: 0.10.0 >Reporter: Igor Kabiljo >Assignee: Navis >Priority: Minor > Attachments: HIVE-2608.D4317.5.patch > > > Currently, it is required to state column names when LATERAL VIEW is used. > That shouldn't be necessary, since UDTF returns struct which contains column > names - and they should be used by default. > For example, it would be great if this was possible: > SELECT t.*, t.key1 + t.key4 > FROM some_table > LATERAL VIEW JSON_TUPLE(json, 'key1', 'key2', 'key3', 'key3') t; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2608) Do not require AS a,b,c part in LATERAL VIEW
[ https://issues.apache.org/jira/browse/HIVE-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704047#comment-13704047 ] Navis commented on HIVE-2608: - Sorry, I think it's based on other branch. Will be updated soon. > Do not require AS a,b,c part in LATERAL VIEW > > > Key: HIVE-2608 > URL: https://issues.apache.org/jira/browse/HIVE-2608 > Project: Hive > Issue Type: Improvement > Components: Query Processor, UDF >Affects Versions: 0.10.0 >Reporter: Igor Kabiljo >Assignee: Navis >Priority: Minor > > Currently, it is required to state column names when LATERAL VIEW is used. > That shouldn't be necessary, since UDTF returns struct which contains column > names - and they should be used by default. > For example, it would be great if this was possible: > SELECT t.*, t.key1 + t.key4 > FROM some_table > LATERAL VIEW JSON_TUPLE(json, 'key1', 'key2', 'key3', 'key3') t; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3630) udf_substr.q fails when using JDK7
[ https://issues.apache.org/jira/browse/HIVE-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704043#comment-13704043 ] Xuefu Zhang commented on HIVE-3630: --- I think HIVE-3630 and HIVE-3840 are dealing with two different issues: HIVE-3840 is about inconsistency of null vs NULL, while HIVE-3630 about an internal error causing a result diff of empty string vs NULL. With patch in HIVE-3840, the test fails with the following diff: [junit] 36c36 [junit] < NULL NULLNULLNULL [junit] --- [junit] > NULL NULLNULLNULLNULL [junit] 184c184 [junit] < NULL NULLNULLNULLA AB ABC ABC A AB ABC ABC B BC BC BC C C C C C C C C B BC BC BC A AB ABC ABC [junit] --- [junit] > NULL NULLNULLNULLNULLA AB ABC ABC A AB ABC ABC B BC BC BC C C C C C C C C B BC BC BC A AB ABC ABC Compare it with the original diff in JDK7: [junit] 36c36 [junit] < NULL NULLNULLNULL [junit] --- [junit] > NULL NULLNULLNULLNULL [junit] 184c184 [junit] < NULL NULLNULLNULLA AB ABC ABC A AB ABC ABC B BC BC BC C C C C C C C C B BC BC BC A AB ABC ABC [junit] --- [junit] > NULL NULLNULLNULLNULLA AB ABC ABC A AB ABC ABC B BC BC BC C C C C C C C C B BC BC BC A AB ABC ABC Please note that there is no "null" in the result any more, thanks to the patch in HIVE-3840. With patch in HIVE-3630, the test passes. In fact, with JDK7, more test failures are observed because of output ordering, probably due to the iterator behaviour difference introduced in JDK7, same cause as HIVE-3630. > udf_substr.q fails when using JDK7 > -- > > Key: HIVE-3630 > URL: https://issues.apache.org/jira/browse/HIVE-3630 > Project: Hive > Issue Type: Bug > Components: Tests >Affects Versions: 0.9.1, 0.10.0, 0.11.0 >Reporter: Chris Drome >Assignee: Chris Drome > Attachments: HIVE-3630-0.10.patch, HIVE-3630-0.9.patch, > HIVE-3630-trunk.patch > > > Internal error: Cannot find ConstantObjectInspector for BINARY > This exception has two causes. > JDK7 iterators do not return values in the same order as JDK6, which selects > a different implementation of this UDF when the first argument is null. With > JDK7 this happens to be the binary version. > The binary version is not implemented properly which ultimately causes the > exception when the method is called. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4810) Refactor exec package
[ https://issues.apache.org/jira/browse/HIVE-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704035#comment-13704035 ] Edward Capriolo commented on HIVE-4810: --- I do not think we are going about this the correct way. This is an excessively large patch on one of the keys pieces of hive. I dont think this type of thing should be done in 10 days with the +1 of only one committer, for the sole purpose of making it easier to add new cool feature x , while simultaniously sending a big fu to all the other people that have patches waiting for review for months that they will now have to rebase. I am not sure anyone has sold tez to the committers in a way that we should refactor key components of hive just so we can play with it. > Refactor exec package > - > > Key: HIVE-4810 > URL: https://issues.apache.org/jira/browse/HIVE-4810 > Project: Hive > Issue Type: Bug >Reporter: Gunther Hagleitner >Assignee: Gunther Hagleitner > Fix For: 0.12.0 > > Attachments: HIVE-4810.1.patch, HIVE-4810.2.patch, HIVE-4810.3.patch, > HIVE-4810.4.patch, HIVE-4810.5.patch, HIVE-4810.6.patch, HIVE-4810.7.patch > > > The exec package contains both operators and classes used to execute the job. > Moving the latter into a sub package makes the package slightly more > manageable and will make it easier to provide a tez-based implementation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4833) Fix eclipse template classpath to include the correct jdo lib
[ https://issues.apache.org/jira/browse/HIVE-4833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-4833: --- Resolution: Fixed Fix Version/s: 0.12.0 Status: Resolved (was: Patch Available) Committed to trunk. Thanks, Yin! > Fix eclipse template classpath to include the correct jdo lib > - > > Key: HIVE-4833 > URL: https://issues.apache.org/jira/browse/HIVE-4833 > Project: Hive > Issue Type: Bug >Reporter: Yin Huai >Assignee: Yin Huai >Priority: Trivial > Fix For: 0.12.0 > > Attachments: HIVE-4833.patch.txt > > > HIVE-4089 upgraded jdo to 3.0.1, but .classpath and classpath._hbase in > eclipse tempalte has not been changed accordingly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4833) Fix eclipse template classpath to include the correct jdo lib
[ https://issues.apache.org/jira/browse/HIVE-4833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704023#comment-13704023 ] Ashutosh Chauhan commented on HIVE-4833: +1 > Fix eclipse template classpath to include the correct jdo lib > - > > Key: HIVE-4833 > URL: https://issues.apache.org/jira/browse/HIVE-4833 > Project: Hive > Issue Type: Bug >Reporter: Yin Huai >Assignee: Yin Huai >Priority: Trivial > Attachments: HIVE-4833.patch.txt > > > HIVE-4089 upgraded jdo to 3.0.1, but .classpath and classpath._hbase in > eclipse tempalte has not been changed accordingly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4830) Test clientnegative/nested_complex_neg.q got broken due to 4580
[ https://issues.apache.org/jira/browse/HIVE-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-4830: --- Resolution: Fixed Fix Version/s: 0.12.0 Status: Resolved (was: Patch Available) Committed to trunk. Thanks, Vikram! > Test clientnegative/nested_complex_neg.q got broken due to 4580 > --- > > Key: HIVE-4830 > URL: https://issues.apache.org/jira/browse/HIVE-4830 > Project: Hive > Issue Type: Bug > Components: Tests >Affects Versions: 0.12.0 >Reporter: Ashutosh Chauhan >Assignee: Vikram Dixit K > Fix For: 0.12.0 > > Attachments: HIVE-4830.patch > > > Both HIVE-3253 and HIVE-4580 were racing to modify .q.out files for this > test. Eventually, one patch lost. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4830) Test clientnegative/nested_complex_neg.q got broken due to 4580
[ https://issues.apache.org/jira/browse/HIVE-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704016#comment-13704016 ] Ashutosh Chauhan commented on HIVE-4830: +1 > Test clientnegative/nested_complex_neg.q got broken due to 4580 > --- > > Key: HIVE-4830 > URL: https://issues.apache.org/jira/browse/HIVE-4830 > Project: Hive > Issue Type: Bug > Components: Tests >Affects Versions: 0.12.0 >Reporter: Ashutosh Chauhan >Assignee: Vikram Dixit K > Attachments: HIVE-4830.patch > > > Both HIVE-3253 and HIVE-4580 were racing to modify .q.out files for this > test. Eventually, one patch lost. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-4836) make checkstyle ignore IntelliJ files and templeton e2e files
Eugene Koifman created HIVE-4836: Summary: make checkstyle ignore IntelliJ files and templeton e2e files Key: HIVE-4836 URL: https://issues.apache.org/jira/browse/HIVE-4836 Project: Hive Issue Type: Bug Components: HCatalog Affects Versions: 0.12.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 hcatalog/build-support/ant/checkstyle.xml already has It needs to exclude the same under e2e/templeton/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4820) webhcat_config.sh should set default values for HIVE_HOME and HCAT_PREFIX that work with default build tree structure
[ https://issues.apache.org/jira/browse/HIVE-4820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eugene Koifman updated HIVE-4820: - Status: Patch Available (was: Open) > webhcat_config.sh should set default values for HIVE_HOME and HCAT_PREFIX > that work with default build tree structure > - > > Key: HIVE-4820 > URL: https://issues.apache.org/jira/browse/HIVE-4820 > Project: Hive > Issue Type: Bug > Components: HCatalog >Affects Versions: 0.12.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman > Fix For: 0.12.0 > > Attachments: HIVE4820.patch > > > Currently they are expected to be set by the user which makes development > inconvenient. > It makes writing unit tests for WebHcat more difficult as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4820) webhcat_config.sh should set default values for HIVE_HOME and HCAT_PREFIX that work with default build tree structure
[ https://issues.apache.org/jira/browse/HIVE-4820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eugene Koifman updated HIVE-4820: - Attachment: HIVE4820.patch 1. added logic in hcat/webhcat scripts to come up with defaults that make sense in the standard build tree for HIVE_HOME, HCAT_PREFIX and TEMPLETON_HOME (unless defined by user) 2. propagate the same values through Ant build files so that TestWebHCatE2e can run w/o having to define HCAT_PREFIX, HIVE_HOME explicitly. 3. improved a few error messages > webhcat_config.sh should set default values for HIVE_HOME and HCAT_PREFIX > that work with default build tree structure > - > > Key: HIVE-4820 > URL: https://issues.apache.org/jira/browse/HIVE-4820 > Project: Hive > Issue Type: Bug > Components: HCatalog >Affects Versions: 0.12.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman > Fix For: 0.12.0 > > Attachments: HIVE4820.patch > > > Currently they are expected to be set by the user which makes development > inconvenient. > It makes writing unit tests for WebHcat more difficult as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4824) make TestWebHCatE2e run w/o requiring installing external hadoop
[ https://issues.apache.org/jira/browse/HIVE-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703976#comment-13703976 ] Eugene Koifman commented on HIVE-4824: -- HIVE-4820 eliminates the need to define HIVE_HOME, HCAT_PREFIX env vars explicitly. Once this is fixed the rest of the tests in TestWebHCatE2e can be enabled. > make TestWebHCatE2e run w/o requiring installing external hadoop > > > Key: HIVE-4824 > URL: https://issues.apache.org/jira/browse/HIVE-4824 > Project: Hive > Issue Type: Bug > Components: HCatalog >Affects Versions: 0.12.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman > > Currently WebHCat will use hive/build/dist/hcatalog/bin/hcat to execute DDL > commands, which in turn uses Hadoop Jar command. > This in turn requires that HADOOP_HOME env var be defined and point to an > existing Hadoop install. > Need to see we can apply hive/testutils/hadoop idea here to make WebHCat not > depend on external hadoop. > This will make Unit tests better/easier to write and make dev/test cycle > simpler. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4835) Methods in Metrics class could avoid throwing IOException
[ https://issues.apache.org/jira/browse/HIVE-4835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703975#comment-13703975 ] Arup Malakar commented on HIVE-4835: [~thiruvel] Makes sense, that way the caller could handle failure if it prefers to, but is not forced to. > Methods in Metrics class could avoid throwing IOException > - > > Key: HIVE-4835 > URL: https://issues.apache.org/jira/browse/HIVE-4835 > Project: Hive > Issue Type: Bug >Affects Versions: 0.11.0 >Reporter: Arup Malakar >Priority: Minor > > I see that most of the methods in the Metrics class throws exception: > {code:java} > public void resetMetrics() throws IOException { > public void open() throws IOException { > public void close() throws IOException { > public void reopen() throws IOException { > public static void init() throws Exception { > public static Long incrementCounter(String name) throws IOException{ > public static Long incrementCounter(String name, long increment) throws > IOException{ > public static void set(String name, Object value) throws IOException{ > public static Object get(String name) throws IOException{ > public static void initializeScope(String name) throws IOException { > public static MetricsScope startScope(String name) throws IOException{ > public static MetricsScope getScope(String name) throws IOException { > public static void endScope(String name) throws IOException{ > {code} > I believe Metrics should be best effort and the Metrics system should just > log error messages in case it is unable to capture the Metrics. Throwing > exception makes the caller code unnecessarily lengthy. Also the caller would > never want to stop execution because of failure to capture metrics, so it > ends up just logging the exception. > The kind of code we see is like: > {code:java} > // Snippet from HiveMetaStore.java > try { > Metrics.startScope(function); > } catch (IOException e) { > LOG.debug("Exception when starting metrics scope" > + e.getClass().getName() + " " + e.getMessage()); > MetaStoreUtils.printStackTrace(e); > } > {code} > which could have been: > {code:java} > Metrics.startScope(function); > {code} > Thoughts? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4835) Methods in Metrics class could avoid throwing IOException
[ https://issues.apache.org/jira/browse/HIVE-4835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703965#comment-13703965 ] Thiruvel Thirumoolan commented on HIVE-4835: I think the method should return at-least return a boolean on whether an increment succeeded, so a corresponding decrement can be avoided if the increment failed. An incr might succeed but a decr fail, but that's again best effort to be consistent. > Methods in Metrics class could avoid throwing IOException > - > > Key: HIVE-4835 > URL: https://issues.apache.org/jira/browse/HIVE-4835 > Project: Hive > Issue Type: Bug >Affects Versions: 0.11.0 >Reporter: Arup Malakar >Priority: Minor > > I see that most of the methods in the Metrics class throws exception: > {code:java} > public void resetMetrics() throws IOException { > public void open() throws IOException { > public void close() throws IOException { > public void reopen() throws IOException { > public static void init() throws Exception { > public static Long incrementCounter(String name) throws IOException{ > public static Long incrementCounter(String name, long increment) throws > IOException{ > public static void set(String name, Object value) throws IOException{ > public static Object get(String name) throws IOException{ > public static void initializeScope(String name) throws IOException { > public static MetricsScope startScope(String name) throws IOException{ > public static MetricsScope getScope(String name) throws IOException { > public static void endScope(String name) throws IOException{ > {code} > I believe Metrics should be best effort and the Metrics system should just > log error messages in case it is unable to capture the Metrics. Throwing > exception makes the caller code unnecessarily lengthy. Also the caller would > never want to stop execution because of failure to capture metrics, so it > ends up just logging the exception. > The kind of code we see is like: > {code:java} > // Snippet from HiveMetaStore.java > try { > Metrics.startScope(function); > } catch (IOException e) { > LOG.debug("Exception when starting metrics scope" > + e.getClass().getName() + " " + e.getMessage()); > MetaStoreUtils.printStackTrace(e); > } > {code} > which could have been: > {code:java} > Metrics.startScope(function); > {code} > Thoughts? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4810) Refactor exec package
[ https://issues.apache.org/jira/browse/HIVE-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703945#comment-13703945 ] Hudson commented on HIVE-4810: -- Integrated in Hive-trunk-hadoop1-ptest #56 (See [https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/56/]) HIVE-4810 [jira] Refactor exec package (Gunther Hagleitner via Ashutosh Chauhan) Summary: HIVE-4810 The exec package contains both operators and classes used to execute the job. Moving the latter into a sub package makes the package slightly more manageable and will make it easier to provide a tez-based implementation. Test Plan: Refactoring Reviewers: ashutoshc Reviewed By: ashutoshc Differential Revision: https://reviews.facebook.net/D11625 (Revision 1501476) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501476 Files : * /hive/trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java * /hive/trunk/contrib/src/test/results/clientnegative/case_with_row_sequence.q.out * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExecMapper.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExecMapperContext.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExecReducer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHook.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JobDebugger.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JobTrackerURLResolver.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapRedTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapredContext.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapredLocalTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Throttle.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapper.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapperContext.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHook.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/JobDebugger.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/JobTrackerURLResolver.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/Throttle.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveInputSplit.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveRecordReader.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveRecordReader.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/BlockMergeTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AbstractJoinTaskDispatcher.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/BucketingSortingInferenceOptimizer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MapJoinResolver.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SamplingOp
[jira] [Updated] (HIVE-4834) Hive eclipse classpath update for jdo
[ https://issues.apache.org/jira/browse/HIVE-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikram Dixit K updated HIVE-4834: - Resolution: Duplicate Status: Resolved (was: Patch Available) > Hive eclipse classpath update for jdo > - > > Key: HIVE-4834 > URL: https://issues.apache.org/jira/browse/HIVE-4834 > Project: Hive > Issue Type: Bug >Reporter: Vikram Dixit K >Assignee: Vikram Dixit K >Priority: Minor > Attachments: HIVE-4834.patch > > > The eclipse template files point to an invalid jdo version. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4835) Methods in Metrics class could avoid throwing IOException
[ https://issues.apache.org/jira/browse/HIVE-4835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703934#comment-13703934 ] Sushanth Sowmyan commented on HIVE-4835: Agreed, that should make a lot of the metrics calls simpler, and will clean up calling code. > Methods in Metrics class could avoid throwing IOException > - > > Key: HIVE-4835 > URL: https://issues.apache.org/jira/browse/HIVE-4835 > Project: Hive > Issue Type: Bug >Affects Versions: 0.11.0 >Reporter: Arup Malakar >Priority: Minor > > I see that most of the methods in the Metrics class throws exception: > {code:java} > public void resetMetrics() throws IOException { > public void open() throws IOException { > public void close() throws IOException { > public void reopen() throws IOException { > public static void init() throws Exception { > public static Long incrementCounter(String name) throws IOException{ > public static Long incrementCounter(String name, long increment) throws > IOException{ > public static void set(String name, Object value) throws IOException{ > public static Object get(String name) throws IOException{ > public static void initializeScope(String name) throws IOException { > public static MetricsScope startScope(String name) throws IOException{ > public static MetricsScope getScope(String name) throws IOException { > public static void endScope(String name) throws IOException{ > {code} > I believe Metrics should be best effort and the Metrics system should just > log error messages in case it is unable to capture the Metrics. Throwing > exception makes the caller code unnecessarily lengthy. Also the caller would > never want to stop execution because of failure to capture metrics, so it > ends up just logging the exception. > The kind of code we see is like: > {code:java} > // Snippet from HiveMetaStore.java > try { > Metrics.startScope(function); > } catch (IOException e) { > LOG.debug("Exception when starting metrics scope" > + e.getClass().getName() + " " + e.getMessage()); > MetaStoreUtils.printStackTrace(e); > } > {code} > which could have been: > {code:java} > Metrics.startScope(function); > {code} > Thoughts? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4835) Methods in Metrics class could avoid throwing IOException
[ https://issues.apache.org/jira/browse/HIVE-4835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703914#comment-13703914 ] Ashutosh Chauhan commented on HIVE-4835: I agree. Metrics is best effort, throwing exceptions from it is not best of the ideas. CC'ing [~sushanth] who originally authored this class. > Methods in Metrics class could avoid throwing IOException > - > > Key: HIVE-4835 > URL: https://issues.apache.org/jira/browse/HIVE-4835 > Project: Hive > Issue Type: Bug >Affects Versions: 0.11.0 >Reporter: Arup Malakar >Priority: Minor > > I see that most of the methods in the Metrics class throws exception: > {code:java} > public void resetMetrics() throws IOException { > public void open() throws IOException { > public void close() throws IOException { > public void reopen() throws IOException { > public static void init() throws Exception { > public static Long incrementCounter(String name) throws IOException{ > public static Long incrementCounter(String name, long increment) throws > IOException{ > public static void set(String name, Object value) throws IOException{ > public static Object get(String name) throws IOException{ > public static void initializeScope(String name) throws IOException { > public static MetricsScope startScope(String name) throws IOException{ > public static MetricsScope getScope(String name) throws IOException { > public static void endScope(String name) throws IOException{ > {code} > I believe Metrics should be best effort and the Metrics system should just > log error messages in case it is unable to capture the Metrics. Throwing > exception makes the caller code unnecessarily lengthy. Also the caller would > never want to stop execution because of failure to capture metrics, so it > ends up just logging the exception. > The kind of code we see is like: > {code:java} > // Snippet from HiveMetaStore.java > try { > Metrics.startScope(function); > } catch (IOException e) { > LOG.debug("Exception when starting metrics scope" > + e.getClass().getName() + " " + e.getMessage()); > MetaStoreUtils.printStackTrace(e); > } > {code} > which could have been: > {code:java} > Metrics.startScope(function); > {code} > Thoughts? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-4835) Methods in Metrics class could avoid throwing IOException
Arup Malakar created HIVE-4835: -- Summary: Methods in Metrics class could avoid throwing IOException Key: HIVE-4835 URL: https://issues.apache.org/jira/browse/HIVE-4835 Project: Hive Issue Type: Bug Affects Versions: 0.11.0 Reporter: Arup Malakar Priority: Minor I see that most of the methods in the Metrics class throws exception: {code:java} public void resetMetrics() throws IOException { public void open() throws IOException { public void close() throws IOException { public void reopen() throws IOException { public static void init() throws Exception { public static Long incrementCounter(String name) throws IOException{ public static Long incrementCounter(String name, long increment) throws IOException{ public static void set(String name, Object value) throws IOException{ public static Object get(String name) throws IOException{ public static void initializeScope(String name) throws IOException { public static MetricsScope startScope(String name) throws IOException{ public static MetricsScope getScope(String name) throws IOException { public static void endScope(String name) throws IOException{ {code} I believe Metrics should be best effort and the Metrics system should just log error messages in case it is unable to capture the Metrics. Throwing exception makes the caller code unnecessarily lengthy. Also the caller would never want to stop execution because of failure to capture metrics, so it ends up just logging the exception. The kind of code we see is like: {code:java} // Snippet from HiveMetaStore.java try { Metrics.startScope(function); } catch (IOException e) { LOG.debug("Exception when starting metrics scope" + e.getClass().getName() + " " + e.getMessage()); MetaStoreUtils.printStackTrace(e); } {code} which could have been: {code:java} Metrics.startScope(function); {code} Thoughts? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4833) Fix eclipse template classpath to include the correct jdo lib
[ https://issues.apache.org/jira/browse/HIVE-4833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yin Huai updated HIVE-4833: --- Attachment: (was: HIVE-4833.patch.txt) > Fix eclipse template classpath to include the correct jdo lib > - > > Key: HIVE-4833 > URL: https://issues.apache.org/jira/browse/HIVE-4833 > Project: Hive > Issue Type: Bug >Reporter: Yin Huai >Assignee: Yin Huai >Priority: Trivial > Attachments: HIVE-4833.patch.txt > > > HIVE-4089 upgraded jdo to 3.0.1, but .classpath and classpath._hbase in > eclipse tempalte has not been changed accordingly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4833) Fix eclipse template classpath to include the correct jdo lib
[ https://issues.apache.org/jira/browse/HIVE-4833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yin Huai updated HIVE-4833: --- Attachment: HIVE-4833.patch.txt > Fix eclipse template classpath to include the correct jdo lib > - > > Key: HIVE-4833 > URL: https://issues.apache.org/jira/browse/HIVE-4833 > Project: Hive > Issue Type: Bug >Reporter: Yin Huai >Assignee: Yin Huai >Priority: Trivial > Attachments: HIVE-4833.patch.txt > > > HIVE-4089 upgraded jdo to 3.0.1, but .classpath and classpath._hbase in > eclipse tempalte has not been changed accordingly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4833) Fix eclipse template classpath to include the correct jdo lib
[ https://issues.apache.org/jira/browse/HIVE-4833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yin Huai updated HIVE-4833: --- Status: Patch Available (was: Open) > Fix eclipse template classpath to include the correct jdo lib > - > > Key: HIVE-4833 > URL: https://issues.apache.org/jira/browse/HIVE-4833 > Project: Hive > Issue Type: Bug >Reporter: Yin Huai >Assignee: Yin Huai >Priority: Trivial > Attachments: HIVE-4833.patch.txt > > > HIVE-4089 upgraded jdo to 3.0.1, but .classpath and classpath._hbase in > eclipse tempalte has not been changed accordingly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4833) Fix eclipse template classpath to include the correct jdo lib
[ https://issues.apache.org/jira/browse/HIVE-4833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yin Huai updated HIVE-4833: --- Attachment: HIVE-4833.patch.txt > Fix eclipse template classpath to include the correct jdo lib > - > > Key: HIVE-4833 > URL: https://issues.apache.org/jira/browse/HIVE-4833 > Project: Hive > Issue Type: Bug >Reporter: Yin Huai >Assignee: Yin Huai >Priority: Trivial > Attachments: HIVE-4833.patch.txt > > > HIVE-4089 upgraded jdo to 3.0.1, but .classpath and classpath._hbase in > eclipse tempalte has not been changed accordingly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4834) Hive eclipse classpath update for jdo
[ https://issues.apache.org/jira/browse/HIVE-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikram Dixit K updated HIVE-4834: - Status: Patch Available (was: Open) > Hive eclipse classpath update for jdo > - > > Key: HIVE-4834 > URL: https://issues.apache.org/jira/browse/HIVE-4834 > Project: Hive > Issue Type: Bug >Reporter: Vikram Dixit K >Assignee: Vikram Dixit K >Priority: Minor > Attachments: HIVE-4834.patch > > > The eclipse template files point to an invalid jdo version. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4834) Hive eclipse classpath update for jdo
[ https://issues.apache.org/jira/browse/HIVE-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikram Dixit K updated HIVE-4834: - Attachment: HIVE-4834.patch > Hive eclipse classpath update for jdo > - > > Key: HIVE-4834 > URL: https://issues.apache.org/jira/browse/HIVE-4834 > Project: Hive > Issue Type: Bug >Reporter: Vikram Dixit K >Assignee: Vikram Dixit K >Priority: Minor > Attachments: HIVE-4834.patch > > > The eclipse template files point to an invalid jdo version. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-4834) Hive eclipse classpath update for jdo
Vikram Dixit K created HIVE-4834: Summary: Hive eclipse classpath update for jdo Key: HIVE-4834 URL: https://issues.apache.org/jira/browse/HIVE-4834 Project: Hive Issue Type: Bug Reporter: Vikram Dixit K Assignee: Vikram Dixit K Priority: Minor The eclipse template files point to an invalid jdo version. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-4833) Fix eclipse template classpath to include the correct jdo lib
Yin Huai created HIVE-4833: -- Summary: Fix eclipse template classpath to include the correct jdo lib Key: HIVE-4833 URL: https://issues.apache.org/jira/browse/HIVE-4833 Project: Hive Issue Type: Bug Reporter: Yin Huai Assignee: Yin Huai Priority: Trivial HIVE-4089 upgraded jdo to 3.0.1, but .classpath and classpath._hbase in eclipse tempalte has not been changed accordingly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4832) script_pipe.q test fails on windows as streaming shell cmd requires 'cmd /c'
[ https://issues.apache.org/jira/browse/HIVE-4832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703815#comment-13703815 ] Edward Capriolo commented on HIVE-4832: --- We should stream only to java processes in our test cases so they are platform independent and we can avoid all these IFWINDOWZ hacks. http://my.safaribooksonline.com/book/databases/hadoop/9781449326944/14dot-streaming/_genericmr_tools_for_streaming_to_java_html > script_pipe.q test fails on windows as streaming shell cmd requires 'cmd /c' > > > Key: HIVE-4832 > URL: https://issues.apache.org/jira/browse/HIVE-4832 > Project: Hive > Issue Type: Test > Components: Tests >Affects Versions: 0.11.0 >Reporter: Thejas M Nair >Assignee: Thejas M Nair > Labels: windows > Attachments: HIVE-4832.1.patch > > > script_pipe.q is a streaming test case that uses 'head -n 1' shell command. > On windows, for streaming, the command needs to be replaced with 'cmd /c head > -n 1' . > The wiki doc has been updated - > https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=27362047&selectedPageVersions=6&selectedPageVersions=5 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4830) Test clientnegative/nested_complex_neg.q got broken due to 4580
[ https://issues.apache.org/jira/browse/HIVE-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikram Dixit K updated HIVE-4830: - Status: Patch Available (was: Open) Updated the q file output. > Test clientnegative/nested_complex_neg.q got broken due to 4580 > --- > > Key: HIVE-4830 > URL: https://issues.apache.org/jira/browse/HIVE-4830 > Project: Hive > Issue Type: Bug > Components: Tests >Affects Versions: 0.12.0 >Reporter: Ashutosh Chauhan >Assignee: Vikram Dixit K > Attachments: HIVE-4830.patch > > > Both HIVE-3253 and HIVE-4580 were racing to modify .q.out files for this > test. Eventually, one patch lost. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4830) Test clientnegative/nested_complex_neg.q got broken due to 4580
[ https://issues.apache.org/jira/browse/HIVE-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikram Dixit K updated HIVE-4830: - Assignee: Vikram Dixit K > Test clientnegative/nested_complex_neg.q got broken due to 4580 > --- > > Key: HIVE-4830 > URL: https://issues.apache.org/jira/browse/HIVE-4830 > Project: Hive > Issue Type: Bug > Components: Tests >Affects Versions: 0.12.0 >Reporter: Ashutosh Chauhan >Assignee: Vikram Dixit K > Attachments: HIVE-4830.patch > > > Both HIVE-3253 and HIVE-4580 were racing to modify .q.out files for this > test. Eventually, one patch lost. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4832) script_pipe.q test fails on windows as streaming shell cmd requires 'cmd /c'
[ https://issues.apache.org/jira/browse/HIVE-4832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703805#comment-13703805 ] Edward Capriolo commented on HIVE-4832: --- This is getting really ludicrous that we are trying to support hive on windows, and we literally have no way to test anything. > script_pipe.q test fails on windows as streaming shell cmd requires 'cmd /c' > > > Key: HIVE-4832 > URL: https://issues.apache.org/jira/browse/HIVE-4832 > Project: Hive > Issue Type: Test > Components: Tests >Affects Versions: 0.11.0 >Reporter: Thejas M Nair >Assignee: Thejas M Nair > Labels: windows > Attachments: HIVE-4832.1.patch > > > script_pipe.q is a streaming test case that uses 'head -n 1' shell command. > On windows, for streaming, the command needs to be replaced with 'cmd /c head > -n 1' . > The wiki doc has been updated - > https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=27362047&selectedPageVersions=6&selectedPageVersions=5 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4830) Test clientnegative/nested_complex_neg.q got broken due to 4580
[ https://issues.apache.org/jira/browse/HIVE-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikram Dixit K updated HIVE-4830: - Attachment: HIVE-4830.patch Updated the output file. > Test clientnegative/nested_complex_neg.q got broken due to 4580 > --- > > Key: HIVE-4830 > URL: https://issues.apache.org/jira/browse/HIVE-4830 > Project: Hive > Issue Type: Bug > Components: Tests >Affects Versions: 0.12.0 >Reporter: Ashutosh Chauhan > Attachments: HIVE-4830.patch > > > Both HIVE-3253 and HIVE-4580 were racing to modify .q.out files for this > test. Eventually, one patch lost. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4832) script_pipe.q test fails on windows as streaming shell cmd requires 'cmd /c'
[ https://issues.apache.org/jira/browse/HIVE-4832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-4832: Attachment: HIVE-4832.1.patch HIVE-4832.1.patch - excludes script_pipe.q from windows, and adds a new test case script_pipe_win.q that is run only on windows. > script_pipe.q test fails on windows as streaming shell cmd requires 'cmd /c' > > > Key: HIVE-4832 > URL: https://issues.apache.org/jira/browse/HIVE-4832 > Project: Hive > Issue Type: Test > Components: Tests >Affects Versions: 0.11.0 >Reporter: Thejas M Nair >Assignee: Thejas M Nair > Labels: windows > Attachments: HIVE-4832.1.patch > > > script_pipe.q is a streaming test case that uses 'head -n 1' shell command. > On windows, for streaming, the command needs to be replaced with 'cmd /c head > -n 1' . > The wiki doc has been updated - > https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=27362047&selectedPageVersions=6&selectedPageVersions=5 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-4832) script_pipe.q test fails on windows as streaming shell cmd requires 'cmd /c'
Thejas M Nair created HIVE-4832: --- Summary: script_pipe.q test fails on windows as streaming shell cmd requires 'cmd /c' Key: HIVE-4832 URL: https://issues.apache.org/jira/browse/HIVE-4832 Project: Hive Issue Type: Test Components: Tests Affects Versions: 0.11.0 Reporter: Thejas M Nair Assignee: Thejas M Nair script_pipe.q is a streaming test case that uses 'head -n 1' shell command. On windows, for streaming, the command needs to be replaced with 'cmd /c head -n 1' . The wiki doc has been updated - https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=27362047&selectedPageVersions=6&selectedPageVersions=5 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3810) HiveHistory.log need to replace '\r' with space before writing Entry.value to historyfile
[ https://issues.apache.org/jira/browse/HIVE-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703737#comment-13703737 ] Hudson commented on HIVE-3810: -- Integrated in Hive-trunk-h0.21 #2188 (See [https://builds.apache.org/job/Hive-trunk-h0.21/2188/]) HIVE-3810 : HiveHistory.log need to replace \r with space before writing Entry.value to historyfile (Mark Grover via Ashutosh Chauhan) (Revision 1500991) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1500991 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java > HiveHistory.log need to replace '\r' with space before writing Entry.value to > historyfile > - > > Key: HIVE-3810 > URL: https://issues.apache.org/jira/browse/HIVE-3810 > Project: Hive > Issue Type: Bug > Components: Logging >Reporter: qiangwang >Assignee: Mark Grover >Priority: Minor > Fix For: 0.12.0 > > Attachments: HIVE-3810.1.patch, HIVE-3810.2.patch, HIVE-3810.3.patch, > HIVE-3810.4.patch > > > HiveHistory.log will replace '\n' with space before writing Entry.value to > history file: > val = val.replace('\n', ' '); > but HiveHistory.parseHiveHistory use BufferedReader.readLine which takes > '\n', '\r', '\r\n' as line delimiter to parse history file > if val contains '\r', there is a high possibility that HiveHistory.parseLine > will fail, in which case usually RecordTypes.valueOf(recType) will throw > exception 'java.lang.IllegalArgumentException' > HiveHistory.log need to replace '\r' with space as well: > val = val.replace('\n', ' '); > changed to > val = val.replaceAll("\r|\n", " "); > or > val = val.replace('\r', ' ').replace('\n', ' '); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4796) Increase coverage of package org.apache.hadoop.hive.common.metrics
[ https://issues.apache.org/jira/browse/HIVE-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703738#comment-13703738 ] Hudson commented on HIVE-4796: -- Integrated in Hive-trunk-h0.21 #2188 (See [https://builds.apache.org/job/Hive-trunk-h0.21/2188/]) HIVE-4796 : Increase coverage of package org.apache.hadoop.hive.common.metrics (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1501052) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501052 Files : * /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java * /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java * /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java * /hive/trunk/common/src/test/org/apache/hadoop/hive/common * /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics * /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java > Increase coverage of package org.apache.hadoop.hive.common.metrics > -- > > Key: HIVE-4796 > URL: https://issues.apache.org/jira/browse/HIVE-4796 > Project: Hive > Issue Type: Test >Affects Versions: 0.12.0 >Reporter: Ivan A. Veselovsky >Assignee: Ivan A. Veselovsky > Fix For: 0.12.0 > > Attachments: HIVE-4796-trunk--N1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4812) Logical explain plan
[ https://issues.apache.org/jira/browse/HIVE-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703735#comment-13703735 ] Hudson commented on HIVE-4812: -- Integrated in Hive-trunk-h0.21 #2188 (See [https://builds.apache.org/job/Hive-trunk-h0.21/2188/]) HIVE-4812 : Logical explain plan (Gunther Hagleitner V via Navis) (Revision 1501036) Result = ABORTED navis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501036 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Context.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExplainWork.java * /hive/trunk/ql/src/test/queries/clientpositive/explain_logical.q * /hive/trunk/ql/src/test/results/clientpositive/explain_logical.q.out > Logical explain plan > > > Key: HIVE-4812 > URL: https://issues.apache.org/jira/browse/HIVE-4812 > Project: Hive > Issue Type: Bug > Components: Diagnosability >Reporter: Gunther Hagleitner >Assignee: Gunther Hagleitner > Fix For: 0.12.0 > > Attachments: HIVE-4812.1.patch, HIVE-4812.2.patch, HIVE-4812.3.patch > > > In various situations it would have been useful to me to glance at the > operator plan before we break it into tasks and apply join, total order sort, > etc optimizations. > I've added this as an options to explain. "Explain logical " will > output the full operator tree (not the stage plans, tasks, AST etc). > Again, I don't think this has to even be documented for users, but might be > useful to developers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4813) Improve test coverage of package org.apache.hadoop.hive.ql.optimizer.pcr
[ https://issues.apache.org/jira/browse/HIVE-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703736#comment-13703736 ] Hudson commented on HIVE-4813: -- Integrated in Hive-trunk-h0.21 #2188 (See [https://builds.apache.org/job/Hive-trunk-h0.21/2188/]) HIVE-4813 : Improve test coverage of package org.apache.hadoop.hive.ql.optimizer.pcr (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1501099) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501099 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/lib/DefaultRuleDispatcher.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/lib/RuleRegExp.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcCtx.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java * /hive/trunk/ql/src/test/queries/clientpositive/pcr.q * /hive/trunk/ql/src/test/results/clientpositive/pcr.q.out > Improve test coverage of package org.apache.hadoop.hive.ql.optimizer.pcr > > > Key: HIVE-4813 > URL: https://issues.apache.org/jira/browse/HIVE-4813 > Project: Hive > Issue Type: Test >Affects Versions: 0.12.0 >Reporter: Ivan A. Veselovsky >Assignee: Ivan A. Veselovsky > Fix For: 0.12.0 > > Attachments: HIVE-4813-trunk--N1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703734#comment-13703734 ] Hudson commented on HIVE-4580: -- Integrated in Hive-trunk-h0.21 #2188 (See [https://builds.apache.org/job/Hive-trunk-h0.21/2188/]) HIVE-4580 : Change DDLTask to report errors using canonical error messages rather than http status codes (Eugene Koifman via Ashutosh Chauhan) (Revision 1501053) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501053 Files : * /hive/trunk/contrib/src/test/results/clientnegative/serde_regex.q.out * /hive/trunk/contrib/src/test/results/clientnegative/url_hook.q.out * /hive/trunk/hcatalog/src/test/e2e/templeton/tests/ddl.conf * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/AppConfig.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/BadParam.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/BusyException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/CallbackFailedException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/CatchallExceptionMapper.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/HcatDelegator.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/HcatException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/JsonBuilder.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/Main.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/NotAuthorizedException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/QueueException.java * /hive/trunk/hcatalog/webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestWebHCatE2e.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskResult.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveException.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/InvalidTableException.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java * /hive/trunk/ql/src/test/results/clientnegative/add_partition_with_whitelist.q.out * /hive/trunk/ql/src/test/results/clientnegative/addpart1.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_partition_nodrop_table.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_partition_with_whitelist.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure2.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure3.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_table_wrong_regex.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_view_failure4.q.out * /hive/trunk/ql/src/test/results/clientnegative/altern1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive2.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi2.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi3.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi4.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi5.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi6.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi7.q.out * /hive/trunk/ql/src/test/results/clientnegative/authorization_fail_1.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename1.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename2.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename4.q.out * /hive/trunk/ql/src/test/results/clientnegative/create_table_failure3.q.out * /hive/trunk/ql/src/test/results/clientnegative/create_table_failure4.q.out * /h
[jira] [Updated] (HIVE-4831) QTestUtil based test exiting abnormally on windows fails startup of other QTestUtil tests
[ https://issues.apache.org/jira/browse/HIVE-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-4831: Status: Patch Available (was: Open) > QTestUtil based test exiting abnormally on windows fails startup of other > QTestUtil tests > - > > Key: HIVE-4831 > URL: https://issues.apache.org/jira/browse/HIVE-4831 > Project: Hive > Issue Type: Bug > Components: Testing Infrastructure >Affects Versions: 0.11.0 >Reporter: Thejas M Nair >Assignee: Thejas M Nair > Attachments: HIVE-4831.1.patch > > > QTestUtil tests start mini zookeeper cluster. If it exits abnormally (eg > timeout), it fails to stop the zookeeper mini cluster. On Windows when the > process is still running the files can't be deleted, and as a result the new > zookeeper cluster started by a new QFileUtil based test case fails to start. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4831) QTestUtil based test exiting abnormally on windows fails startup of other QTestUtil tests
[ https://issues.apache.org/jira/browse/HIVE-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-4831: Attachment: HIVE-4831.1.patch HIVE-4831.1.patch - change to pick a different directory for use by zookeeper mini cluster > QTestUtil based test exiting abnormally on windows fails startup of other > QTestUtil tests > - > > Key: HIVE-4831 > URL: https://issues.apache.org/jira/browse/HIVE-4831 > Project: Hive > Issue Type: Bug > Components: Testing Infrastructure >Affects Versions: 0.11.0 >Reporter: Thejas M Nair >Assignee: Thejas M Nair > Attachments: HIVE-4831.1.patch > > > QTestUtil tests start mini zookeeper cluster. If it exits abnormally (eg > timeout), it fails to stop the zookeeper mini cluster. On Windows when the > process is still running the files can't be deleted, and as a result the new > zookeeper cluster started by a new QFileUtil based test case fails to start. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-4831) QTestUtil based test exiting abnormally on windows fails startup of other QTestUtil tests
Thejas M Nair created HIVE-4831: --- Summary: QTestUtil based test exiting abnormally on windows fails startup of other QTestUtil tests Key: HIVE-4831 URL: https://issues.apache.org/jira/browse/HIVE-4831 Project: Hive Issue Type: Bug Components: Testing Infrastructure Affects Versions: 0.11.0 Reporter: Thejas M Nair Assignee: Thejas M Nair QTestUtil tests start mini zookeeper cluster. If it exits abnormally (eg timeout), it fails to stop the zookeeper mini cluster. On Windows when the process is still running the files can't be deleted, and as a result the new zookeeper cluster started by a new QFileUtil based test case fails to start. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4830) Test clientnegative/nested_complex_neg.q got broken due to 4580
[ https://issues.apache.org/jira/browse/HIVE-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703690#comment-13703690 ] Ashutosh Chauhan commented on HIVE-4830: Simply need to update .q.out file. > Test clientnegative/nested_complex_neg.q got broken due to 4580 > --- > > Key: HIVE-4830 > URL: https://issues.apache.org/jira/browse/HIVE-4830 > Project: Hive > Issue Type: Bug > Components: Tests >Affects Versions: 0.12.0 >Reporter: Ashutosh Chauhan > > Both HIVE-3253 and HIVE-4580 were racing to modify .q.out files for this > test. Eventually, one patch lost. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-4830) Test clientnegative/nested_complex_neg.q got broken due to 4580
Ashutosh Chauhan created HIVE-4830: -- Summary: Test clientnegative/nested_complex_neg.q got broken due to 4580 Key: HIVE-4830 URL: https://issues.apache.org/jira/browse/HIVE-4830 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 0.12.0 Reporter: Ashutosh Chauhan Both HIVE-3253 and HIVE-4580 were racing to modify .q.out files for this test. Eventually, one patch lost. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4815) Create cloud hosting option for ptest2
[ https://issues.apache.org/jira/browse/HIVE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703689#comment-13703689 ] Brock Noland commented on HIVE-4815: The parallel tests are currently failing despite HIVE-4829 being fixed because ptest only understands git, therefore pulls from github.com/apache/hive. I'll fix this so it can pull from svn. > Create cloud hosting option for ptest2 > -- > > Key: HIVE-4815 > URL: https://issues.apache.org/jira/browse/HIVE-4815 > Project: Hive > Issue Type: New Feature >Reporter: Brock Noland >Assignee: Brock Noland > Fix For: 0.12.0 > > Attachments: HIVE-4815.patch, HIVE-4815.patch, HIVE-4815.patch, > HIVE-4815.patch, HIVE-4815.patch, HIVE-4815.patch > > > HIVE-4675 creates a parallel testing environment. To support HIVE-4739 we > should allow this environment to run in a cloud environment. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HIVE-4810) Refactor exec package
[ https://issues.apache.org/jira/browse/HIVE-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan resolved HIVE-4810. Resolution: Fixed Fix Version/s: 0.12.0 Committed to trunk. Thanks, Gunther! > Refactor exec package > - > > Key: HIVE-4810 > URL: https://issues.apache.org/jira/browse/HIVE-4810 > Project: Hive > Issue Type: Bug >Reporter: Gunther Hagleitner >Assignee: Gunther Hagleitner > Fix For: 0.12.0 > > Attachments: HIVE-4810.1.patch, HIVE-4810.2.patch, HIVE-4810.3.patch, > HIVE-4810.4.patch, HIVE-4810.5.patch, HIVE-4810.6.patch, HIVE-4810.7.patch > > > The exec package contains both operators and classes used to execute the job. > Moving the latter into a sub package makes the package slightly more > manageable and will make it easier to provide a tez-based implementation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4829) TestWebHCatE2e checkstyle violation causes all tests to fail
[ https://issues.apache.org/jira/browse/HIVE-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703686#comment-13703686 ] Hudson commented on HIVE-4829: -- Integrated in Hive-trunk-hadoop1-ptest #55 (See [https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/55/]) HIVE-4829 : TestWebHCatE2e checkstyle violation causes all tests to fail (Eugene Koifman via Ashutosh Chauhan) (Revision 1501463) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501463 Files : * /hive/trunk/hcatalog/webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestWebHCatE2e.java > TestWebHCatE2e checkstyle violation causes all tests to fail > > > Key: HIVE-4829 > URL: https://issues.apache.org/jira/browse/HIVE-4829 > Project: Hive > Issue Type: Bug > Components: HCatalog >Reporter: Brock Noland >Assignee: Eugene Koifman >Priority: Critical > Fix For: 0.12.0 > > Attachments: HIVE-4829.patch > > > The following error caused all tests to fail and thus filled up the ptest > systems drives. > {noformat} > [echo] hcatalog > [checkstyle] Running Checkstyle 5.5 on 419 files > [checkstyle] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestWebHCatE2e.java:31:8: > Unused import - org.junit.BeforeClass. > [for] hcatalog: The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/build.xml:310: > The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/build.xml:123: > The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/build-support/ant/checkstyle.xml:32: > Got 1 errors and 0 warnings. > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4829) TestWebHCatE2e checkstyle violation causes all tests to fail
[ https://issues.apache.org/jira/browse/HIVE-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-4829: --- Resolution: Fixed Fix Version/s: 0.12.0 Status: Resolved (was: Patch Available) Committed to trunk. Thanks, Eugene! > TestWebHCatE2e checkstyle violation causes all tests to fail > > > Key: HIVE-4829 > URL: https://issues.apache.org/jira/browse/HIVE-4829 > Project: Hive > Issue Type: Bug > Components: HCatalog >Reporter: Brock Noland >Assignee: Eugene Koifman >Priority: Critical > Fix For: 0.12.0 > > Attachments: HIVE-4829.patch > > > The following error caused all tests to fail and thus filled up the ptest > systems drives. > {noformat} > [echo] hcatalog > [checkstyle] Running Checkstyle 5.5 on 419 files > [checkstyle] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestWebHCatE2e.java:31:8: > Unused import - org.junit.BeforeClass. > [for] hcatalog: The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/build.xml:310: > The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/build.xml:123: > The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/build-support/ant/checkstyle.xml:32: > Got 1 errors and 0 warnings. > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4829) TestWebHCatE2e checkstyle violation causes all tests to fail
[ https://issues.apache.org/jira/browse/HIVE-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703657#comment-13703657 ] Brock Noland commented on HIVE-4829: Thanks for the quick turnaround on this! > TestWebHCatE2e checkstyle violation causes all tests to fail > > > Key: HIVE-4829 > URL: https://issues.apache.org/jira/browse/HIVE-4829 > Project: Hive > Issue Type: Bug > Components: HCatalog >Reporter: Brock Noland >Assignee: Eugene Koifman >Priority: Critical > Fix For: 0.12.0 > > Attachments: HIVE-4829.patch > > > The following error caused all tests to fail and thus filled up the ptest > systems drives. > {noformat} > [echo] hcatalog > [checkstyle] Running Checkstyle 5.5 on 419 files > [checkstyle] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestWebHCatE2e.java:31:8: > Unused import - org.junit.BeforeClass. > [for] hcatalog: The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/build.xml:310: > The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/build.xml:123: > The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/build-support/ant/checkstyle.xml:32: > Got 1 errors and 0 warnings. > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4829) TestWebHCatE2e checkstyle violation causes all tests to fail
[ https://issues.apache.org/jira/browse/HIVE-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eugene Koifman updated HIVE-4829: - Component/s: HCatalog > TestWebHCatE2e checkstyle violation causes all tests to fail > > > Key: HIVE-4829 > URL: https://issues.apache.org/jira/browse/HIVE-4829 > Project: Hive > Issue Type: Bug > Components: HCatalog >Reporter: Brock Noland >Assignee: Eugene Koifman >Priority: Critical > Attachments: HIVE-4829.patch > > > The following error caused all tests to fail and thus filled up the ptest > systems drives. > {noformat} > [echo] hcatalog > [checkstyle] Running Checkstyle 5.5 on 419 files > [checkstyle] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestWebHCatE2e.java:31:8: > Unused import - org.junit.BeforeClass. > [for] hcatalog: The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/build.xml:310: > The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/build.xml:123: > The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/build-support/ant/checkstyle.xml:32: > Got 1 errors and 0 warnings. > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4824) make TestWebHCatE2e run w/o requiring installing external hadoop
[ https://issues.apache.org/jira/browse/HIVE-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eugene Koifman updated HIVE-4824: - Component/s: HCatalog > make TestWebHCatE2e run w/o requiring installing external hadoop > > > Key: HIVE-4824 > URL: https://issues.apache.org/jira/browse/HIVE-4824 > Project: Hive > Issue Type: Bug > Components: HCatalog >Affects Versions: 0.12.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman > > Currently WebHCat will use hive/build/dist/hcatalog/bin/hcat to execute DDL > commands, which in turn uses Hadoop Jar command. > This in turn requires that HADOOP_HOME env var be defined and point to an > existing Hadoop install. > Need to see we can apply hive/testutils/hadoop idea here to make WebHCat not > depend on external hadoop. > This will make Unit tests better/easier to write and make dev/test cycle > simpler. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4801) output deprecation warning for hive.mapred.map.tasks.speculative.execution
[ https://issues.apache.org/jira/browse/HIVE-4801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chu Tong updated HIVE-4801: --- Description: Output deprecation warning for hive.mapred.map.tasks.speculative.execution, use are encouraged to use (was: Hive does not honor hive.mapred.map.tasks.speculative.execution parameter while it comes to configuring hadoop jobs.) > output deprecation warning for hive.mapred.map.tasks.speculative.execution > -- > > Key: HIVE-4801 > URL: https://issues.apache.org/jira/browse/HIVE-4801 > Project: Hive > Issue Type: Bug > Components: Configuration >Affects Versions: 0.10.0 >Reporter: Chu Tong >Assignee: Chu Tong > Attachments: HIVE-4801.patch, HIVE-4801.patch > > > Output deprecation warning for hive.mapred.map.tasks.speculative.execution, > use are encouraged to use -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4801) output deprecation warning for hive.mapred.map.tasks.speculative.execution
[ https://issues.apache.org/jira/browse/HIVE-4801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chu Tong updated HIVE-4801: --- Status: Patch Available (was: Open) > output deprecation warning for hive.mapred.map.tasks.speculative.execution > -- > > Key: HIVE-4801 > URL: https://issues.apache.org/jira/browse/HIVE-4801 > Project: Hive > Issue Type: Bug > Components: Configuration >Affects Versions: 0.10.0 >Reporter: Chu Tong >Assignee: Chu Tong > Attachments: HIVE-4801.patch, HIVE-4801.patch > > > Output deprecation warning for hive.mapred.map.tasks.speculative.execution, > use are encouraged to use mapred.reduce.tasks.speculative.execution -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4801) output deprecation warning for hive.mapred.map.tasks.speculative.execution
[ https://issues.apache.org/jira/browse/HIVE-4801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chu Tong updated HIVE-4801: --- Description: Output deprecation warning for hive.mapred.map.tasks.speculative.execution, use are encouraged to use mapred.reduce.tasks.speculative.execution (was: Output deprecation warning for hive.mapred.map.tasks.speculative.execution, use are encouraged to use ) > output deprecation warning for hive.mapred.map.tasks.speculative.execution > -- > > Key: HIVE-4801 > URL: https://issues.apache.org/jira/browse/HIVE-4801 > Project: Hive > Issue Type: Bug > Components: Configuration >Affects Versions: 0.10.0 >Reporter: Chu Tong >Assignee: Chu Tong > Attachments: HIVE-4801.patch, HIVE-4801.patch > > > Output deprecation warning for hive.mapred.map.tasks.speculative.execution, > use are encouraged to use mapred.reduce.tasks.speculative.execution -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4801) output deprecation warning for hive.mapred.map.tasks.speculative.execution
[ https://issues.apache.org/jira/browse/HIVE-4801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chu Tong updated HIVE-4801: --- Summary: output deprecation warning for hive.mapred.map.tasks.speculative.execution (was: hive.mapred.map.tasks.speculative.execution is not used to configure Hadoop jobs) > output deprecation warning for hive.mapred.map.tasks.speculative.execution > -- > > Key: HIVE-4801 > URL: https://issues.apache.org/jira/browse/HIVE-4801 > Project: Hive > Issue Type: Bug > Components: Configuration >Affects Versions: 0.10.0 >Reporter: Chu Tong >Assignee: Chu Tong > Attachments: HIVE-4801.patch, HIVE-4801.patch > > > Hive does not honor hive.mapred.map.tasks.speculative.execution parameter > while it comes to configuring hadoop jobs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4801) output deprecation warning for hive.mapred.map.tasks.speculative.execution
[ https://issues.apache.org/jira/browse/HIVE-4801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chu Tong updated HIVE-4801: --- Attachment: HIVE-4801.patch > output deprecation warning for hive.mapred.map.tasks.speculative.execution > -- > > Key: HIVE-4801 > URL: https://issues.apache.org/jira/browse/HIVE-4801 > Project: Hive > Issue Type: Bug > Components: Configuration >Affects Versions: 0.10.0 >Reporter: Chu Tong >Assignee: Chu Tong > Attachments: HIVE-4801.patch, HIVE-4801.patch > > > Output deprecation warning for hive.mapred.map.tasks.speculative.execution, > use are encouraged to use mapred.reduce.tasks.speculative.execution -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4822) implement vectorized math functions
[ https://issues.apache.org/jira/browse/HIVE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Hanson updated HIVE-4822: -- Assignee: Eric Hanson > implement vectorized math functions > --- > > Key: HIVE-4822 > URL: https://issues.apache.org/jira/browse/HIVE-4822 > Project: Hive > Issue Type: Sub-task >Affects Versions: vectorization-branch >Reporter: Eric Hanson >Assignee: Eric Hanson > > Implement vectorized support for the all the built-in math functions. This > includes implementing the vectorized operation, and tying it all together in > VectorizationContext so it runs end-to-end. These functions include: > round(Col) > Round(Col, N) > Floor(Col) > Ceil(Col) > Rand(), Rand(seed) > Exp(Col) > Ln(Col) > Log10(Col) > Log2(Col) > Log(base, Col) > Pow(col, p), Power(col, p) > Sqrt(Col) > Bin(Col) > Hex(Col) > Unhex(Col) > Conv(Col, from_base, to_base) > Abs(Col) > Pmod(arg1, arg2) > Sin(Col) > Asin(Col) > Cos(Col) > ACos(Col) > Atan(Col) > Degrees(Col) > Radians(Col) > Positive(Col) > Negative(Col) > Sign(Col) > E() > Pi() > To reduce the total code volume, do an implicit type cast from non-double > input types to double. > Also, POSITITVE and NEGATIVE are syntactic sugar for unary + and unary -, so > reuse code for those as appropriate. > Try to call the function directly in the inner loop and avoid new() or > expensive operations, as appropriate. > Templatize the code where appropriate, e.g. all the unary function of form > DOUBLE func(DOUBLE) > can probably be done with a template. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4822) implement vectorized math functions
[ https://issues.apache.org/jira/browse/HIVE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703480#comment-13703480 ] Eric Hanson commented on HIVE-4822: --- I just started on this. Probably I will break it down to some smaller JIRAs. I started with ROUND(). If anybody wants to help, please let me know. > implement vectorized math functions > --- > > Key: HIVE-4822 > URL: https://issues.apache.org/jira/browse/HIVE-4822 > Project: Hive > Issue Type: Sub-task >Affects Versions: vectorization-branch >Reporter: Eric Hanson >Assignee: Eric Hanson > > Implement vectorized support for the all the built-in math functions. This > includes implementing the vectorized operation, and tying it all together in > VectorizationContext so it runs end-to-end. These functions include: > round(Col) > Round(Col, N) > Floor(Col) > Ceil(Col) > Rand(), Rand(seed) > Exp(Col) > Ln(Col) > Log10(Col) > Log2(Col) > Log(base, Col) > Pow(col, p), Power(col, p) > Sqrt(Col) > Bin(Col) > Hex(Col) > Unhex(Col) > Conv(Col, from_base, to_base) > Abs(Col) > Pmod(arg1, arg2) > Sin(Col) > Asin(Col) > Cos(Col) > ACos(Col) > Atan(Col) > Degrees(Col) > Radians(Col) > Positive(Col) > Negative(Col) > Sign(Col) > E() > Pi() > To reduce the total code volume, do an implicit type cast from non-double > input types to double. > Also, POSITITVE and NEGATIVE are syntactic sugar for unary + and unary -, so > reuse code for those as appropriate. > Try to call the function directly in the inner loop and avoid new() or > expensive operations, as appropriate. > Templatize the code where appropriate, e.g. all the unary function of form > DOUBLE func(DOUBLE) > can probably be done with a template. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HIVE-4822) implement vectorized math functions
[ https://issues.apache.org/jira/browse/HIVE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-4822 started by Eric Hanson. > implement vectorized math functions > --- > > Key: HIVE-4822 > URL: https://issues.apache.org/jira/browse/HIVE-4822 > Project: Hive > Issue Type: Sub-task >Affects Versions: vectorization-branch >Reporter: Eric Hanson >Assignee: Eric Hanson > > Implement vectorized support for the all the built-in math functions. This > includes implementing the vectorized operation, and tying it all together in > VectorizationContext so it runs end-to-end. These functions include: > round(Col) > Round(Col, N) > Floor(Col) > Ceil(Col) > Rand(), Rand(seed) > Exp(Col) > Ln(Col) > Log10(Col) > Log2(Col) > Log(base, Col) > Pow(col, p), Power(col, p) > Sqrt(Col) > Bin(Col) > Hex(Col) > Unhex(Col) > Conv(Col, from_base, to_base) > Abs(Col) > Pmod(arg1, arg2) > Sin(Col) > Asin(Col) > Cos(Col) > ACos(Col) > Atan(Col) > Degrees(Col) > Radians(Col) > Positive(Col) > Negative(Col) > Sign(Col) > E() > Pi() > To reduce the total code volume, do an implicit type cast from non-double > input types to double. > Also, POSITITVE and NEGATIVE are syntactic sugar for unary + and unary -, so > reuse code for those as appropriate. > Try to call the function directly in the inner loop and avoid new() or > expensive operations, as appropriate. > Templatize the code where appropriate, e.g. all the unary function of form > DOUBLE func(DOUBLE) > can probably be done with a template. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4829) TestWebHCatE2e checkstyle violation causes all tests to fail
[ https://issues.apache.org/jira/browse/HIVE-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eugene Koifman updated HIVE-4829: - Attachment: HIVE-4829.patch HIVE-4829.patch removes the unused import stmt. ant test -logfile ant.log -Dmodule=hcatalog -Dtestcase=TestWebHCatE2e checkstyle is happy > TestWebHCatE2e checkstyle violation causes all tests to fail > > > Key: HIVE-4829 > URL: https://issues.apache.org/jira/browse/HIVE-4829 > Project: Hive > Issue Type: Bug >Reporter: Brock Noland >Assignee: Eugene Koifman >Priority: Critical > Attachments: HIVE-4829.patch > > > The following error caused all tests to fail and thus filled up the ptest > systems drives. > {noformat} > [echo] hcatalog > [checkstyle] Running Checkstyle 5.5 on 419 files > [checkstyle] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestWebHCatE2e.java:31:8: > Unused import - org.junit.BeforeClass. > [for] hcatalog: The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/build.xml:310: > The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/build.xml:123: > The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/build-support/ant/checkstyle.xml:32: > Got 1 errors and 0 warnings. > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4829) TestWebHCatE2e checkstyle violation causes all tests to fail
[ https://issues.apache.org/jira/browse/HIVE-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eugene Koifman updated HIVE-4829: - Status: Patch Available (was: Open) > TestWebHCatE2e checkstyle violation causes all tests to fail > > > Key: HIVE-4829 > URL: https://issues.apache.org/jira/browse/HIVE-4829 > Project: Hive > Issue Type: Bug >Reporter: Brock Noland >Assignee: Eugene Koifman >Priority: Critical > Attachments: HIVE-4829.patch > > > The following error caused all tests to fail and thus filled up the ptest > systems drives. > {noformat} > [echo] hcatalog > [checkstyle] Running Checkstyle 5.5 on 419 files > [checkstyle] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestWebHCatE2e.java:31:8: > Unused import - org.junit.BeforeClass. > [for] hcatalog: The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/build.xml:310: > The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/build.xml:123: > The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/build-support/ant/checkstyle.xml:32: > Got 1 errors and 0 warnings. > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4815) Create cloud hosting option for ptest2
[ https://issues.apache.org/jira/browse/HIVE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brock Noland updated HIVE-4815: --- Attachment: HIVE-4815.patch I had changed the source-prep script which executes ant package to use tee so the ant package logs show up on jenkins. The problem with this was that now the pipe was eating the exit code and therefore we were not catching failures to build hive (see HIVE-4829). The following change fixes this, manually verified it works: {noformat} ) 2>&1 | tee $logDir/source-prep.txt +exit ${PIPESTATUS[0]} {noformat} > Create cloud hosting option for ptest2 > -- > > Key: HIVE-4815 > URL: https://issues.apache.org/jira/browse/HIVE-4815 > Project: Hive > Issue Type: New Feature >Reporter: Brock Noland >Assignee: Brock Noland > Fix For: 0.12.0 > > Attachments: HIVE-4815.patch, HIVE-4815.patch, HIVE-4815.patch, > HIVE-4815.patch, HIVE-4815.patch, HIVE-4815.patch > > > HIVE-4675 creates a parallel testing environment. To support HIVE-4739 we > should allow this environment to run in a cloud environment. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703363#comment-13703363 ] Eugene Koifman commented on HIVE-4580: -- I can fix the checkstyle issue. Why do you think this is causing disks to fill up. There is nothing in this change that writes anything to disk (that I know of). > Change DDLTask to report errors using canonical error messages rather than > http status codes > > > Key: HIVE-4580 > URL: https://issues.apache.org/jira/browse/HIVE-4580 > Project: Hive > Issue Type: Bug > Components: HCatalog >Affects Versions: 0.11.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman > Fix For: 0.12.0 > > Attachments: HIVE-4580.1.patch, HIVE-4580.2.patch, HIVE-4580.3.patch, > HIVE-4580.patch > > Original Estimate: 40h > Remaining Estimate: 40h > > org.apache.hadoop.hive.ql.exec.DDLTask handles DDL operations in Hive. > Some operations (those exposed as REST API by Templeton) in this class, write > a JSON object to stdout (on failure) which includes "error" and "errorCode" > fields. "errorCode" is set to values like 404, 500, etc. i.e. Http Status > codes. I believe this was done to support Templeton REST API. This is not > the right place to introduce Http codes. > DDLTask should use canonical error messages defined in > org.apache.hadoop.hive.ql.ErrorMsg and propagate it up to HCatCli which can > decide how to encode the error and to which stream. In particular it can > create a parseable JSON object which Templeton can then interpret. JSON > object can also be generated here for errors from the parser/resolver (e.g. > trying to describe a table which doesn't exist). > Then Templeton can map the canonical error code to appropriate Http Code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4829) TestWebHCatE2e checkstyle violation causes all tests to fail
[ https://issues.apache.org/jira/browse/HIVE-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-4829: --- Assignee: Eugene Koifman > TestWebHCatE2e checkstyle violation causes all tests to fail > > > Key: HIVE-4829 > URL: https://issues.apache.org/jira/browse/HIVE-4829 > Project: Hive > Issue Type: Bug >Reporter: Brock Noland >Assignee: Eugene Koifman >Priority: Critical > > The following error caused all tests to fail and thus filled up the ptest > systems drives. > {noformat} > [echo] hcatalog > [checkstyle] Running Checkstyle 5.5 on 419 files > [checkstyle] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestWebHCatE2e.java:31:8: > Unused import - org.junit.BeforeClass. > [for] hcatalog: The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/build.xml:310: > The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/build.xml:123: > The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/build-support/ant/checkstyle.xml:32: > Got 1 errors and 0 warnings. > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703368#comment-13703368 ] Brock Noland commented on HIVE-4580: Sorry to be unclear...that was caused by a bug in ptest2 which I am fixing at present. > Change DDLTask to report errors using canonical error messages rather than > http status codes > > > Key: HIVE-4580 > URL: https://issues.apache.org/jira/browse/HIVE-4580 > Project: Hive > Issue Type: Bug > Components: HCatalog >Affects Versions: 0.11.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman > Fix For: 0.12.0 > > Attachments: HIVE-4580.1.patch, HIVE-4580.2.patch, HIVE-4580.3.patch, > HIVE-4580.patch > > Original Estimate: 40h > Remaining Estimate: 40h > > org.apache.hadoop.hive.ql.exec.DDLTask handles DDL operations in Hive. > Some operations (those exposed as REST API by Templeton) in this class, write > a JSON object to stdout (on failure) which includes "error" and "errorCode" > fields. "errorCode" is set to values like 404, 500, etc. i.e. Http Status > codes. I believe this was done to support Templeton REST API. This is not > the right place to introduce Http codes. > DDLTask should use canonical error messages defined in > org.apache.hadoop.hive.ql.ErrorMsg and propagate it up to HCatCli which can > decide how to encode the error and to which stream. In particular it can > create a parseable JSON object which Templeton can then interpret. JSON > object can also be generated here for errors from the parser/resolver (e.g. > trying to describe a table which doesn't exist). > Then Templeton can map the canonical error code to appropriate Http Code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4299) exported metadata by HIVE-3068 cannot be imported because of wrong file name
[ https://issues.apache.org/jira/browse/HIVE-4299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703313#comment-13703313 ] Edward Capriolo commented on HIVE-4299: --- No. I mean in one file with have a magic string "_metadata" and in another file we have a magic string ".METADATA" Create a constant like this: {quote} public static final String META_DATA="_metadata"; {quote} and have both methods reference the constant. > exported metadata by HIVE-3068 cannot be imported because of wrong file name > > > Key: HIVE-4299 > URL: https://issues.apache.org/jira/browse/HIVE-4299 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 0.11.0 >Reporter: Sho Shimauchi >Assignee: Sho Shimauchi > Attachments: HIVE-4299.patch > > > h2. Symptom > When DROP TABLE a table, metadata of the table is generated to be able to > import the dropped table again. > However, the exported metadata name is '.metadata'. > Since ImportSemanticAnalyzer allows only '_metadata' as metadata filename, > user have to rename the metadata file to import the table. > h2. How to reproduce > Set the following setting to hive-site.xml: > {code} > >hive.metastore.pre.event.listeners >org.apache.hadoop.hive.ql.parse.MetaDataExportListener > > {code} > Then run the following queries: > {code} > > CREATE TABLE test_table (id INT, name STRING); > > DROP TABLE test_table; > > IMPORT TABLE test_table_imported FROM '/path/to/metadata/file'; > FAILED: SemanticException [Error 10027]: Invalid path > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4779) Enhance coverage of package org.apache.hadoop.hive.ql.udf
[ https://issues.apache.org/jira/browse/HIVE-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703308#comment-13703308 ] Ivan A. Veselovsky commented on HIVE-4779: -- Hi, Ashotush, Edward, thanks for the comments, answering regarding the deleted UDFs. 1) UDFToDate was a function converting numbers (surprisingly not Writable-s) to java.sql.Date. It was not registered in FunctionRegistry, and not used anyhow else (neither in Java code nor .q scripts). In function registry we have registerUDF("to_date", UDFDate.class, false); (line 271). But its purpose slightly different: it extracts date part from Text or Timestamp writables. Conversion of an arbitrary type to Timestamp is done using org.apache.hadoop.hive.ql.udf.generic.GenericUDFTimestamp. 2) UDFUnixTimeStamp was also not used anyhow, and, as far as I understand, is superseded by the following functions: registerGenericUDF("unix_timestamp", GenericUDFUnixTimeStamp.class); registerGenericUDF("to_unix_timestamp", GenericUDFToUnixTimeStamp.class); These functions are covered well by .q tests. 3) UDFBaseCompare was simply not used. I suppose that all the generic comparison logic was transferred to org.apache.hadoop.hive.ql.udf.generic.GenericUDFBaseCompare and related classes. If some of these removed classes are still needed, of course, I will change the patch to return them back. > Enhance coverage of package org.apache.hadoop.hive.ql.udf > - > > Key: HIVE-4779 > URL: https://issues.apache.org/jira/browse/HIVE-4779 > Project: Hive > Issue Type: Test >Affects Versions: 0.12.0 >Reporter: Ivan A. Veselovsky >Assignee: Ivan A. Veselovsky > Attachments: HIVE-4779-trunk--N1.patch > > > Enhance coverage of package org.apache.hadoop.hive.ql.udf up to 80%. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4779) Enhance coverage of package org.apache.hadoop.hive.ql.udf
[ https://issues.apache.org/jira/browse/HIVE-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan A. Veselovsky updated HIVE-4779: - Status: Patch Available (was: Open) > Enhance coverage of package org.apache.hadoop.hive.ql.udf > - > > Key: HIVE-4779 > URL: https://issues.apache.org/jira/browse/HIVE-4779 > Project: Hive > Issue Type: Test >Affects Versions: 0.12.0 >Reporter: Ivan A. Veselovsky >Assignee: Ivan A. Veselovsky > Attachments: HIVE-4779-trunk--N1.patch > > > Enhance coverage of package org.apache.hadoop.hive.ql.udf up to 80%. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3810) HiveHistory.log need to replace '\r' with space before writing Entry.value to historyfile
[ https://issues.apache.org/jira/browse/HIVE-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703290#comment-13703290 ] Hudson commented on HIVE-3810: -- Integrated in Hive-trunk-hadoop2 #279 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/279/]) HIVE-3810 : HiveHistory.log need to replace \r with space before writing Entry.value to historyfile (Mark Grover via Ashutosh Chauhan) (Revision 1500991) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1500991 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java > HiveHistory.log need to replace '\r' with space before writing Entry.value to > historyfile > - > > Key: HIVE-3810 > URL: https://issues.apache.org/jira/browse/HIVE-3810 > Project: Hive > Issue Type: Bug > Components: Logging >Reporter: qiangwang >Assignee: Mark Grover >Priority: Minor > Fix For: 0.12.0 > > Attachments: HIVE-3810.1.patch, HIVE-3810.2.patch, HIVE-3810.3.patch, > HIVE-3810.4.patch > > > HiveHistory.log will replace '\n' with space before writing Entry.value to > history file: > val = val.replace('\n', ' '); > but HiveHistory.parseHiveHistory use BufferedReader.readLine which takes > '\n', '\r', '\r\n' as line delimiter to parse history file > if val contains '\r', there is a high possibility that HiveHistory.parseLine > will fail, in which case usually RecordTypes.valueOf(recType) will throw > exception 'java.lang.IllegalArgumentException' > HiveHistory.log need to replace '\r' with space as well: > val = val.replace('\n', ' '); > changed to > val = val.replaceAll("\r|\n", " "); > or > val = val.replace('\r', ' ').replace('\n', ' '); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4829) TestWebHCatE2e checkstyle violation causes all tests to fail
[ https://issues.apache.org/jira/browse/HIVE-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703255#comment-13703255 ] Brock Noland commented on HIVE-4829: OK from a ptest side I introduced a bug in the shell script which builds the source which meant the exit code was not transfered accordingly. I'll fix that via HIVE-4815. > TestWebHCatE2e checkstyle violation causes all tests to fail > > > Key: HIVE-4829 > URL: https://issues.apache.org/jira/browse/HIVE-4829 > Project: Hive > Issue Type: Bug >Reporter: Brock Noland >Priority: Critical > > The following error caused all tests to fail and thus filled up the ptest > systems drives. > {noformat} > [echo] hcatalog > [checkstyle] Running Checkstyle 5.5 on 419 files > [checkstyle] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestWebHCatE2e.java:31:8: > Unused import - org.junit.BeforeClass. > [for] hcatalog: The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/build.xml:310: > The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/build.xml:123: > The following error occurred while executing this line: > [for] > /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/build-support/ant/checkstyle.xml:32: > Got 1 errors and 0 warnings. > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703239#comment-13703239 ] Brock Noland commented on HIVE-4580: Hey guys, it looks like this caused HIVE-4829 which results in all tests failing and the parallel test system filling it's drives. > Change DDLTask to report errors using canonical error messages rather than > http status codes > > > Key: HIVE-4580 > URL: https://issues.apache.org/jira/browse/HIVE-4580 > Project: Hive > Issue Type: Bug > Components: HCatalog >Affects Versions: 0.11.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman > Fix For: 0.12.0 > > Attachments: HIVE-4580.1.patch, HIVE-4580.2.patch, HIVE-4580.3.patch, > HIVE-4580.patch > > Original Estimate: 40h > Remaining Estimate: 40h > > org.apache.hadoop.hive.ql.exec.DDLTask handles DDL operations in Hive. > Some operations (those exposed as REST API by Templeton) in this class, write > a JSON object to stdout (on failure) which includes "error" and "errorCode" > fields. "errorCode" is set to values like 404, 500, etc. i.e. Http Status > codes. I believe this was done to support Templeton REST API. This is not > the right place to introduce Http codes. > DDLTask should use canonical error messages defined in > org.apache.hadoop.hive.ql.ErrorMsg and propagate it up to HCatCli which can > decide how to encode the error and to which stream. In particular it can > create a parseable JSON object which Templeton can then interpret. JSON > object can also be generated here for errors from the parser/resolver (e.g. > trying to describe a table which doesn't exist). > Then Templeton can map the canonical error code to appropriate Http Code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-4829) TestWebHCatE2e checkstyle violation causes all tests to fail
Brock Noland created HIVE-4829: -- Summary: TestWebHCatE2e checkstyle violation causes all tests to fail Key: HIVE-4829 URL: https://issues.apache.org/jira/browse/HIVE-4829 Project: Hive Issue Type: Bug Reporter: Brock Noland Priority: Critical The following error caused all tests to fail and thus filled up the ptest systems drives. {noformat} [echo] hcatalog [checkstyle] Running Checkstyle 5.5 on 419 files [checkstyle] /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestWebHCatE2e.java:31:8: Unused import - org.junit.BeforeClass. [for] hcatalog: The following error occurred while executing this line: [for] /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/build.xml:310: The following error occurred while executing this line: [for] /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/build.xml:123: The following error occurred while executing this line: [for] /home/hiveptest/ip-10-234-1-228-hiveptest-1/apache-github-source/hcatalog/build-support/ant/checkstyle.xml:32: Got 1 errors and 0 warnings. {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4299) exported metadata by HIVE-3068 cannot be imported because of wrong file name
[ https://issues.apache.org/jira/browse/HIVE-4299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703130#comment-13703130 ] Sho Shimauchi commented on HIVE-4299: - Hi Edward, Thanks for the comment. Do you mean a filepath of the exported data should be changed to more static one, like '/user/sho/test_table/test_table.metadata' ? Or should I retain a filepath '/user/sho/test_table.2013-04-05-20-13-14/test_table.metadata' in some place like '/${user.home}/.hive_table_metadata'? Sho > exported metadata by HIVE-3068 cannot be imported because of wrong file name > > > Key: HIVE-4299 > URL: https://issues.apache.org/jira/browse/HIVE-4299 > Project: Hive > Issue Type: Bug > Components: Query Processor >Affects Versions: 0.11.0 >Reporter: Sho Shimauchi >Assignee: Sho Shimauchi > Attachments: HIVE-4299.patch > > > h2. Symptom > When DROP TABLE a table, metadata of the table is generated to be able to > import the dropped table again. > However, the exported metadata name is '.metadata'. > Since ImportSemanticAnalyzer allows only '_metadata' as metadata filename, > user have to rename the metadata file to import the table. > h2. How to reproduce > Set the following setting to hive-site.xml: > {code} > >hive.metastore.pre.event.listeners >org.apache.hadoop.hive.ql.parse.MetaDataExportListener > > {code} > Then run the following queries: > {code} > > CREATE TABLE test_table (id INT, name STRING); > > DROP TABLE test_table; > > IMPORT TABLE test_table_imported FROM '/path/to/metadata/file'; > FAILED: SemanticException [Error 10027]: Invalid path > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4819) Comments in CommonJoinOperator for aliasTag is not valid
[ https://issues.apache.org/jira/browse/HIVE-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703089#comment-13703089 ] Hudson commented on HIVE-4819: -- Integrated in Hive-trunk-hadoop1-ptest #51 (See [https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/51/]) HIVE-4819 : Comments in CommonJoinOperator for aliasTag is not valid (Navis via Ashutosh Chauhan) (Revision 1501129) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501129 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java > Comments in CommonJoinOperator for aliasTag is not valid > > > Key: HIVE-4819 > URL: https://issues.apache.org/jira/browse/HIVE-4819 > Project: Hive > Issue Type: Task > Components: Documentation >Reporter: Navis >Assignee: Navis >Priority: Trivial > Fix For: 0.12.0 > > Attachments: HIVE-4819.D11619.1.patch > > > I've written that but it's does not make sense even to me. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HIVE-4828) Make vectorization branch compile under JDK 7
[ https://issues.apache.org/jira/browse/HIVE-4828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan resolved HIVE-4828. Resolution: Fixed Fix Version/s: vectorization-branch Assignee: Ashutosh Chauhan (was: Dmitriy V. Ryaboy) We do it using svn merge command. I just merged in the latest trunk in vectorization branch. > Make vectorization branch compile under JDK 7 > - > > Key: HIVE-4828 > URL: https://issues.apache.org/jira/browse/HIVE-4828 > Project: Hive > Issue Type: Sub-task >Reporter: Dmitriy V. Ryaboy >Assignee: Ashutosh Chauhan > Fix For: vectorization-branch > > Attachments: HIVE-4828.patch > > > It seems that, at minimum, HIVE-4496 is not in the vectorization branch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4828) Make vectorization branch compile under JDK 7
[ https://issues.apache.org/jira/browse/HIVE-4828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-4828: --- Assignee: Dmitriy V. Ryaboy > Make vectorization branch compile under JDK 7 > - > > Key: HIVE-4828 > URL: https://issues.apache.org/jira/browse/HIVE-4828 > Project: Hive > Issue Type: Sub-task >Reporter: Dmitriy V. Ryaboy >Assignee: Dmitriy V. Ryaboy > Attachments: HIVE-4828.patch > > > It seems that, at minimum, HIVE-4496 is not in the vectorization branch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4826) Setup build infrastructure for tez
[ https://issues.apache.org/jira/browse/HIVE-4826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gunther Hagleitner updated HIVE-4826: - Issue Type: New Feature (was: Sub-task) Parent: (was: HIVE-4660) > Setup build infrastructure for tez > -- > > Key: HIVE-4826 > URL: https://issues.apache.org/jira/browse/HIVE-4826 > Project: Hive > Issue Type: New Feature > Components: Tez >Affects Versions: tez-branch >Reporter: Vikram Dixit K >Assignee: Vikram Dixit K > Fix For: tez-branch > > Attachments: HIVE-4826.patch > > > Address changes required in ivy and build xml files to support tez. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-4819) Comments in CommonJoinOperator for aliasTag is not valid
[ https://issues.apache.org/jira/browse/HIVE-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-4819: --- Resolution: Fixed Fix Version/s: 0.12.0 Status: Resolved (was: Patch Available) Committed to trunk. Thanks, Navis! > Comments in CommonJoinOperator for aliasTag is not valid > > > Key: HIVE-4819 > URL: https://issues.apache.org/jira/browse/HIVE-4819 > Project: Hive > Issue Type: Task > Components: Documentation >Reporter: Navis >Assignee: Navis >Priority: Trivial > Fix For: 0.12.0 > > Attachments: HIVE-4819.D11619.1.patch > > > I've written that but it's does not make sense even to me. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4813) Improve test coverage of package org.apache.hadoop.hive.ql.optimizer.pcr
[ https://issues.apache.org/jira/browse/HIVE-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703013#comment-13703013 ] Hudson commented on HIVE-4813: -- Integrated in Hive-trunk-hadoop1-ptest #50 (See [https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/50/]) HIVE-4813 : Improve test coverage of package org.apache.hadoop.hive.ql.optimizer.pcr (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1501099) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501099 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/lib/DefaultRuleDispatcher.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/lib/RuleRegExp.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcCtx.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java * /hive/trunk/ql/src/test/queries/clientpositive/pcr.q * /hive/trunk/ql/src/test/results/clientpositive/pcr.q.out > Improve test coverage of package org.apache.hadoop.hive.ql.optimizer.pcr > > > Key: HIVE-4813 > URL: https://issues.apache.org/jira/browse/HIVE-4813 > Project: Hive > Issue Type: Test >Affects Versions: 0.12.0 >Reporter: Ivan A. Veselovsky >Assignee: Ivan A. Veselovsky > Fix For: 0.12.0 > > Attachments: HIVE-4813-trunk--N1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703010#comment-13703010 ] Hudson commented on HIVE-4580: -- Integrated in Hive-trunk-hadoop1-ptest #49 (See [https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/49/]) HIVE-4580 : Change DDLTask to report errors using canonical error messages rather than http status codes (Eugene Koifman via Ashutosh Chauhan) (Revision 1501053) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501053 Files : * /hive/trunk/contrib/src/test/results/clientnegative/serde_regex.q.out * /hive/trunk/contrib/src/test/results/clientnegative/url_hook.q.out * /hive/trunk/hcatalog/src/test/e2e/templeton/tests/ddl.conf * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/AppConfig.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/BadParam.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/BusyException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/CallbackFailedException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/CatchallExceptionMapper.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/HcatDelegator.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/HcatException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/JsonBuilder.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/Main.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/NotAuthorizedException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/QueueException.java * /hive/trunk/hcatalog/webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestWebHCatE2e.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskResult.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveException.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/InvalidTableException.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java * /hive/trunk/ql/src/test/results/clientnegative/add_partition_with_whitelist.q.out * /hive/trunk/ql/src/test/results/clientnegative/addpart1.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_partition_nodrop_table.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_partition_with_whitelist.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure2.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure3.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_table_wrong_regex.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_view_failure4.q.out * /hive/trunk/ql/src/test/results/clientnegative/altern1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive2.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi2.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi3.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi4.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi5.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi6.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi7.q.out * /hive/trunk/ql/src/test/results/clientnegative/authorization_fail_1.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename1.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename2.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename4.q.out * /hive/trunk/ql/src/test/results/clientnegative/create_table_failure3.q.out * /hive/trunk/ql/src/test/results/clientnegative/create_table_failure