[jira] [Commented] (HIVE-5683) JDBC support for char
[
https://issues.apache.org/jira/browse/HIVE-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818065#comment-13818065
]
Hive QA commented on HIVE-5683:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12612921/HIVE-5683.2.patch
{color:green}SUCCESS:{color} +1 4566 tests passed
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/226/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/226/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12612921
JDBC support for char
-
Key: HIVE-5683
URL: https://issues.apache.org/jira/browse/HIVE-5683
Project: Hive
Issue Type: Bug
Components: JDBC, Types
Reporter: Jason Dere
Assignee: Jason Dere
Attachments: HIVE-5683.1.patch, HIVE-5683.2.patch
Support char type in JDBC, including char length in result set metadata.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HIVE-5627) Document 'usehcatalog' parameter on WebHCat calls
[ https://issues.apache.org/jira/browse/HIVE-5627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818071#comment-13818071 ] Lefty Leverenz commented on HIVE-5627: -- Done, please review here: * [https://cwiki.apache.org/confluence/display/Hive/WebHCat+Reference+MapReduceJar] * [https://cwiki.apache.org/confluence/display/Hive/WebHCat+Reference+Pig] I assumed the default was 'false' for both calls. Document 'usehcatalog' parameter on WebHCat calls - Key: HIVE-5627 URL: https://issues.apache.org/jira/browse/HIVE-5627 Project: Hive Issue Type: Sub-task Components: Documentation, WebHCat Affects Versions: 0.12.0 Reporter: Eugene Koifman Assignee: Lefty Leverenz Fix For: 0.13.0 The following REST calls in WebHCat: 1. mapreduce/jar 2. pig now support an additional parameter 'usehcatalog'. This is a mechanism for the caller to tell WebHCat that the submitted job uses HCat, and thus needs to access the metastore, which requires additional steps for WebHCat to perform in a secure cluster. The JavaDoc on corresponding methods in org.apache.hive.hcatalog.templeton.Server describe this parameter. Additionally, if templeton.hive.archive, templeton.hive.home and templeton.hcat.home are defined in webhcat-site.xml (documented in webhcat-default.xml) then WebHCat will ship the Hive tar to the target node where the job actually runs. This means that Hive doesn't need to be installed on every node in the Hadoop cluster. (This part was added in HIVE-5547). This is independent of security, but improves manageability. This should be added to the sections in https://cwiki.apache.org/confluence/display/Hive/WebHCat+Reference that correspond to these methods. -- This message was sent by Atlassian JIRA (v6.1#6144)
Re: Scheduling the next Hive Contributors Meeting
Please RSVP for the meetup here: http://www.meetup.com/Hive-Contributors-Group/events/150001922/ Thanks. Carl On Fri, Nov 8, 2013 at 12:24 PM, Gunther Hagleitner ghagleit...@hortonworks.com wrote: Looking forward to it! I would like to do a status update and quick demo of the Tez integration work (HIVE-4660), if there is time and interest. Thanks, Gunther. On Fri, Nov 8, 2013 at 11:44 AM, Brock Noland br...@cloudera.com wrote: Hi, On Fri, Nov 8, 2013 at 1:43 PM, Nitin Pawar nitinpawar...@gmail.com wrote: I am not a contributor but a spectator to what hive have been doing last couple of years. I work out of India and would love to just sit back and listen to all the new upcoming things (if that's allowed) :) Not only allowed, but encouraged! Great to have your interest! On Sat, Nov 9, 2013 at 1:08 AM, Brock Noland br...@cloudera.com wrote: Hi, Thanks Carl and Thejas! I would be attending remotely so the webex or google hangout would be very much appreciated. Please let me know if there is anything I can do to help enable either a webex or hangout! The Apache Sentry (incubating)[1] community which depends on Hive would be interested in briefly describing the project to the Hive community and discuss how we can work together to move both projects forward! As a side note, there have been lively discussions on the integration of other incubating projects therefore I'd just like to share that the changes Sentry is interested in are very small in scope and unlikely to cause disruption to the Hive community. Cheers! Brock [1] http://incubator.apache.org/projects/sentry.html On Fri, Nov 8, 2013 at 1:08 PM, Carl Steinbach c...@apache.org wrote: We're long overdue for a Hive Contributors Meeting. Thejas has offered to host the next meeting at Hortonworks on November 19th from 4-6pm. We will have a Google Hangout or Webex setup for people who wish to attend remotely. If you want to attend but can't because of a scheduling conflict please let us know. If enough people fall into this category we will try to reschedule. Thanks. Carl -- Nitin Pawar -- Apache MRUnit - Unit testing MapReduce - http://mrunit.apache.org -- CONFIDENTIALITY NOTICE NOTICE: This message is intended for the use of the individual or entity to which it is addressed and may contain information that is confidential, privileged and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, you are hereby notified that any printing, copying, dissemination, distribution, disclosure or forwarding of this communication is strictly prohibited. If you have received this communication in error, please contact the sender immediately and delete it from your system. Thank You.
[jira] [Updated] (HIVE-5786) Remove HadoopShims methods that were needed for pre-Hadoop 0.20
[ https://issues.apache.org/jira/browse/HIVE-5786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carl Steinbach updated HIVE-5786: - Resolution: Fixed Fix Version/s: 0.13.0 Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Committed to trunk. Thanks Jason! Remove HadoopShims methods that were needed for pre-Hadoop 0.20 --- Key: HIVE-5786 URL: https://issues.apache.org/jira/browse/HIVE-5786 Project: Hive Issue Type: Bug Components: Shims Reporter: Jason Dere Assignee: Jason Dere Fix For: 0.13.0 Attachments: HIVE-5786.1.patch There are several methods in HadoopShims that can be removed since we are only supporting 0.20+. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5700) enforce single date format for partition column storage
[
https://issues.apache.org/jira/browse/HIVE-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818110#comment-13818110
]
Hive QA commented on HIVE-5700:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12612963/HIVE-5700.02.patch
{color:green}SUCCESS:{color} +1 4599 tests passed
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/227/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/227/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12612963
enforce single date format for partition column storage
---
Key: HIVE-5700
URL: https://issues.apache.org/jira/browse/HIVE-5700
Project: Hive
Issue Type: Improvement
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Attachments: HIVE-5700.01.patch, HIVE-5700.02.patch, HIVE-5700.patch
inspired by HIVE-5286.
Partition column for dates should be stored as either integer, or as fixed
representation e.g. -mm-dd. External representation can remain varied as
is.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HIVE-5790) maven test build failure shows wrong error message
[ https://issues.apache.org/jira/browse/HIVE-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818124#comment-13818124 ] Brock Noland commented on HIVE-5790: +1 maven test build failure shows wrong error message --- Key: HIVE-5790 URL: https://issues.apache.org/jira/browse/HIVE-5790 Project: Hive Issue Type: Bug Reporter: Mohammad Kamrul Islam Assignee: Mohammad Kamrul Islam Attachments: HIVE-5790.1.patch This is the error message that was correct for ant. See build/ql/tmp/hive.log, or try ant test ... -Dtest.silent=false to get more logs. This JIRA is to replace this message with mvn-specific error message. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (HIVE-5791) TestUseDatabase in hcategory failed to pass when illegal filename in /tmp
hellojinjie created HIVE-5791: - Summary: TestUseDatabase in hcategory failed to pass when illegal filename in /tmp Key: HIVE-5791 URL: https://issues.apache.org/jira/browse/HIVE-5791 Project: Hive Issue Type: Bug Components: HCatalog Affects Versions: 0.13.0 Reporter: hellojinjie Priority: Minor Fix For: 0.13.0 The test code is trying to read /tmp directory. But, if in /tmp directory, there is a file name fcitx-socket-:0. Accroding to this issue https://issues.apache.org/jira/browse/HADOOP-7945 hadoop did not allow : in filename. The code print following message: FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.DDLTask. MetaException(message:java.lang.IllegalArgumentException: java.net.URISyntaxException: Relative path in absolute URI: fcitx-socket-:0) -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HIVE-5791) TestUseDatabase in hcategory failed to pass when illegal filename in /tmp
[ https://issues.apache.org/jira/browse/HIVE-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hellojinjie updated HIVE-5791: -- Attachment: HIVE-5791.patch.txt TestUseDatabase in hcategory failed to pass when illegal filename in /tmp - Key: HIVE-5791 URL: https://issues.apache.org/jira/browse/HIVE-5791 Project: Hive Issue Type: Bug Components: HCatalog Affects Versions: 0.13.0 Reporter: hellojinjie Priority: Minor Labels: test Fix For: 0.13.0 Attachments: HIVE-5791.patch.txt Original Estimate: 1h Remaining Estimate: 1h The test code is trying to read /tmp directory. But, if in /tmp directory, there is a file name fcitx-socket-:0. Accroding to this issue https://issues.apache.org/jira/browse/HADOOP-7945 hadoop did not allow : in filename. The code print following message: FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.DDLTask. MetaException(message:java.lang.IllegalArgumentException: java.net.URISyntaxException: Relative path in absolute URI: fcitx-socket-:0) -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HIVE-5791) TestUseDatabase in hcategory failed to pass when illegal filename in /tmp
[ https://issues.apache.org/jira/browse/HIVE-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hellojinjie updated HIVE-5791: -- Status: Patch Available (was: Open) TestUseDatabase in hcategory failed to pass when illegal filename in /tmp - Key: HIVE-5791 URL: https://issues.apache.org/jira/browse/HIVE-5791 Project: Hive Issue Type: Bug Components: HCatalog Affects Versions: 0.13.0 Reporter: hellojinjie Priority: Minor Labels: test Fix For: 0.13.0 Attachments: HIVE-5791.patch.txt Original Estimate: 1h Remaining Estimate: 1h The test code is trying to read /tmp directory. But, if in /tmp directory, there is a file name fcitx-socket-:0. Accroding to this issue https://issues.apache.org/jira/browse/HADOOP-7945 hadoop did not allow : in filename. The code print following message: FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.DDLTask. MetaException(message:java.lang.IllegalArgumentException: java.net.URISyntaxException: Relative path in absolute URI: fcitx-socket-:0) -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HIVE-5791) TestUseDatabase in hcategory failed to pass when illegal filename in /tmp
[ https://issues.apache.org/jira/browse/HIVE-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hellojinjie updated HIVE-5791: -- Attachment: (was: HIVE-5791.patch.txt) TestUseDatabase in hcategory failed to pass when illegal filename in /tmp - Key: HIVE-5791 URL: https://issues.apache.org/jira/browse/HIVE-5791 Project: Hive Issue Type: Bug Components: HCatalog Affects Versions: 0.13.0 Reporter: hellojinjie Priority: Minor Labels: test Fix For: 0.13.0 Attachments: HIVE-5791.patch Original Estimate: 1h Remaining Estimate: 1h The test code is trying to read /tmp directory. But, if in /tmp directory, there is a file name fcitx-socket-:0. Accroding to this issue https://issues.apache.org/jira/browse/HADOOP-7945 hadoop did not allow : in filename. The code print following message: FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.DDLTask. MetaException(message:java.lang.IllegalArgumentException: java.net.URISyntaxException: Relative path in absolute URI: fcitx-socket-:0) -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HIVE-5791) TestUseDatabase in hcategory failed to pass when illegal filename in /tmp
[ https://issues.apache.org/jira/browse/HIVE-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hellojinjie updated HIVE-5791: -- Attachment: HIVE-5791.patch TestUseDatabase in hcategory failed to pass when illegal filename in /tmp - Key: HIVE-5791 URL: https://issues.apache.org/jira/browse/HIVE-5791 Project: Hive Issue Type: Bug Components: HCatalog Affects Versions: 0.13.0 Reporter: hellojinjie Priority: Minor Labels: test Fix For: 0.13.0 Attachments: HIVE-5791.patch Original Estimate: 1h Remaining Estimate: 1h The test code is trying to read /tmp directory. But, if in /tmp directory, there is a file name fcitx-socket-:0. Accroding to this issue https://issues.apache.org/jira/browse/HADOOP-7945 hadoop did not allow : in filename. The code print following message: FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.DDLTask. MetaException(message:java.lang.IllegalArgumentException: java.net.URISyntaxException: Relative path in absolute URI: fcitx-socket-:0) -- This message was sent by Atlassian JIRA (v6.1#6144)
Re: Review Request 15375: HIVE-5683 JDBC support for char
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15375/#review28616 --- jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java https://reviews.apache.org/r/15375/#comment55506 Could you remove the trailing space/tab? service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TProtocolVersion.java https://reviews.apache.org/r/15375/#comment55508 I know this is generated code, but I don't see any essential changes. Specially, as fmi, why V4 is missing from here. - Xuefu Zhang On Nov. 8, 2013, 11:05 p.m., Jason Dere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15375/ --- (Updated Nov. 8, 2013, 11:05 p.m.) Review request for hive and Thejas Nair. Bugs: HIVE-5683 https://issues.apache.org/jira/browse/HIVE-5683 Repository: hive-git Description --- thrift/jdbc changes for char. Diffs - data/files/datatypes.txt 10daa1b itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java a270cc6 jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java b693e93 jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 25faf48 jdbc/src/java/org/apache/hive/jdbc/HiveResultSetMetaData.java 79e8c8c jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java d612cf6 jdbc/src/java/org/apache/hive/jdbc/Utils.java 45de290 service/if/TCLIService.thrift 1f49445 service/src/gen/thrift/gen-cpp/TCLIService_constants.h 7471811 service/src/gen/thrift/gen-cpp/TCLIService_constants.cpp d085b30 service/src/gen/thrift/gen-cpp/TCLIService_types.h 490b393 service/src/gen/thrift/gen-cpp/TCLIService_types.cpp a3fd46c service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCLIServiceConstants.java 7b4c576 service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionResp.java 5d353f7 service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TProtocolVersion.java 15f2973 service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTypeId.java be70a3a service/src/gen/thrift/gen-py/TCLIService/constants.py 589ce88 service/src/gen/thrift/gen-py/TCLIService/ttypes.py b286b05 service/src/gen/thrift/gen-rb/t_c_l_i_service_constants.rb 8c341c8 service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb c608364 service/src/java/org/apache/hive/service/cli/ColumnValue.java 62e221b service/src/java/org/apache/hive/service/cli/Type.java f414fca service/src/java/org/apache/hive/service/cli/TypeQualifiers.java 66a4b12 Diff: https://reviews.apache.org/r/15375/diff/ Testing --- Thanks, Jason Dere
[jira] [Commented] (HIVE-5683) JDBC support for char
[ https://issues.apache.org/jira/browse/HIVE-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818150#comment-13818150 ] Xuefu Zhang commented on HIVE-5683: --- Patch looks good to me. Minor comment on review board. JDBC support for char - Key: HIVE-5683 URL: https://issues.apache.org/jira/browse/HIVE-5683 Project: Hive Issue Type: Bug Components: JDBC, Types Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-5683.1.patch, HIVE-5683.2.patch Support char type in JDBC, including char length in result set metadata. -- This message was sent by Atlassian JIRA (v6.1#6144)
Review Request 15385: HIVE-5791 TestUseDatabase in hcategory failed to pass when illegal filenames in /tmp
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15385/ --- Review request for hive. Bugs: HIVE-5791 https://issues.apache.org/jira/browse/HIVE-5791 Repository: hive-git Description --- TestUseDatabase in hcategory failed to pass when illegal filenames in /tmp Diffs - hcatalog/core/src/test/java/org/apache/hcatalog/cli/TestUseDatabase.java d164da3 hcatalog/core/src/test/java/org/apache/hive/hcatalog/cli/TestUseDatabase.java f362b69 Diff: https://reviews.apache.org/r/15385/diff/ Testing --- Thanks, jin jie
[jira] [Commented] (HIVE-5791) TestUseDatabase in hcategory failed to pass when illegal filename in /tmp
[ https://issues.apache.org/jira/browse/HIVE-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818159#comment-13818159 ] Ashutosh Chauhan commented on HIVE-5791: +1 TestUseDatabase in hcategory failed to pass when illegal filename in /tmp - Key: HIVE-5791 URL: https://issues.apache.org/jira/browse/HIVE-5791 Project: Hive Issue Type: Bug Components: HCatalog Affects Versions: 0.13.0 Reporter: hellojinjie Priority: Minor Labels: test Fix For: 0.13.0 Attachments: HIVE-5791.patch Original Estimate: 1h Remaining Estimate: 1h The test code is trying to read /tmp directory. But, if in /tmp directory, there is a file name fcitx-socket-:0. Accroding to this issue https://issues.apache.org/jira/browse/HADOOP-7945 hadoop did not allow : in filename. The code print following message: FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.DDLTask. MetaException(message:java.lang.IllegalArgumentException: java.net.URISyntaxException: Relative path in absolute URI: fcitx-socket-:0) -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HIVE-5657) TopN produces incorrect results with count(distinct)
[ https://issues.apache.org/jira/browse/HIVE-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-5657: --- Resolution: Fixed Fix Version/s: 0.13.0 Status: Resolved (was: Patch Available) Committed to trunk. Thanks, Sergey! TopN produces incorrect results with count(distinct) Key: HIVE-5657 URL: https://issues.apache.org/jira/browse/HIVE-5657 Project: Hive Issue Type: Bug Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Priority: Critical Fix For: 0.13.0 Attachments: D13797.1.patch, D13797.2.patch, HIVE-5657.02.patch, HIVE-5657.03.patch, HIVE-5657.1.patch.txt, example.patch Attached patch illustrates the problem. limit_pushdown test has various other cases of aggregations and distincts, incl. count-distinct, that work correctly (that said, src dataset is bad for testing these things because every count, for example, produces one record only), so something must be special about this. I am not very familiar with distinct- code and these nuances; if someone knows a quick fix feel free to take this, otherwise I will probably start looking next week. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5626) enable metastore direct SQL for drop/similar queries
[ https://issues.apache.org/jira/browse/HIVE-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818165#comment-13818165 ] Ashutosh Chauhan commented on HIVE-5626: +1 enable metastore direct SQL for drop/similar queries Key: HIVE-5626 URL: https://issues.apache.org/jira/browse/HIVE-5626 Project: Hive Issue Type: Improvement Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Priority: Minor Attachments: HIVE-5626.01.patch, HIVE-5626.02.patch, HIVE-5626.patch Metastore direct SQL is currently disabled for any queries running inside external transaction (i.e. all modification queries, like dropping stuff). This was done to keep the strictly performance-optimization behavior when using Postgres, which unlike other RDBMS-es fails the tx on any syntax error; so, if direct SQL is broken there's no way to fall back. So, it is disabled for these cases. It is not as important because drop commands are rare, but we might want to address that. Either by some config setting or by making it work on non-postgres DBs. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HIVE-5686) partition column type validation doesn't quite work for dates
[
https://issues.apache.org/jira/browse/HIVE-5686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashutosh Chauhan updated HIVE-5686:
---
Status: Open (was: Patch Available)
partition column type validation doesn't quite work for dates
-
Key: HIVE-5686
URL: https://issues.apache.org/jira/browse/HIVE-5686
Project: Hive
Issue Type: Bug
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Attachments: HIVE-5686.01.patch, HIVE-5686.patch
Another interesting issue...
{noformat}
hive create table z(c string) partitioned by (i date,j date);
OK
Time taken: 0.099 seconds
hive alter table z add partition (i='2012-01-01', j='foo');
FAILED: SemanticException [Error 10248]: Cannot add partition column j of
type string as it cannot be converted to type date
hive alter table z add partition (i='2012-01-01', j=date 'foo');
OK
Time taken: 0.119 seconds
{noformat}
The fake date is caught in normal queries:
{noformat}
hive select * from z where j == date 'foo';
FAILED: SemanticException Unable to convert date literal string to date value.
{noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HIVE-5700) enforce single date format for partition column storage
[ https://issues.apache.org/jira/browse/HIVE-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818166#comment-13818166 ] Ashutosh Chauhan commented on HIVE-5700: +1 enforce single date format for partition column storage --- Key: HIVE-5700 URL: https://issues.apache.org/jira/browse/HIVE-5700 Project: Hive Issue Type: Improvement Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Attachments: HIVE-5700.01.patch, HIVE-5700.02.patch, HIVE-5700.patch inspired by HIVE-5286. Partition column for dates should be stored as either integer, or as fixed representation e.g. -mm-dd. External representation can remain varied as is. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HIVE-4116) Can't use views using map datatype.
[
https://issues.apache.org/jira/browse/HIVE-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashutosh Chauhan updated HIVE-4116:
---
Status: Open (was: Patch Available)
Can't use views using map datatype.
---
Key: HIVE-4116
URL: https://issues.apache.org/jira/browse/HIVE-4116
Project: Hive
Issue Type: Bug
Affects Versions: 0.11.0, 0.10.0, 0.8.1
Reporter: Karel Vervaeke
Assignee: Navis
Attachments: D12975.1.patch
Executing the following
{noformat}
DROP TABLE IF EXISTS `items`;
CREATE TABLE IF NOT EXISTS `items` (id INT, name STRING, info
MAPSTRING,STRING) PARTITIONED BY (ds STRING);
DROP VIEW IF EXISTS `priceview`;
CREATE VIEW `priceview` AS
SELECT
`items`.`id`,
`items`.info['price']
FROM
`items`
;
select * from `priceview`;
{noformat}
Produces the following error:
{noformat}
karel@tomato:~/tmp$ $HIVE_HOME/bin/hive -f hivebug.sql
WARNING: org.apache.hadoop.metrics.jvm.EventCounter is deprecated. Please use
org.apache.hadoop.log.metrics.EventCounter in all the log4j.properties files.
Logging initialized using configuration in
jar:file:/home/karel/opt/hive-0.10.0-bin/lib/hive-common-0.10.0.jar!/hive-log4j.properties
Hive history file=/tmp/karel/hive_job_log_karel_201303051117_945318761.txt
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/home/karel/opt/hadoop-2.0.0-mr1-cdh4.0.0/lib/slf4j-log4j12-1.6.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/home/karel/opt/hive-0.10.0-bin/lib/slf4j-log4j12-1.6.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
explanation.
OK
Time taken: 5.449 seconds
OK
Time taken: 0.303 seconds
OK
Time taken: 0.131 seconds
OK
Time taken: 0.206 seconds
FAILED: SemanticException line 3:22 mismatched input '.' expecting FROM near
'`items`' in from clause
in definition of VIEW priceview [
SELECT
`items`.`id`,
`items``items`.`info`info['price']
FROM
`default`.`items`
] used as priceview at Line 3:14
{noformat}
Unless I'm not using the right syntax, I would expect this simple example to
work. I have tried some variations (quotes, no quotes, ...), to no avail.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HIVE-4116) Can't use views using map datatype.
[
https://issues.apache.org/jira/browse/HIVE-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818170#comment-13818170
]
Ashutosh Chauhan commented on HIVE-4116:
+1 [~navis] Can you re-upload the patch so that Hive QA gets to run on it?
Can't use views using map datatype.
---
Key: HIVE-4116
URL: https://issues.apache.org/jira/browse/HIVE-4116
Project: Hive
Issue Type: Bug
Affects Versions: 0.8.1, 0.10.0, 0.11.0
Reporter: Karel Vervaeke
Assignee: Navis
Attachments: D12975.1.patch
Executing the following
{noformat}
DROP TABLE IF EXISTS `items`;
CREATE TABLE IF NOT EXISTS `items` (id INT, name STRING, info
MAPSTRING,STRING) PARTITIONED BY (ds STRING);
DROP VIEW IF EXISTS `priceview`;
CREATE VIEW `priceview` AS
SELECT
`items`.`id`,
`items`.info['price']
FROM
`items`
;
select * from `priceview`;
{noformat}
Produces the following error:
{noformat}
karel@tomato:~/tmp$ $HIVE_HOME/bin/hive -f hivebug.sql
WARNING: org.apache.hadoop.metrics.jvm.EventCounter is deprecated. Please use
org.apache.hadoop.log.metrics.EventCounter in all the log4j.properties files.
Logging initialized using configuration in
jar:file:/home/karel/opt/hive-0.10.0-bin/lib/hive-common-0.10.0.jar!/hive-log4j.properties
Hive history file=/tmp/karel/hive_job_log_karel_201303051117_945318761.txt
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/home/karel/opt/hadoop-2.0.0-mr1-cdh4.0.0/lib/slf4j-log4j12-1.6.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/home/karel/opt/hive-0.10.0-bin/lib/slf4j-log4j12-1.6.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
explanation.
OK
Time taken: 5.449 seconds
OK
Time taken: 0.303 seconds
OK
Time taken: 0.131 seconds
OK
Time taken: 0.206 seconds
FAILED: SemanticException line 3:22 mismatched input '.' expecting FROM near
'`items`' in from clause
in definition of VIEW priceview [
SELECT
`items`.`id`,
`items``items`.`info`info['price']
FROM
`default`.`items`
] used as priceview at Line 3:14
{noformat}
Unless I'm not using the right syntax, I would expect this simple example to
work. I have tried some variations (quotes, no quotes, ...), to no avail.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (HIVE-4200) Consolidate submodule dependencies using ivy inheritance
[ https://issues.apache.org/jira/browse/HIVE-4200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-4200: --- Resolution: Won't Fix Fix Version/s: 0.13.0 Status: Resolved (was: Patch Available) Not required after mavenization. Consolidate submodule dependencies using ivy inheritance Key: HIVE-4200 URL: https://issues.apache.org/jira/browse/HIVE-4200 Project: Hive Issue Type: Bug Reporter: Gunther Hagleitner Assignee: Gunther Hagleitner Fix For: 0.13.0 Attachments: HIVE-4200.1.patch.txt, HIVE-4200.2.patch, HIVE-4200.3.patch, HIVE-4200.4.patch As discussed in 4187: For easier maintenance of ivy dependencies across submodules: Create parent ivy file with consolidated dependencies and include into submodules via inheritance. This way we're not relying on transitive dependencies, but also have the dependencies in a single place. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5753) Remove collector from Operator base class
[ https://issues.apache.org/jira/browse/HIVE-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818173#comment-13818173 ] Ashutosh Chauhan commented on HIVE-5753: +1 Remove collector from Operator base class - Key: HIVE-5753 URL: https://issues.apache.org/jira/browse/HIVE-5753 Project: Hive Issue Type: Improvement Reporter: Mohammad Kamrul Islam Assignee: Mohammad Kamrul Islam Attachments: HIVE-5753.1.patch Collector is required for few operators. Managing this into base class is overkill and bad design. This JIRA is to refactor the code pushing this to where it is required. Background: https://issues.apache.org/jira/browse/HIVE-5345?focusedCommentId=13775665page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13775665 -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5221) Issue in column type with data type as BINARY
[ https://issues.apache.org/jira/browse/HIVE-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818176#comment-13818176 ] Ashutosh Chauhan commented on HIVE-5221: [~brocknoland] I think you have a valid point. I think we should do same on write side as we are now doing on read side, ie if user wants to store binary data in text file (which is weird, but anyways) he need to use an udf to encode it before passing it to serde. Than, we are consistent on both read and write side, asking user to use appropriate udfs for encoding/decoding and setting serde free from any assumptions. [~kamrul] Can you make changes in LazyUtils.writePrimitiveUtf8 so that it doesn't do any encoding? Issue in column type with data type as BINARY - Key: HIVE-5221 URL: https://issues.apache.org/jira/browse/HIVE-5221 Project: Hive Issue Type: Bug Reporter: Arun Vasu Assignee: Mohammad Kamrul Islam Priority: Critical Attachments: HIVE-5221.1.patch, HIVE-5221.2.patch Hi, I am using Hive 10. When I create an external table with column type as Binary, the query result on the table is showing some junk values for the column with binary datatype. Please find below the query I have used to create the table: CREATE EXTERNAL TABLE BOOL1(NB BOOLEAN,email STRING, bitfld BINARY) ROW FORMAT DELIMITED FIELDS TERMINATED BY '^' LINES TERMINATED BY '\n' STORED AS TEXTFILE LOCATION '/user/hivetables/testbinary'; The query I have used is : select * from bool1 The sample data in the hdfs file is: 0^a...@abc.com^001 1^a...@abc.com^010 ^a...@abc.com^011 ^a...@abc.com^100 t^a...@abc.com^101 f^a...@abc.com^110 true^a...@abc.com^111 false^a...@abc.com^001 123^^01100010 12344^^0111 Please share your inputs if it is possible. Thanks, Arun -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HIVE-5221) Issue in column type with data type as BINARY
[ https://issues.apache.org/jira/browse/HIVE-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-5221: --- Status: Open (was: Patch Available) Issue in column type with data type as BINARY - Key: HIVE-5221 URL: https://issues.apache.org/jira/browse/HIVE-5221 Project: Hive Issue Type: Bug Reporter: Arun Vasu Assignee: Mohammad Kamrul Islam Priority: Critical Attachments: HIVE-5221.1.patch, HIVE-5221.2.patch Hi, I am using Hive 10. When I create an external table with column type as Binary, the query result on the table is showing some junk values for the column with binary datatype. Please find below the query I have used to create the table: CREATE EXTERNAL TABLE BOOL1(NB BOOLEAN,email STRING, bitfld BINARY) ROW FORMAT DELIMITED FIELDS TERMINATED BY '^' LINES TERMINATED BY '\n' STORED AS TEXTFILE LOCATION '/user/hivetables/testbinary'; The query I have used is : select * from bool1 The sample data in the hdfs file is: 0^a...@abc.com^001 1^a...@abc.com^010 ^a...@abc.com^011 ^a...@abc.com^100 t^a...@abc.com^101 f^a...@abc.com^110 true^a...@abc.com^111 false^a...@abc.com^001 123^^01100010 12344^^0111 Please share your inputs if it is possible. Thanks, Arun -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5737) Provide StructObjectInspector for UDTFs rather than ObjectInspect[]
[
https://issues.apache.org/jira/browse/HIVE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818180#comment-13818180
]
Ashutosh Chauhan commented on HIVE-5737:
+1
Provide StructObjectInspector for UDTFs rather than ObjectInspect[]
---
Key: HIVE-5737
URL: https://issues.apache.org/jira/browse/HIVE-5737
Project: Hive
Issue Type: Improvement
Components: UDF
Reporter: Navis
Assignee: Navis
Priority: Trivial
Attachments: HIVE-5737.1.patch.txt
In UDTF, column names can be useful sometimes. For example, complex function
with many optional parameters something like,
xml_explode('\t' as field, '\n' as line, '=' as mapkey, ':' as items, input)
Without column name, it's not easy to discern each parameter is for what.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (HIVE-5699) Add unit test for vectorized BETWEEN for timestamp inputs
[ https://issues.apache.org/jira/browse/HIVE-5699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-5699: --- Resolution: Fixed Fix Version/s: 0.13.0 Status: Resolved (was: Patch Available) Committed to trunk. Thanks, Eric! Add unit test for vectorized BETWEEN for timestamp inputs - Key: HIVE-5699 URL: https://issues.apache.org/jira/browse/HIVE-5699 Project: Hive Issue Type: Sub-task Components: Vectorization Affects Versions: 0.13.0 Reporter: Eric Hanson Assignee: Eric Hanson Priority: Minor Fix For: 0.13.0 Attachments: HIVE-5699.2.patch See request for this in HIVE-5582 -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HIVE-5685) partition column type validation doesn't work in some cases
[
https://issues.apache.org/jira/browse/HIVE-5685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashutosh Chauhan updated HIVE-5685:
---
Status: Open (was: Patch Available)
[~vikram.dixit] Seems like you need to re-upload the patch for Hive QA
partition column type validation doesn't work in some cases
---
Key: HIVE-5685
URL: https://issues.apache.org/jira/browse/HIVE-5685
Project: Hive
Issue Type: Bug
Reporter: Sergey Shelukhin
Assignee: Vikram Dixit K
Attachments: HIVE-5685.1.patch, HIVE-5685.2.patch, HIVE-5685.3.patch
It seems like it works if there's more than one partition column, and doesn't
work if there's just one. At least that's the case that I found. The
situation for different types is the same.
{noformat}
hive create table zzz(c string) partitioned by (i int);
OK
Time taken: 0.41 seconds
hive alter table zzz add partition (i='foo');
OK
Time taken: 0.185 seconds
hive create table (c string) partitioned by (i int,j int);
OK
Time taken: 0.085 seconds
hive alter table add partition (i='foo',j=5);
FAILED: SemanticException [Error 10248]: Cannot add partition column i of
type string as it cannot be converted to type int
hive alter table add partition (i=5,j='foo');
FAILED: SemanticException [Error 10248]: Cannot add partition column j of
type string as it cannot be converted to type int
{noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (HIVE-5697) Correlation Optimizer may generate wrong plans for cases involving outer join
[
https://issues.apache.org/jira/browse/HIVE-5697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashutosh Chauhan updated HIVE-5697:
---
Status: Open (was: Patch Available)
+1 [~yhuai] Can you re-upload a patch so that Hive QA gets to run on it?
Correlation Optimizer may generate wrong plans for cases involving outer join
-
Key: HIVE-5697
URL: https://issues.apache.org/jira/browse/HIVE-5697
Project: Hive
Issue Type: Sub-task
Affects Versions: 0.12.0, 0.13.0
Reporter: Yin Huai
Assignee: Yin Huai
Attachments: HIVE-5697.1.patch, HIVE-5697.2.patch
For example,
{code:sql}
select x.key, y.value, count(*) from src x right outer join src1 y on
(x.key=y.key and x.value=y.value) group by x.key, y.value;
{code}
Correlation optimizer will determine that a single MR job is enough for this
query. However, the group by key are from both left and right tables of the
right outer join.
We will have a wrong result like
{code}
NULL 4
NULL val_165 1
NULL val_193 1
NULL val_265 1
NULL val_27 1
NULL val_409 1
NULL val_484 1
NULL 1
146 val_146 2
150 val_150 1
213 val_213 2
NULL 1
238 val_238 2
255 val_255 2
273 val_273 3
278 val_278 2
311 val_311 3
NULL 1
401 val_401 5
406 val_406 4
66val_66 1
98val_98 2
{code}
Rows with both x.key and y.value are null may not be grouped.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (HIVE-5763) ExprNodeGenericFuncDesc.toString() generating unbalanced parenthesises
[
https://issues.apache.org/jira/browse/HIVE-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashutosh Chauhan updated HIVE-5763:
---
Status: Open (was: Patch Available)
Patch needs to be re-uploaded for Hive QA
ExprNodeGenericFuncDesc.toString() generating unbalanced parenthesises
--
Key: HIVE-5763
URL: https://issues.apache.org/jira/browse/HIVE-5763
Project: Hive
Issue Type: Bug
Components: Query Processor
Reporter: Xuefu Zhang
Assignee: Xuefu Zhang
Priority: Minor
Attachments: HIVE-5763.1.patch, HIVE-5763.patch
This makes the generated expression tree unreadable.
{code}
public String toString() {
StringBuilder sb = new StringBuilder();
sb.append(genericUDF.getClass().toString());
sb.append(();
for (int i = 0; i chidren.size(); i++) {
if (i 0) {
sb.append(, );
}
sb.append(chidren.get(i).toString());
}
sb.append((); -- This needs to be removed.
sb.append());
return sb.toString();
}
{code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (HIVE-5722) Skip generating vectorization code if possible
[ https://issues.apache.org/jira/browse/HIVE-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-5722: --- Status: Open (was: Patch Available) Patch needs to be re-uploaded for Hive QA Skip generating vectorization code if possible -- Key: HIVE-5722 URL: https://issues.apache.org/jira/browse/HIVE-5722 Project: Hive Issue Type: Improvement Components: Build Infrastructure Reporter: Navis Assignee: Navis Priority: Minor Attachments: D13941.1.patch, HIVE-5722.1.patch.txt Currently, ql module always generates new vectorization code, which might not be changed so frequently. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5692) Make VectorGroupByOperator parameters configurable
[ https://issues.apache.org/jira/browse/HIVE-5692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818194#comment-13818194 ] Ashutosh Chauhan commented on HIVE-5692: [~gopalv] I think you have encountered this bug in wild. Would you like to review this patch ? Make VectorGroupByOperator parameters configurable -- Key: HIVE-5692 URL: https://issues.apache.org/jira/browse/HIVE-5692 Project: Hive Issue Type: Bug Reporter: Remus Rusanu Assignee: Remus Rusanu Priority: Minor Attachments: HIVE-5692.1.patch, HIVE-5692.2.patch, HIVE-5692.3.patch The FLUSH_CHECK_THRESHOLD and PERCENT_ENTRIES_TO_FLUSH should be configurable. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5790) maven test build failure shows wrong error message
[
https://issues.apache.org/jira/browse/HIVE-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818196#comment-13818196
]
Hive QA commented on HIVE-5790:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12612974/HIVE-5790.1.patch
{color:green}SUCCESS:{color} +1 4598 tests passed
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/229/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/229/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12612974
maven test build failure shows wrong error message
---
Key: HIVE-5790
URL: https://issues.apache.org/jira/browse/HIVE-5790
Project: Hive
Issue Type: Bug
Reporter: Mohammad Kamrul Islam
Assignee: Mohammad Kamrul Islam
Attachments: HIVE-5790.1.patch
This is the error message that was correct for ant.
See build/ql/tmp/hive.log, or try ant test ... -Dtest.silent=false to get
more logs.
This JIRA is to replace this message with mvn-specific error message.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HIVE-4880) Rearrange explain order of stages simpler
[
https://issues.apache.org/jira/browse/HIVE-4880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818200#comment-13818200
]
Ashutosh Chauhan commented on HIVE-4880:
+1 I think I will use execution option in most cases.
Rearrange explain order of stages simpler
-
Key: HIVE-4880
URL: https://issues.apache.org/jira/browse/HIVE-4880
Project: Hive
Issue Type: Improvement
Components: Diagnosability
Reporter: Navis
Assignee: Navis
Priority: Trivial
Attachments: D11733.2.patch, D11733.3.patch, D11733.4.patch,
HIVE-4880.D11733.1.patch
Current explain order of stages is not best form to read (and to debug)
{noformat}
Before:
STAGE DEPENDENCIES:
Stage-1 is a root stage
Stage-7 depends on stages: Stage-1 , consists of Stage-4, Stage-3, Stage-5
Stage-4
Stage-0 depends on stages: Stage-4, Stage-3, Stage-6
Stage-9 depends on stages: Stage-0
Stage-2 depends on stages: Stage-9
Stage-3
Stage-5
Stage-6 depends on stages: Stage-5
After:
STAGE DEPENDENCIES:
Stage-1 is a root stage
Stage-2 depends on stages: Stage-1 , consists of Stage-3, Stage-4, Stage-5
Stage-3
Stage-4
Stage-5
Stage-6 depends on stages: Stage-5
Stage-7 depends on stages: Stage-3, Stage-4, Stage-6
Stage-8 depends on stages: Stage-7
Stage-9 depends on stages: Stage-8
{noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HIVE-5731) Use new GenericUDF instead of basic UDF for UDFDate* classes
[
https://issues.apache.org/jira/browse/HIVE-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818209#comment-13818209
]
Hive QA commented on HIVE-5731:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12612973/HIVE-5731.4.patch
{color:green}SUCCESS:{color} +1 4607 tests passed
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/230/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/230/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12612973
Use new GenericUDF instead of basic UDF for UDFDate* classes
-
Key: HIVE-5731
URL: https://issues.apache.org/jira/browse/HIVE-5731
Project: Hive
Issue Type: Improvement
Reporter: Mohammad Kamrul Islam
Assignee: Mohammad Kamrul Islam
Attachments: HIVE-5731.1.patch, HIVE-5731.2.patch, HIVE-5731.3.patch,
HIVE-5731.4.patch
GenericUDF class is the latest and recommended base class for any UDFs.
This JIRA is to change the current UDFDate* classes extended from GenericUDF.
The general benefit of GenericUDF is described in comments as
* The GenericUDF are superior to normal UDFs in the following ways: 1. It can
accept arguments of complex types, and return complex types. 2. It can
accept
variable length of arguments. 3. It can accept an infinite number of
function
signature - for example, it's easy to write a GenericUDF that accepts
arrayint, arrayarrayint and so on (arbitrary levels of nesting). 4.
It
can do short-circuit evaluations using DeferedObject.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HIVE-3990) Provide input threshold for direct-fetcher (HIVE-2925)
[ https://issues.apache.org/jira/browse/HIVE-3990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818225#comment-13818225 ] Ashutosh Chauhan commented on HIVE-3990: +1 Provide input threshold for direct-fetcher (HIVE-2925) -- Key: HIVE-3990 URL: https://issues.apache.org/jira/browse/HIVE-3990 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: Navis Assignee: Navis Priority: Trivial Attachments: D8415.2.patch, D8415.3.patch, HIVE-3990.D8415.1.patch As a followup of HIVE-2925, add input threshold for fetch task conversion. -- This message was sent by Atlassian JIRA (v6.1#6144)
Re: Review Request 15213: HIVE-5731: Use new GenericUDF instead of basic UDF for UDFDate* classes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15213/#review28624 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java https://reviews.apache.org/r/15213/#comment55521 Shouldn't the outputOI be writableDateOI ? ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java https://reviews.apache.org/r/15213/#comment55518 First argument should be argumentOI. ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java https://reviews.apache.org/r/15213/#comment55519 First argument should be argumentOI. ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java https://reviews.apache.org/r/15213/#comment55520 Instead of throwing up in parse exception, we should return null in such cases. ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateAdd.java https://reviews.apache.org/r/15213/#comment55522 outputOI should be writableDateOI ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateAdd.java https://reviews.apache.org/r/15213/#comment55523 First arg should be ((PrimitiveObjectInspector) arguments[0]) ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateAdd.java https://reviews.apache.org/r/15213/#comment55524 Instead of throwing exception, this should return null. ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java https://reviews.apache.org/r/15213/#comment55528 In evaluate() you are creating new IntWritable everytime, instead that function should return int and you should do output.set() and return output. This way we will save unnecessary object creation of intWritable for each invocation. ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java https://reviews.apache.org/r/15213/#comment55525 outputOI should be writableOI ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java https://reviews.apache.org/r/15213/#comment55526 first argument should be ((PrimitiveObjectInspector) arguments[0]) ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java https://reviews.apache.org/r/15213/#comment55527 this should return null, instead of throwing exception. - Ashutosh Chauhan On Nov. 5, 2013, 7:33 p.m., Mohammad Islam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15213/ --- (Updated Nov. 5, 2013, 7:33 p.m.) Review request for hive. Bugs: HIVE-5731 https://issues.apache.org/jira/browse/HIVE-5731 Repository: hive-git Description --- GenericUDF class is the latest and recommended base class for any UDFs. This JIRA is to change the current UDFDate* classes extended from GenericUDF. Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 8d3a84f ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDate.java 3df453c ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateAdd.java b1b0bf2 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateDiff.java da14c4f ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateSub.java c8a1d1f ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateAdd.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDate.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateAdd.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateDiff.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateSub.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFDateAdd.java f0af069 ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFDateDiff.java 8a6dbc3 ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFDateSub.java fa722a9 Diff: https://reviews.apache.org/r/15213/diff/ Testing --- Thanks, Mohammad Islam
[jira] [Updated] (HIVE-5731) Use new GenericUDF instead of basic UDF for UDFDate* classes
[ https://issues.apache.org/jira/browse/HIVE-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-5731: --- Status: Open (was: Patch Available) Left some comments on RB. Use new GenericUDF instead of basic UDF for UDFDate* classes - Key: HIVE-5731 URL: https://issues.apache.org/jira/browse/HIVE-5731 Project: Hive Issue Type: Improvement Reporter: Mohammad Kamrul Islam Assignee: Mohammad Kamrul Islam Attachments: HIVE-5731.1.patch, HIVE-5731.2.patch, HIVE-5731.3.patch, HIVE-5731.4.patch GenericUDF class is the latest and recommended base class for any UDFs. This JIRA is to change the current UDFDate* classes extended from GenericUDF. The general benefit of GenericUDF is described in comments as * The GenericUDF are superior to normal UDFs in the following ways: 1. It can accept arguments of complex types, and return complex types. 2. It can accept variable length of arguments. 3. It can accept an infinite number of function signature - for example, it's easy to write a GenericUDF that accepts arrayint, arrayarrayint and so on (arbitrary levels of nesting). 4. It can do short-circuit evaluations using DeferedObject. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (HIVE-5792) The TBLPROPERTIES may no longer get passed properly to SerDes
Swarnim Kulkarni created HIVE-5792: -- Summary: The TBLPROPERTIES may no longer get passed properly to SerDes Key: HIVE-5792 URL: https://issues.apache.org/jira/browse/HIVE-5792 Project: Hive Issue Type: Bug Affects Versions: 0.12.0 Reporter: Swarnim Kulkarni I noticed this with HBaseSerDe but it seems like with the latest release only the SERDEPROPERTIES get passed to the SerDes and not the TBLPROPERTIES which seems like a non-passive change and could affect existing consumers with custom serdes relying on TBLPROPERTIES. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5627) Document 'usehcatalog' parameter on WebHCat calls
[ https://issues.apache.org/jira/browse/HIVE-5627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818239#comment-13818239 ] Eugene Koifman commented on HIVE-5627: -- For the Pig call I would add the following: If '-useHCatalog' is included in the 'arg' parameter, then 'usehcatalog' is interpreted as true. Othewrwise it looks fine. Thanks! Document 'usehcatalog' parameter on WebHCat calls - Key: HIVE-5627 URL: https://issues.apache.org/jira/browse/HIVE-5627 Project: Hive Issue Type: Sub-task Components: Documentation, WebHCat Affects Versions: 0.12.0 Reporter: Eugene Koifman Assignee: Lefty Leverenz Fix For: 0.13.0 The following REST calls in WebHCat: 1. mapreduce/jar 2. pig now support an additional parameter 'usehcatalog'. This is a mechanism for the caller to tell WebHCat that the submitted job uses HCat, and thus needs to access the metastore, which requires additional steps for WebHCat to perform in a secure cluster. The JavaDoc on corresponding methods in org.apache.hive.hcatalog.templeton.Server describe this parameter. Additionally, if templeton.hive.archive, templeton.hive.home and templeton.hcat.home are defined in webhcat-site.xml (documented in webhcat-default.xml) then WebHCat will ship the Hive tar to the target node where the job actually runs. This means that Hive doesn't need to be installed on every node in the Hadoop cluster. (This part was added in HIVE-5547). This is independent of security, but improves manageability. This should be added to the sections in https://cwiki.apache.org/confluence/display/Hive/WebHCat+Reference that correspond to these methods. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5627) Document 'usehcatalog' parameter on WebHCat calls
[ https://issues.apache.org/jira/browse/HIVE-5627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818252#comment-13818252 ] Lefty Leverenz commented on HIVE-5627: -- Done. Thanks for the quick review. Document 'usehcatalog' parameter on WebHCat calls - Key: HIVE-5627 URL: https://issues.apache.org/jira/browse/HIVE-5627 Project: Hive Issue Type: Sub-task Components: Documentation, WebHCat Affects Versions: 0.12.0 Reporter: Eugene Koifman Assignee: Lefty Leverenz Fix For: 0.13.0 The following REST calls in WebHCat: 1. mapreduce/jar 2. pig now support an additional parameter 'usehcatalog'. This is a mechanism for the caller to tell WebHCat that the submitted job uses HCat, and thus needs to access the metastore, which requires additional steps for WebHCat to perform in a secure cluster. The JavaDoc on corresponding methods in org.apache.hive.hcatalog.templeton.Server describe this parameter. Additionally, if templeton.hive.archive, templeton.hive.home and templeton.hcat.home are defined in webhcat-site.xml (documented in webhcat-default.xml) then WebHCat will ship the Hive tar to the target node where the job actually runs. This means that Hive doesn't need to be installed on every node in the Hadoop cluster. (This part was added in HIVE-5547). This is independent of security, but improves manageability. This should be added to the sections in https://cwiki.apache.org/confluence/display/Hive/WebHCat+Reference that correspond to these methods. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5791) TestUseDatabase in hcategory failed to pass when illegal filename in /tmp
[
https://issues.apache.org/jira/browse/HIVE-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818265#comment-13818265
]
Hive QA commented on HIVE-5791:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12612990/HIVE-5791.patch
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 4600 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_smb_mapjoin_8
org.apache.hcatalog.cli.TestUseDatabase.testAlterTablePass
{noformat}
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/231/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/231/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests failed with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12612990
TestUseDatabase in hcategory failed to pass when illegal filename in /tmp
-
Key: HIVE-5791
URL: https://issues.apache.org/jira/browse/HIVE-5791
Project: Hive
Issue Type: Bug
Components: HCatalog
Affects Versions: 0.13.0
Reporter: hellojinjie
Priority: Minor
Labels: test
Fix For: 0.13.0
Attachments: HIVE-5791.patch
Original Estimate: 1h
Remaining Estimate: 1h
The test code is trying to read /tmp directory. But, if in /tmp directory,
there is a file name fcitx-socket-:0.
Accroding to this issue https://issues.apache.org/jira/browse/HADOOP-7945
hadoop did not allow : in filename.
The code print following message:
FAILED: Execution Error, return code 1 from
org.apache.hadoop.hive.ql.exec.DDLTask.
MetaException(message:java.lang.IllegalArgumentException:
java.net.URISyntaxException: Relative path in absolute URI: fcitx-socket-:0)
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HIVE-5731) Use new GenericUDF instead of basic UDF for UDFDate* classes
[
https://issues.apache.org/jira/browse/HIVE-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818289#comment-13818289
]
Edward Capriolo commented on HIVE-5731:
---
{quote}
GenericUDF class is the latest and recommended base class for any UDFs.
This JIRA is to change the current UDFDate* classes extended from GenericUDF.
{quote}
Had anyone done performance evaluation on the speed of a UDF vs a generic UDF.
I understand the motivation in the vectorized case, but are users of the
non-vectorized case getting less performance. If I knew the performance was
negligible I would not care, but I have not seen any numbers and I am wondering
if we have considered the implications of this.
Use new GenericUDF instead of basic UDF for UDFDate* classes
-
Key: HIVE-5731
URL: https://issues.apache.org/jira/browse/HIVE-5731
Project: Hive
Issue Type: Improvement
Reporter: Mohammad Kamrul Islam
Assignee: Mohammad Kamrul Islam
Attachments: HIVE-5731.1.patch, HIVE-5731.2.patch, HIVE-5731.3.patch,
HIVE-5731.4.patch
GenericUDF class is the latest and recommended base class for any UDFs.
This JIRA is to change the current UDFDate* classes extended from GenericUDF.
The general benefit of GenericUDF is described in comments as
* The GenericUDF are superior to normal UDFs in the following ways: 1. It can
accept arguments of complex types, and return complex types. 2. It can
accept
variable length of arguments. 3. It can accept an infinite number of
function
signature - for example, it's easy to write a GenericUDF that accepts
arrayint, arrayarrayint and so on (arbitrary levels of nesting). 4.
It
can do short-circuit evaluations using DeferedObject.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (HIVE-5728) Make ORC InputFormat/OutputFormat usable outside Hive
[ https://issues.apache.org/jira/browse/HIVE-5728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated HIVE-5728: - Attachment: HIVE-5728-3.patch Addressing [~owen.omalley]'s review comments. The code movement is not necessary, I retained the code in OrcInputFormat this time. I also leave OrcStruct non-public, it is not absolutely needed here. Make ORC InputFormat/OutputFormat usable outside Hive - Key: HIVE-5728 URL: https://issues.apache.org/jira/browse/HIVE-5728 Project: Hive Issue Type: Improvement Components: File Formats Reporter: Daniel Dai Assignee: Daniel Dai Fix For: 0.13.0 Attachments: HIVE-5728-1.patch, HIVE-5728-2.patch, HIVE-5728-3.patch ORC InputFormat/OutputFormat is currently not usable outside Hive. There are several issues need to solve: 1. Several class is not public, eg: OrcStruct 2. There is no InputFormat/OutputFormat for new api (Some tools such as Pig need new api) 3. Has no way to push WriteOption to OutputFormat outside Hive -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HIVE-5722) Skip generating vectorization code if possible
[ https://issues.apache.org/jira/browse/HIVE-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Navis updated HIVE-5722: Status: Patch Available (was: Open) Skip generating vectorization code if possible -- Key: HIVE-5722 URL: https://issues.apache.org/jira/browse/HIVE-5722 Project: Hive Issue Type: Improvement Components: Build Infrastructure Reporter: Navis Assignee: Navis Priority: Minor Attachments: D13941.1.patch, HIVE-5722.1.patch.txt, HIVE-5722.3.patch.txt Currently, ql module always generates new vectorization code, which might not be changed so frequently. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HIVE-5722) Skip generating vectorization code if possible
[ https://issues.apache.org/jira/browse/HIVE-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Navis updated HIVE-5722: Attachment: HIVE-5722.3.patch.txt Skip generating vectorization code if possible -- Key: HIVE-5722 URL: https://issues.apache.org/jira/browse/HIVE-5722 Project: Hive Issue Type: Improvement Components: Build Infrastructure Reporter: Navis Assignee: Navis Priority: Minor Attachments: D13941.1.patch, HIVE-5722.1.patch.txt, HIVE-5722.3.patch.txt Currently, ql module always generates new vectorization code, which might not be changed so frequently. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HIVE-4144) Add select database() command to show the current database
[
https://issues.apache.org/jira/browse/HIVE-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Navis updated HIVE-4144:
Status: Open (was: Patch Available)
Add select database() command to show the current database
Key: HIVE-4144
URL: https://issues.apache.org/jira/browse/HIVE-4144
Project: Hive
Issue Type: Bug
Components: SQL
Reporter: Mark Grover
Assignee: Navis
Attachments: D9597.5.patch, HIVE-4144.6.patch.txt,
HIVE-4144.D9597.1.patch, HIVE-4144.D9597.2.patch, HIVE-4144.D9597.3.patch,
HIVE-4144.D9597.4.patch
A recent hive-user mailing list conversation asked about having a command to
show the current database.
http://mail-archives.apache.org/mod_mbox/hive-user/201303.mbox/%3CCAMGr+0i+CRY69m3id=DxthmUCWLf0NxpKMCtROb=uauh2va...@mail.gmail.com%3E
MySQL seems to have a command to do so:
{code}
select database();
{code}
http://dev.mysql.com/doc/refman/5.0/en/information-functions.html#function_database
We should look into having something similar in Hive.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (HIVE-4144) Add select database() command to show the current database
[
https://issues.apache.org/jira/browse/HIVE-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Navis updated HIVE-4144:
Status: Patch Available (was: Open)
Add select database() command to show the current database
Key: HIVE-4144
URL: https://issues.apache.org/jira/browse/HIVE-4144
Project: Hive
Issue Type: Bug
Components: SQL
Reporter: Mark Grover
Assignee: Navis
Attachments: D9597.5.patch, HIVE-4144.6.patch.txt,
HIVE-4144.7.patch.txt, HIVE-4144.D9597.1.patch, HIVE-4144.D9597.2.patch,
HIVE-4144.D9597.3.patch, HIVE-4144.D9597.4.patch
A recent hive-user mailing list conversation asked about having a command to
show the current database.
http://mail-archives.apache.org/mod_mbox/hive-user/201303.mbox/%3CCAMGr+0i+CRY69m3id=DxthmUCWLf0NxpKMCtROb=uauh2va...@mail.gmail.com%3E
MySQL seems to have a command to do so:
{code}
select database();
{code}
http://dev.mysql.com/doc/refman/5.0/en/information-functions.html#function_database
We should look into having something similar in Hive.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (HIVE-4144) Add select database() command to show the current database
[
https://issues.apache.org/jira/browse/HIVE-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Navis updated HIVE-4144:
Attachment: HIVE-4144.7.patch.txt
Add select database() command to show the current database
Key: HIVE-4144
URL: https://issues.apache.org/jira/browse/HIVE-4144
Project: Hive
Issue Type: Bug
Components: SQL
Reporter: Mark Grover
Assignee: Navis
Attachments: D9597.5.patch, HIVE-4144.6.patch.txt,
HIVE-4144.7.patch.txt, HIVE-4144.D9597.1.patch, HIVE-4144.D9597.2.patch,
HIVE-4144.D9597.3.patch, HIVE-4144.D9597.4.patch
A recent hive-user mailing list conversation asked about having a command to
show the current database.
http://mail-archives.apache.org/mod_mbox/hive-user/201303.mbox/%3CCAMGr+0i+CRY69m3id=DxthmUCWLf0NxpKMCtROb=uauh2va...@mail.gmail.com%3E
MySQL seems to have a command to do so:
{code}
select database();
{code}
http://dev.mysql.com/doc/refman/5.0/en/information-functions.html#function_database
We should look into having something similar in Hive.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
Re: Review Request 15375: HIVE-5683 JDBC support for char
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15375/#review28630 --- service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TProtocolVersion.java https://reviews.apache.org/r/15375/#comment55545 I simply did the thrift code generation and added any changed files, which includes this file. True there aren't any significant changes in this one, but the previous version of this file was edited manually. Anyway, I don't see any need to modify this part of the diff. V4 is in this file, it's not missing. - Jason Dere On Nov. 8, 2013, 11:05 p.m., Jason Dere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15375/ --- (Updated Nov. 8, 2013, 11:05 p.m.) Review request for hive and Thejas Nair. Bugs: HIVE-5683 https://issues.apache.org/jira/browse/HIVE-5683 Repository: hive-git Description --- thrift/jdbc changes for char. Diffs - data/files/datatypes.txt 10daa1b itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java a270cc6 jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java b693e93 jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 25faf48 jdbc/src/java/org/apache/hive/jdbc/HiveResultSetMetaData.java 79e8c8c jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java d612cf6 jdbc/src/java/org/apache/hive/jdbc/Utils.java 45de290 service/if/TCLIService.thrift 1f49445 service/src/gen/thrift/gen-cpp/TCLIService_constants.h 7471811 service/src/gen/thrift/gen-cpp/TCLIService_constants.cpp d085b30 service/src/gen/thrift/gen-cpp/TCLIService_types.h 490b393 service/src/gen/thrift/gen-cpp/TCLIService_types.cpp a3fd46c service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCLIServiceConstants.java 7b4c576 service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionResp.java 5d353f7 service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TProtocolVersion.java 15f2973 service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTypeId.java be70a3a service/src/gen/thrift/gen-py/TCLIService/constants.py 589ce88 service/src/gen/thrift/gen-py/TCLIService/ttypes.py b286b05 service/src/gen/thrift/gen-rb/t_c_l_i_service_constants.rb 8c341c8 service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb c608364 service/src/java/org/apache/hive/service/cli/ColumnValue.java 62e221b service/src/java/org/apache/hive/service/cli/Type.java f414fca service/src/java/org/apache/hive/service/cli/TypeQualifiers.java 66a4b12 Diff: https://reviews.apache.org/r/15375/diff/ Testing --- Thanks, Jason Dere
Re: Review Request 15375: HIVE-5683 JDBC support for char
On Nov. 9, 2013, 2:47 p.m., Xuefu Zhang wrote: jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java, line 138 https://reviews.apache.org/r/15375/diff/1/?file=381307#file381307line138 Could you remove the trailing space/tab? Ok, will fix in next patch - Jason --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15375/#review28616 --- On Nov. 8, 2013, 11:05 p.m., Jason Dere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15375/ --- (Updated Nov. 8, 2013, 11:05 p.m.) Review request for hive and Thejas Nair. Bugs: HIVE-5683 https://issues.apache.org/jira/browse/HIVE-5683 Repository: hive-git Description --- thrift/jdbc changes for char. Diffs - data/files/datatypes.txt 10daa1b itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java a270cc6 jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java b693e93 jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 25faf48 jdbc/src/java/org/apache/hive/jdbc/HiveResultSetMetaData.java 79e8c8c jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java d612cf6 jdbc/src/java/org/apache/hive/jdbc/Utils.java 45de290 service/if/TCLIService.thrift 1f49445 service/src/gen/thrift/gen-cpp/TCLIService_constants.h 7471811 service/src/gen/thrift/gen-cpp/TCLIService_constants.cpp d085b30 service/src/gen/thrift/gen-cpp/TCLIService_types.h 490b393 service/src/gen/thrift/gen-cpp/TCLIService_types.cpp a3fd46c service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCLIServiceConstants.java 7b4c576 service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionResp.java 5d353f7 service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TProtocolVersion.java 15f2973 service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTypeId.java be70a3a service/src/gen/thrift/gen-py/TCLIService/constants.py 589ce88 service/src/gen/thrift/gen-py/TCLIService/ttypes.py b286b05 service/src/gen/thrift/gen-rb/t_c_l_i_service_constants.rb 8c341c8 service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb c608364 service/src/java/org/apache/hive/service/cli/ColumnValue.java 62e221b service/src/java/org/apache/hive/service/cli/Type.java f414fca service/src/java/org/apache/hive/service/cli/TypeQualifiers.java 66a4b12 Diff: https://reviews.apache.org/r/15375/diff/ Testing --- Thanks, Jason Dere
[jira] [Updated] (HIVE-5683) JDBC support for char
[ https://issues.apache.org/jira/browse/HIVE-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Dere updated HIVE-5683: - Attachment: HIVE-5683.3.patch patch v3 - remove trailing space JDBC support for char - Key: HIVE-5683 URL: https://issues.apache.org/jira/browse/HIVE-5683 Project: Hive Issue Type: Bug Components: JDBC, Types Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-5683.1.patch, HIVE-5683.2.patch, HIVE-5683.3.patch Support char type in JDBC, including char length in result set metadata. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HIVE-5684) Serde support for char
[ https://issues.apache.org/jira/browse/HIVE-5684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Dere updated HIVE-5684: - Attachment: HIVE-5684.2.patch re-upload patch to start pre-commit tests Serde support for char -- Key: HIVE-5684 URL: https://issues.apache.org/jira/browse/HIVE-5684 Project: Hive Issue Type: Bug Components: Serializers/Deserializers, Types Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-5684.1.patch, HIVE-5684.2.patch Update some of the SerDe's with char support -- This message was sent by Atlassian JIRA (v6.1#6144)
Review Request 15387: HIVE-5684 Serde support for char
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15387/ --- Review request for hive, Ashutosh Chauhan and Prasanth_J. Bugs: HIVE-5684 https://issues.apache.org/jira/browse/HIVE-5684 Repository: hive-git Description --- support for char type in orc file, serde tests. Diffs - ql/src/gen/protobuf/gen-java/org/apache/hadoop/hive/ql/io/orc/OrcProto.java 9409b8f ql/src/java/org/apache/hadoop/hive/ql/io/orc/ColumnStatisticsImpl.java e257887 ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcStruct.java a46ef53 ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java e715eb8 ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java 76b7cf3 ql/src/protobuf/org/apache/hadoop/hive/ql/io/orc/orc_proto.proto 2f20793 ql/src/test/queries/clientpositive/char_serde.q PRE-CREATION ql/src/test/results/clientpositive/char_serde.q.out PRE-CREATION serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java 6726973 Diff: https://reviews.apache.org/r/15387/diff/ Testing --- Thanks, Jason Dere
[jira] [Updated] (HIVE-5697) Correlation Optimizer may generate wrong plans for cases involving outer join
[
https://issues.apache.org/jira/browse/HIVE-5697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yin Huai updated HIVE-5697:
---
Attachment: (was: HIVE-5697.2.patch)
Correlation Optimizer may generate wrong plans for cases involving outer join
-
Key: HIVE-5697
URL: https://issues.apache.org/jira/browse/HIVE-5697
Project: Hive
Issue Type: Sub-task
Affects Versions: 0.12.0, 0.13.0
Reporter: Yin Huai
Assignee: Yin Huai
Attachments: HIVE-5697.1.patch, HIVE-5697.2.patch
For example,
{code:sql}
select x.key, y.value, count(*) from src x right outer join src1 y on
(x.key=y.key and x.value=y.value) group by x.key, y.value;
{code}
Correlation optimizer will determine that a single MR job is enough for this
query. However, the group by key are from both left and right tables of the
right outer join.
We will have a wrong result like
{code}
NULL 4
NULL val_165 1
NULL val_193 1
NULL val_265 1
NULL val_27 1
NULL val_409 1
NULL val_484 1
NULL 1
146 val_146 2
150 val_150 1
213 val_213 2
NULL 1
238 val_238 2
255 val_255 2
273 val_273 3
278 val_278 2
311 val_311 3
NULL 1
401 val_401 5
406 val_406 4
66val_66 1
98val_98 2
{code}
Rows with both x.key and y.value are null may not be grouped.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (HIVE-5697) Correlation Optimizer may generate wrong plans for cases involving outer join
[
https://issues.apache.org/jira/browse/HIVE-5697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yin Huai updated HIVE-5697:
---
Attachment: HIVE-5697.2.patch
reuploading patch .2
Correlation Optimizer may generate wrong plans for cases involving outer join
-
Key: HIVE-5697
URL: https://issues.apache.org/jira/browse/HIVE-5697
Project: Hive
Issue Type: Sub-task
Affects Versions: 0.12.0, 0.13.0
Reporter: Yin Huai
Assignee: Yin Huai
Attachments: HIVE-5697.1.patch, HIVE-5697.2.patch
For example,
{code:sql}
select x.key, y.value, count(*) from src x right outer join src1 y on
(x.key=y.key and x.value=y.value) group by x.key, y.value;
{code}
Correlation optimizer will determine that a single MR job is enough for this
query. However, the group by key are from both left and right tables of the
right outer join.
We will have a wrong result like
{code}
NULL 4
NULL val_165 1
NULL val_193 1
NULL val_265 1
NULL val_27 1
NULL val_409 1
NULL val_484 1
NULL 1
146 val_146 2
150 val_150 1
213 val_213 2
NULL 1
238 val_238 2
255 val_255 2
273 val_273 3
278 val_278 2
311 val_311 3
NULL 1
401 val_401 5
406 val_406 4
66val_66 1
98val_98 2
{code}
Rows with both x.key and y.value are null may not be grouped.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (HIVE-3990) Provide input threshold for direct-fetcher (HIVE-2925)
[ https://issues.apache.org/jira/browse/HIVE-3990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-3990: --- Resolution: Fixed Fix Version/s: 0.13.0 Status: Resolved (was: Patch Available) Committed to trunk. Thanks, Navis! Provide input threshold for direct-fetcher (HIVE-2925) -- Key: HIVE-3990 URL: https://issues.apache.org/jira/browse/HIVE-3990 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: Navis Assignee: Navis Priority: Trivial Fix For: 0.13.0 Attachments: D8415.2.patch, D8415.3.patch, HIVE-3990.D8415.1.patch As a followup of HIVE-2925, add input threshold for fetch task conversion. -- This message was sent by Atlassian JIRA (v6.1#6144)
Review Request 15389: Skip useless string encoding stage for hiveserver2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15389/ --- Review request for hive. Bugs: HIVE-5276 https://issues.apache.org/jira/browse/HIVE-5276 Repository: hive-git Description --- Returning rows for HiveServer2 need not to be serialized to a string (which should decoded to Object[] again). Diffs - ql/src/java/org/apache/hadoop/hive/ql/Driver.java c09ffde ql/src/java/org/apache/hadoop/hive/ql/exec/DefaultFetchFormatter.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/FetchFormatter.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 343f760 ql/src/java/org/apache/hadoop/hive/ql/exec/ListSinkOperator.java 0174bcf ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 9fc7afa ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java 128ce77 serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java ea007ee service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java ecbf3cd service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java cfda752 Diff: https://reviews.apache.org/r/15389/diff/ Testing --- Thanks, Navis Ryu
[jira] [Updated] (HIVE-5276) Skip useless string encoding stage for hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Navis updated HIVE-5276: Status: Patch Available (was: Open) Skip useless string encoding stage for hiveserver2 -- Key: HIVE-5276 URL: https://issues.apache.org/jira/browse/HIVE-5276 Project: Hive Issue Type: Improvement Components: HiveServer2 Reporter: Navis Assignee: Navis Priority: Minor Attachments: HIVE-5276.3.patch.txt, HIVE-5276.4.patch.txt, HIVE-5276.5.patch.txt Current hiveserver2 acquires rows in string format which is used for cli output. Then convert them into row again and convert to final format lastly. This is inefficient and memory consuming. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HIVE-5276) Skip useless string encoding stage for hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Navis updated HIVE-5276: Attachment: HIVE-5276.5.patch.txt Skip useless string encoding stage for hiveserver2 -- Key: HIVE-5276 URL: https://issues.apache.org/jira/browse/HIVE-5276 Project: Hive Issue Type: Improvement Components: HiveServer2 Reporter: Navis Assignee: Navis Priority: Minor Attachments: HIVE-5276.3.patch.txt, HIVE-5276.4.patch.txt, HIVE-5276.5.patch.txt Current hiveserver2 acquires rows in string format which is used for cli output. Then convert them into row again and convert to final format lastly. This is inefficient and memory consuming. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5683) JDBC support for char
[ https://issues.apache.org/jira/browse/HIVE-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818357#comment-13818357 ] Xuefu Zhang commented on HIVE-5683: --- +1 JDBC support for char - Key: HIVE-5683 URL: https://issues.apache.org/jira/browse/HIVE-5683 Project: Hive Issue Type: Bug Components: JDBC, Types Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-5683.1.patch, HIVE-5683.2.patch, HIVE-5683.3.patch Support char type in JDBC, including char length in result set metadata. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HIVE-5286) Negative test date_literal1.q fails on java7 because the syntax is valid
[
https://issues.apache.org/jira/browse/HIVE-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xuefu Zhang updated HIVE-5286:
--
Resolution: Fixed
Fix Version/s: 0.13.0
Status: Resolved (was: Patch Available)
Negative test date_literal1.q fails on java7 because the syntax is valid
Key: HIVE-5286
URL: https://issues.apache.org/jira/browse/HIVE-5286
Project: Hive
Issue Type: Bug
Affects Versions: 0.12.0
Reporter: Brock Noland
Assignee: Szehon Ho
Fix For: 0.13.0
Attachments: HIVE-5286.patch
{noformat}
[brock@bigboy java-date]$ cat Test.java
import java.sql.Date;
public class Test {
public static void main(String[] args) throws Exception {
System.out.println(Date.valueOf(2001-1-1));
}
}
[brock@bigboy java-date]$ exec-via-java6 java -cp . Test
Exception in thread main java.lang.IllegalArgumentException
at java.sql.Date.valueOf(Date.java:138)
at Test.main(Test.java:4)
[brock@bigboy java-date]$ exec-via-java7 java -cp . Test
2001-01-01
{noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HIVE-5286) Negative test date_literal1.q fails on java7 because the syntax is valid
[
https://issues.apache.org/jira/browse/HIVE-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818358#comment-13818358
]
Xuefu Zhang commented on HIVE-5286:
---
Patch committed to trunk. Thanks to Szehon for the contribution.
Negative test date_literal1.q fails on java7 because the syntax is valid
Key: HIVE-5286
URL: https://issues.apache.org/jira/browse/HIVE-5286
Project: Hive
Issue Type: Bug
Affects Versions: 0.12.0
Reporter: Brock Noland
Assignee: Szehon Ho
Fix For: 0.13.0
Attachments: HIVE-5286.patch
{noformat}
[brock@bigboy java-date]$ cat Test.java
import java.sql.Date;
public class Test {
public static void main(String[] args) throws Exception {
System.out.println(Date.valueOf(2001-1-1));
}
}
[brock@bigboy java-date]$ exec-via-java6 java -cp . Test
Exception in thread main java.lang.IllegalArgumentException
at java.sql.Date.valueOf(Date.java:138)
at Test.main(Test.java:4)
[brock@bigboy java-date]$ exec-via-java7 java -cp . Test
2001-01-01
{noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HIVE-5722) Skip generating vectorization code if possible
[
https://issues.apache.org/jira/browse/HIVE-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818384#comment-13818384
]
Hive QA commented on HIVE-5722:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12613024/HIVE-5722.3.patch.txt
{color:green}SUCCESS:{color} +1 4600 tests passed
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/232/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/232/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12613024
Skip generating vectorization code if possible
--
Key: HIVE-5722
URL: https://issues.apache.org/jira/browse/HIVE-5722
Project: Hive
Issue Type: Improvement
Components: Build Infrastructure
Reporter: Navis
Assignee: Navis
Priority: Minor
Attachments: D13941.1.patch, HIVE-5722.1.patch.txt,
HIVE-5722.3.patch.txt
Currently, ql module always generates new vectorization code, which might not
be changed so frequently.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HIVE-3990) Provide input threshold for direct-fetcher (HIVE-2925)
[ https://issues.apache.org/jira/browse/HIVE-3990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818388#comment-13818388 ] Lefty Leverenz commented on HIVE-3990: -- * hive.fetch.task.conversion.threshold needs to be documented in the wiki: [Configuration Properties|https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties]. * hive.fetch.task.aggr also needs to be documented. It isn't in hive-default.xml.template or the wiki, but it's in HiveConf.java. Apparently it was added in Hive 0.12.0 (HIVE-4002, Fetch task aggregation for simple group by query). I can add these two parameters to the wiki if someone agrees to review them. But adding hive.fetch.task.aggr to hive-default.xml.template requires a new JIRA, unless it gets piggybacked onto HIVE-5498 (open, unassigned: Merge metadata only optimizer into simple fetch optimizer). Provide input threshold for direct-fetcher (HIVE-2925) -- Key: HIVE-3990 URL: https://issues.apache.org/jira/browse/HIVE-3990 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: Navis Assignee: Navis Priority: Trivial Fix For: 0.13.0 Attachments: D8415.2.patch, D8415.3.patch, HIVE-3990.D8415.1.patch As a followup of HIVE-2925, add input threshold for fetch task conversion. -- This message was sent by Atlassian JIRA (v6.1#6144)
