[jira] [Created] (HIVE-13156) Allow specifying the name of the queue in which llap will run

2016-02-24 Thread Siddharth Seth (JIRA)
Siddharth Seth created HIVE-13156:
-

 Summary: Allow specifying the name of the queue in which llap will 
run
 Key: HIVE-13156
 URL: https://issues.apache.org/jira/browse/HIVE-13156
 Project: Hive
  Issue Type: Improvement
Reporter: Siddharth Seth


llap service driver should accept a parameter for the llap queue name.
cc [~gopalv]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-13155) LLAP: JMX Metrics is not always published in the JSON interface

2016-02-24 Thread Gopal V (JIRA)
Gopal V created HIVE-13155:
--

 Summary: LLAP: JMX Metrics is not always published in the JSON 
interface
 Key: HIVE-13155
 URL: https://issues.apache.org/jira/browse/HIVE-13155
 Project: Hive
  Issue Type: Bug
  Components: llap
Affects Versions: 2.1.0
Reporter: Gopal V
Assignee: Gopal V
Priority: Minor


Occasionally, the JMX metrics for LlapDaemonExecutorMetrics returns without the 
Queue information.

{code}
{
"name" : "Hadoop:service=LlapDaemon,name=LlapDaemonExecutorMetrics-cn107",
"modelerType" : "LlapDaemonExecutorMetrics-cn107",
"tag.Context" : "llap",
"tag.ProcessName" : "LlapDaemon",
"tag.SessionId" : "44f4e76a-5ad6-4c17-9ed9-5dcec9bf9a64",
"tag.Hostname" : "cn107-10.l42scl.hortonworks.com"
  },
{code}

And is missing usual information like

{code}
"ExecutorTotalRequestsHandled" : 514083,
"ExecutorNumQueuedRequests" : 189467,
"ExecutorTotalSuccess" : 323011,
"ExecutorTotalExecutionFailure" : 16,
"ExecutorTotalInterrupted" : 1483,
"PreemptionTimeLost" : 1208279
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-13154) sum two or more clumns by sum function

2016-02-24 Thread lu ping (JIRA)
lu ping created HIVE-13154:
--

 Summary: sum two or more clumns by sum function
 Key: HIVE-13154
 URL: https://issues.apache.org/jira/browse/HIVE-13154
 Project: Hive
  Issue Type: Improvement
Affects Versions: 1.2.1
Reporter: lu ping


 I use sum function to get the sum of two  or more columns, but i found the res 
us wrong. And then i found out that sum function could only get one column sum. 
I think that if sum function could not compute sum of multiple columns, should 
give some warning or error? Or else, make sum could summing the values from two 
or more  columns into one number



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-13153) SessionID is appended to thread name twice

2016-02-24 Thread Prasanth Jayachandran (JIRA)
Prasanth Jayachandran created HIVE-13153:


 Summary: SessionID is appended to thread name twice
 Key: HIVE-13153
 URL: https://issues.apache.org/jira/browse/HIVE-13153
 Project: Hive
  Issue Type: Bug
Affects Versions: 2.1.0
Reporter: Prasanth Jayachandran
Assignee: Prasanth Jayachandran


HIVE-12249 added sessionId to thread name. In some cases the sessionId could be 
appended twice. Example log line
{code}
DEBUG [6432ec22-9f66-4fa5-8770-488a9d3f0b61 
6432ec22-9f66-4fa5-8770-488a9d3f0b61 main]
{code} 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 43706: HIVE-13063 Create UDFs for CHAR and REPLACE

2016-02-24 Thread Jason Dere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43706/#review120646
---




ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java (line 230)


Using "char" as the function name may conflict with the use of "char" as a 
type name .. can you make this "chr"/UDFChr instead?



ql/src/java/org/apache/hadoop/hive/ql/udf/UDFChar.java (line 51)


I believe you can replace all of the numeric Writable versions of 
evaluate() to possibly 2 versions: LongWritable and DoubleWritable.

For the old-style UDFs, Hive is able to convert a parameter of short type 
to a long, and so on.



ql/src/java/org/apache/hadoop/hive/ql/udf/UDFChar.java (line 82)


Can you confirm if that is the right behavior here, to return null for 
value 0?


Can you also add qfile tests for TestCliDriver?

- Jason Dere


On Feb. 18, 2016, 3:37 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43706/
> ---
> 
> (Updated Feb. 18, 2016, 3:37 a.m.)
> 
> 
> Review request for hive, Jason Dere and Vikram Dixit Kumaraswamy.
> 
> 
> Bugs: HIVE-13063
> https://issues.apache.org/jira/browse/HIVE-13063
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Create UDFS for these functions.
> 
> CHAR: convert n where n : [0, 256) into the ascii equivalent as a varchar. If 
> n is less than 0 or greater than 255, return the empty string. If n is 0, 
> return null.
> 
> REPLACE: replace all substrings of 'str' that match 'search' with 'rep'.
> Example. SELECT REPLACE('Hack and Hue', 'H', 'BL');
> Equals 'BLack and BLue'"
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e0e030f 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFChar.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFReplace.java PRE-CREATION 
>   ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFChar.java 
> PRE-CREATION 
>   
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFReplace.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43706/diff/
> 
> 
> Testing
> ---
> 
> Verified that UDFs work.
> 
> ADD JAR hdfs://c6401.ambari.apache.org:8020/tmp/hive-exec.jar;
> CREATE TEMPORARY FUNCTION char_udf AS 'org.apache.hadoop.hive.ql.udf.UDFChar';
> CREATE TEMPORARY FUNCTION replace_udf AS 
> 'org.apache.hadoop.hive.ql.udf.UDFReplace';
> 
> SHOW FUNCTIONS;
> 
> DESCRIBE FUNCTION char_udf;
> DESCRIBE FUNCTION replace_udf;
> 
> select char_udf(-1), 
> char_udf(0), 
> char_udf(1), 
> char_udf(48), 
> char_udf(65), 
> char_udf(68.12), 
> char_udf(32457964);
> 
> select replace_udf('', '', ''), 
> replace_udf(null, '', ''), 
> replace_udf('', null, ''), 
> replace_udf('', '', null), 
> replace_udf('Hack and Hue', 'H', 'BL'), 
> replace_udf('ABABrdvABrk', 'AB', 'a');
> 
> 
> File Attachments
> 
> 
> Query1
>   
> https://reviews.apache.org/media/uploaded/files/2016/02/18/6f9c8b55-3e75-448f-bd71-93d6c3c900b8__Screen_Shot_2016-02-17_at_7.21.07_PM.png
> Query2
>   
> https://reviews.apache.org/media/uploaded/files/2016/02/18/cedeeec0-388b-433b-a4f6-94888054d1a9__Screen_Shot_2016-02-17_at_7.20.57_PM.png
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>



[jira] [Created] (HIVE-13152) JDBC split refactoring and handle some edge cases

2016-02-24 Thread Vikram Dixit K (JIRA)
Vikram Dixit K created HIVE-13152:
-

 Summary: JDBC split refactoring and handle some edge cases
 Key: HIVE-13152
 URL: https://issues.apache.org/jira/browse/HIVE-13152
 Project: Hive
  Issue Type: Sub-task
  Components: JDBC
Affects Versions: llap
Reporter: Vikram Dixit K
Assignee: Vikram Dixit K
 Fix For: llap


wrap jdbc split

allow zero split returns in llapdump

allow setting of llap output format as file format option

create job conf via dag utils

JDCB LlapInputSplit should not be an inner class

Hack: Spark uses hive-1.2.1, which does not have 
HiveConf.ConfVars.LLAP_DAEMON_RPC_PORT, use "hive.llap.daemon.rpc.port"

- Use Class.getName() rather than Class.toString() for class name
- Add LlapInputSplit Writable test

Fix for filesink operator close NPE.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-13151) Clean up UGI objects in FileSystem cache for transactions

2016-02-24 Thread Wei Zheng (JIRA)
Wei Zheng created HIVE-13151:


 Summary: Clean up UGI objects in FileSystem cache for transactions
 Key: HIVE-13151
 URL: https://issues.apache.org/jira/browse/HIVE-13151
 Project: Hive
  Issue Type: Bug
  Components: Hive
Affects Versions: 2.0.0
Reporter: Wei Zheng
Assignee: Wei Zheng


One issue with FileSystem.CACHE is that it does not clean itself. The key in 
that cache includes UGI object. When new UGI objects are created and used with 
the FileSystem api, new entries get added to the cache.

We need to manually clean up those UGI objects once they are no longer in use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-13150) HMS connection leak when the query is run in async.

2016-02-24 Thread Aihua Xu (JIRA)
Aihua Xu created HIVE-13150:
---

 Summary: HMS connection leak when the query is run in async.
 Key: HIVE-13150
 URL: https://issues.apache.org/jira/browse/HIVE-13150
 Project: Hive
  Issue Type: Sub-task
  Components: HiveServer2
Affects Versions: 2.0.0
Reporter: Aihua Xu
Assignee: Aihua Xu


HMS connection leak has been addressed for the session thread, task threads if 
the execution is run in parallel. 

While if we execute the queries in async, we will run the queries in separate 
threads and the HMS connections there are not released. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-02-24 Thread Aihua Xu (JIRA)
Aihua Xu created HIVE-13149:
---

 Summary: Remove some unnecessary HMS connections from HS2 
 Key: HIVE-13149
 URL: https://issues.apache.org/jira/browse/HIVE-13149
 Project: Hive
  Issue Type: Sub-task
  Components: HiveServer2
Affects Versions: 2.0.0
Reporter: Aihua Xu
Assignee: Aihua Xu


In SessionState class, currently we will always try to get a HMS connection in 
{{start(SessionState startSs, boolean isAsync, LogHelper console)}} regardless 
of if the connection will be used later or not. 

When SessionState is accessed by the tasks in TaskRunner.java, although most of 
the tasks other than some of them like StatsTask, don't need to access HMS, 
currently a new HMS connection will be established for each thread. If 
HiveServer2 is configured to run in parallel and the query involves many tasks, 
then the connections are created but unused.

{noformat}
  @Override
  public void run() {
runner = Thread.currentThread();
try {
  OperationLog.setCurrentOperationLog(operationLog);
  SessionState.start(ss);
  runSequential();
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-13148) Address some HMS connection issues in HS2

2016-02-24 Thread Aihua Xu (JIRA)
Aihua Xu created HIVE-13148:
---

 Summary: Address some HMS connection issues in HS2
 Key: HIVE-13148
 URL: https://issues.apache.org/jira/browse/HIVE-13148
 Project: Hive
  Issue Type: Bug
  Components: HiveServer2
Affects Versions: 2.0.0
Reporter: Aihua Xu
Assignee: Vaibhav Gumashta


Notice some HMS connection leaking and unnecessary connections. Use this jira 
to address them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-13147) COLUMN_STATS_ACCURATE is not accurate

2016-02-24 Thread Romain Rigaux (JIRA)
Romain Rigaux created HIVE-13147:


 Summary: COLUMN_STATS_ACCURATE is not accurate
 Key: HIVE-13147
 URL: https://issues.apache.org/jira/browse/HIVE-13147
 Project: Hive
  Issue Type: Bug
Affects Versions: 1.2.0
Reporter: Romain Rigaux


Often we see on a described table:
{code}
Table Parameters:   NULLNULL
18  COLUMN_STATS_ACCURATE   true
19  numFiles1   
20  numRows 0   
21  rawDataSize 0   
22  totalSize   46069   
23  transient_lastDdlTime   1448930216  
{code}

Notice
{code}
20  numRows 0   
21  rawDataSize 0   
{code}
are wrong.

After doing an analyze we get:
{code}
Table Parameters:   NULLNULL
18  COLUMN_STATS_ACCURATE   true
19  numFiles1   
20  numRows 823 
21  rawDataSize 45246   
22  totalSize   46069   
23  transient_lastDdlTime   1456338426 
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 43885: HIVE-13102

2016-02-24 Thread Jesús Camacho Rodríguez


> On Feb. 23, 2016, 7:17 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexUtil.java, 
> > line 199
> > 
> >
> > Can you add a comment about why we are treating inverted and negated 
> > terms in same manner. My assumption was we can fold to false only in 
> > presence of negated terms, not inverted terms.

Assume we have the expression a > 5.
Then we can derive the negated term: NOT(a <= 5).
But as the comparison is string based and thus operands order dependent, we 
should also add the inverted negated term: NOT(5 >= a). Observe that for 
creating the inverted term we invert the list of operands.

I will add a comment about this to the code to make it clear.


> On Feb. 23, 2016, 7:17 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/ppd_udf_col.q.out, line 117
> > 
> >
> > Seems like we missed opportunity to fold constant here.

This is correct. In fact, we were inferring the constant on the Hive side 
because we were not folding the expression in CBO. In the following you can see 
the plans:

CBO plan before patch:
 HiveProject(key=[$0], randum123=[rand()], 
h4=[CAST(_UTF-16LE'4'):VARCHAR(2147483647) CHARACTER SET "ISO-8859-1" COLLATE 
"ISO-8859-1$en_US$primary"])
  HiveFilter(condition=[AND(=(CAST($0):DOUBLE, CAST(100):DOUBLE), 
<=(CAST(CAST(_UTF-16LE'4'):VARCHAR(2147483647) CHARACTER SET "ISO-8859-1" 
COLLATE "ISO-8859-1$en_US$primary"):DOUBLE, CAST(3):DOUBLE))])
HiveTableScan(table=[[default.src]])

CBO plan after patch:
 HiveProject(key=[$0], randum123=[rand()], 
h4=[CAST(_UTF-16LE'4'):VARCHAR(2147483647) CHARACTER SET "ISO-8859-1" COLLATE 
"ISO-8859-1$en_US$primary"])
  HiveFilter(condition=[false])
HiveTableScan(table=[[default.src]])

The reason was the code in line 150 in HiveReduceExpressionsRule: it was 
quiting the method even if a reduction (e.g. into the literal false) was 
possible. Currently we infer that the predicate is false, thus we do not need 
to propagate any constant anymore.


- Jesús


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43885/#review120363
---


On Feb. 23, 2016, 5:27 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43885/
> ---
> 
> (Updated Feb. 23, 2016, 5:27 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-13102
> https://issues.apache.org/jira/browse/HIVE-13102
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-13102
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 
> 58a7cff97cf8120b7afdb52af6a8f6cd07b408ea 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexUtil.java 
> 3f6dd6a3738bdcb3c4756136965c54ea6f943f53 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinPushTransitivePredicatesRule.java
>  994af976f12f8b59c2379f23a33cf8fc94a2efc5 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
>  8f15ec7e5f075ceee1ca71b9a389837b9a31167e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdPredicates.java
>  36d0b458d4c33707f8e3a5b823e35edf8c5d09d1 
>   ql/src/test/queries/clientpositive/constprog3.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/infer_join_preds.q PRE-CREATION 
>   ql/src/test/results/clientpositive/constprog3.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/fold_case.q.out 
> 90ea0afa49673910be4b28ce5f96e942b42936b0 
>   ql/src/test/results/clientpositive/infer_join_preds.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/mergejoin.q.out 
> f2c04e2221c1e7164ffb7cfe49f2fe3e0536e321 
>   ql/src/test/results/clientpositive/partition_boolexpr.q.out 
> 5272f33621a45616895f81684e4f620f6b0ec765 
>   ql/src/test/results/clientpositive/ppd_udf_col.q.out 
> 2641f5c89a1a8839e8c3e5bfa5f4b6d756ec47fb 
>   ql/src/test/results/clientpositive/tez/mergejoin.q.out 
> 14d04317d17684877566ae4aad29a862255ba02c 
> 
> Diff: https://reviews.apache.org/r/43885/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>



Re: Review Request 43145: HIVE-12994

2016-02-24 Thread Jesús Camacho Rodríguez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43145/
---

(Updated Feb. 24, 2016, 5:11 p.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-12994
https://issues.apache.org/jira/browse/HIVE-12994


Repository: hive-git


Description
---

Implement support for NULLS FIRST/NULLS LAST


Diffs (updated)
-

  data/files/over4_null PRE-CREATION 
  itests/src/test/resources/testconfiguration.properties 
58d0a45fde7fbfb8f20518fd549dfc64a3b89b64 
  metastore/if/hive_metastore.thrift e8f0a68fd640fddf6f711e1063bf97195a42f83d 
  metastore/scripts/upgrade/derby/034-HIVE-12994.derby.sql PRE-CREATION 
  metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 
42f4eb643d0073a80f4ba505e788abb19f31fb4c 
  metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql 
a0bac3ced7024afff964b298da52c1aa4f77bb2e 
  metastore/scripts/upgrade/mssql/019-HIVE-12994.mssql.sql PRE-CREATION 
  metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql 
cf5a6620610461eed9aa1b35cc282ced3c2e877f 
  metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql 
f25daf26bea2d6c8abb8f40803f2e99307813462 
  metastore/scripts/upgrade/mysql/034-HIVE-12994.mysql.sql PRE-CREATION 
  metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 
6fd32095af797c0a0925ab6b9ebce528bc42cb3e 
  metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql 
e7906368efb490f7c8951a1b8e6a4ec45890d475 
  metastore/scripts/upgrade/oracle/034-HIVE-12994.oracle.sql PRE-CREATION 
  metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 
774f6bea712ed2a1def8ab502a3f957c31c87d6d 
  metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 
8368d088c9332d43b62aa0f29802e81e896635ec 
  metastore/scripts/upgrade/postgres/033-HIVE-12994.postgres.sql PRE-CREATION 
  metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 
7463a373384bb1b3ff0944566971f65c9faf144d 
  metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 
6172407b18c235a39fc7b85720b3aa04455e9cf6 
  
metastore/src/gen/protobuf/gen-java/org/apache/hadoop/hive/metastore/Metastore.java
 416ae9d68d99110a2d9c2524e4156a43aac18ea6 
  
metastore/src/gen/protobuf/gen-java/org/apache/hadoop/hive/metastore/hbase/HbaseMetastoreProto.java
 3b2d7b5db638dc6b35f968279d6b5129977e6f1d 
  metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 
97c07a568a1b8451fa9843552eebdc828d122aaf 
  metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 
2695ffa17c5d3fccf8d1e99b7d78846f7b8a8f20 
  
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Order.java
 cc0e2dd027d2e909ea4a39a742b33218c3f8411f 
  metastore/src/gen/thrift/gen-php/metastore/Types.php 
488a920e2fe1c6d9f9d966ec98f16d82c12b74d5 
  metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 
10eaf4a01f1ee8130b0f67340635ed462a24ab77 
  metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 
1cf40ae568bc2749ee1775d165da6685351694e3 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 
6da295e246e2259647e32d8ba33c783b28d41550 
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
d4852b025503eb0087555fa3ca9a72cbafa6a22e 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseUtils.java 
d6d01bdbb879397d1b28675f5dfaa345d9b1066f 
  metastore/src/model/org/apache/hadoop/hive/metastore/model/MOrder.java 
1fa82a4fde9d315d4955ee5698796f58ce8a0921 
  
metastore/src/protobuf/org/apache/hadoop/hive/metastore/hbase/hbase_metastore_proto.proto
 466fdf9dc0b0e9d1c58c9b44977896780963e2ac 
  metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStore.java 
29d5a64154fdb9ab9586fb919fbeae7106b1a874 
  
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreBitVector.java
 b0d76620b94b25c66b8e0857100e6a8c8343 
  
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestSharedStorageDescriptor.java
 e0d8ce4dede474ad1b752794379342993bf89fa4 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 
6fca9f7ec86574a6053af3672c551c6a63aa4870 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java 
91b5ca769f88b04c379f38bad3518d36958f1c71 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 
27e7b43ca92cf081e34415002c2b2f6ecc7a18d9 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/HybridHashTableContainer.java
 fdc1dfffd977ef3a71fcf56da19a3b2b91538921 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinBytesTableContainer.java
 5c2ff9276b575f93a3df0fd2da378b85f7074a22 
  ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinKey.java 
cfb9abc380880da2cefe6968fd81dc3b974ec1ed 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicPartitionPruner.java 
1510fdd555223514786dfd9137103c1339c4fc2a 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java
 

Re: Review Request 43145: HIVE-12994

2016-02-24 Thread Jesús Camacho Rodríguez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43145/
---

(Updated Feb. 24, 2016, 4:30 p.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-12994
https://issues.apache.org/jira/browse/HIVE-12994


Repository: hive-git


Description
---

Implement support for NULLS FIRST/NULLS LAST


Diffs (updated)
-

  data/files/over4_null PRE-CREATION 
  itests/src/test/resources/testconfiguration.properties 
58d0a45fde7fbfb8f20518fd549dfc64a3b89b64 
  metastore/if/hive_metastore.thrift e8f0a68fd640fddf6f711e1063bf97195a42f83d 
  metastore/scripts/upgrade/derby/034-HIVE-12994.derby.sql PRE-CREATION 
  metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 
42f4eb643d0073a80f4ba505e788abb19f31fb4c 
  metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql 
a0bac3ced7024afff964b298da52c1aa4f77bb2e 
  metastore/scripts/upgrade/mssql/019-HIVE-12994.mssql.sql PRE-CREATION 
  metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql 
cf5a6620610461eed9aa1b35cc282ced3c2e877f 
  metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql 
f25daf26bea2d6c8abb8f40803f2e99307813462 
  metastore/scripts/upgrade/mysql/034-HIVE-12994.mysql.sql PRE-CREATION 
  metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 
6fd32095af797c0a0925ab6b9ebce528bc42cb3e 
  metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql 
e7906368efb490f7c8951a1b8e6a4ec45890d475 
  metastore/scripts/upgrade/oracle/034-HIVE-12994.oracle.sql PRE-CREATION 
  metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 
774f6bea712ed2a1def8ab502a3f957c31c87d6d 
  metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 
8368d088c9332d43b62aa0f29802e81e896635ec 
  metastore/scripts/upgrade/postgres/033-HIVE-12994.postgres.sql PRE-CREATION 
  metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 
7463a373384bb1b3ff0944566971f65c9faf144d 
  metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 
6172407b18c235a39fc7b85720b3aa04455e9cf6 
  
metastore/src/gen/protobuf/gen-java/org/apache/hadoop/hive/metastore/Metastore.java
 416ae9d68d99110a2d9c2524e4156a43aac18ea6 
  
metastore/src/gen/protobuf/gen-java/org/apache/hadoop/hive/metastore/hbase/HbaseMetastoreProto.java
 3b2d7b5db638dc6b35f968279d6b5129977e6f1d 
  metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 
97c07a568a1b8451fa9843552eebdc828d122aaf 
  metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 
2695ffa17c5d3fccf8d1e99b7d78846f7b8a8f20 
  
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Order.java
 cc0e2dd027d2e909ea4a39a742b33218c3f8411f 
  metastore/src/gen/thrift/gen-php/metastore/Types.php 
488a920e2fe1c6d9f9d966ec98f16d82c12b74d5 
  metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 
10eaf4a01f1ee8130b0f67340635ed462a24ab77 
  metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 
1cf40ae568bc2749ee1775d165da6685351694e3 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 
6da295e246e2259647e32d8ba33c783b28d41550 
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
d4852b025503eb0087555fa3ca9a72cbafa6a22e 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseUtils.java 
d6d01bdbb879397d1b28675f5dfaa345d9b1066f 
  metastore/src/model/org/apache/hadoop/hive/metastore/model/MOrder.java 
1fa82a4fde9d315d4955ee5698796f58ce8a0921 
  
metastore/src/protobuf/org/apache/hadoop/hive/metastore/hbase/hbase_metastore_proto.proto
 466fdf9dc0b0e9d1c58c9b44977896780963e2ac 
  metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStore.java 
29d5a64154fdb9ab9586fb919fbeae7106b1a874 
  
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreBitVector.java
 b0d76620b94b25c66b8e0857100e6a8c8343 
  
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestSharedStorageDescriptor.java
 e0d8ce4dede474ad1b752794379342993bf89fa4 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 
6fca9f7ec86574a6053af3672c551c6a63aa4870 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java 
91b5ca769f88b04c379f38bad3518d36958f1c71 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 
27e7b43ca92cf081e34415002c2b2f6ecc7a18d9 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/HybridHashTableContainer.java
 fdc1dfffd977ef3a71fcf56da19a3b2b91538921 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinBytesTableContainer.java
 5c2ff9276b575f93a3df0fd2da378b85f7074a22 
  ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinKey.java 
cfb9abc380880da2cefe6968fd81dc3b974ec1ed 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicPartitionPruner.java 
1510fdd555223514786dfd9137103c1339c4fc2a 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java
 

[jira] [Created] (HIVE-13146) OrcFile table property values are case sensitive

2016-02-24 Thread Andrew Sears (JIRA)
Andrew Sears created HIVE-13146:
---

 Summary: OrcFile table property values are case sensitive
 Key: HIVE-13146
 URL: https://issues.apache.org/jira/browse/HIVE-13146
 Project: Hive
  Issue Type: Bug
  Components: ORC
Affects Versions: 1.2.1
Reporter: Andrew Sears
Priority: Minor


In Hive v1.2.1.2.3, with Tez , create an external table with compression SNAPPY 
value marked as lower case.  Table is created successfully.  Insert data into 
table fails with no enum constant error.

CREATE EXTERNAL TABLE mydb.mytable 
(id int)
  PARTITIONED BY (business_date date)
STORED AS ORC
LOCATION
  '/data/mydb/mytable'
TBLPROPERTIES (
  'orc.compress'='snappy');

set hive.exec.dynamic.partition=true;
set hive.exec.dynamic.partition.mode=nonstrict;

INSERT OVERWRITE mydb.mytable PARTITION (business_date)
SELECT * from mydb.sourcetable;

Caused by: java.lang.IllegalArgumentException: No enum constant 
org.apache.hadoop.hive.ql.io.orc.CompressionKind.snappy
at java.lang.Enum.valueOf(Enum.java:238)
at 
org.apache.hadoop.hive.ql.io.orc.CompressionKind.valueOf(CompressionKind.java:25)

Constant SNAPPY needs to be uppercase in definition to fix.  Case should be 
agnostic or throw error on creation of table.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-13145) Separate the output path of metrics file of HS2 and HMS

2016-02-24 Thread Shinichi Yamashita (JIRA)
Shinichi Yamashita created HIVE-13145:
-

 Summary: Separate the output path of metrics file of HS2 and HMS
 Key: HIVE-13145
 URL: https://issues.apache.org/jira/browse/HIVE-13145
 Project: Hive
  Issue Type: Improvement
  Components: HiveServer2, Metastore
Reporter: Shinichi Yamashita
Assignee: Shinichi Yamashita


The output path of  metrics file of HS2 and HMS can define by 
{{hive.service.metrics.file.location}} property at present.
When it starts HS2 and HMS by the same server, both metrics is written in the 
same file. And when confirming this file, it is difficult to judge which 
metrics it is.

Therefore the output path of metrics file of HS2 and HMS is separated.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-13144) HS2 can leak ZK ACL objects when curator retries to create the persistent ephemeral node

2016-02-24 Thread Vaibhav Gumashta (JIRA)
Vaibhav Gumashta created HIVE-13144:
---

 Summary: HS2 can leak ZK ACL objects when curator retries to 
create the persistent ephemeral node
 Key: HIVE-13144
 URL: https://issues.apache.org/jira/browse/HIVE-13144
 Project: Hive
  Issue Type: Bug
Reporter: Vaibhav Gumashta
Assignee: Vaibhav Gumashta


When the node gets deleted from ZK due to connection loss and curator tries to 
recreate the node, it might leak ZK ACL.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-13143) LLAP: Queue counters need to handle SubmissionState.EVICTED_OTHER

2016-02-24 Thread Gopal V (JIRA)
Gopal V created HIVE-13143:
--

 Summary: LLAP: Queue counters need to handle 
SubmissionState.EVICTED_OTHER
 Key: HIVE-13143
 URL: https://issues.apache.org/jira/browse/HIVE-13143
 Project: Hive
  Issue Type: Bug
  Components: llap
Affects Versions: 2.1.0
Reporter: Gopal V


{code}
if (submissionState.equals(Scheduler.SubmissionState.REJECTED)) {
...
}
metrics.incrExecutorTotalRequestsHandled();
metrics.incrExecutorNumQueuedRequests();
{code}

Means when a task evicts another task, the metrics aren't updated to indicate 
eviction from the wait queue - the queue counters keeps climbing without going 
down.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 43408: HIVE-13034 : Add jdeb plugin to build debian

2016-02-24 Thread Arshad Matin


> On Feb. 24, 2016, 9:36 a.m., Amareshwari Sriramadasu wrote:
> > Can you update testing done?

done


- Arshad


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43408/#review120482
---


On Feb. 24, 2016, 10:24 a.m., Arshad Matin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43408/
> ---
> 
> (Updated Feb. 24, 2016, 10:24 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-13034
> https://issues.apache.org/jira/browse/HIVE-13034
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-13034 : Add jdeb plugin to build debian
> 
> 
> Diffs
> -
> 
>   packaging/pom.xml e7feb62 
>   packaging/src/deb/control/control PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43408/diff/
> 
> 
> Testing
> ---
> 
> arshad.matin$ mvn clean install -DskipTests -Pdist,deb
> [INFO] Hive ... SUCCESS [  9.819 
> s]
> [INFO] Hive Shims Common .. SUCCESS [ 12.134 
> s]
> [INFO] Hive Shims 0.23  SUCCESS [  7.379 
> s]
> [INFO] Hive Shims Scheduler ... SUCCESS [  2.241 
> s]
> [INFO] Hive Shims . SUCCESS [  1.620 
> s]
> [INFO] Hive Storage API ... SUCCESS [  2.654 
> s]
> [INFO] Hive ORC ... SUCCESS [  5.873 
> s]
> [INFO] Hive Common  SUCCESS [ 19.173 
> s]
> [INFO] Hive Serde . SUCCESS [  9.903 
> s]
> [INFO] Hive Metastore . SUCCESS [ 44.618 
> s]
> [INFO] Hive Ant Utilities . SUCCESS [  0.983 
> s]
> [INFO] Hive Llap Common ... SUCCESS [  4.128 
> s]
> [INFO] Hive Llap Client ... SUCCESS [  2.377 
> s]
> [INFO] Hive Llap Tez .. SUCCESS [  3.217 
> s]
> [INFO] Hive Service RPC ... SUCCESS [  5.472 
> s]
> [INFO] Spark Remote Client  SUCCESS [ 20.618 
> s]
> [INFO] Hive Query Language  SUCCESS [02:34 
> min]
> [INFO] Hive Service ... SUCCESS [ 39.862 
> s]
> [INFO] Hive Accumulo Handler .. SUCCESS [ 23.901 
> s]
> [INFO] Hive JDBC .. SUCCESS [04:33 
> min]
> [INFO] Hive Beeline ... SUCCESS [ 16.428 
> s]
> [INFO] Hive CLI ... SUCCESS [  6.161 
> s]
> [INFO] Hive Contrib ... SUCCESS [  5.277 
> s]
> [INFO] Hive HBase Handler . SUCCESS [  8.963 
> s]
> [INFO] Hive HCatalog .. SUCCESS [  1.383 
> s]
> [INFO] Hive HCatalog Core . SUCCESS [  5.323 
> s]
> [INFO] Hive HCatalog Pig Adapter .. SUCCESS [  3.491 
> s]
> [INFO] Hive HCatalog Server Extensions  SUCCESS [  3.544 
> s]
> [INFO] Hive HCatalog Webhcat Java Client .. SUCCESS [  2.992 
> s]
> [INFO] Hive HCatalog Webhcat .. SUCCESS [ 14.926 
> s]
> [INFO] Hive HCatalog Streaming  SUCCESS [ 10.478 
> s]
> [INFO] Hive HPL/SQL ... SUCCESS [  8.266 
> s]
> [INFO] Hive HWI ... SUCCESS [  2.919 
> s]
> [INFO] Hive ODBC .. SUCCESS [  2.420 
> s]
> [INFO] Hive Llap Server ... SUCCESS [  5.595 
> s]
> [INFO] Hive Shims Aggregator .. SUCCESS [  0.192 
> s]
> [INFO] Hive TestUtils . SUCCESS [  0.496 
> s]
> [INFO] Hive Packaging . SUCCESS [02:54 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 15:18 min
> [INFO] Finished at: 2016-02-24T13:27:54+05:30
> [INFO] Final Memory: 266M/1666M
> [INFO] 
> 
> arshad.matin$ find . -name "*deb"
> ./hcatalog/src/packages/deb
> ./packaging/src/deb
> ./packaging/target/hive_2.1.0-SNAPSHOT.deb
> 
> 
> arshad.matin$ mvn clean install -DskipTests -Pdist
> [INFO] Hive 

Re: Review Request 43408: HIVE-13034 : Add jdeb plugin to build debian

2016-02-24 Thread Arshad Matin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43408/
---

(Updated Feb. 24, 2016, 10:24 a.m.)


Review request for hive.


Bugs: HIVE-13034
https://issues.apache.org/jira/browse/HIVE-13034


Repository: hive-git


Description
---

HIVE-13034 : Add jdeb plugin to build debian


Diffs
-

  packaging/pom.xml e7feb62 
  packaging/src/deb/control/control PRE-CREATION 

Diff: https://reviews.apache.org/r/43408/diff/


Testing (updated)
---

arshad.matin$ mvn clean install -DskipTests -Pdist,deb
[INFO] Hive ... SUCCESS [  9.819 s]
[INFO] Hive Shims Common .. SUCCESS [ 12.134 s]
[INFO] Hive Shims 0.23  SUCCESS [  7.379 s]
[INFO] Hive Shims Scheduler ... SUCCESS [  2.241 s]
[INFO] Hive Shims . SUCCESS [  1.620 s]
[INFO] Hive Storage API ... SUCCESS [  2.654 s]
[INFO] Hive ORC ... SUCCESS [  5.873 s]
[INFO] Hive Common  SUCCESS [ 19.173 s]
[INFO] Hive Serde . SUCCESS [  9.903 s]
[INFO] Hive Metastore . SUCCESS [ 44.618 s]
[INFO] Hive Ant Utilities . SUCCESS [  0.983 s]
[INFO] Hive Llap Common ... SUCCESS [  4.128 s]
[INFO] Hive Llap Client ... SUCCESS [  2.377 s]
[INFO] Hive Llap Tez .. SUCCESS [  3.217 s]
[INFO] Hive Service RPC ... SUCCESS [  5.472 s]
[INFO] Spark Remote Client  SUCCESS [ 20.618 s]
[INFO] Hive Query Language  SUCCESS [02:34 min]
[INFO] Hive Service ... SUCCESS [ 39.862 s]
[INFO] Hive Accumulo Handler .. SUCCESS [ 23.901 s]
[INFO] Hive JDBC .. SUCCESS [04:33 min]
[INFO] Hive Beeline ... SUCCESS [ 16.428 s]
[INFO] Hive CLI ... SUCCESS [  6.161 s]
[INFO] Hive Contrib ... SUCCESS [  5.277 s]
[INFO] Hive HBase Handler . SUCCESS [  8.963 s]
[INFO] Hive HCatalog .. SUCCESS [  1.383 s]
[INFO] Hive HCatalog Core . SUCCESS [  5.323 s]
[INFO] Hive HCatalog Pig Adapter .. SUCCESS [  3.491 s]
[INFO] Hive HCatalog Server Extensions  SUCCESS [  3.544 s]
[INFO] Hive HCatalog Webhcat Java Client .. SUCCESS [  2.992 s]
[INFO] Hive HCatalog Webhcat .. SUCCESS [ 14.926 s]
[INFO] Hive HCatalog Streaming  SUCCESS [ 10.478 s]
[INFO] Hive HPL/SQL ... SUCCESS [  8.266 s]
[INFO] Hive HWI ... SUCCESS [  2.919 s]
[INFO] Hive ODBC .. SUCCESS [  2.420 s]
[INFO] Hive Llap Server ... SUCCESS [  5.595 s]
[INFO] Hive Shims Aggregator .. SUCCESS [  0.192 s]
[INFO] Hive TestUtils . SUCCESS [  0.496 s]
[INFO] Hive Packaging . SUCCESS [02:54 min]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 15:18 min
[INFO] Finished at: 2016-02-24T13:27:54+05:30
[INFO] Final Memory: 266M/1666M
[INFO] 
arshad.matin$ find . -name "*deb"
./hcatalog/src/packages/deb
./packaging/src/deb
./packaging/target/hive_2.1.0-SNAPSHOT.deb


arshad.matin$ mvn clean install -DskipTests -Pdist
[INFO] Hive ... SUCCESS [ 12.084 s]
[INFO] Hive Shims Common .. SUCCESS [ 17.276 s]
[INFO] Hive Shims 0.23  SUCCESS [ 10.904 s]
[INFO] Hive Shims Scheduler ... SUCCESS [  2.368 s]
[INFO] Hive Shims . SUCCESS [  1.805 s]
[INFO] Hive Storage API ... SUCCESS [  3.587 s]
[INFO] Hive ORC ... SUCCESS [  6.167 s]
[INFO] Hive Common  SUCCESS [ 31.180 s]
[INFO] Hive Serde . SUCCESS [ 12.715 s]
[INFO] Hive Metastore 

Re: Review Request 43408: HIVE-13034 : Add jdeb plugin to build debian

2016-02-24 Thread Amareshwari Sriramadasu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43408/#review120482
---


Ship it!




Can you update testing done?

- Amareshwari Sriramadasu


On Feb. 24, 2016, 9:22 a.m., Arshad Matin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43408/
> ---
> 
> (Updated Feb. 24, 2016, 9:22 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-13034
> https://issues.apache.org/jira/browse/HIVE-13034
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-13034 : Add jdeb plugin to build debian
> 
> 
> Diffs
> -
> 
>   packaging/pom.xml e7feb62 
>   packaging/src/deb/control/control PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43408/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Arshad Matin
> 
>



Re: Review Request 43408: HIVE-13034 : Add jdeb plugin to build debian

2016-02-24 Thread Arshad Matin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43408/
---

(Updated Feb. 24, 2016, 9:22 a.m.)


Review request for hive.


Bugs: HIVE-13034
https://issues.apache.org/jira/browse/HIVE-13034


Repository: hive-git


Description
---

HIVE-13034 : Add jdeb plugin to build debian


Diffs (updated)
-

  packaging/pom.xml e7feb62 
  packaging/src/deb/control/control PRE-CREATION 

Diff: https://reviews.apache.org/r/43408/diff/


Testing
---


Thanks,

Arshad Matin



[jira] [Created] (HIVE-13142) Make HiveSplitGenerator usable independent of Tez

2016-02-24 Thread Siddharth Seth (JIRA)
Siddharth Seth created HIVE-13142:
-

 Summary: Make HiveSplitGenerator usable independent of Tez
 Key: HIVE-13142
 URL: https://issues.apache.org/jira/browse/HIVE-13142
 Project: Hive
  Issue Type: Sub-task
Reporter: Siddharth Seth


Already exists in the branch, but a bunch of cleanup is required. The branch 
contains code which makes some fields non-final, and a separate set method 
instead of the constructor. Should be simplified so that it can be constructed 
independently of Tez



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)