Review Request 47155: compute stats in certain cases fails with NPE

[pengcheng xiong]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47155/
---

Review request for hive, Gunther Hagleitner and Vikram Dixit Kumaraswamy.


Repository: hive-git


Description
---

HIVE-13621


Diffs
-

  itests/src/test/resources/testconfiguration.properties 5aedd10 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseUtils.java 
e0b449b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java f330564 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
 320dc10 
  ql/src/test/queries/clientpositive/deleteAnalyze.q PRE-CREATION 
  ql/src/test/results/clientpositive/deleteAnalyze.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/tez/deleteAnalyze.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/47155/diff/


Testing
---


Thanks,

pengcheng xiong

[jira] [Created] (HIVE-13726) Improve dynamic partition loading VI

[Ashutosh Chauhan (JIRA)]

Ashutosh Chauhan created HIVE-13726:
---

 Summary: Improve dynamic partition loading VI
 Key: HIVE-13726
 URL: https://issues.apache.org/jira/browse/HIVE-13726
 Project: Hive
  Issue Type: Improvement
  Components: Query Processor
Affects Versions: 2.0.0, 1.2.0
Reporter: Ashutosh Chauhan
Assignee: Ashutosh Chauhan


Parallelize deletes and other refactoring.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 47040: Monitor changes to FairScheduler.xml file and automatically update / validate jobs submitted to fair-scheduler

[Reuben Kuhnert]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47040/
---

(Updated 5 10, 2016, 1:18 오전)


Review request for hive, Lenni Kuff, Mohit Sabharwal, and Sergio Pena.


Changes
---

Make requested changes to patch


Summary (updated)
-

Monitor changes to FairScheduler.xml file and automatically update / validate 
jobs submitted to fair-scheduler


Bugs: HIVE-13696
https://issues.apache.org/jira/browse/HIVE-13696


Repository: hive-git


Description (updated)
---

Ensure that jobs sent to YARN with impersonation off are correctly routed to 
the proper queue based on fair-scheduler.xml. Monitor this file for changes and 
validate that jobs can only be sent to queues authorized for the user.


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 
926f6e883030b5a01d025994bd02c67f0f5a275c 
  ql/src/java/org/apache/hadoop/hive/ql/session/YarnFairScheduling.java 
PRE-CREATION 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
a0015ebc655931f241b28c53fbb94cfe172841b1 
  shims/common/src/main/java/org/apache/hadoop/fs/FileSystemWatcher.java 
PRE-CREATION 
  shims/common/src/main/java/org/apache/hadoop/hive/shims/SchedulerShim.java 
63803b8b0752745bd2fedaccc5d100befd97093b 
  
shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/FairSchedulerShim.java
 372244dc3c989d2a3ae2eb2bfb8cd0a235705e18 

Diff: https://reviews.apache.org/r/47040/diff/


Testing
---


Thanks,

Reuben Kuhnert

Re: Review Request 47040: Validate jobs submitted to fair-scheduler

[Reuben Kuhnert]

> On 5 6, 2016, 4:21 오후, Sergio Pena wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/session/YarnFairScheduling.java, line 
> > 24
> > 
> >
> > There is another validation on Hadoop23Shims.refreshDefaultQueue(). Why 
> > don't we have that one too here?

I'm not sure what this means.


- Reuben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47040/#review132054
---


On 5 5, 2016, 8:06 오후, Reuben Kuhnert wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47040/
> ---
> 
> (Updated 5 5, 2016, 8:06 오후)
> 
> 
> Review request for hive, Lenni Kuff, Mohit Sabharwal, and Sergio Pena.
> 
> 
> Bugs: HIVE-13696
> https://issues.apache.org/jira/browse/HIVE-13696
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Ensure that jobs sent to yarn with impersonation off are correctly routed to 
> the proper queue based on fair-scheduler.xml. Validate that jobs can only be 
> sent to queues authorized for the user.
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java 
> 6a610cbcb1deb7f7f55bb8aff58020b057454b31 
>   ql/src/java/org/apache/hadoop/hive/ql/session/YarnFairScheduling.java 
> PRE-CREATION 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
> a0015ebc655931f241b28c53fbb94cfe172841b1 
>   shims/common/src/main/java/org/apache/hadoop/fs/FileSystemWatcher.java 
> PRE-CREATION 
>   shims/common/src/main/java/org/apache/hadoop/hive/shims/SchedulerShim.java 
> 63803b8b0752745bd2fedaccc5d100befd97093b 
>   
> shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/FairSchedulerShim.java
>  372244dc3c989d2a3ae2eb2bfb8cd0a235705e18 
> 
> Diff: https://reviews.apache.org/r/47040/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Reuben Kuhnert
> 
>

[jira] [Created] (HIVE-13725) ACID: Streaming API should synchronize calls when multiple threads use the same endpoint

[Vaibhav Gumashta (JIRA)]

Vaibhav Gumashta created HIVE-13725:
---

 Summary: ACID: Streaming API should synchronize calls when 
multiple threads use the same endpoint
 Key: HIVE-13725
 URL: https://issues.apache.org/jira/browse/HIVE-13725
 Project: Hive
  Issue Type: Bug
  Components: Metastore
Affects Versions: 2.0.0, 1.2.1
Reporter: Vaibhav Gumashta


Currently, the streaming endpoint creates a metastore client which gets used 
for RPC. The client itself is not internally thread safe. Therefore, the API 
methods should provide the relevant synchronization so that the methods can be 
called from different threads. A sample use case is as follows:

1. Thread 1 creates a streaming endpoint and opens a txn batch.
2. Thread 2 heartbeats the txn batch.

With the current impl, this can result in an "out of sequence response", since 
the response of the calls in thread1 might end up going to thread2 and 
vice-versa.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-13724) Backport HIVE-11591 to branch-1 to use undated annotations

[Wei Zheng (JIRA)]

Wei Zheng created HIVE-13724:


 Summary: Backport HIVE-11591 to branch-1 to use undated annotations
 Key: HIVE-13724
 URL: https://issues.apache.org/jira/browse/HIVE-13724
 Project: Hive
  Issue Type: Bug
  Components: Thrift API
Affects Versions: 1.2.1
Reporter: Wei Zheng
Assignee: Wei Zheng


HIVE-12832 changed branch-1 hive pom file and updated thrift version from 0.9.2 
to 0.9.3. But it didn't update the thrift args part to use undated annotation 
from HIVE-11591.

So every time someone is running maven thrift re-gen command, it will still 
update a lot of unrelated files, just because of the date change.

Need backport HIVE-11591 to branch-1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-13723) Executing join query on type Float using Thrift Serde will result in Float cast to Double error

[Ziyang Zhao (JIRA)]

Ziyang Zhao created HIVE-13723:
--

 Summary: Executing join query on type Float using Thrift Serde 
will result in Float cast to Double error
 Key: HIVE-13723
 URL: https://issues.apache.org/jira/browse/HIVE-13723
 Project: Hive
  Issue Type: Bug
  Components: Serializers/Deserializers
Affects Versions: 2.1.0
Reporter: Ziyang Zhao


After enable thrift Serde, execute the following queries in beeline,
>create table test1 (a int);
>create table test2 (b float);
>insert into test1 values (1);
>insert into test2 values (1);
>select * from test1 join test2 on test1.a=test2.b;

this will give the error:

java.lang.Exception: java.lang.RuntimeException: 
org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while 
processing row {"b":1.0}
at 
org.apache.hadoop.mapred.LocalJobRunner$Job.runTasks(LocalJobRunner.java:462) 
~[hadoop-mapreduce-client-common-2.7.1.2.4.0.0-169.jar:?]
at 
org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:522) 
[hadoop-mapreduce-client-common-2.7.1.2.4.0.0-169.jar:?]
Caused by: java.lang.RuntimeException: 
org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while 
processing row {"b":1.0}
at 
org.apache.hadoop.hive.ql.exec.mr.ExecMapper.map(ExecMapper.java:168) 
~[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:54) 
~[hadoop-mapreduce-client-core-2.7.1.2.4.0.0-169.jar:?]
at org.apache.hadoop.mapred.MapTask.runOldMapper(MapTask.java:453) 
~[hadoop-mapreduce-client-core-2.7.1.2.4.0.0-169.jar:?]
at org.apache.hadoop.mapred.MapTask.run(MapTask.java:343) 
~[hadoop-mapreduce-client-core-2.7.1.2.4.0.0-169.jar:?]
at 
org.apache.hadoop.mapred.LocalJobRunner$Job$MapTaskRunnable.run(LocalJobRunner.java:243)
 ~[hadoop-mapreduce-client-common-2.7.1.2.4.0.0-169.jar:?]
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) 
~[?:1.7.0_95]
at java.util.concurrent.FutureTask.run(FutureTask.java:262) 
~[?:1.7.0_95]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) 
~[?:1.7.0_95]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) 
~[?:1.7.0_95]
at java.lang.Thread.run(Thread.java:745) ~[?:1.7.0_95]
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error 
while processing row {"b":1.0}
at 
org.apache.hadoop.hive.ql.exec.MapOperator.process(MapOperator.java:568) 
~[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at 
org.apache.hadoop.hive.ql.exec.mr.ExecMapper.map(ExecMapper.java:159) 
~[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:54) 
~[hadoop-mapreduce-client-core-2.7.1.2.4.0.0-169.jar:?]
at org.apache.hadoop.mapred.MapTask.runOldMapper(MapTask.java:453) 
~[hadoop-mapreduce-client-core-2.7.1.2.4.0.0-169.jar:?]
at org.apache.hadoop.mapred.MapTask.run(MapTask.java:343) 
~[hadoop-mapreduce-client-core-2.7.1.2.4.0.0-169.jar:?]
at 
org.apache.hadoop.mapred.LocalJobRunner$Job$MapTaskRunnable.run(LocalJobRunner.java:243)
 ~[hadoop-mapreduce-client-common-2.7.1.2.4.0.0-169.jar:?]
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) 
~[?:1.7.0_95]
at java.util.concurrent.FutureTask.run(FutureTask.java:262) 
~[?:1.7.0_95]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) 
~[?:1.7.0_95]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) 
~[?:1.7.0_95]
at java.lang.Thread.run(Thread.java:745) ~[?:1.7.0_95]
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Unexpected 
exception from MapJoinOperator : org.apache.hadoop.hive.serde2.SerDeException: 
java.lang.ClassCastException: java.lang.Float cannot be cast to java.lang.Double
at 
org.apache.hadoop.hive.ql.exec.MapJoinOperator.process(MapJoinOperator.java:454)
 ~[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at org.apache.hadoop.hive.ql.exec.Operator.forward(Operator.java:837) 
~[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at 
org.apache.hadoop.hive.ql.exec.FilterOperator.process(FilterOperator.java:126) 
~[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at org.apache.hadoop.hive.ql.exec.Operator.forward(Operator.java:837) 
~[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at 
org.apache.hadoop.hive.ql.exec.TableScanOperator.process(TableScanOperator.java:130)
 ~[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at 
org.apache.hadoop.hive.ql.exec.MapOperator$MapOpCtx.forward(MapOperator.java:164)
 ~[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at 
org.apache.hadoop.hive.ql.exec.MapOperator.process(MapOperator.java:558) 
~[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHO

[jira] [Created] (HIVE-13722) Add flag to detect constants to CBO pull up rules

[Jesus Camacho Rodriguez (JIRA)]

Jesus Camacho Rodriguez created HIVE-13722:
--

 Summary: Add flag to detect constants to CBO pull up rules
 Key: HIVE-13722
 URL: https://issues.apache.org/jira/browse/HIVE-13722
 Project: Hive
  Issue Type: Sub-task
Affects Versions: 2.1.0
Reporter: Jesus Camacho Rodriguez
Assignee: Jesus Camacho Rodriguez


Add flag to avoid firing CBO pull up constants rules indefinitely. This issue 
can be reproduced using e.g. union27.q, union_remove_19.q, unionDistinct_1.q.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: new HiveQA jenkins queue doesn't have JIRA numbers

[Sergio Pena]

I tried searching for a Jenkins plugin or something that allowed it to
display the JIRA number. Sadly, I did not find any.
Does any of you know how to do that in Jenkins?

On Mon, May 2, 2016 at 1:34 PM, Sergey Shelukhin 
wrote:

> Thanks! That is, however, not very useful if you are trying to see if your
> jira is somewhere in a 50-item queue ;)
>
> On 16/4/29, 17:15, "Thejas Nair"  wrote:
>
> >the jira number shows up if you hover your mouse over the notepad-and-pen
> >icon.
> >
> >
> >On Thu, Apr 28, 2016 at 11:20 AM, Sergey Shelukhin
> > wrote:
> >> Subj. Is it a limitation of the new Jenkins instance, or can it be
> >>enabled
> >> again? The JIRA number associated with the run used to be shown for the
> >> pending items in the left column.
> >>
> >
>
>

[jira] [Created] (HIVE-13721) HPL/SQL COPY FROM FTP Statement: lack of DIR option leads to NPE

[Carter Shanklin (JIRA)]

Carter Shanklin created HIVE-13721:
--

 Summary: HPL/SQL COPY FROM FTP Statement: lack of DIR option leads 
to NPE
 Key: HIVE-13721
 URL: https://issues.apache.org/jira/browse/HIVE-13721
 Project: Hive
  Issue Type: Bug
  Components: hpl/sql
Reporter: Carter Shanklin


The docs (http://www.hplsql.org/copy-from-ftp) suggest DIR is optional. When I 
left it out in:

{code}
copy from ftp hdp250.example.com user 'vagrant' pwd 'vagrant'  files 
'sampledata.csv' to /tmp overwrite
{code}

I got:

{code}
Ln:2 Connected to ftp: hdp250.example.com (29 ms)
Ln:2 Retrieving directory listing
  Listing the current working FTP directory
Ln:2 Files to copy: 45 bytes, 1 file, 0 subdirectories scanned (27 ms)
Exception in thread "main" java.lang.NullPointerException
at org.apache.hive.hplsql.Ftp.getTargetFileName(Ftp.java:342)
at org.apache.hive.hplsql.Ftp.run(Ftp.java:149)
at org.apache.hive.hplsql.Ftp.copyFiles(Ftp.java:121)
at org.apache.hive.hplsql.Ftp.run(Ftp.java:91)
at org.apache.hive.hplsql.Exec.visitCopy_from_ftp_stmt(Exec.java:1292)
at org.apache.hive.hplsql.Exec.visitCopy_from_ftp_stmt(Exec.java:52)
at 
org.apache.hive.hplsql.HplsqlParser$Copy_from_ftp_stmtContext.accept(HplsqlParser.java:11956)
at 
org.antlr.v4.runtime.tree.AbstractParseTreeVisitor.visitChildren(AbstractParseTreeVisitor.java:70)
at org.apache.hive.hplsql.Exec.visitStmt(Exec.java:994)
at org.apache.hive.hplsql.Exec.visitStmt(Exec.java:52)
at 
org.apache.hive.hplsql.HplsqlParser$StmtContext.accept(HplsqlParser.java:1012)
at 
org.antlr.v4.runtime.tree.AbstractParseTreeVisitor.visitChildren(AbstractParseTreeVisitor.java:70)
at 
org.apache.hive.hplsql.HplsqlBaseVisitor.visitBlock(HplsqlBaseVisitor.java:28)
at 
org.apache.hive.hplsql.HplsqlParser$BlockContext.accept(HplsqlParser.java:446)
at 
org.antlr.v4.runtime.tree.AbstractParseTreeVisitor.visitChildren(AbstractParseTreeVisitor.java:70)
at org.apache.hive.hplsql.Exec.visitProgram(Exec.java:901)
at org.apache.hive.hplsql.Exec.visitProgram(Exec.java:52)
at 
org.apache.hive.hplsql.HplsqlParser$ProgramContext.accept(HplsqlParser.java:389)
at 
org.antlr.v4.runtime.tree.AbstractParseTreeVisitor.visit(AbstractParseTreeVisitor.java:42)
at org.apache.hive.hplsql.Exec.run(Exec.java:760)
at org.apache.hive.hplsql.Exec.run(Exec.java:736)
at org.apache.hive.hplsql.Hplsql.main(Hplsql.java:23)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.hadoop.util.RunJar.run(RunJar.java:221)
at org.apache.hadoop.util.RunJar.main(RunJar.java:136)
{code}

Traceback leads to:
{code}
  /**
   * Get the target file relative path and name
   */
  String getTargetFileName(String file) {
int len = dir.length();
return targetDir + file.substring(len);
  }
{code}
in Ftp.java

When I added DIR '/' this worked.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-13720) TestLlapTaskCommunicator fails on master

[Ashutosh Chauhan (JIRA)]

Ashutosh Chauhan created HIVE-13720:
---

 Summary: TestLlapTaskCommunicator fails on master
 Key: HIVE-13720
 URL: https://issues.apache.org/jira/browse/HIVE-13720
 Project: Hive
  Issue Type: Bug
  Components: llap, Test
Affects Versions: 2.1.0
Reporter: Ashutosh Chauhan


Can be reproduced locally as well



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-13719) TestConverters fail on master

[Ashutosh Chauhan (JIRA)]

Ashutosh Chauhan created HIVE-13719:
---

 Summary: TestConverters fail on master
 Key: HIVE-13719
 URL: https://issues.apache.org/jira/browse/HIVE-13719
 Project: Hive
  Issue Type: Bug
  Components: llap, Tests
Affects Versions: 2.1.0
Reporter: Ashutosh Chauhan


Can be reproduced locally also.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-13718) The delegation token "hive.cluster.delegation.token.store.class" configuration for HMS is reused for HS2

[Aihua Xu (JIRA)]

Aihua Xu created HIVE-13718:
---

 Summary: The delegation token 
"hive.cluster.delegation.token.store.class" configuration for HMS is reused for 
HS2 
 Key: HIVE-13718
 URL: https://issues.apache.org/jira/browse/HIVE-13718
 Project: Hive
  Issue Type: Bug
  Components: HiveServer2
Reporter: Aihua Xu
Assignee: Aihua Xu
 Fix For: 2.0.0


The token class setting "hive.cluster.delegation.token.store.class" was 
intended for HMS initially. Later DBTokenStore support was added for HS2 and we 
reused the same setting. 

Open this jira to discuss if it makes sense to have 2 separate settings for HMS 
and HS2. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 46929: HIVE-13676: Tests failing because metastore doesn't come up

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46929/
---

(Updated May 9, 2016, 3:41 p.m.)


Review request for hive.


Bugs: HIVE-13676
https://issues.apache.org/jira/browse/HIVE-13676


Repository: hive-git


Description
---

In 5-6 test classes, metastore is required to be up for tests to run. The 
metastore is started in setup Phase asynchronously. But there's no logic to 
wait till the metastore comes up. Hence, sometimes tests run even when 
metastore isn't up and fail.


Diffs (updated)
-

  
hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMultiOutputFormat.java
 9fa263d53596378276fabc43b7f44409b4b0ccfb 
  
hcatalog/webhcat/java-client/src/test/java/org/apache/hive/hcatalog/api/TestHCatClient.java
 aa9c7d31f2cbe187e84bfddfe411da1f49943819 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java
 7576f3923c7ae2e144263445d0a69e5424489567 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 
76220f45c079d8d284421c6c7952698207ece868 
  
metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreGetMetaConf.java
 3f4561cc4b2a737f18e274779d6e748dcd3abad0 
  
metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStorePartitionSpecs.java
 922a4bf11cbc5693cc5753b8488c5ae3085dd3f4 
  ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveRemote.java 
ee95e160c858a93c43f96775b360f28f8d6a178f 

Diff: https://reviews.apache.org/r/46929/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 46929: HIVE-13676: Tests failing because metastore doesn't come up

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46929/
---

(Updated May 9, 2016, 3:20 p.m.)


Review request for hive.


Bugs: HIVE-13676
https://issues.apache.org/jira/browse/HIVE-13676


Repository: hive-git


Description
---

In 5-6 test classes, metastore is required to be up for tests to run. The 
metastore is started in setup Phase asynchronously. But there's no logic to 
wait till the metastore comes up. Hence, sometimes tests run even when 
metastore isn't up and fail.


Diffs (updated)
-

  
hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMultiOutputFormat.java
 9fa263d53596378276fabc43b7f44409b4b0ccfb 
  
hcatalog/webhcat/java-client/src/test/java/org/apache/hive/hcatalog/api/TestHCatClient.java
 aa9c7d31f2cbe187e84bfddfe411da1f49943819 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java
 7576f3923c7ae2e144263445d0a69e5424489567 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 
76220f45c079d8d284421c6c7952698207ece868 
  
metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreGetMetaConf.java
 3f4561cc4b2a737f18e274779d6e748dcd3abad0 
  
metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStorePartitionSpecs.java
 922a4bf11cbc5693cc5753b8488c5ae3085dd3f4 
  ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveRemote.java 
ee95e160c858a93c43f96775b360f28f8d6a178f 

Diff: https://reviews.apache.org/r/46929/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 46929: HIVE-13676: Tests failing because metastore doesn't come up

[Rajat Khandelwal]

> On May 3, 2016, 9:31 p.m., Ashutosh Chauhan wrote:
> > hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMultiOutputFormat.java,
> >  line 117
> > 
> >
> > I don't follow this. If it throws exception in what circumstance you 
> > will be able to connect after 1 sec?

Dropping as now I'm using pre-existing methods.


> On May 3, 2016, 9:31 p.m., Ashutosh Chauhan wrote:
> > hcatalog/webhcat/java-client/src/test/java/org/apache/hive/hcatalog/api/TestHCatClient.java,
> >  line 120
> > 
> >
> > There is already a utility method for this. See: 
> > MetastoreUtils::startMetaStore()

I wonder why it isn't already used in these places.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46929/#review131518
---


On May 9, 2016, 3:20 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46929/
> ---
> 
> (Updated May 9, 2016, 3:20 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-13676
> https://issues.apache.org/jira/browse/HIVE-13676
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> In 5-6 test classes, metastore is required to be up for tests to run. The 
> metastore is started in setup Phase asynchronously. But there's no logic to 
> wait till the metastore comes up. Hence, sometimes tests run even when 
> metastore isn't up and fail.
> 
> 
> Diffs
> -
> 
>   
> hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMultiOutputFormat.java
>  9fa263d53596378276fabc43b7f44409b4b0ccfb 
>   
> hcatalog/webhcat/java-client/src/test/java/org/apache/hive/hcatalog/api/TestHCatClient.java
>  aa9c7d31f2cbe187e84bfddfe411da1f49943819 
>   
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java
>  7576f3923c7ae2e144263445d0a69e5424489567 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 
> 76220f45c079d8d284421c6c7952698207ece868 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreGetMetaConf.java
>  3f4561cc4b2a737f18e274779d6e748dcd3abad0 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStorePartitionSpecs.java
>  922a4bf11cbc5693cc5753b8488c5ae3085dd3f4 
>   ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveRemote.java 
> ee95e160c858a93c43f96775b360f28f8d6a178f 
> 
> Diff: https://reviews.apache.org/r/46929/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>