Re: Review Request 49494: HIVE-14144: Permanent functions are showing up in show functions, but describe says it doesn't exist

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49494/#review140956
---


Ship it!




Ship It!

- Amareshwari Sriramadasu


On July 1, 2016, 7:22 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49494/
> ---
> 
> (Updated July 1, 2016, 7:22 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-14144
> https://issues.apache.org/jira/browse/HIVE-14144
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java 
> a4584e3eaebc052a6870c543bfbfc9e5d78e771b 
>   ql/src/java/org/apache/hadoop/hive/ql/util/ResourceDownloader.java 
> 14102b5108164616b4cf2e7f7d22c894321f027e 
> 
> Diff: https://reviews.apache.org/r/49494/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Created] (HIVE-14167) Use work directories provided by Tez instead of directly using YARN local dirs

[Siddharth Seth (JIRA)]

Siddharth Seth created HIVE-14167:
-

 Summary: Use work directories provided by Tez instead of directly 
using YARN local dirs
 Key: HIVE-14167
 URL: https://issues.apache.org/jira/browse/HIVE-14167
 Project: Hive
  Issue Type: Improvement
Reporter: Siddharth Seth


HIVE-13303 fixed things to use multiple directories instead of a single tmp 
directory. However it's using yarn-local-dirs directly.
I'm not sure how well using the yarn-local-dir will work on a secure cluster.

Would be better to use Tez*Context.getWorkDirs. This provides an app specific 
directory - writable by the user.

cc [~sershe]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 49644: Support masking and filtering of rows/columns: deal with derived column names

[pengcheng xiong]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49644/
---

(Updated July 6, 2016, 12:41 a.m.)


Review request for hive and Gunther Hagleitner.


Repository: hive-git


Description
---

HIVE-14158


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 20d9649 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java 1686f36 
  ql/src/test/queries/clientpositive/masking_6.q PRE-CREATION 
  ql/src/test/queries/clientpositive/view_alias.q PRE-CREATION 
  ql/src/test/results/clientpositive/masking_6.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/view_alias.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/49644/diff/


Testing
---


Thanks,

pengcheng xiong

[jira] [Created] (HIVE-14166) Minor updates to the website.

[Owen O'Malley (JIRA)]

Owen O'Malley created HIVE-14166:


 Summary: Minor updates to the website.
 Key: HIVE-14166
 URL: https://issues.apache.org/jira/browse/HIVE-14166
 Project: Hive
  Issue Type: Bug
Reporter: Owen O'Malley
Assignee: Owen O'Malley


Minor updates to the website & documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-14165) Enable faster S3 Split Computation by listing files in blocks

[Abdullah Yousufi (JIRA)]

Abdullah Yousufi created HIVE-14165:
---

 Summary: Enable faster S3 Split Computation by listing files in 
blocks
 Key: HIVE-14165
 URL: https://issues.apache.org/jira/browse/HIVE-14165
 Project: Hive
  Issue Type: Improvement
Affects Versions: 2.1.0
Reporter: Abdullah Yousufi
Assignee: Abdullah Yousufi


During split computation when a large of files are required to be listed from 
S3 then instead of executing 1 API call per file, one can optimize by listing 
1000 files in each API call. Thereby reducing the amount of time required for 
listing files.
Qubole has this optimization in place as detailed here: 
https://www.qubole.com/blog/product/optimizing-hadoop-for-s3-part-1/?nabe=5695374637924352:0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HIVE-14164) JDBC: Add retry in JDBC driver when reading config values from ZK

[Vaibhav Gumashta (JIRA)]

Vaibhav Gumashta created HIVE-14164:
---

 Summary: JDBC: Add retry in JDBC driver when reading config values 
from ZK
 Key: HIVE-14164
 URL: https://issues.apache.org/jira/browse/HIVE-14164
 Project: Hive
  Issue Type: Bug
Reporter: Vaibhav Gumashta
Assignee: Vaibhav Gumashta


Sometimes ZK may intermittently experience network partitioning. During this 
time, clients trying to open a JDBC connection get an exception. To improve 
user experience, we should implement a retry logic and fail after retrying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 49347: HIVE-14111 better concurrency handling for TezSessionState - part I

[Sergey Shelukhin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49347/
---

(Updated July 5, 2016, 8:29 p.m.)


Review request for hive and Siddharth Seth.


Repository: hive-git


Description
---

.


Diffs (updated)
-

  itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 573fea1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java e154d13 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 
f8f3cad 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 919b35a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java 9e114c0 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java d4051a1 
  ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java 
956fd29 
  service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java 
44463c9 
  service/src/java/org/apache/hive/service/cli/operation/Operation.java ba034ab 
  service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 
28c4553 

Diff: https://reviews.apache.org/r/49347/diff/


Testing
---


Thanks,

Sergey Shelukhin

[jira] [Created] (HIVE-14163) LLAP: use different kerberized/unkerberized paths for registry

[Sergey Shelukhin (JIRA)]

Sergey Shelukhin created HIVE-14163:
---

 Summary: LLAP: use different kerberized/unkerberized paths for 
registry
 Key: HIVE-14163
 URL: https://issues.apache.org/jira/browse/HIVE-14163
 Project: Hive
  Issue Type: Bug
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 49644: Support masking and filtering of rows/columns: deal with derived column names

[pengcheng xiong]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49644/
---

Review request for hive and Ashutosh Chauhan.


Repository: hive-git


Description
---

HIVE-14158


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/parse/TableMask.java 1686f36 
  ql/src/test/queries/clientnegative/masking_6.q PRE-CREATION 
  ql/src/test/queries/clientpositive/masking_6.q PRE-CREATION 
  ql/src/test/results/clientnegative/masking_6.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/masking_6.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/49644/diff/


Testing
---


Thanks,

pengcheng xiong

[jira] [Created] (HIVE-14162) Allow disabling of long running job on Hive On Spark On YARN

[Thomas Scott (JIRA)]

Thomas Scott created HIVE-14162:
---

 Summary: Allow disabling of long running job on Hive On Spark On 
YARN
 Key: HIVE-14162
 URL: https://issues.apache.org/jira/browse/HIVE-14162
 Project: Hive
  Issue Type: New Feature
  Components: Spark
Reporter: Thomas Scott
Priority: Minor


Hive On Spark launches a long running process on the first query to handle all 
queries for that user session. In some use cases this is not desired, for 
instance when using Hue with large intervals between query executions.

Could we have a property that would cause long running spark jobs to be 
terminated after each query execution and started again for the next one?





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] hive pull request #82: Update to UDFRegExpExtract

[dark0dave]

Github user dark0dave closed the pull request at:

https://github.com/apache/hive/pull/82


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (HIVE-14161) from_utc_timestamp()/to_utc_timestamp return incorrect results with EST

[Chaoyu Tang (JIRA)]

Chaoyu Tang created HIVE-14161:
--

 Summary: from_utc_timestamp()/to_utc_timestamp return incorrect 
results with EST
 Key: HIVE-14161
 URL: https://issues.apache.org/jira/browse/HIVE-14161
 Project: Hive
  Issue Type: Bug
  Components: UDF
Reporter: Chaoyu Tang
Assignee: Chaoyu Tang


{code}
hive> SELECT to_utc_timestamp('2016-06-30 06:00:00', 'PST'); 
OK
2016-06-30 13:00:00  ==>Correct, UTC is 7 hours ahead of PST
Time taken: 1.674 seconds, Fetched: 1 row(s)
hive> SELECT to_utc_timestamp('2016-06-30 08:00:00', 'CST');
OK
2016-06-30 13:00:00  ==>Correct, UTC is 5 hours ahead of CST
Time taken: 1.776 seconds, Fetched: 1 row(s)
hive> SELECT to_utc_timestamp('2016-06-30 09:00:00', 'EST');
OK
2016-06-30 14:00:00  ==>Wrong, UTC should be 4 hours ahead of EST
Time taken: 1.686 seconds, Fetched: 1 row(s)
hive> select from_utc_timestamp('2016-06-30 14:00:00', 'EST');
OK
2016-06-30 09:00:00  ==>Wrong, UTC should be 4 hours ahead of EST
{code}
It might be something related to daylight savings time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] hive pull request #84: Update to UDFRegExpExtract & created .travis.yaml fil...

[dark0dave]

GitHub user dark0dave opened a pull request:

https://github.com/apache/hive/pull/84

 Update to UDFRegExpExtract & created .travis.yaml file

I would like to return a clearer error message, for failed regex extract 
commands.

And added a travis.yaml file so integration with travis works.

Also I have changed the pom file to be in line with this:

https://github.com/apache/hive/pull/70/commits/6c0909ea107ed34a717891fe3af236a8b73df895

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dark0dave/hive master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/hive/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #84


commit c10f56a8859069ca9c3b0d8708cbbba8cd780388
Author: dark0dave 
Date:   2016-07-05T11:29:12Z

Created .travis.yaml file

Need this file so our tests actually run.

commit 59c4ac4bb718c5441a874fb04b5fad09cd6b9da2
Author: dark0dave 
Date:   2016-07-05T11:36:07Z

Update to UDFRegExpExtract

I would like to return a clearer error message, for failed regex extract 
commands.

commit de672c5c0d427abdedbf9195c9854ae3b38264d8
Author: dark0dave 
Date:   2016-07-05T11:49:26Z

Update to pom.xml

Updated pom to ensure travis runs, copied from here 
https://github.com/apache/hive/pull/70/commits.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] hive pull request #83: Update to UDFRegExpExtract & created .travis.yaml fil...

[dark0dave]

Github user dark0dave closed the pull request at:

https://github.com/apache/hive/pull/83


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] hive pull request #83: Update to UDFRegExpExtract & created .travis.yaml fil...

[dark0dave]

Github user dark0dave closed the pull request at:

https://github.com/apache/hive/pull/83


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] hive pull request #83: Update to UDFRegExpExtract & created .travis.yaml fil...

[dark0dave]

GitHub user dark0dave reopened a pull request:

https://github.com/apache/hive/pull/83

Update to UDFRegExpExtract & created .travis.yaml file

I would like to return a clearer error message, for failed regex extract 
commands.

And added a travis.yaml file so integration with travis works.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dark0dave/hive master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/hive/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #83


commit c10f56a8859069ca9c3b0d8708cbbba8cd780388
Author: dark0dave 
Date:   2016-07-05T11:29:12Z

Created .travis.yaml file

Need this file so our tests actually run.

commit 59c4ac4bb718c5441a874fb04b5fad09cd6b9da2
Author: dark0dave 
Date:   2016-07-05T11:36:07Z

Update to UDFRegExpExtract

I would like to return a clearer error message, for failed regex extract 
commands.

commit de672c5c0d427abdedbf9195c9854ae3b38264d8
Author: dark0dave 
Date:   2016-07-05T11:49:26Z

Update to pom.xml

Updated pom to ensure travis runs, copied from here 
https://github.com/apache/hive/pull/70/commits.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] hive pull request #83: Update to UDFRegExpExtract & created .travis.yaml fil...

[dark0dave]

GitHub user dark0dave opened a pull request:

https://github.com/apache/hive/pull/83

Update to UDFRegExpExtract & created .travis.yaml file

I would like to return a clearer error message, for failed regex extract 
commands.

And added a travis.yaml file so integration with travis works.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dark0dave/hive master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/hive/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #83


commit c10f56a8859069ca9c3b0d8708cbbba8cd780388
Author: dark0dave 
Date:   2016-07-05T11:29:12Z

Created .travis.yaml file

Need this file so our tests actually run.

commit 59c4ac4bb718c5441a874fb04b5fad09cd6b9da2
Author: dark0dave 
Date:   2016-07-05T11:36:07Z

Update to UDFRegExpExtract

I would like to return a clearer error message, for failed regex extract 
commands.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (HIVE-14160) Reduce-task costs a long time to finish on the condition that the certain sql "select a,distinct(b) group by a" has been executed on the data which has skew distribution

[marymwu (JIRA)]

marymwu created HIVE-14160:
--

 Summary: Reduce-task costs a long time to finish on the condition 
that the certain sql "select a,distinct(b) group by a" has been executed on the 
data which has skew distribution
 Key: HIVE-14160
 URL: https://issues.apache.org/jira/browse/HIVE-14160
 Project: Hive
  Issue Type: Improvement
  Components: hpl/sql
Affects Versions: 1.1.0
Reporter: marymwu


Reduce-task costs a long time to finish on the condition that the certain sql 
"select a,distinct(b) group by a" has been executed on the data which has skew 
distribution

data scale: 64G



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] hive pull request #82: Update to UDFRegExpExtract

[dark0dave]

GitHub user dark0dave opened a pull request:

https://github.com/apache/hive/pull/82

Update to UDFRegExpExtract

I would like to return a clearer error message, for failed regex extract 
commands.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dark0dave/hive patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/hive/pull/82.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #82


commit 9be927c4dff58a2345cbc7a105d5710a43b16820
Author: dark0dave 
Date:   2016-07-05T10:33:28Z

Update to UDFRegExpExtract

I would like to return a clearer error message, for failed regex extract 
commands.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

[Peter Vary]

> On July 1, 2016, 5:19 p.m., Szehon Ho wrote:
> > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java, line 481
> > 
> >
> > It seems a hacky way to detect embedded mode.
> > 
> > What do you think about doing an or, say if the command line opts is 
> > set, or the hive.cli.pring.current.db is in the properties file.  (i guess 
> > now there is beeline.properties)
> 
> Peter Vary wrote:
> To tell the truth, I did not know, that there were two modes of running 
> beeline, until I found this type of check everywhere in the code, and finally 
> found it where this was set. :) See HiveCli. I will think about your 
> suggestions too, thanks

Thanks for your, and for Vihang's comment, I think I have a better 
understanding of beeline modes now.
It is not embedded/remote mode which makes the difference here, but the 
beeline/compatibility mode.

I will change the JIRA, and the comments to match this.

If you think my reasoning is faulty, or I should do the changes for other modes 
as well, state it, and I will do my best :)


- Peter


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49498/#review140385
---


On July 1, 2016, 3:08 p.m., Peter Vary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49498/
> ---
> 
> (Updated July 1, 2016, 3:08 p.m.)
> 
> 
> Review request for hive, Sergio Pena, Szehon Ho, and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-14123
> https://issues.apache.org/jira/browse/HIVE-14123
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> There are several jira issues complaining that, the Beeline does not respect 
> hive.cli.print.current.db.
> This is partially true, since in embedded mode, it uses the 
> hive.cli.print.current.db to change the prompt, since HIVE-10511.
> In remote mode, I think this function should use a beeline command line 
> option instead, like for the showHeader option emphasizing, that this is a 
> client side option.
> 
> The patch contains:
> - New configuration option
> - Changing the help text
> - Updating command hooks, to run in remote mode as well
> - Adding new hooks, for connect and go sqllite commands
> - Generalize database connection refresh command
> - Changing prompt
> 
> 
> Diffs
> -
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 66185f6 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 5aaa385 
>   beeline/src/java/org/apache/hive/beeline/ClientCommandHookFactory.java 
> c4d97bc 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 3a204c0 
>   beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 
> 3b863ae 
>   beeline/src/main/resources/BeeLine.properties 7500df9 
>   beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java ce1f538 
>   beeline/src/test/org/apache/hive/beeline/TestClientCommandHookFactory.java 
> c86de0a 
> 
> Diff: https://reviews.apache.org/r/49498/diff/
> 
> 
> Testing
> ---
> 
> Unit tests for the hooks, and the configuration option
> 
> Manual test in remote, and embedded mode
> 
> 
> Thanks,
> 
> Peter Vary
> 
>

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

[Peter Vary]

> On July 1, 2016, 9:58 p.m., Vihang Karajgaonkar wrote:
> > Thanks for the changes. Can you please test your code by setting 
> > USE_DEPRECATED_CLI=false.

Ok. Maybe something is not yet clear for me :)
Could you please explain?

My understanding of the command prompt clients:
- CLI - Deprecated - uses org.apache.hadoop.hive.cli.CliDriver class, when the 
USE_DEPRECATED_CLI is set, then it uses this class to start - no developement 
is planned
- Beeline Cli - The new one, and this should be used, and developed further, 
and could start in two modes:
-- Beeline mode - org.apache.hive.beeline.BeeLine class will start in this mode 
(beeLine.isBeeLine()==true)
-- Compatibility mode - org.apache.hive.beeline.cli.HiveCli class will start in 
this mode (beeLine.isBeeLine()==false)

Depending on the connection URL, the Beeline Cli could start an embedded HS2 
server - This is independent of the compatibility mode settings, and dependent 
only on the connection url. I have learned this since your, and Szehon Ho's 
review, so I have to change my comments at least :)

Assuming the above is correct, I think we should not change the behavior of the 
CLI, and the Beeline in Compatiblity mode.
I think we should only use the new parameter in Beeline/Beeline mode, like it 
is happened with the showHeader command line option.

If something is wrong with the above assumptions, or you think we should use 
the new parameter in another modes as well, just say so, and I will look at it

Thanks, and sorry, but still learning the code, and the hive specific practices


> On July 1, 2016, 9:58 p.m., Vihang Karajgaonkar wrote:
> > beeline/src/java/org/apache/hive/beeline/BeeLine.java, line 1446
> > 
> >
> > Is there a reason to remove previous check for 
> > HiveConf.ConfVars.CLIPRINTCURRENTDB? Looks like this method is getting 
> > called from getPromptForCli() and if the beeline option for db is false, it 
> > will not set db name in the cli prompt too irrespective of the value of 
> > HiveConf.ConfVars.CLIPRINTCURRENTDB. btw, you may want to look at 
> > HIVE-14151 if you finding trouble while using beeline as cli

I moved the HiveConf.ConfVars.CLIPRINTCURRENTDB check inside the 
getShowDbInPrompt() method, to match the outline of the getShowHeader() 
parameter.

Thanks for the pointer, it helped a lot in testing and understanding :)


- Peter


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49498/#review140391
---


On July 1, 2016, 3:08 p.m., Peter Vary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49498/
> ---
> 
> (Updated July 1, 2016, 3:08 p.m.)
> 
> 
> Review request for hive, Sergio Pena, Szehon Ho, and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-14123
> https://issues.apache.org/jira/browse/HIVE-14123
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> There are several jira issues complaining that, the Beeline does not respect 
> hive.cli.print.current.db.
> This is partially true, since in embedded mode, it uses the 
> hive.cli.print.current.db to change the prompt, since HIVE-10511.
> In remote mode, I think this function should use a beeline command line 
> option instead, like for the showHeader option emphasizing, that this is a 
> client side option.
> 
> The patch contains:
> - New configuration option
> - Changing the help text
> - Updating command hooks, to run in remote mode as well
> - Adding new hooks, for connect and go sqllite commands
> - Generalize database connection refresh command
> - Changing prompt
> 
> 
> Diffs
> -
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 66185f6 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 5aaa385 
>   beeline/src/java/org/apache/hive/beeline/ClientCommandHookFactory.java 
> c4d97bc 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 3a204c0 
>   beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 
> 3b863ae 
>   beeline/src/main/resources/BeeLine.properties 7500df9 
>   beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java ce1f538 
>   beeline/src/test/org/apache/hive/beeline/TestClientCommandHookFactory.java 
> c86de0a 
> 
> Diff: https://reviews.apache.org/r/49498/diff/
> 
> 
> Testing
> ---
> 
> Unit tests for the hooks, and the configuration option
> 
> Manual test in remote, and embedded mode
> 
> 
> Thanks,
> 
> Peter Vary
> 
>