Review Request 68733: HIVE-20549: Allow user set query tag, and kill query with tag

2018-09-16 Thread Daniel Dai

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68733/
---

Review request for hive.


Repository: hive-git


Description
---

See HIVE-20549


Diffs
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java aa58d74 
  
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniLlapArrow.java
 4942ed9 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java dad2035 
  ql/src/java/org/apache/hadoop/hive/ql/QueryState.java 028dd60 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java 
e4186c4 
  ql/src/test/queries/clientnegative/authorization_kill_query.q 5379f87 
  service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 
8db6a29 
  service/src/java/org/apache/hive/service/server/KillQueryImpl.java 490a04d 


Diff: https://reviews.apache.org/r/68733/diff/1/


Testing
---


Thanks,

Daniel Dai



[jira] [Created] (HIVE-20570) Union ALL with hive.optimize.union.remove=true has incorrect plan

2018-09-16 Thread Janaki Lahorani (JIRA)
Janaki Lahorani created HIVE-20570:
--

 Summary: Union ALL with hive.optimize.union.remove=true has 
incorrect plan
 Key: HIVE-20570
 URL: https://issues.apache.org/jira/browse/HIVE-20570
 Project: Hive
  Issue Type: Bug
Reporter: Janaki Lahorani


When hive.optimize.union.remove=true and a select query is run with group by, 
the final fetch is waiting only for one of the branches and not both.

Test Case:
{code}
create table if not exists test_table(column1 string, column2 int);
insert into test_table values('a',1),('b',2);

set hive.optimize.union.remove=true;
set mapred.input.dir.recursive=true;

explain
select column1 from test_table group by column1
union all
select column1 from test_table group by column1;
{code}

In the below the two stages correspond to the two parts of union all.  But the 
final fetch operator (Stage 0) only depends on one of the stages, but it should 
depend on both.
Plan:
{code}
STAGE DEPENDENCIES:
  Stage-1 is a root stage
  Stage-2 is a root stage
*  Stage-0 depends on stages: Stage-1*

STAGE PLANS:
  Stage: Stage-1
Map Reduce
  Map Operator Tree:
  TableScan
alias: test_table
Statistics: Num rows: 2 Data size: 6 Basic stats: COMPLETE Column 
stats: NONE
Select Operator
  expressions: column1 (type: string)
  outputColumnNames: column1
  Statistics: Num rows: 2 Data size: 6 Basic stats: COMPLETE Column 
stats: NONE
  Group By Operator
keys: column1 (type: string)
mode: hash
outputColumnNames: _col0
Statistics: Num rows: 2 Data size: 6 Basic stats: COMPLETE 
Column stats: NONE
Reduce Output Operator
  key expressions: _col0 (type: string)
  sort order: +
  Map-reduce partition columns: _col0 (type: string)
  Statistics: Num rows: 2 Data size: 6 Basic stats: COMPLETE 
Column stats: NONE
  Execution mode: vectorized
  Reduce Operator Tree:
Group By Operator
  keys: KEY._col0 (type: string)
  mode: mergepartial
  outputColumnNames: _col0
  Statistics: Num rows: 1 Data size: 3 Basic stats: COMPLETE Column 
stats: NONE
  File Output Operator
compressed: false
Statistics: Num rows: 1 Data size: 3 Basic stats: COMPLETE Column 
stats: NONE
table:
input format: org.apache.hadoop.mapred.SequenceFileInputFormat
output format: 
org.apache.hadoop.hive.ql.io.HiveSequenceFileOutputFormat
serde: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe

  Stage: Stage-2
Map Reduce
  Map Operator Tree:
  TableScan
alias: test_table
Statistics: Num rows: 2 Data size: 6 Basic stats: COMPLETE Column 
stats: NONE
Select Operator
  expressions: column1 (type: string)
  outputColumnNames: column1
  Statistics: Num rows: 2 Data size: 6 Basic stats: COMPLETE Column 
stats: NONE
  Group By Operator
keys: column1 (type: string)
mode: hash
outputColumnNames: _col0
Statistics: Num rows: 2 Data size: 6 Basic stats: COMPLETE 
Column stats: NONE
Reduce Output Operator
  key expressions: _col0 (type: string)
  sort order: +
  Map-reduce partition columns: _col0 (type: string)
  Statistics: Num rows: 2 Data size: 6 Basic stats: COMPLETE 
Column stats: NONE
  Execution mode: vectorized
  Reduce Operator Tree:
Group By Operator
  keys: KEY._col0 (type: string)
  mode: mergepartial
  outputColumnNames: _col0
  Statistics: Num rows: 1 Data size: 3 Basic stats: COMPLETE Column 
stats: NONE
  File Output Operator
compressed: false
Statistics: Num rows: 1 Data size: 3 Basic stats: COMPLETE Column 
stats: NONE
table:
input format: org.apache.hadoop.mapred.SequenceFileInputFormat
output format: 
org.apache.hadoop.hive.ql.io.HiveSequenceFileOutputFormat
serde: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe

  Stage: Stage-0
Fetch Operator
  limit: -1
  Processor Tree:
ListSink
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 68310: HIVE-17040

2018-09-16 Thread Vineet Garg

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68310/#review208669
---


Ship it!




Ship It!

- Vineet Garg


On Sept. 14, 2018, 9:51 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68310/
> ---
> 
> (Updated Sept. 14, 2018, 9:51 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-17040
> https://issues.apache.org/jira/browse/HIVE-17040
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-17040
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> 0bfee2e43e8bf35234ddabb173d71de4e00b11a2 
>   itests/src/test/resources/testconfiguration.properties 
> 3a5aec7d6b8ab624f5f4526cf81e48678eca601f 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java 
> 268284a6da22755f801be87651f9d4a6d228b24d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinConstraintsRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveProjectJoinTransposeRule.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveProjectMergeRule.java
>  07518df9ec1cea1c331846bbe636cf1a039e762f 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
> 8a1a2520c83bf645ad8b402bef20d9990e434779 
>   ql/src/test/queries/clientpositive/join_constraints_optimization.q 
> PRE-CREATION 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_1.q 
> ee4844277e5dd1d9ea3911ad2e33a9c3f2481344 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_3.q 
> 4aadd5fb0a4bc74c5bc4088b3d4e62c81bf9cf8b 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_4.q 
> dc20b68ba9a9e0bbcb9c414b10b00f3228fe63fe 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_5.q 
> 0e4fdf49ac04935f6f14c2ceaa0969008b34f926 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_6.q 
> 4f05f76330cb74be50187e3b175d4675f5ea8763 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_7.q 
> 59ed5757569a8dde70fe04eb9ec5e8c91b5931bf 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_no_join_opt.q 
> PRE-CREATION 
>   
> ql/src/test/queries/clientpositive/materialized_view_rewrite_no_join_opt_2.q 
> PRE-CREATION 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_part_1.q 
> 5a2e74c8a005ae8422c00a998fa3c07183749176 
>   ql/src/test/results/clientpositive/ambiguitycheck.q.out 
> 80c9582fec9754fe56400064ab3f88e3e9ea2da7 
>   
> ql/src/test/results/clientpositive/beeline/materialized_view_create_rewrite.q.out
>  7813aac29465b5193789464fcd32771741a98071 
>   ql/src/test/results/clientpositive/druid/druidmini_mv.q.out 
> 806262d72e687bbdd09b47380eed77c14764c2a5 
>   ql/src/test/results/clientpositive/list_bucket_dml_2.q.out 
> bd8e215c2207c48ce2e446fcc10333ec0fb4648c 
>   ql/src/test/results/clientpositive/list_bucket_dml_4.q.out 
> 520d48e3d9fa67301852efc9ed1c92494fd528a0 
>   ql/src/test/results/clientpositive/list_bucket_dml_9.q.out 
> fbd4fde1bd8d2f7379585afe07c018139b7d64e8 
>   ql/src/test/results/clientpositive/list_bucket_query_multiskew_1.q.out 
> e324cab738c22e31089f437d6e7d8a65160dc5b9 
>   ql/src/test/results/clientpositive/list_bucket_query_multiskew_2.q.out 
> ec1e54060cb7d380bda4d965fff540d002bd456a 
>   ql/src/test/results/clientpositive/list_bucket_query_multiskew_3.q.out 
> 889f23c6da7e3c7b955b83d44afd1bd048468b49 
>   ql/src/test/results/clientpositive/list_bucket_query_oneskew_1.q.out 
> dcff8a50370b4ebb07300d4a7d9c34aa84f4ae17 
>   ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 
> 268051e2acbbabd02206c5a21690fb563a3dcd2b 
>   ql/src/test/results/clientpositive/llap/acid_bucket_pruning.q.out 
> 3951b71227d93469347264362492e64554efee32 
>   ql/src/test/results/clientpositive/llap/bucketpruning1.q.out 
> 55442ad04668a193a2d40b6a3088149f6072b28c 
>   ql/src/test/results/clientpositive/llap/current_date_timestamp.q.out 
> 6831fb2573788033393544b835f1a56d69fb1712 
>   ql/src/test/results/clientpositive/llap/join_constraints_optimization.q.out 
> PRE-CREATION 
>   
> ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite.q.out
>  71adebb2acad1545c48d45835cd5876434b141b5 
>   
> ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite_dummy.q.out
>  ce1c281bea0bd2a96e67057ee990fa5b45850905 
>   
> ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite_multi_db.q.out
>  98f74379f6275aed90273929c65144e4bbd51a97 
>   ql/src/test/results/clientpositive/llap/materialized_view_rewrite_1.q.out 
> 4d8fa52aa94a77faa9d1d1872afcb016e5a3c438 
>   

[jira] [Created] (HIVE-20569) hour/minute/second UDFs not working on String values with Time format

2018-09-16 Thread Jesus Camacho Rodriguez (JIRA)
Jesus Camacho Rodriguez created HIVE-20569:
--

 Summary: hour/minute/second UDFs not working on String values with 
Time format
 Key: HIVE-20569
 URL: https://issues.apache.org/jira/browse/HIVE-20569
 Project: Hive
  Issue Type: Bug
  Components: UDF
Affects Versions: 4.0.0, 3.2.0
Reporter: Jesus Camacho Rodriguez


We do not have 'TIME' type in Hive, but applying this functions on String 
values with time format used to work before HIVE-12192 was applied, e.g., 
HOUR('15:13:46').

This issue is to extend hour/minute/second to be able to parse time string 
values.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)