[GitHub] [hive] rmsmani commented on issue #540: HIVE-21283 Synonyms for the existing functions

2019-03-25 Thread GitBox
rmsmani commented on issue #540: HIVE-21283 Synonyms for the existing functions
URL: https://github.com/apache/hive/pull/540#issuecomment-476459266
 
 
   Source committed to master,so closing


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hive] rmsmani closed pull request #540: HIVE-21283 Synonyms for the existing functions

2019-03-25 Thread GitBox
rmsmani closed pull request #540: HIVE-21283 Synonyms for the existing functions
URL: https://github.com/apache/hive/pull/540
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: Review Request 70190: HIVE-21316 Varchar cmp

2019-03-25 Thread Vineet Garg

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70190/#review214003
---




ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
Line 816 (original), 836 (patched)


Adding enum interperation for CHAR and going through same path of 
makeHiveUnicodeString for CHAR will make the code more redabled and clear.

ExprNodeDesc visitLiteral(RexLiteral literal) will need to be udpated 
accordingly.



ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
Lines 1442 (patched)


Add a comment explaining why



ql/src/test/results/clientpositive/in_typecheck_varchar.q.out
Line 125 (original)


Strange that this is not being vectorized anymore.


- Vineet Garg


On March 12, 2019, 11:55 a.m., Zoltan Haindrich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70190/
> ---
> 
> (Updated March 12, 2019, 11:55 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-21316
> https://issues.apache.org/jira/browse/HIVE-21316
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> preserver varchar type during/after constant folding
> 
> 
> Diffs
> -
> 
>   itests/src/test/resources/testconfiguration.properties 
> a237745487785bc259ee10ee0989f215ee854572 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ExprNodeConverter.java
>  6dd00189d60e5c01495a5ebd8b64ac339ea59525 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
>  d15c710c5e12ec7c6af0256afab3ba1dd4d6a92e 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 
> a2dd554b6ea00a3769d2d1593e36835433a96d57 
>   ql/src/test/queries/clientpositive/fold_varchar.q PRE-CREATION 
>   ql/src/test/results/clientpositive/in_typecheck_varchar.q.out 
> f51ff29dbac90b8d35ab8cb4007bf17efbf34543 
>   ql/src/test/results/clientpositive/llap/fold_varchar.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/materialized_view_rewrite_6.q.out 
> ee5dfd1e1cfc1b2204f7260626f6c43f1ab2ba88 
>   
> ql/src/test/results/clientpositive/llap/materialized_view_rewrite_no_join_opt.q.out
>  b022ee8ff57c34cc4244bb790e6971a8127fd1b8 
>   ql/src/test/results/clientpositive/llap/vector_case_when_1.q.out 
> 6529758a3a9977154276ba6d8b2dafce922c4d64 
>   ql/src/test/results/clientpositive/vector_case_when_1.q.out 
> 61062e1f8e08306061034c1923d0178a428c6475 
> 
> 
> Diff: https://reviews.apache.org/r/70190/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zoltan Haindrich
> 
>



[jira] [Created] (HIVE-21505) JDBC: Hive jdbc standalone does not have hadoop-common SASL servers

2019-03-25 Thread Gopal V (JIRA)
Gopal V created HIVE-21505:
--

 Summary: JDBC: Hive jdbc standalone does not have hadoop-common 
SASL servers
 Key: HIVE-21505
 URL: https://issues.apache.org/jira/browse/HIVE-21505
 Project: Hive
  Issue Type: Bug
Reporter: Gopal V


Either the detection code should use SASL client classes or the shading should 
include it.

{code}
Caused by: java.lang.NoClassDefFoundError: 
org/apache/hadoop/security/SaslRpcServer
at 
org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge23.(HadoopThriftAuthBridge23.java:66)
at 
org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge.getBridge(HadoopThriftAuthBridge.java:82)
at 
org.apache.hive.service.auth.KerberosSaslHelper.getKerberosTransport(KerberosSaslHelper.java:55)
at 
org.apache.hive.jdbc.HiveConnection.createBinaryTransport(HiveConnection.java:588)
at org.apache.hive.jdbc.HiveConnection.openTransport(HiveConnection.java:337)
at org.apache.hive.jdbc.HiveConnection.(HiveConnection.java:224)
at org.apache.hive.jdbc.HiveDriver.connect(HiveDriver.java:107)
at java.sql.DriverManager.getConnection(DriverManager.java:664)
at java.sql.DriverManager.getConnection(DriverManager.java:270)
at org.notmysock.jdbc.JDBCActor.call(JDBCActor.java:49)
at org.notmysock.jdbc.JDBCActor.call(JDBCActor.java:15)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadP
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HIVE-21504) map data type in hive allows complex data type as map key

2019-03-25 Thread Mounica Annaparthi (JIRA)
Mounica Annaparthi created HIVE-21504:
-

 Summary: map data type in hive allows complex data type as map key
 Key: HIVE-21504
 URL: https://issues.apache.org/jira/browse/HIVE-21504
 Project: Hive
  Issue Type: Bug
  Components: HiveServer2
Reporter: Mounica Annaparthi


Hi,

We are trying to use TypeInfoUtils to validate the data type information of a 
string.

map,string> comes back as data type MAP . I was expecting this to 
give back error as map key should only be a primitive type.

Could you please check and let us know if this is already known issue or this 
is something that has to be fixed.

Thanks!

Mona



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HIVE-21503) Vectorization: query with regex gives incorrect results with vectorization

2019-03-25 Thread Rajesh Balamohan (JIRA)
Rajesh Balamohan created HIVE-21503:
---

 Summary: Vectorization: query with regex gives incorrect results 
with vectorization
 Key: HIVE-21503
 URL: https://issues.apache.org/jira/browse/HIVE-21503
 Project: Hive
  Issue Type: Bug
  Components: Vectorization
Reporter: Rajesh Balamohan


i see wrong results with vectorization. Without vectorization, it works fine. 
Suspecting minor issue in {{StringGroupColConcatCharScalar}}
{noformat}
e.g 

WHEN x like '%radio%' THEN 'radio' 
WHEN x like '%tv%' THEN 'tv'
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HIVE-21501) Invisible views using ODBC

2019-03-25 Thread JIRA
Ernest Jaroń created HIVE-21501:
---

 Summary: Invisible views using ODBC 
 Key: HIVE-21501
 URL: https://issues.apache.org/jira/browse/HIVE-21501
 Project: Hive
  Issue Type: Bug
  Components: Database/Schema, Hive, ODBC, Views
Affects Versions: 3.1.0
Reporter: Ernest Jaroń
 Attachments: jiira.png

Hive show tables command does not list views  - they're invisible when we're 
using ODBC. 
We could operate on this views, for example select records but they're 
invisible on list of data structures. We're connecting with Hive by using 
Hortonworks ODBC Driver for Apache Hive. Any of tools that we're using (Aginity 
for Hadoop, Microsoft Excel, Tableau Desktop) does not list views but only 
tables. This views are visible in HUE.  !jiira.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HIVE-21502) Bumping ZooKeeper Curator dependency

2019-03-25 Thread Peter Vary (JIRA)
Peter Vary created HIVE-21502:
-

 Summary: Bumping ZooKeeper Curator dependency
 Key: HIVE-21502
 URL: https://issues.apache.org/jira/browse/HIVE-21502
 Project: Hive
  Issue Type: Task
Reporter: Peter Vary
Assignee: Peter Vary


Pumping Curator dependency



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HIVE-21500) Support converting managed ACID table to external if the corresponding non-ACID table is converted to external at source.

2019-03-25 Thread Sankar Hariappan (JIRA)
Sankar Hariappan created HIVE-21500:
---

 Summary: Support converting managed ACID table to external if the 
corresponding non-ACID table is converted to external at source.
 Key: HIVE-21500
 URL: https://issues.apache.org/jira/browse/HIVE-21500
 Project: Hive
  Issue Type: Sub-task
Affects Versions: 4.0.0
Reporter: Sankar Hariappan
Assignee: Sankar Hariappan


For the below scenario of Hive2  to Hive3 replication (with strict 
managed=true), the managed ACID table at target should be converted to external 
table.
1. Create non-ACID ORC format table.
2. Insert some rows
3. Replicate this create event which creates ACID table at target (due to 
migration rule). Each insert event adds metadata in HMS corresponding to the 
current table.
4. Convert table to external table using ALTER command.
5. Replicating this alter event should convert ACID table to external table and 
make sure corresponding metadata are removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [hive] ashutosh-bapat opened a new pull request #579: HIVE-21109 : Support stats replication for ACID tables.

2019-03-25 Thread GitBox
ashutosh-bapat opened a new pull request #579: HIVE-21109 : Support stats 
replication for ACID tables.
URL: https://github.com/apache/hive/pull/579
 
 
   During bootstrap we use a method similar to non-ACID tables to transfer 
statistics of an ACID table
   from source to replica. However installing statistics of an ACID table 
requires a valid writeId and
   writeId list. We use the table/partition's latest writeId and a valid 
transaction list containing
   only that writeId to install the statistics in the metastore.
   
   During incremental replication writeId is obtained from the UpdateStats 
event and valid writeId list
   with that writeId marked as valid is used to install the column statistics. 
Table level statistics is
   replicated by replaying corresponding ALTER_TABLE/ALTER_PARTITION event.
   
   Further this commit has following related changes.
   
   1. The table or the partition associated with the commit transaction event 
should have been created
   when replaying corresponding events before commit transaction event. Thus 
there is no need to add
   tasks for creating the table or the partition.
   
   2 Maintain a list of open replicated transactions and use that to create 
valid transactions list
   when replaying a replicated event.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services