[jira] [Created] (HIVE-22924) Optimise VectorGroupByOperator::prepareBatchAggregationBufferSets

2020-02-24 Thread Rajesh Balamohan (Jira)
Rajesh Balamohan created HIVE-22924:
---

 Summary: Optimise 
VectorGroupByOperator::prepareBatchAggregationBufferSets 
 Key: HIVE-22924
 URL: https://issues.apache.org/jira/browse/HIVE-22924
 Project: Hive
  Issue Type: Bug
  Components: Hive
Reporter: Rajesh Balamohan
 Attachments: Screenshot 2020-02-24 at 1.40.02 PM.jpg

{{VectorHashKeyWrapperGeneral::equals}} comparison becomes expensive in 
[https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java#L496]

 

!Screenshot 2020-02-24 at 1.40.02 PM.jpg|width=494,height=328!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72159: StorageBasedAuthorizationProvider does not allow create databases after changing hive.metastore.warehouse.dir

2020-02-24 Thread Oleksiy Sayankin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72159/
---

(Updated Feb. 24, 2020, 1:59 p.m.)


Review request for hive.


Changes
---

Added JUnit test


Repository: hive-git


Description
---

Initial commit


Diffs (updated)
-

  
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/StorageBasedAuthorizationProvider.java
 2a52e8354b 
  
ql/src/test/org/apache/hadoop/hive/ql/security/authorization/TestStorageBasedAuthorizationProviderWarehouse.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/72159/diff/2/

Changes: https://reviews.apache.org/r/72159/diff/1-2/


Testing
---


Thanks,

Oleksiy Sayankin



[jira] [Created] (HIVE-22925) Implement TopNKeyFilter efficiency check

2020-02-24 Thread Attila Magyar (Jira)
Attila Magyar created HIVE-22925:


 Summary: Implement TopNKeyFilter efficiency check
 Key: HIVE-22925
 URL: https://issues.apache.org/jira/browse/HIVE-22925
 Project: Hive
  Issue Type: Bug
  Components: Hive
Reporter: Attila Magyar
Assignee: Attila Magyar
 Fix For: 4.0.0


In certain cases the TopNKey filter might work in an inefficient way and adds 
extra CPU overhead. For example if the rows are coming in an ascending order 
but the filter wants the top N smallest elements the filter will forward 
everything.

Inefficient should be detected in runtime so that the filter can be disabled of 
the ration between forwarder_rows/total_rows is too high.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 71962: HIVE-22699: Fix mask functions not masking numeric 0

2020-02-24 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71962/#review219643
---


Ship it!




Ship It!

- Madhan Neethiraj


On Feb. 18, 2020, 10:48 p.m., Quanlong Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71962/
> ---
> 
> (Updated Feb. 18, 2020, 10:48 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> For numeric value 0 (tinyint, smallint, int, bigint), the mask functions are 
> not masking it correctly. It should be replaced as 'numberChat' if masked.
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMask.java 
> 27c3bf8 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMaskFirstN.java 
> 76ee292 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMaskLastN.java 
> c0c5c61 
>   
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMaskShowFirstN.java
>  a8f70f2 
>   
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMaskShowLastN.java
>  c72d75e 
>   ql/src/test/queries/clientpositive/udf_mask.q 15f7d27 
>   ql/src/test/queries/clientpositive/udf_mask_first_n.q 3cd3962 
>   ql/src/test/queries/clientpositive/udf_mask_last_n.q 89eb05d 
>   ql/src/test/queries/clientpositive/udf_mask_show_first_n.q 1425a82 
>   ql/src/test/queries/clientpositive/udf_mask_show_last_n.q c4d15fb 
>   ql/src/test/results/clientpositive/udf_mask.q.out ed01449 
>   ql/src/test/results/clientpositive/udf_mask_first_n.q.out e33fb42 
>   ql/src/test/results/clientpositive/udf_mask_last_n.q.out 07a254f 
>   ql/src/test/results/clientpositive/udf_mask_show_first_n.q.out 3ec3270 
>   ql/src/test/results/clientpositive/udf_mask_show_last_n.q.out 4dd42fd 
> 
> 
> Diff: https://reviews.apache.org/r/71962/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Quanlong Huang
> 
>



[jira] [Created] (HIVE-22926) Scheduling Repl Dump Task using Hive scheduler

2020-02-24 Thread Aasha Medhi (Jira)
Aasha Medhi created HIVE-22926:
--

 Summary: Scheduling Repl Dump Task using Hive scheduler
 Key: HIVE-22926
 URL: https://issues.apache.org/jira/browse/HIVE-22926
 Project: Hive
  Issue Type: Bug
Reporter: Aasha Medhi
Assignee: Aasha Medhi






--
This message was sent by Atlassian Jira
(v8.3.4#803005)