Re: Review Request 44524: HIVE-11484 : Fix ObjectInspector for Char and VarChar

2016-03-30 Thread Deepak Barr

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44524/
---

(Updated March 30, 2016, 1:43 p.m.)


Review request for hive and Amareshwari Sriramadasu.


Changes
---

Added testcases


Bugs: HIVE-11484
https://issues.apache.org/jira/browse/HIVE-11484


Repository: hive-git


Description
---

Fixed ObjectInspectorConverter and Java ObjectInspector for Char and Varchar


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java 3514726 
  common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java 969d474 
  common/src/test/org/apache/hadoop/hive/common/type/TestHiveBaseChar.java 
2848465 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveCharObjectInspector.java
 f429709 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java
 a8e34ff 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java
 5eb41d5 
  
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestObjectInspectorConverters.java
 dd18517 
  
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java
 7d87666 

Diff: https://reviews.apache.org/r/44524/diff/


Testing
---

Yes.


Thanks,

Deepak Barr



Review Request 44524: HIVE-11484 : Fix ObjectInspector for Char and VarChar

2016-03-08 Thread Deepak Barr

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44524/
---

Review request for hive and Amareshwari Sriramadasu.


Bugs: HIVE-11484
https://issues.apache.org/jira/browse/HIVE-11484


Repository: hive-git


Description
---

Fixed ObjectInspectorConverter and Java ObjectInspector for Char and Varchar


Diffs
-

  common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java 3514726 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveCharObjectInspector.java
 f429709 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java
 a8e34ff 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java
 5eb41d5 

Diff: https://reviews.apache.org/r/44524/diff/


Testing
---

Yes.


Thanks,

Deepak Barr



Review Request 41924: HIVE - 11485 : Session close should not close async SQL operations

2016-01-05 Thread Deepak Barr

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41924/
---

Review request for hive and Amareshwari Sriramadasu.


Bugs: HIVE-11485
https://issues.apache.org/jira/browse/HIVE-11485


Repository: hive-git


Description
---

Removed 3 actions on closing of a hive session  :
1. Closing of operations running on the session.
2. Dropping of the session paths.
3. FileSystem.closeAllForUGI() for the session.


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 5f15557 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 
50c912e 
  
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java
 441db7c 

Diff: https://reviews.apache.org/r/41924/diff/


Testing
---


Thanks,

Deepak Barr