Re: Review Request 46396: Had to escape the slash because statement preparation isn't fully escaping input. There may be other characters that need to be escaped.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46396/ --- (Updated May 3, 2016, 4:04 p.m.) Review request for hive. Bugs: HIVE-13548 https://issues.apache.org/jira/browse/HIVE-13548 Repository: hive-git Description --- Slash is not escaped during prepare statement setString, see HIVE-13548 Diffs - itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 2c85877 jdbc/src/java/org/apache/hive/jdbc/HivePreparedStatement.java 8a0671f Diff: https://reviews.apache.org/r/46396/diff/ Testing --- Thanks, Nasron Cheong
Review Request 46396: Had to escape the slash because statement preparation isn't fully escaping input. There may be other characters that need to be escaped.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46396/ --- Review request for hive. Repository: hive-git Description --- Slash is not escaped during prepare statement setString, see HIVE-13548 Diffs - itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 2c85877 jdbc/src/java/org/apache/hive/jdbc/HivePreparedStatement.java 8a0671f Diff: https://reviews.apache.org/r/46396/diff/ Testing --- Thanks, Nasron Cheong
Problem with QA test on patch
https://issues.apache.org/jira/browse/HIVE-13548 has a patch I submitted, and I see some test failures due to the patch? Although I can't tell how they're related. Thanks. - Nasron
[jira] [Created] (HIVE-13548) hive-jdbc isn't escaping slashes during PreparedStatement
Nasron Cheong created HIVE-13548: Summary: hive-jdbc isn't escaping slashes during PreparedStatement Key: HIVE-13548 URL: https://issues.apache.org/jira/browse/HIVE-13548 Project: Hive Issue Type: Bug Components: JDBC Reporter: Nasron Cheong Assignee: Nasron Cheong Calling setString on a prepared statement with a string containing a '\' will cause the SQL construction to fail. I believe the slash should be escaped by the setString function. There may be other characters that require escaping during the same call. -- This message was sent by Atlassian JIRA (v6.3.4#6332)