[jira] [Commented] (HIVE-2930) Add license to the Hive files
[
https://issues.apache.org/jira/browse/HIVE-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248586#comment-13248586
]
Owen O'Malley commented on HIVE-2930:
-
The files that are copyright by Facebook are:
{code}
service/lib/php/ext/thrift_protocol/config.m4
service/lib/py/thrift/protocol/fastbinary.c
service/lib/py/thrift/reflection/__init__.py
{code}
Add license to the Hive files
-
Key: HIVE-2930
URL: https://issues.apache.org/jira/browse/HIVE-2930
Project: Hive
Issue Type: Improvement
Reporter: Owen O'Malley
Assignee: Owen O'Malley
Priority: Blocker
We need to clean up the RAT report to 0. Apache projects aren't supposed to
release until they have shown that all of their files have proper headers.
Note that although most of the files are just missing headers, some of them
explicitly say copyright by facebook and released under the Thrift (not
Apache) license. I'll generate a list of them, but I'd really appreciate it
if someone from facebook could in verify that they intend to license them to
Apache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2930) Add license to the Hive files
[
https://issues.apache.org/jira/browse/HIVE-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248891#comment-13248891
]
Owen O'Malley commented on HIVE-2930:
-
I ran through the files without headers and found the commit that first added
them and converted it to a jira from the log message. My intent was to show
that all of the files that I was adding headers to had been properly
contributed to the project via the checkbox on jira or the contributor's ICLA.
Here's the list of Jiras that added the files that are currently without
headers:
{code}
HADOOP-3601
HADOOP-4230
HADOOP-4566
HIVE-65
HIVE-82
HIVE-166
HIVE-203
HIVE-251
HIVE-299
HIVE-343
HIVE-382
HIVE-675
HIVE-705
HIVE-713
HIVE-956
HIVE-1003
HIVE-1104
HIVE-1135
HIVE-1163
HIVE-1204
HIVE-1361
HIVE-1405
HIVE-1513
HIVE-1609
HIVE-1616
HIVE-1867
HIVE-1983
HIVE-2011
HIVE-2076
HIVE-2185
HIVE-2244
HIVE-2246 *** contributed by Sohan Jain
HIVE-2441
HIVE-2442
HIVE-2523 (covered by John Sichi's ICLA)
HIVE-2795 (covered by Kevin Wilfong's ICLA)
HIVE-2797
HIVE-2805 (covered by Kevin Wilfong's ICLA)
HIVE-2853 (covered by Kevin Wilfong's ICLA)
HIVE-2866 (covered by Kevin Wilfong's ICLA)
{code}
The only one that doesn't seem covered is HIVE-2246, which was contributed by
Sohan Jain. I'll start a discussion on the dev list rather than continue on in
a jira. *smile*
Add license to the Hive files
-
Key: HIVE-2930
URL: https://issues.apache.org/jira/browse/HIVE-2930
Project: Hive
Issue Type: Improvement
Reporter: Owen O'Malley
Assignee: Owen O'Malley
Priority: Blocker
We need to clean up the RAT report to 0. Apache projects aren't supposed to
release until they have shown that all of their files have proper headers.
Note that although most of the files are just missing headers, some of them
explicitly say copyright by facebook and released under the Thrift (not
Apache) license. I'll generate a list of them, but I'd really appreciate it
if someone from facebook could in verify that they intend to license them to
Apache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2879) Add rat target to build to look for missing license headers
[ https://issues.apache.org/jira/browse/HIVE-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233026#comment-13233026 ] Owen O'Malley commented on HIVE-2879: - I got the exclude patterns so that there are only 81 files being reported, most of which look like files that should have the header. Add rat target to build to look for missing license headers - Key: HIVE-2879 URL: https://issues.apache.org/jira/browse/HIVE-2879 Project: Hive Issue Type: Improvement Components: Build Infrastructure Reporter: Owen O'Malley Assignee: Owen O'Malley Attachments: HIVE-2879.D2373.1.patch We should have a rat target that can generate an Apache RAT report. RAT is used for finding missing license headers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2835) Change default configuration for hive.exec.dynamic.partition
[ https://issues.apache.org/jira/browse/HIVE-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226300#comment-13226300 ] Owen O'Malley commented on HIVE-2835: - Thanks for catching the problem, Ed. I uploaded a new patch although clearly you already have the fixed patch. Change default configuration for hive.exec.dynamic.partition Key: HIVE-2835 URL: https://issues.apache.org/jira/browse/HIVE-2835 Project: Hive Issue Type: Improvement Reporter: Owen O'Malley Assignee: Owen O'Malley Attachments: HIVE-2835.D2157.1.patch, HIVE-2835.D2157.2.patch I think we should enable dynamic partitions by default. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2841) Fix javadoc warnings
[ https://issues.apache.org/jira/browse/HIVE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13224734#comment-13224734 ] Owen O'Malley commented on HIVE-2841: - Sure, but because I've filed an ICLA anything I share on the Apache lists defaults to usable. Fix javadoc warnings Key: HIVE-2841 URL: https://issues.apache.org/jira/browse/HIVE-2841 Project: Hive Issue Type: Improvement Reporter: Owen O'Malley Assignee: Owen O'Malley Fix For: 0.9.0 Attachments: HIVE-2841.D2139.1.patch, h-2841.patch We currently have 219 warnings out of Javadoc and I'd like to fix them all. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
