[jira] [Created] (HIVE-14290) Refactor HIVE-14054 to use Collections#newSetFromMap
Peter Slawski created HIVE-14290: Summary: Refactor HIVE-14054 to use Collections#newSetFromMap Key: HIVE-14290 URL: https://issues.apache.org/jira/browse/HIVE-14290 Project: Hive Issue Type: Improvement Components: Metastore Affects Versions: 2.1.0 Reporter: Peter Slawski Assignee: Peter Slawski Priority: Trivial There is a minor refactor that can be made to HiveMetaStoreChecker so that it cleanly creates and uses a set that is backed by a Map implementation. In this case, the underlying Map implementation is ConcurrentHashMap. This refactor will help prevent issues such as the one reported in HIVE-14054. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-14288) Suppress 'which: no hbase' error message outputted from hive cli
Peter Slawski created HIVE-14288: Summary: Suppress 'which: no hbase' error message outputted from hive cli Key: HIVE-14288 URL: https://issues.apache.org/jira/browse/HIVE-14288 Project: Hive Issue Type: Bug Components: CLI Affects Versions: 2.1.0 Reporter: Peter Slawski Assignee: Peter Slawski Priority: Minor There is an error message that is always outputted from the Hive CLI when HBase is not install. This was introduced in HIVE-12058 which had the intention of removing suppression of such error messages for HBase related logic as it made it harder to debug. However, if HBase is not being used or intentionally not installed, then always printing the same error message does not make sense. {code} $ hive which: no hbase in (/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin) {code} To compromise, we could add a --verbose parameter to the Hive CLI to allow such information to be printed out for debugging purposes. But, by default, this error message would be suppressed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-13699) Make JavaDataModel#get thread safe for parallel compilation
Peter Slawski created HIVE-13699: Summary: Make JavaDataModel#get thread safe for parallel compilation Key: HIVE-13699 URL: https://issues.apache.org/jira/browse/HIVE-13699 Project: Hive Issue Type: Bug Components: HiveServer2, storage-api Affects Versions: 2.0.0 Reporter: Peter Slawski Assignee: Peter Slawski Priority: Minor The class JavaDataModel has a static method, #get, that is not thread safe. This may be an issue when parallel query compilation is enabled because two threads may attempt to call JavaDataModel#get at the same time, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-13512) Make initializing dag ids in TezWork thread safe for parallel compilation
Peter Slawski created HIVE-13512: Summary: Make initializing dag ids in TezWork thread safe for parallel compilation Key: HIVE-13512 URL: https://issues.apache.org/jira/browse/HIVE-13512 Project: Hive Issue Type: Bug Components: HiveServer2, Query Planning Affects Versions: 2.0.0 Reporter: Peter Slawski Assignee: Peter Slawski Priority: Minor When parallel query compilation is enabled, it is possible for concurrent running threads to create TezWork objects that have the same dag id. This is because the counter used to obtain the next dag id is not thread safe. The counter should be an AtomicInteger rather than an int. {code:java} private static int counter; ... public TezWork(String queryId, Configuration conf) { this.dagId = queryId + ":" + (++counter); ... } {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-10538) Fix NPE in FileSinkOperator from hashcode mismatch
Peter Slawski created HIVE-10538: Summary: Fix NPE in FileSinkOperator from hashcode mismatch Key: HIVE-10538 URL: https://issues.apache.org/jira/browse/HIVE-10538 Project: Hive Issue Type: Bug Components: Query Processor Affects Versions: 1.0.0, 1.2.0 Reporter: Peter Slawski A Null Pointer Exception occurs when in FileSinkOperator when using bucketed tables and distribute by with multiFileSpray enabled. The following snippet query reproduces this issue: {code} set hive.enforce.bucketing = true; set hive.exec.reducers.max = 20; create table bucket_a(key int, value_a string) clustered by (key) into 256 buckets; create table bucket_b(key int, value_b string) clustered by (key) into 256 buckets; create table bucket_ab(key int, value_a string, value_b string) clustered by (key) into 256 buckets; -- Insert data into bucket_a and bucket_b insert overwrite table bucket_ab select a.key, a.value_a, b.value_b from bucket_a a join bucket_b b on (a.key = b.key) distribute by key; {code} The following stack trace is logged. {code} 2015-04-29 12:54:12,841 FATAL [pool-110-thread-1]: ExecReducer (ExecReducer.java:reduce(255)) - org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while processing row (tag=0) {key:{},value:{_col0:113,_col1:val_113}} at org.apache.hadoop.hive.ql.exec.mr.ExecReducer.reduce(ExecReducer.java:244) at org.apache.hadoop.mapred.ReduceTask.runOldReducer(ReduceTask.java:444) at org.apache.hadoop.mapred.ReduceTask.run(ReduceTask.java:392) at org.apache.hadoop.mapred.LocalJobRunner$Job$ReduceTaskRunnable.run(LocalJobRunner.java:319) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) Caused by: java.lang.NullPointerException at org.apache.hadoop.hive.ql.exec.FileSinkOperator.findWriterOffset(FileSinkOperator.java:819) at org.apache.hadoop.hive.ql.exec.FileSinkOperator.process(FileSinkOperator.java:747) at org.apache.hadoop.hive.ql.exec.Operator.forward(Operator.java:837) at org.apache.hadoop.hive.ql.exec.SelectOperator.process(SelectOperator.java:88) at org.apache.hadoop.hive.ql.exec.mr.ExecReducer.reduce(ExecReducer.java:235) ... 8 more {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9148) Fix default value for HWI_WAR_FILE
[ https://issues.apache.org/jira/browse/HIVE-9148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14251912#comment-14251912 ] Peter Slawski commented on HIVE-9148: - No, the description is correct as *hive.hwi.war.file* is assumed to be relative to *$HIVE_HOME* in HWIServer.java. *$HWI_WAR_FILE* is being set wrongly in [hwi.sh|https://github.com/apache/hive/blob/b8250ac2f30539f6b23ce80a20a9e338d3d31458/bin/ext/hwi.sh#L29]. So if you didn't overwrote *hive.hwi.war.file* in hive-site.xml, the path to the HWI war file would be wrong. From [hwi/src/java/org/apache/hadoop/hive/hwi/HWIServer.java:77|https://github.com/apache/hive/blob/release-0.14.0/hwi/src/java/org/apache/hadoop/hive/hwi/HWIServer.java#L77] {code:java} String hwiWAR = conf.getVar(HiveConf.ConfVars.HIVEHWIWARFILE); String hivehome = System.getenv().get(HIVE_HOME); File hwiWARFile = new File(hivehome, hwiWAR); {code} Fix default value for HWI_WAR_FILE -- Key: HIVE-9148 URL: https://issues.apache.org/jira/browse/HIVE-9148 Project: Hive Issue Type: Bug Components: Web UI Affects Versions: 0.14.0, 0.13.1 Reporter: Peter Slawski Priority: Minor Fix For: 0.15.0 Attachments: HIVE-9148.1.patch The path to the hwi war file should be relative to hive home. However, HWI_WAR_FILE is set in hwi.sh to be an absolute path. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-9147) Add unit test for HIVE-7323
Peter Slawski created HIVE-9147: --- Summary: Add unit test for HIVE-7323 Key: HIVE-9147 URL: https://issues.apache.org/jira/browse/HIVE-9147 Project: Hive Issue Type: Test Components: Statistics Affects Versions: 0.13.1, 0.14.0 Reporter: Peter Slawski Priority: Minor This unit test verifies that DateStatisticImpl doesn't store mutable objects from callers for minimum and maximum values. This ensures callers cannot modify the internal minimum and maximum values outside of DateStatisticImpl. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-9147) Add unit test for HIVE-7323
[ https://issues.apache.org/jira/browse/HIVE-9147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Slawski updated HIVE-9147: Attachment: HIVE-9147.1.patch Add unit test for HIVE-7323 --- Key: HIVE-9147 URL: https://issues.apache.org/jira/browse/HIVE-9147 Project: Hive Issue Type: Test Components: Statistics Affects Versions: 0.14.0, 0.13.1 Reporter: Peter Slawski Priority: Minor Attachments: HIVE-9147.1.patch This unit test verifies that DateStatisticImpl doesn't store mutable objects from callers for minimum and maximum values. This ensures callers cannot modify the internal minimum and maximum values outside of DateStatisticImpl. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-9147) Add unit test for HIVE-7323
[ https://issues.apache.org/jira/browse/HIVE-9147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Slawski updated HIVE-9147: Fix Version/s: 0.15.0 Status: Patch Available (was: Open) Attached patch for unit test. Add unit test for HIVE-7323 --- Key: HIVE-9147 URL: https://issues.apache.org/jira/browse/HIVE-9147 Project: Hive Issue Type: Test Components: Statistics Affects Versions: 0.13.1, 0.14.0 Reporter: Peter Slawski Priority: Minor Fix For: 0.15.0 Attachments: HIVE-9147.1.patch This unit test verifies that DateStatisticImpl doesn't store mutable objects from callers for minimum and maximum values. This ensures callers cannot modify the internal minimum and maximum values outside of DateStatisticImpl. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-9148) Fix default value for HWI_WAR_FILE
Peter Slawski created HIVE-9148: --- Summary: Fix default value for HWI_WAR_FILE Key: HIVE-9148 URL: https://issues.apache.org/jira/browse/HIVE-9148 Project: Hive Issue Type: Bug Components: Web UI Affects Versions: 0.13.1, 0.14.0 Reporter: Peter Slawski Priority: Minor The path to the hwi war file should be relative to hive home. However, HWI_WAR_FILE is set in hwi.sh to be an absolute path. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-9148) Fix default value for HWI_WAR_FILE
[ https://issues.apache.org/jira/browse/HIVE-9148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Slawski updated HIVE-9148: Attachment: HIVE-9148.1.patch Fix default value for HWI_WAR_FILE -- Key: HIVE-9148 URL: https://issues.apache.org/jira/browse/HIVE-9148 Project: Hive Issue Type: Bug Components: Web UI Affects Versions: 0.14.0, 0.13.1 Reporter: Peter Slawski Priority: Minor Attachments: HIVE-9148.1.patch The path to the hwi war file should be relative to hive home. However, HWI_WAR_FILE is set in hwi.sh to be an absolute path. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-9148) Fix default value for HWI_WAR_FILE
[ https://issues.apache.org/jira/browse/HIVE-9148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Slawski updated HIVE-9148: Fix Version/s: 0.15.0 Status: Patch Available (was: Open) Fix default value for HWI_WAR_FILE -- Key: HIVE-9148 URL: https://issues.apache.org/jira/browse/HIVE-9148 Project: Hive Issue Type: Bug Components: Web UI Affects Versions: 0.13.1, 0.14.0 Reporter: Peter Slawski Priority: Minor Fix For: 0.15.0 Attachments: HIVE-9148.1.patch The path to the hwi war file should be relative to hive home. However, HWI_WAR_FILE is set in hwi.sh to be an absolute path. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8525) Add jasper-compiler-jdt runtime dependency to hwi
[ https://issues.apache.org/jira/browse/HIVE-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Slawski updated HIVE-8525: Attachment: HIVE-8525.1.patch Add jasper-compiler-jdt runtime dependency to hwi - Key: HIVE-8525 URL: https://issues.apache.org/jira/browse/HIVE-8525 Project: Hive Issue Type: Bug Components: Web UI Affects Versions: 0.13.1 Reporter: Peter Slawski Attachments: HIVE-8525.1.patch Without the jasper-compiler-jdt*.jar in hive/lib, the HWI service cannot compile jsp files. I've also noticed that this is mentioned in HIVE-5132 and HIVE-6912 in order to get HWI working. But, no code change or documentation were made in light of this. It seems reasonable to include jasper-compiler-jdt as a dependency in hwi/pom.xml. Are there any reasons not to do so? -- I had to do the following to reproduce this error: 1. Generate war file (HIVE-8400) 2. Fix bin/ext/hwi.sh script to make HWI_WAR_FILE be relative to HIVE_HOME 3. Run `hive --service hwi` 4. Go to http://localhost:/hwi/ 5. A 500 Error appears: {code} HTTP ERROR 500 Problem accessing /hwi/. Reason: Unable to find a javac compiler; com.sun.tools.javac.Main is not on the classpath. Perhaps JAVA_HOME does not point to the JDK. It is currently set to /usr/java/jdk1.7.0_65/jre Caused by: Unable to find a javac compiler; com.sun.tools.javac.Main is not on the classpath. Perhaps JAVA_HOME does not point to the JDK. It is currently set to /usr/java/jdk1.7.0_65/jre at org.apache.tools.ant.taskdefs.compilers.CompilerAdapterFactory.getCompiler(CompilerAdapterFactory.java:129) at org.apache.tools.ant.taskdefs.Javac.findSupportedFileExtensions(Javac.java:979) at org.apache.tools.ant.taskdefs.Javac.scanDir(Javac.java:956) at org.apache.tools.ant.taskdefs.Javac.execute(Javac.java:927) at org.apache.jasper.compiler.AntCompiler.generateClass(AntCompiler.java:220) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:298) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:277) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:265) at org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:564) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:299) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450) at org.mortbay.jetty.servlet.Dispatcher.forward(Dispatcher.java:327) at org.mortbay.jetty.servlet.Dispatcher.forward(Dispatcher.java:126) at org.mortbay.jetty.servlet.DefaultServlet.doGet(DefaultServlet.java:503) at javax.servlet.http.HttpServlet.service(HttpServlet.java:707) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.handler.RequestLogHandler.handle(RequestLogHandler.java:49) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.Server.handle(Server.java:326) at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542) at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928) at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549) at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212) at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404) at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228) at
[jira] [Updated] (HIVE-8525) Add jasper-compiler-jdt runtime dependency to hwi
[ https://issues.apache.org/jira/browse/HIVE-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Slawski updated HIVE-8525: Status: Patch Available (was: Open) Add jasper-compiler-jdt runtime dependency to hwi - Key: HIVE-8525 URL: https://issues.apache.org/jira/browse/HIVE-8525 Project: Hive Issue Type: Bug Components: Web UI Affects Versions: 0.13.1 Reporter: Peter Slawski Attachments: HIVE-8525.1.patch Without the jasper-compiler-jdt*.jar in hive/lib, the HWI service cannot compile jsp files. I've also noticed that this is mentioned in HIVE-5132 and HIVE-6912 in order to get HWI working. But, no code change or documentation were made in light of this. It seems reasonable to include jasper-compiler-jdt as a dependency in hwi/pom.xml. Are there any reasons not to do so? -- I had to do the following to reproduce this error: 1. Generate war file (HIVE-8400) 2. Fix bin/ext/hwi.sh script to make HWI_WAR_FILE be relative to HIVE_HOME 3. Run `hive --service hwi` 4. Go to http://localhost:/hwi/ 5. A 500 Error appears: {code} HTTP ERROR 500 Problem accessing /hwi/. Reason: Unable to find a javac compiler; com.sun.tools.javac.Main is not on the classpath. Perhaps JAVA_HOME does not point to the JDK. It is currently set to /usr/java/jdk1.7.0_65/jre Caused by: Unable to find a javac compiler; com.sun.tools.javac.Main is not on the classpath. Perhaps JAVA_HOME does not point to the JDK. It is currently set to /usr/java/jdk1.7.0_65/jre at org.apache.tools.ant.taskdefs.compilers.CompilerAdapterFactory.getCompiler(CompilerAdapterFactory.java:129) at org.apache.tools.ant.taskdefs.Javac.findSupportedFileExtensions(Javac.java:979) at org.apache.tools.ant.taskdefs.Javac.scanDir(Javac.java:956) at org.apache.tools.ant.taskdefs.Javac.execute(Javac.java:927) at org.apache.jasper.compiler.AntCompiler.generateClass(AntCompiler.java:220) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:298) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:277) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:265) at org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:564) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:299) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450) at org.mortbay.jetty.servlet.Dispatcher.forward(Dispatcher.java:327) at org.mortbay.jetty.servlet.Dispatcher.forward(Dispatcher.java:126) at org.mortbay.jetty.servlet.DefaultServlet.doGet(DefaultServlet.java:503) at javax.servlet.http.HttpServlet.service(HttpServlet.java:707) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.handler.RequestLogHandler.handle(RequestLogHandler.java:49) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.Server.handle(Server.java:326) at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542) at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928) at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549) at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212) at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404) at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228) at
[jira] [Updated] (HIVE-8400) Fix building and packaging hwi war file
[ https://issues.apache.org/jira/browse/HIVE-8400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Slawski updated HIVE-8400: Summary: Fix building and packaging hwi war file (was: hwi does not have war file) Fix building and packaging hwi war file --- Key: HIVE-8400 URL: https://issues.apache.org/jira/browse/HIVE-8400 Project: Hive Issue Type: Bug Components: Web UI Affects Versions: 0.13.1 Reporter: Pankit Thapar Fix For: 0.14.0 Attachments: HIVE-8400.1.patch hive 0.11 used to have hwi-0.11.war file but it seems that hive 13 is not configured to build a war file, instead it builds a jar file for hwi. A fix for this would be to change jar to war in hwi/pom.xml. Diff is below : diff --git a/hwi/pom.xml b/hwi/pom.xml index 35c124b..88d83fb 100644 --- a/hwi/pom.xml +++ b/hwi/pom.xml @@ -24,7 +24,7 @@ /parent artifactIdhive-hwi/artifactId - packagingjar/packaging + packagingwar/packaging nameHive HWI/name Please let me know if jar was intended or is it actually a bug so that I can submit a patch for the fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8400) Fix building and packaging hwi war file
[ https://issues.apache.org/jira/browse/HIVE-8400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Slawski updated HIVE-8400: Attachment: HIVE-8400.1.patch Fix building and packaging hwi war file --- Key: HIVE-8400 URL: https://issues.apache.org/jira/browse/HIVE-8400 Project: Hive Issue Type: Bug Components: Web UI Affects Versions: 0.13.1 Reporter: Pankit Thapar Fix For: 0.14.0 Attachments: HIVE-8400.1.patch hive 0.11 used to have hwi-0.11.war file but it seems that hive 13 is not configured to build a war file, instead it builds a jar file for hwi. A fix for this would be to change jar to war in hwi/pom.xml. Diff is below : diff --git a/hwi/pom.xml b/hwi/pom.xml index 35c124b..88d83fb 100644 --- a/hwi/pom.xml +++ b/hwi/pom.xml @@ -24,7 +24,7 @@ /parent artifactIdhive-hwi/artifactId - packagingjar/packaging + packagingwar/packaging nameHive HWI/name Please let me know if jar was intended or is it actually a bug so that I can submit a patch for the fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8400) Fix building and packaging hwi war file
[ https://issues.apache.org/jira/browse/HIVE-8400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Slawski updated HIVE-8400: Status: Patch Available (was: Open) This patch fixes this issue by modifying the pom.xml files for hwi and packaging modules. The hwi jar file is still built and packaged but instead under the 'classes' maven classifier. Fix building and packaging hwi war file --- Key: HIVE-8400 URL: https://issues.apache.org/jira/browse/HIVE-8400 Project: Hive Issue Type: Bug Components: Web UI Affects Versions: 0.13.1 Reporter: Pankit Thapar Fix For: 0.14.0 Attachments: HIVE-8400.1.patch hive 0.11 used to have hwi-0.11.war file but it seems that hive 13 is not configured to build a war file, instead it builds a jar file for hwi. A fix for this would be to change jar to war in hwi/pom.xml. Diff is below : diff --git a/hwi/pom.xml b/hwi/pom.xml index 35c124b..88d83fb 100644 --- a/hwi/pom.xml +++ b/hwi/pom.xml @@ -24,7 +24,7 @@ /parent artifactIdhive-hwi/artifactId - packagingjar/packaging + packagingwar/packaging nameHive HWI/name Please let me know if jar was intended or is it actually a bug so that I can submit a patch for the fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-8525) Missing runtime dependency for HWI: japser-compiler-jdt
Peter Slawski created HIVE-8525: --- Summary: Missing runtime dependency for HWI: japser-compiler-jdt Key: HIVE-8525 URL: https://issues.apache.org/jira/browse/HIVE-8525 Project: Hive Issue Type: Bug Components: Web UI Affects Versions: 0.13.1 Reporter: Peter Slawski Without the jasper-compiler-jdt*.jar in hive/lib, the HWI service cannot compile jsp files. I've also noticed that this is mentioned in HIVE-5132 and HIVE-6912 in order to get HWI working. But, no code change or documentation were made in light of this. It seems reasonable to include jasper-compiler-jdt as a dependency in hwi/pom.xml. Are there any reasons not to do so? -- I had to do the following to reproduce this error: 1. Generate war file (HIVE-8400) 2. Fix bin/ext/hwi.sh script to correct the paths of HWI_JAR_FILE and HWI_WAR_FILE. 3. Run `hive --service hwi` 4. Go to http://localhost:/hwi/ 5. A 500 Error appears: {code} HTTP ERROR 500 Problem accessing /hwi/. Reason: Unable to find a javac compiler; com.sun.tools.javac.Main is not on the classpath. Perhaps JAVA_HOME does not point to the JDK. It is currently set to /usr/java/jdk1.7.0_65/jre Caused by: Unable to find a javac compiler; com.sun.tools.javac.Main is not on the classpath. Perhaps JAVA_HOME does not point to the JDK. It is currently set to /usr/java/jdk1.7.0_65/jre at org.apache.tools.ant.taskdefs.compilers.CompilerAdapterFactory.getCompiler(CompilerAdapterFactory.java:129) at org.apache.tools.ant.taskdefs.Javac.findSupportedFileExtensions(Javac.java:979) at org.apache.tools.ant.taskdefs.Javac.scanDir(Javac.java:956) at org.apache.tools.ant.taskdefs.Javac.execute(Javac.java:927) at org.apache.jasper.compiler.AntCompiler.generateClass(AntCompiler.java:220) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:298) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:277) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:265) at org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:564) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:299) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450) at org.mortbay.jetty.servlet.Dispatcher.forward(Dispatcher.java:327) at org.mortbay.jetty.servlet.Dispatcher.forward(Dispatcher.java:126) at org.mortbay.jetty.servlet.DefaultServlet.doGet(DefaultServlet.java:503) at javax.servlet.http.HttpServlet.service(HttpServlet.java:707) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.handler.RequestLogHandler.handle(RequestLogHandler.java:49) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.Server.handle(Server.java:326) at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542) at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928) at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549) at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212) at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404) at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228) at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582) {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8525) Missing runtime dependency for HWI: japser-compiler-jdt
[ https://issues.apache.org/jira/browse/HIVE-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Slawski updated HIVE-8525: Description: Without the jasper-compiler-jdt*.jar in hive/lib, the HWI service cannot compile jsp files. I've also noticed that this is mentioned in HIVE-5132 and HIVE-6912 in order to get HWI working. But, no code change or documentation were made in light of this. It seems reasonable to include jasper-compiler-jdt as a dependency in hwi/pom.xml. Are there any reasons not to do so? -- I had to do the following to reproduce this error: 1. Generate war file (HIVE-8400) 2. Fix bin/ext/hwi.sh script to make HWI_WAR_FILE be relative to HIVE_HOME 3. Run `hive --service hwi` 4. Go to http://localhost:/hwi/ 5. A 500 Error appears: {code} HTTP ERROR 500 Problem accessing /hwi/. Reason: Unable to find a javac compiler; com.sun.tools.javac.Main is not on the classpath. Perhaps JAVA_HOME does not point to the JDK. It is currently set to /usr/java/jdk1.7.0_65/jre Caused by: Unable to find a javac compiler; com.sun.tools.javac.Main is not on the classpath. Perhaps JAVA_HOME does not point to the JDK. It is currently set to /usr/java/jdk1.7.0_65/jre at org.apache.tools.ant.taskdefs.compilers.CompilerAdapterFactory.getCompiler(CompilerAdapterFactory.java:129) at org.apache.tools.ant.taskdefs.Javac.findSupportedFileExtensions(Javac.java:979) at org.apache.tools.ant.taskdefs.Javac.scanDir(Javac.java:956) at org.apache.tools.ant.taskdefs.Javac.execute(Javac.java:927) at org.apache.jasper.compiler.AntCompiler.generateClass(AntCompiler.java:220) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:298) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:277) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:265) at org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:564) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:299) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450) at org.mortbay.jetty.servlet.Dispatcher.forward(Dispatcher.java:327) at org.mortbay.jetty.servlet.Dispatcher.forward(Dispatcher.java:126) at org.mortbay.jetty.servlet.DefaultServlet.doGet(DefaultServlet.java:503) at javax.servlet.http.HttpServlet.service(HttpServlet.java:707) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.handler.RequestLogHandler.handle(RequestLogHandler.java:49) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.Server.handle(Server.java:326) at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542) at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928) at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549) at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212) at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404) at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228) at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582) {code} was: Without the jasper-compiler-jdt*.jar in hive/lib, the HWI service cannot compile jsp files. I've also noticed that this is mentioned in HIVE-5132 and HIVE-6912 in order to get HWI working. But, no code change or documentation were made in light of this. It seems reasonable to include jasper-compiler-jdt as a
[jira] [Updated] (HIVE-8525) Add jasper-compiler-jdt runtime dependency to hwi
[ https://issues.apache.org/jira/browse/HIVE-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Slawski updated HIVE-8525: Summary: Add jasper-compiler-jdt runtime dependency to hwi (was: Missing runtime dependency for HWI: japser-compiler-jdt) Add jasper-compiler-jdt runtime dependency to hwi - Key: HIVE-8525 URL: https://issues.apache.org/jira/browse/HIVE-8525 Project: Hive Issue Type: Bug Components: Web UI Affects Versions: 0.13.1 Reporter: Peter Slawski Without the jasper-compiler-jdt*.jar in hive/lib, the HWI service cannot compile jsp files. I've also noticed that this is mentioned in HIVE-5132 and HIVE-6912 in order to get HWI working. But, no code change or documentation were made in light of this. It seems reasonable to include jasper-compiler-jdt as a dependency in hwi/pom.xml. Are there any reasons not to do so? -- I had to do the following to reproduce this error: 1. Generate war file (HIVE-8400) 2. Fix bin/ext/hwi.sh script to make HWI_WAR_FILE be relative to HIVE_HOME 3. Run `hive --service hwi` 4. Go to http://localhost:/hwi/ 5. A 500 Error appears: {code} HTTP ERROR 500 Problem accessing /hwi/. Reason: Unable to find a javac compiler; com.sun.tools.javac.Main is not on the classpath. Perhaps JAVA_HOME does not point to the JDK. It is currently set to /usr/java/jdk1.7.0_65/jre Caused by: Unable to find a javac compiler; com.sun.tools.javac.Main is not on the classpath. Perhaps JAVA_HOME does not point to the JDK. It is currently set to /usr/java/jdk1.7.0_65/jre at org.apache.tools.ant.taskdefs.compilers.CompilerAdapterFactory.getCompiler(CompilerAdapterFactory.java:129) at org.apache.tools.ant.taskdefs.Javac.findSupportedFileExtensions(Javac.java:979) at org.apache.tools.ant.taskdefs.Javac.scanDir(Javac.java:956) at org.apache.tools.ant.taskdefs.Javac.execute(Javac.java:927) at org.apache.jasper.compiler.AntCompiler.generateClass(AntCompiler.java:220) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:298) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:277) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:265) at org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:564) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:299) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450) at org.mortbay.jetty.servlet.Dispatcher.forward(Dispatcher.java:327) at org.mortbay.jetty.servlet.Dispatcher.forward(Dispatcher.java:126) at org.mortbay.jetty.servlet.DefaultServlet.doGet(DefaultServlet.java:503) at javax.servlet.http.HttpServlet.service(HttpServlet.java:707) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.handler.RequestLogHandler.handle(RequestLogHandler.java:49) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.Server.handle(Server.java:326) at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542) at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928) at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549) at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212) at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404) at