[jira] [Commented] (HIVE-8090) Potential null pointer reference in WriterImpl#StreamFactory#createStream()
[
https://issues.apache.org/jira/browse/HIVE-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14134475#comment-14134475
]
Rahul Palamuttam commented on HIVE-8090:
Thanks Gopal.
I will send an email to dev-subscr...@hive.apache.org
Potential null pointer reference in WriterImpl#StreamFactory#createStream()
---
Key: HIVE-8090
URL: https://issues.apache.org/jira/browse/HIVE-8090
Project: Hive
Issue Type: Bug
Affects Versions: 0.14.0
Reporter: Ted Yu
Priority: Minor
Attachments: HIVE-8090.1.patch, HIVE-8090.2.patch, HIVE-8090.3.patch,
HIVE-8090.4.patch
{code}
switch (kind) {
...
default:
modifiers = null;
break;
}
BufferedStream result = streams.get(name);
if (result == null) {
result = new BufferedStream(name.toString(), bufferSize,
codec == null ? codec : codec.modify(modifiers));
{code}
In case modifiers is null and codec is ZlibCodec, there would be NPE in
ZlibCodec#modify(EnumSetModifier modifiers) :
{code}
for (Modifier m : modifiers) {
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8090) Potential null pointer reference in WriterImpl#StreamFactory#createStream()
[
https://issues.apache.org/jira/browse/HIVE-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rahul Palamuttam updated HIVE-8090:
---
Status: Patch Available (was: Open)
Potential null pointer reference in WriterImpl#StreamFactory#createStream()
---
Key: HIVE-8090
URL: https://issues.apache.org/jira/browse/HIVE-8090
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
{code}
switch (kind) {
...
default:
modifiers = null;
break;
}
BufferedStream result = streams.get(name);
if (result == null) {
result = new BufferedStream(name.toString(), bufferSize,
codec == null ? codec : codec.modify(modifiers));
{code}
In case modifiers is null and codec is ZlibCodec, there would be NPE in
ZlibCodec#modify(EnumSetModifier modifiers) :
{code}
for (Modifier m : modifiers) {
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-8090) Potential null pointer reference in WriterImpl#StreamFactory#createStream()
[
https://issues.apache.org/jira/browse/HIVE-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14133124#comment-14133124
]
Rahul Palamuttam commented on HIVE-8090:
Please ignore that patch
Potential null pointer reference in WriterImpl#StreamFactory#createStream()
---
Key: HIVE-8090
URL: https://issues.apache.org/jira/browse/HIVE-8090
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
{code}
switch (kind) {
...
default:
modifiers = null;
break;
}
BufferedStream result = streams.get(name);
if (result == null) {
result = new BufferedStream(name.toString(), bufferSize,
codec == null ? codec : codec.modify(modifiers));
{code}
In case modifiers is null and codec is ZlibCodec, there would be NPE in
ZlibCodec#modify(EnumSetModifier modifiers) :
{code}
for (Modifier m : modifiers) {
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8090) Potential null pointer reference in WriterImpl#StreamFactory#createStream()
[
https://issues.apache.org/jira/browse/HIVE-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rahul Palamuttam updated HIVE-8090:
---
Attachment: HIVE-8090.1.patch
A new boolean variable is introduced which checks if the codec is null or of
type ZlibCodec. This is substituted in place of the evaluated expression for
the boolean operator. Anymore conditionals for this to this parameter should be
updated to the new boolean variable.
Potential null pointer reference in WriterImpl#StreamFactory#createStream()
---
Key: HIVE-8090
URL: https://issues.apache.org/jira/browse/HIVE-8090
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Attachments: HIVE-8090.1.patch
{code}
switch (kind) {
...
default:
modifiers = null;
break;
}
BufferedStream result = streams.get(name);
if (result == null) {
result = new BufferedStream(name.toString(), bufferSize,
codec == null ? codec : codec.modify(modifiers));
{code}
In case modifiers is null and codec is ZlibCodec, there would be NPE in
ZlibCodec#modify(EnumSetModifier modifiers) :
{code}
for (Modifier m : modifiers) {
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8090) Potential null pointer reference in WriterImpl#StreamFactory#createStream()
[
https://issues.apache.org/jira/browse/HIVE-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rahul Palamuttam updated HIVE-8090:
---
Attachment: HIVE-8090.2.patch
Potential null pointer reference in WriterImpl#StreamFactory#createStream()
---
Key: HIVE-8090
URL: https://issues.apache.org/jira/browse/HIVE-8090
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Attachments: HIVE-8090.1.patch, HIVE-8090.2.patch
{code}
switch (kind) {
...
default:
modifiers = null;
break;
}
BufferedStream result = streams.get(name);
if (result == null) {
result = new BufferedStream(name.toString(), bufferSize,
codec == null ? codec : codec.modify(modifiers));
{code}
In case modifiers is null and codec is ZlibCodec, there would be NPE in
ZlibCodec#modify(EnumSetModifier modifiers) :
{code}
for (Modifier m : modifiers) {
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-8090) Potential null pointer reference in WriterImpl#StreamFactory#createStream()
[
https://issues.apache.org/jira/browse/HIVE-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14133360#comment-14133360
]
Rahul Palamuttam commented on HIVE-8090:
My apologies on the previous patch - a bit embarrassing. This one should be
fine.
Potential null pointer reference in WriterImpl#StreamFactory#createStream()
---
Key: HIVE-8090
URL: https://issues.apache.org/jira/browse/HIVE-8090
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Attachments: HIVE-8090.1.patch, HIVE-8090.2.patch
{code}
switch (kind) {
...
default:
modifiers = null;
break;
}
BufferedStream result = streams.get(name);
if (result == null) {
result = new BufferedStream(name.toString(), bufferSize,
codec == null ? codec : codec.modify(modifiers));
{code}
In case modifiers is null and codec is ZlibCodec, there would be NPE in
ZlibCodec#modify(EnumSetModifier modifiers) :
{code}
for (Modifier m : modifiers) {
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-8090) Potential null pointer reference in WriterImpl#StreamFactory#createStream()
[
https://issues.apache.org/jira/browse/HIVE-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14133363#comment-14133363
]
Rahul Palamuttam commented on HIVE-8090:
Waiting for code review
Potential null pointer reference in WriterImpl#StreamFactory#createStream()
---
Key: HIVE-8090
URL: https://issues.apache.org/jira/browse/HIVE-8090
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Attachments: HIVE-8090.1.patch, HIVE-8090.2.patch
{code}
switch (kind) {
...
default:
modifiers = null;
break;
}
BufferedStream result = streams.get(name);
if (result == null) {
result = new BufferedStream(name.toString(), bufferSize,
codec == null ? codec : codec.modify(modifiers));
{code}
In case modifiers is null and codec is ZlibCodec, there would be NPE in
ZlibCodec#modify(EnumSetModifier modifiers) :
{code}
for (Modifier m : modifiers) {
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8090) Potential null pointer reference in WriterImpl#StreamFactory#createStream()
[
https://issues.apache.org/jira/browse/HIVE-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rahul Palamuttam updated HIVE-8090:
---
Attachment: HIVE-8090.3.patch
Potential null pointer reference in WriterImpl#StreamFactory#createStream()
---
Key: HIVE-8090
URL: https://issues.apache.org/jira/browse/HIVE-8090
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Attachments: HIVE-8090.1.patch, HIVE-8090.2.patch, HIVE-8090.3.patch
{code}
switch (kind) {
...
default:
modifiers = null;
break;
}
BufferedStream result = streams.get(name);
if (result == null) {
result = new BufferedStream(name.toString(), bufferSize,
codec == null ? codec : codec.modify(modifiers));
{code}
In case modifiers is null and codec is ZlibCodec, there would be NPE in
ZlibCodec#modify(EnumSetModifier modifiers) :
{code}
for (Modifier m : modifiers) {
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-8090) Potential null pointer reference in WriterImpl#StreamFactory#createStream()
[
https://issues.apache.org/jira/browse/HIVE-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14133399#comment-14133399
]
Rahul Palamuttam commented on HIVE-8090:
I followed the comment guidelines in CompressionCodec.java.
/**
* Produce a modified compression codec if the underlying algorithm allows
* modification.
*
* This does not modify the current object, but returns a new object if
* modifications are possible. Returns the same object if no modifications
* are possible.
* @param modifiers compression modifiers
* @return codec for use after optional modification
*/
CompressionCodec modify(EnumSetModifier modifiers);
Thus if modifiers are null then no modifications are possible.
As per the comment the function returns the same object.
Waiting for code review.
Potential null pointer reference in WriterImpl#StreamFactory#createStream()
---
Key: HIVE-8090
URL: https://issues.apache.org/jira/browse/HIVE-8090
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Attachments: HIVE-8090.1.patch, HIVE-8090.2.patch, HIVE-8090.3.patch
{code}
switch (kind) {
...
default:
modifiers = null;
break;
}
BufferedStream result = streams.get(name);
if (result == null) {
result = new BufferedStream(name.toString(), bufferSize,
codec == null ? codec : codec.modify(modifiers));
{code}
In case modifiers is null and codec is ZlibCodec, there would be NPE in
ZlibCodec#modify(EnumSetModifier modifiers) :
{code}
for (Modifier m : modifiers) {
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8090) Potential null pointer reference in WriterImpl#StreamFactory#createStream()
[
https://issues.apache.org/jira/browse/HIVE-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rahul Palamuttam updated HIVE-8090:
---
Attachment: (was: HIVE-8090.3.patch)
Potential null pointer reference in WriterImpl#StreamFactory#createStream()
---
Key: HIVE-8090
URL: https://issues.apache.org/jira/browse/HIVE-8090
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Attachments: HIVE-8090.1.patch, HIVE-8090.2.patch
{code}
switch (kind) {
...
default:
modifiers = null;
break;
}
BufferedStream result = streams.get(name);
if (result == null) {
result = new BufferedStream(name.toString(), bufferSize,
codec == null ? codec : codec.modify(modifiers));
{code}
In case modifiers is null and codec is ZlibCodec, there would be NPE in
ZlibCodec#modify(EnumSetModifier modifiers) :
{code}
for (Modifier m : modifiers) {
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8090) Potential null pointer reference in WriterImpl#StreamFactory#createStream()
[
https://issues.apache.org/jira/browse/HIVE-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rahul Palamuttam updated HIVE-8090:
---
Attachment: HIVE-8090.3.patch
Potential null pointer reference in WriterImpl#StreamFactory#createStream()
---
Key: HIVE-8090
URL: https://issues.apache.org/jira/browse/HIVE-8090
Project: Hive
Issue Type: Bug
Reporter: Ted Yu
Attachments: HIVE-8090.1.patch, HIVE-8090.2.patch, HIVE-8090.3.patch
{code}
switch (kind) {
...
default:
modifiers = null;
break;
}
BufferedStream result = streams.get(name);
if (result == null) {
result = new BufferedStream(name.toString(), bufferSize,
codec == null ? codec : codec.modify(modifiers));
{code}
In case modifiers is null and codec is ZlibCodec, there would be NPE in
ZlibCodec#modify(EnumSetModifier modifiers) :
{code}
for (Modifier m : modifiers) {
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8082) generateErrorMessage doesn't handle null ast properly
[
https://issues.apache.org/jira/browse/HIVE-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rahul Palamuttam updated HIVE-8082:
---
Attachment: HIVE-8082.1.patch
generateErrorMessage doesn't handle null ast properly
-
Key: HIVE-8082
URL: https://issues.apache.org/jira/browse/HIVE-8082
Project: Hive
Issue Type: Bug
Affects Versions: 0.11.0, 0.12.0, 0.13.0, 0.13.1
Environment: anything
Reporter: Darren Yin
Priority: Minor
Labels: newbie, patch
Attachments: HIVE-8082.1.patch
in SemanticAnalzyer.genUnionPlan, tabref can be null, and if then one of the
throw new SemanticException lines gets called, generateErrorMessage will
error out with a NullPointerException when ast.getLine() is called. The fix
is just to add a check for if (ast == null)
example stack trace:
{noformat}
2014-09-12 14:02:3014/09/12 21:02:30 ERROR ql.Driver: FAILED:
NullPointerException null
2014-09-12 14:02:30java.lang.NullPointerException
2014-09-12 14:02:30 at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.generateErrorMessage(SemanticAnalyzer.java:484)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genUnionPlan(SemanticAnalyzer.java:7411)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:7970)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:7985)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:8693)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:278)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.ql.Driver.compile(Driver.java:458)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.ql.Driver.compile(Driver.java:407)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.ql.Driver.compile(Driver.java:339)
2014-09-12 14:02:30 at org.apache.hadoop.hive.ql.Driver.run(Driver.java:969)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:261)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:218)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:421)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:356)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:714)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:622)
2014-09-12 14:02:30 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
2014-09-12 14:02:30 at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
2014-09-12 14:02:30 at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
2014-09-12 14:02:30 at java.lang.reflect.Method.invoke(Method.java:597)
2014-09-12 14:02:30 at org.apache.hadoop.util.RunJar.main(RunJar.java:208)
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-8082) generateErrorMessage doesn't handle null ast properly
[
https://issues.apache.org/jira/browse/HIVE-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rahul Palamuttam updated HIVE-8082:
---
Tags: NPE
Labels: newbie patch (was: )
Status: Patch Available (was: Open)
Checked if the ASTNode was null. If it is null then append the message The
abstract tree is null and return the StringBuilder before an null referencing
can happen.
generateErrorMessage doesn't handle null ast properly
-
Key: HIVE-8082
URL: https://issues.apache.org/jira/browse/HIVE-8082
Project: Hive
Issue Type: Bug
Affects Versions: 0.13.1, 0.13.0, 0.12.0, 0.11.0
Environment: anything
Reporter: Darren Yin
Priority: Minor
Labels: newbie, patch
Attachments: HIVE-8082.1.patch
in SemanticAnalzyer.genUnionPlan, tabref can be null, and if then one of the
throw new SemanticException lines gets called, generateErrorMessage will
error out with a NullPointerException when ast.getLine() is called. The fix
is just to add a check for if (ast == null)
example stack trace:
{noformat}
2014-09-12 14:02:3014/09/12 21:02:30 ERROR ql.Driver: FAILED:
NullPointerException null
2014-09-12 14:02:30java.lang.NullPointerException
2014-09-12 14:02:30 at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.generateErrorMessage(SemanticAnalyzer.java:484)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genUnionPlan(SemanticAnalyzer.java:7411)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:7970)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:7985)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:8693)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:278)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.ql.Driver.compile(Driver.java:458)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.ql.Driver.compile(Driver.java:407)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.ql.Driver.compile(Driver.java:339)
2014-09-12 14:02:30 at org.apache.hadoop.hive.ql.Driver.run(Driver.java:969)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:261)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:218)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:421)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:356)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:714)
2014-09-12 14:02:30 at
org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:622)
2014-09-12 14:02:30 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
2014-09-12 14:02:30 at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
2014-09-12 14:02:30 at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
2014-09-12 14:02:30 at java.lang.reflect.Method.invoke(Method.java:597)
2014-09-12 14:02:30 at org.apache.hadoop.util.RunJar.main(RunJar.java:208)
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
