[jira] [Updated] (HIVE-3810) HiveHistory.log need to replace '\r' with space before writing Entry.value to historyfile
[
https://issues.apache.org/jira/browse/HIVE-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
qiangwang updated HIVE-3810:
Resolution: Fixed
Status: Resolved (was: Patch Available)
HiveHistory.log need to replace '\r' with space before writing Entry.value to
historyfile
-
Key: HIVE-3810
URL: https://issues.apache.org/jira/browse/HIVE-3810
Project: Hive
Issue Type: Bug
Components: Logging
Reporter: qiangwang
Assignee: Mark Grover
Priority: Minor
Attachments: HIVE-3810.1.patch, HIVE-3810.2.patch
HiveHistory.log will replace '\n' with space before writing Entry.value to
history file:
val = val.replace('\n', ' ');
but HiveHistory.parseHiveHistory use BufferedReader.readLine which takes
'\n', '\r', '\r\n' as line delimiter to parse history file
if val contains '\r', there is a high possibility that HiveHistory.parseLine
will fail, in which case usually RecordTypes.valueOf(recType) will throw
exception 'java.lang.IllegalArgumentException'
HiveHistory.log need to replace '\r' with space as well:
val = val.replace('\n', ' ');
changed to
val = val.replaceAll(\r|\n, );
or
val = val.replace('\r', ' ').replace('\n', ' ');
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3857) HiveHistoryViewer concurrency problem
[ https://issues.apache.org/jira/browse/HIVE-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] qiangwang updated HIVE-3857: Resolution: Fixed Status: Resolved (was: Patch Available) HiveHistoryViewer concurrency problem - Key: HIVE-3857 URL: https://issues.apache.org/jira/browse/HIVE-3857 Project: Hive Issue Type: Bug Components: Logging Reporter: qiangwang Priority: Minor Attachments: HiveHistory.patch new HiveHistoryViewer() throws ConcurrentModificationException when called concurrently by several threads. According to the stacktrace, HiveHistory.parseLine use private static MapString, String parseBuffer to store parsed data and this finally caused the exception. I don't know why a static buffer rather than a local buffer is used! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HIVE-3857) HiveHistoryViewer concurrency problem
qiangwang created HIVE-3857: --- Summary: HiveHistoryViewer concurrency problem Key: HIVE-3857 URL: https://issues.apache.org/jira/browse/HIVE-3857 Project: Hive Issue Type: Bug Components: Logging Reporter: qiangwang Priority: Minor new HiveHistoryViewer() throws ConcurrentModificationException when called concurrently by several threads. According to the stacktrace, HiveHistory.parseLine use private static MapString, String parseBuffer to store parsed data and this finally caused the exception. I don't know why a static buffer rather than a local buffer is used! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3857) HiveHistoryViewer concurrency problem
[ https://issues.apache.org/jira/browse/HIVE-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] qiangwang updated HIVE-3857: Status: Patch Available (was: Open) HiveHistoryViewer concurrency problem - Key: HIVE-3857 URL: https://issues.apache.org/jira/browse/HIVE-3857 Project: Hive Issue Type: Bug Components: Logging Reporter: qiangwang Priority: Minor new HiveHistoryViewer() throws ConcurrentModificationException when called concurrently by several threads. According to the stacktrace, HiveHistory.parseLine use private static MapString, String parseBuffer to store parsed data and this finally caused the exception. I don't know why a static buffer rather than a local buffer is used! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3857) HiveHistoryViewer concurrency problem
[ https://issues.apache.org/jira/browse/HIVE-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] qiangwang updated HIVE-3857: Status: Open (was: Patch Available) HiveHistoryViewer concurrency problem - Key: HIVE-3857 URL: https://issues.apache.org/jira/browse/HIVE-3857 Project: Hive Issue Type: Bug Components: Logging Reporter: qiangwang Priority: Minor new HiveHistoryViewer() throws ConcurrentModificationException when called concurrently by several threads. According to the stacktrace, HiveHistory.parseLine use private static MapString, String parseBuffer to store parsed data and this finally caused the exception. I don't know why a static buffer rather than a local buffer is used! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3857) HiveHistoryViewer concurrency problem
[ https://issues.apache.org/jira/browse/HIVE-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] qiangwang updated HIVE-3857: Status: Patch Available (was: Open) HiveHistoryViewer concurrency problem - Key: HIVE-3857 URL: https://issues.apache.org/jira/browse/HIVE-3857 Project: Hive Issue Type: Bug Components: Logging Reporter: qiangwang Priority: Minor Attachments: HiveHistory.patch new HiveHistoryViewer() throws ConcurrentModificationException when called concurrently by several threads. According to the stacktrace, HiveHistory.parseLine use private static MapString, String parseBuffer to store parsed data and this finally caused the exception. I don't know why a static buffer rather than a local buffer is used! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3857) HiveHistoryViewer concurrency problem
[ https://issues.apache.org/jira/browse/HIVE-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] qiangwang updated HIVE-3857: Attachment: HiveHistory.patch use local buffer instead of static HiveHistoryViewer concurrency problem - Key: HIVE-3857 URL: https://issues.apache.org/jira/browse/HIVE-3857 Project: Hive Issue Type: Bug Components: Logging Reporter: qiangwang Priority: Minor Attachments: HiveHistory.patch new HiveHistoryViewer() throws ConcurrentModificationException when called concurrently by several threads. According to the stacktrace, HiveHistory.parseLine use private static MapString, String parseBuffer to store parsed data and this finally caused the exception. I don't know why a static buffer rather than a local buffer is used! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3810) HiveHistory.log need to replace '\r' with space before writing Entry.value to historyfile
[
https://issues.apache.org/jira/browse/HIVE-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
qiangwang updated HIVE-3810:
Description:
HiveHistory.log will replace '\n' with space before writing Entry.value to
history file:
val = val.replace('\n', ' ');
but HiveHistory.parseHiveHistory use BufferedReader.readLine which takes '\n',
'\r', '\r\n' as line delimiter to parse history file
if val contains '\r', there is a high possibility that HiveHistory.parseLine
will fail, in which case usually RecordTypes.valueOf(recType) will throw
exception 'java.lang.IllegalArgumentException'
HiveHistory.log need to replace '\r' with space as well:
val = val.replace('\n', ' ');
changed to
val = val.replaceAll(\r|\n, );
or
val = val.replace('\r', ' ').replace('\n', ' ');
was:
HiveHistory.log will replace '\n' with space before writing Entry.value to
history file:
val = val.replace('\n', ' ');
but HiveHistory.parseHiveHistory use BufferedReader.readLine which takes '\n',
'\r', '\r\n' as line delimiter to parse history file
if val contains '\r', there is a high possibility that HiveHistory.parseLine
will fail, in which case usually RecordTypes.valueOf(recType) will throw
exception 'java.lang.IllegalArgumentException'
HiveHistory.log need to replace '\r' with space as well:
- val = val.replace('\n', ' ');
+ val = val.replaceAll(\r|\n, );
or
- val = val.replace('\n', ' ');
+ val = val.replace('\r', ' ').replace('\n', ' ');
HiveHistory.log need to replace '\r' with space before writing Entry.value to
historyfile
-
Key: HIVE-3810
URL: https://issues.apache.org/jira/browse/HIVE-3810
Project: Hive
Issue Type: Bug
Components: Logging
Reporter: qiangwang
Priority: Minor
HiveHistory.log will replace '\n' with space before writing Entry.value to
history file:
val = val.replace('\n', ' ');
but HiveHistory.parseHiveHistory use BufferedReader.readLine which takes
'\n', '\r', '\r\n' as line delimiter to parse history file
if val contains '\r', there is a high possibility that HiveHistory.parseLine
will fail, in which case usually RecordTypes.valueOf(recType) will throw
exception 'java.lang.IllegalArgumentException'
HiveHistory.log need to replace '\r' with space as well:
val = val.replace('\n', ' ');
changed to
val = val.replaceAll(\r|\n, );
or
val = val.replace('\r', ' ').replace('\n', ' ');
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3810) HiveHistory.log need to replace '\r' with space before writing Entry.value to historyfile
[
https://issues.apache.org/jira/browse/HIVE-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
qiangwang updated HIVE-3810:
Summary: HiveHistory.log need to replace '\r' with space before writing
Entry.value to historyfile (was: HiveHistory need replace '\r' with space
before writing Entry.value to historyfile)
HiveHistory.log need to replace '\r' with space before writing Entry.value to
historyfile
-
Key: HIVE-3810
URL: https://issues.apache.org/jira/browse/HIVE-3810
Project: Hive
Issue Type: Bug
Components: Logging
Reporter: qiangwang
Priority: Minor
HiveHistory.log will replace '\n' with space before writing Entry.value to
history file:
val = val.replace('\n', ' ');
but HiveHistoryViewer use BufferedReader.readLine which takes '\n', '\r',
'\r\n' as line delimiter to parse history file
if val contains '\r', there is a high possibility that
HiveHistoryViewer.parseLine will fail, in which case usually
RecordTypes.valueOf(recType) will throw exception
'java.lang.IllegalArgumentException'
HiveHistory.log need to replace '\r' with space as well:
- val = val.replace('\n', ' ');
+ val = val.replaceAll(\r|\n, );
or
- val = val.replace('\n', ' ');
+ val = val.replace('\r', ' ').replace('\n', ' ');
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3810) HiveHistory.log need to replace '\r' with space before writing Entry.value to historyfile
[
https://issues.apache.org/jira/browse/HIVE-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
qiangwang updated HIVE-3810:
Description:
HiveHistory.log will replace '\n' with space before writing Entry.value to
history file:
val = val.replace('\n', ' ');
but HiveHistory.parseHiveHistory use BufferedReader.readLine which takes '\n',
'\r', '\r\n' as line delimiter to parse history file
if val contains '\r', there is a high possibility that HiveHistory.parseLine
will fail, in which case usually RecordTypes.valueOf(recType) will throw
exception 'java.lang.IllegalArgumentException'
HiveHistory.log need to replace '\r' with space as well:
- val = val.replace('\n', ' ');
+ val = val.replaceAll(\r|\n, );
or
- val = val.replace('\n', ' ');
+ val = val.replace('\r', ' ').replace('\n', ' ');
was:
HiveHistory.log will replace '\n' with space before writing Entry.value to
history file:
val = val.replace('\n', ' ');
but HiveHistoryViewer use BufferedReader.readLine which takes '\n', '\r',
'\r\n' as line delimiter to parse history file
if val contains '\r', there is a high possibility that
HiveHistoryViewer.parseLine will fail, in which case usually
RecordTypes.valueOf(recType) will throw exception
'java.lang.IllegalArgumentException'
HiveHistory.log need to replace '\r' with space as well:
- val = val.replace('\n', ' ');
+ val = val.replaceAll(\r|\n, );
or
- val = val.replace('\n', ' ');
+ val = val.replace('\r', ' ').replace('\n', ' ');
HiveHistory.log need to replace '\r' with space before writing Entry.value to
historyfile
-
Key: HIVE-3810
URL: https://issues.apache.org/jira/browse/HIVE-3810
Project: Hive
Issue Type: Bug
Components: Logging
Reporter: qiangwang
Priority: Minor
HiveHistory.log will replace '\n' with space before writing Entry.value to
history file:
val = val.replace('\n', ' ');
but HiveHistory.parseHiveHistory use BufferedReader.readLine which takes
'\n', '\r', '\r\n' as line delimiter to parse history file
if val contains '\r', there is a high possibility that HiveHistory.parseLine
will fail, in which case usually RecordTypes.valueOf(recType) will throw
exception 'java.lang.IllegalArgumentException'
HiveHistory.log need to replace '\r' with space as well:
- val = val.replace('\n', ' ');
+ val = val.replaceAll(\r|\n, );
or
- val = val.replace('\n', ' ');
+ val = val.replace('\r', ' ').replace('\n', ' ');
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
