[jira] [Commented] (HIVE-2362) HiveConf properties not appearing in the output of 'set' or 'set -v'
[ https://issues.apache.org/jira/browse/HIVE-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163803#comment-13163803 ] John Sichi commented on HIVE-2362: -- +1, will commit when tests pass. HiveConf properties not appearing in the output of 'set' or 'set -v' Key: HIVE-2362 URL: https://issues.apache.org/jira/browse/HIVE-2362 Project: Hive Issue Type: Bug Components: CLI, Configuration Reporter: Carl Steinbach Assignee: Carl Steinbach Priority: Blocker Fix For: 0.8.0 Attachments: HIVE-2362.1.patch.txt, HIVE-2362.2.patch.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2362) HiveConf properties not appearing in the output of 'set' or 'set -v'
[ https://issues.apache.org/jira/browse/HIVE-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164081#comment-13164081 ] Hudson commented on HIVE-2362: -- Integrated in Hive-trunk-h0.23.0 #4 (See [https://builds.apache.org/job/Hive-trunk-h0.23.0/4/]) HIVE-2362. HiveConf properties not appearing in the output of 'set' or 'set -v' (Carl Steinbach via jvs) jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1211261 Files : * /hive/trunk/build-common.xml * /hive/trunk/common/build.xml * /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java * /hive/trunk/common/src/test * /hive/trunk/common/src/test/org * /hive/trunk/common/src/test/org/apache * /hive/trunk/common/src/test/org/apache/hadoop * /hive/trunk/common/src/test/org/apache/hadoop/hive * /hive/trunk/common/src/test/org/apache/hadoop/hive/conf * /hive/trunk/common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java * /hive/trunk/common/src/test/resources * /hive/trunk/common/src/test/resources/hive-site.xml * /hive/trunk/conf/hive-default.xml * /hive/trunk/eclipse-templates/.classpath HiveConf properties not appearing in the output of 'set' or 'set -v' Key: HIVE-2362 URL: https://issues.apache.org/jira/browse/HIVE-2362 Project: Hive Issue Type: Bug Components: CLI, Configuration Reporter: Carl Steinbach Assignee: Carl Steinbach Priority: Blocker Fix For: 0.9.0 Attachments: HIVE-2362.1.patch.txt, HIVE-2362.2.patch.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2362) HiveConf properties not appearing in the output of 'set' or 'set -v'
[ https://issues.apache.org/jira/browse/HIVE-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164171#comment-13164171 ] Hudson commented on HIVE-2362: -- Integrated in Hive-trunk-h0.21 #1128 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1128/]) HIVE-2362. HiveConf properties not appearing in the output of 'set' or 'set -v' (Carl Steinbach via jvs) jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1211261 Files : * /hive/trunk/build-common.xml * /hive/trunk/common/build.xml * /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java * /hive/trunk/common/src/test * /hive/trunk/common/src/test/org * /hive/trunk/common/src/test/org/apache * /hive/trunk/common/src/test/org/apache/hadoop * /hive/trunk/common/src/test/org/apache/hadoop/hive * /hive/trunk/common/src/test/org/apache/hadoop/hive/conf * /hive/trunk/common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java * /hive/trunk/common/src/test/resources * /hive/trunk/common/src/test/resources/hive-site.xml * /hive/trunk/conf/hive-default.xml * /hive/trunk/eclipse-templates/.classpath HiveConf properties not appearing in the output of 'set' or 'set -v' Key: HIVE-2362 URL: https://issues.apache.org/jira/browse/HIVE-2362 Project: Hive Issue Type: Bug Components: CLI, Configuration Reporter: Carl Steinbach Assignee: Carl Steinbach Priority: Blocker Fix For: 0.9.0 Attachments: HIVE-2362.1.patch.txt, HIVE-2362.2.patch.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2362) HiveConf properties not appearing in the output of 'set' or 'set -v'
[ https://issues.apache.org/jira/browse/HIVE-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163044#comment-13163044 ] jirapos...@reviews.apache.org commented on HIVE-2362: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2960/ --- (Updated 2011-12-05 21:15:13.146776) Review request for hive and John Sichi. Changes --- Updated diff including a new testcase. Summary --- Fix for HIVE-2362. This addresses bug HIVE-2362. https://issues.apache.org/jira/browse/HIVE-2362 Diffs (updated) - eclipse-templates/.classpath b020907 common/src/test/resources/hive-site.xml PRE-CREATION conf/hive-default.xml 53eca0e common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java PRE-CREATION build-common.xml 1d162de common/build.xml 432eba5 common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d9b6fd5 Diff: https://reviews.apache.org/r/2960/diff Testing --- Thanks, Carl HiveConf properties not appearing in the output of 'set' or 'set -v' Key: HIVE-2362 URL: https://issues.apache.org/jira/browse/HIVE-2362 Project: Hive Issue Type: Bug Components: CLI, Configuration Reporter: Carl Steinbach Assignee: Jakob Homan Priority: Blocker Fix For: 0.8.0 Attachments: HIVE-2362.1.patch.txt, HIVE-2362.2.patch.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2362) HiveConf properties not appearing in the output of 'set' or 'set -v'
[ https://issues.apache.org/jira/browse/HIVE-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163134#comment-13163134 ] John Sichi commented on HIVE-2362: -- (BTW patch applies cleanly to trunk but not 0.8) HiveConf properties not appearing in the output of 'set' or 'set -v' Key: HIVE-2362 URL: https://issues.apache.org/jira/browse/HIVE-2362 Project: Hive Issue Type: Bug Components: CLI, Configuration Reporter: Carl Steinbach Assignee: Carl Steinbach Priority: Blocker Fix For: 0.8.0 Attachments: HIVE-2362.1.patch.txt, HIVE-2362.2.patch.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2362) HiveConf properties not appearing in the output of 'set' or 'set -v'
[ https://issues.apache.org/jira/browse/HIVE-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163177#comment-13163177 ] jirapos...@reviews.apache.org commented on HIVE-2362: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2960/#review3648 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java https://reviews.apache.org/r/2960/#comment8142 Carl, there is an addResource overload which takes an InputStream. Can't we use that plus ByteArrayOutputStream to avoid having to create a temporary file? - John On 2011-12-05 21:15:13, Carl Steinbach wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/2960/ bq. --- bq. bq. (Updated 2011-12-05 21:15:13) bq. bq. bq. Review request for hive and John Sichi. bq. bq. bq. Summary bq. --- bq. bq. Fix for HIVE-2362. bq. bq. bq. This addresses bug HIVE-2362. bq. https://issues.apache.org/jira/browse/HIVE-2362 bq. bq. bq. Diffs bq. - bq. bq.eclipse-templates/.classpath b020907 bq.common/src/test/resources/hive-site.xml PRE-CREATION bq.conf/hive-default.xml 53eca0e bq.common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java PRE-CREATION bq.build-common.xml 1d162de bq.common/build.xml 432eba5 bq.common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d9b6fd5 bq. bq. Diff: https://reviews.apache.org/r/2960/diff bq. bq. bq. Testing bq. --- bq. bq. bq. Thanks, bq. bq. Carl bq. bq. HiveConf properties not appearing in the output of 'set' or 'set -v' Key: HIVE-2362 URL: https://issues.apache.org/jira/browse/HIVE-2362 Project: Hive Issue Type: Bug Components: CLI, Configuration Reporter: Carl Steinbach Assignee: Carl Steinbach Priority: Blocker Fix For: 0.8.0 Attachments: HIVE-2362.1.patch.txt, HIVE-2362.2.patch.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2362) HiveConf properties not appearing in the output of 'set' or 'set -v'
[ https://issues.apache.org/jira/browse/HIVE-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163342#comment-13163342 ] Carl Steinbach commented on HIVE-2362: -- All tests pass for me on trunk. HiveConf properties not appearing in the output of 'set' or 'set -v' Key: HIVE-2362 URL: https://issues.apache.org/jira/browse/HIVE-2362 Project: Hive Issue Type: Bug Components: CLI, Configuration Reporter: Carl Steinbach Assignee: Carl Steinbach Priority: Blocker Fix For: 0.8.0 Attachments: HIVE-2362.1.patch.txt, HIVE-2362.2.patch.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2362) HiveConf properties not appearing in the output of 'set' or 'set -v'
[ https://issues.apache.org/jira/browse/HIVE-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163343#comment-13163343 ] jirapos...@reviews.apache.org commented on HIVE-2362: - bq. On 2011-12-05 23:39:18, John Sichi wrote: bq. common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 776 bq. https://reviews.apache.org/r/2960/diff/2/?file=61977#file61977line776 bq. bq. Carl, there is an addResource overload which takes an InputStream. Can't we use that plus ByteArrayOutputStream to avoid having to create a temporary file? I tried this approach originally, but o.a.h.conf.Configuration.addResource(InputStream) is broken. Anything you add using this method gets added to a list which is reloaded on every subsequent call to addResource, which results in an unexpected EOF exception on the first reload. - Carl --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2960/#review3648 --- On 2011-12-05 21:15:13, Carl Steinbach wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/2960/ bq. --- bq. bq. (Updated 2011-12-05 21:15:13) bq. bq. bq. Review request for hive and John Sichi. bq. bq. bq. Summary bq. --- bq. bq. Fix for HIVE-2362. bq. bq. bq. This addresses bug HIVE-2362. bq. https://issues.apache.org/jira/browse/HIVE-2362 bq. bq. bq. Diffs bq. - bq. bq.eclipse-templates/.classpath b020907 bq.common/src/test/resources/hive-site.xml PRE-CREATION bq.conf/hive-default.xml 53eca0e bq.common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java PRE-CREATION bq.build-common.xml 1d162de bq.common/build.xml 432eba5 bq.common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d9b6fd5 bq. bq. Diff: https://reviews.apache.org/r/2960/diff bq. bq. bq. Testing bq. --- bq. bq. bq. Thanks, bq. bq. Carl bq. bq. HiveConf properties not appearing in the output of 'set' or 'set -v' Key: HIVE-2362 URL: https://issues.apache.org/jira/browse/HIVE-2362 Project: Hive Issue Type: Bug Components: CLI, Configuration Reporter: Carl Steinbach Assignee: Carl Steinbach Priority: Blocker Fix For: 0.8.0 Attachments: HIVE-2362.1.patch.txt, HIVE-2362.2.patch.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2362) HiveConf properties not appearing in the output of 'set' or 'set -v'
[ https://issues.apache.org/jira/browse/HIVE-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159625#comment-13159625 ] John Sichi commented on HIVE-2362: -- Need a testcase, right? HiveConf properties not appearing in the output of 'set' or 'set -v' Key: HIVE-2362 URL: https://issues.apache.org/jira/browse/HIVE-2362 Project: Hive Issue Type: Bug Components: CLI, Configuration Reporter: Carl Steinbach Assignee: Jakob Homan Priority: Blocker Fix For: 0.8.0 Attachments: HIVE-2362.1.patch.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2362) HiveConf properties not appearing in the output of 'set' or 'set -v'
[
https://issues.apache.org/jira/browse/HIVE-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13081401#comment-13081401
]
Carl Steinbach commented on HIVE-2362:
--
HiveConf currently includes definitions for the following Hadoop properties:
{code:language=java}
MAPREDMAXSPLITSIZE(mapred.max.split.size, 25600L),
MAPREDMINSPLITSIZE(mapred.min.split.size, 1L),
MAPREDMINSPLITSIZEPERNODE(mapred.min.split.size.per.rack, 1L),
MAPREDMINSPLITSIZEPERRACK(mapred.min.split.size.per.node, 1L),
{code}
HiveConf properties not appearing in the output of 'set' or 'set -v'
Key: HIVE-2362
URL: https://issues.apache.org/jira/browse/HIVE-2362
Project: Hive
Issue Type: Bug
Components: CLI, Configuration
Reporter: Carl Steinbach
Priority: Blocker
Fix For: 0.8.0
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2362) HiveConf properties not appearing in the output of 'set' or 'set -v'
[
https://issues.apache.org/jira/browse/HIVE-2362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13081405#comment-13081405
]
Carl Steinbach commented on HIVE-2362:
--
However, only {{mapred.min.split.size}} appears in the output of {{set -v}},
and none of these properties appear in the output of {{set}}:
{noformat}
% hive -e 'set' | egrep '^mapred.(min|max).*'
% hive -e 'set -v' | egrep '^mapred.(min|max).*'
mapred.min.split.size=0
%
{noformat}
Looks like mapred.min.split.size is showing up because it's set in
build/hadoopcore/hadoop-0.20.1/src/mapred/mapred-default.xml
HiveConf properties not appearing in the output of 'set' or 'set -v'
Key: HIVE-2362
URL: https://issues.apache.org/jira/browse/HIVE-2362
Project: Hive
Issue Type: Bug
Components: CLI, Configuration
Reporter: Carl Steinbach
Priority: Blocker
Fix For: 0.8.0
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
