[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13592333#comment-13592333 ] Namit Jain commented on HIVE-2439: -- http://mail-archives.apache.org/mod_mbox/hive-dev/201212.mbox/%3CJIRA.12522342.1315521190933.2405.1354828149653@arcas%3E This needs to be addressed. Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Assignee: Thiruvel Thirumoolan Fix For: 0.11.0 Attachments: HIVE-2439_branch10.patch, HIVE-2439_branch9_2.patch, HIVE-2439_branch9_3.patch, HIVE-2439_branch9.patch, hive-2439_incomplete.patch, HIVE-2439_trunk_1.patch, HIVE-2439_trunk_2.patch, HIVE-2439_trunk.patch Upgrade antlr version to 3.4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13592334#comment-13592334 ] Namit Jain commented on HIVE-2439: -- If you want to file a follow-up jira, and close this again, that's fine too. Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Assignee: Thiruvel Thirumoolan Fix For: 0.11.0 Attachments: HIVE-2439_branch10.patch, HIVE-2439_branch9_2.patch, HIVE-2439_branch9_3.patch, HIVE-2439_branch9.patch, hive-2439_incomplete.patch, HIVE-2439_trunk_1.patch, HIVE-2439_trunk_2.patch, HIVE-2439_trunk.patch Upgrade antlr version to 3.4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554826#comment-13554826 ] Hudson commented on HIVE-2439: -- Integrated in Hive-trunk-hadoop2 #67 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/67/]) HIVE-2439 : Upgrade antlr version to 3.4 (Thiruvel Thirumoolan via Ashutosh Chauhan) (Revision 1433458) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1433458 Files : * /hive/trunk/ivy/libraries.properties * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ASTErrorNode.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ASTNode.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java * /hive/trunk/ql/src/test/results/clientnegative/archive_partspec3.q.out * /hive/trunk/ql/src/test/results/clientnegative/clusterbyorderby.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename3.q.out * /hive/trunk/ql/src/test/results/clientnegative/lateral_view_join.q.out * /hive/trunk/ql/src/test/results/clientnegative/select_charliteral.q.out * /hive/trunk/ql/src/test/results/clientnegative/set_table_property.q.out * /hive/trunk/ql/src/test/results/clientnegative/show_columns2.q.out * /hive/trunk/ql/src/test/results/clientnegative/show_tables_bad1.q.out * /hive/trunk/ql/src/test/results/clientnegative/show_tables_bad2.q.out * /hive/trunk/ql/src/test/results/compiler/errors/invalid_select.q.out * /hive/trunk/ql/src/test/results/compiler/parse/case_sensitivity.q.out * /hive/trunk/ql/src/test/results/compiler/parse/cast1.q.out * /hive/trunk/ql/src/test/results/compiler/parse/groupby1.q.out * /hive/trunk/ql/src/test/results/compiler/parse/groupby2.q.out * /hive/trunk/ql/src/test/results/compiler/parse/groupby3.q.out * /hive/trunk/ql/src/test/results/compiler/parse/groupby4.q.out * /hive/trunk/ql/src/test/results/compiler/parse/groupby5.q.out * /hive/trunk/ql/src/test/results/compiler/parse/groupby6.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input1.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input2.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input20.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input3.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input4.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input5.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input6.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input7.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input8.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input9.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input_part1.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input_testsequencefile.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input_testxpath.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input_testxpath2.q.out * /hive/trunk/ql/src/test/results/compiler/parse/join1.q.out * /hive/trunk/ql/src/test/results/compiler/parse/join2.q.out * /hive/trunk/ql/src/test/results/compiler/parse/join3.q.out * /hive/trunk/ql/src/test/results/compiler/parse/join4.q.out * /hive/trunk/ql/src/test/results/compiler/parse/join5.q.out * /hive/trunk/ql/src/test/results/compiler/parse/join6.q.out * /hive/trunk/ql/src/test/results/compiler/parse/join7.q.out * /hive/trunk/ql/src/test/results/compiler/parse/join8.q.out * /hive/trunk/ql/src/test/results/compiler/parse/sample1.q.out * /hive/trunk/ql/src/test/results/compiler/parse/sample2.q.out * /hive/trunk/ql/src/test/results/compiler/parse/sample3.q.out * /hive/trunk/ql/src/test/results/compiler/parse/sample4.q.out * /hive/trunk/ql/src/test/results/compiler/parse/sample5.q.out * /hive/trunk/ql/src/test/results/compiler/parse/sample6.q.out * /hive/trunk/ql/src/test/results/compiler/parse/sample7.q.out * /hive/trunk/ql/src/test/results/compiler/parse/subq.q.out * /hive/trunk/ql/src/test/results/compiler/parse/udf1.q.out * /hive/trunk/ql/src/test/results/compiler/parse/udf4.q.out * /hive/trunk/ql/src/test/results/compiler/parse/udf6.q.out * /hive/trunk/ql/src/test/results/compiler/parse/udf_case.q.out * /hive/trunk/ql/src/test/results/compiler/parse/udf_when.q.out * /hive/trunk/ql/src/test/results/compiler/parse/union.q.out Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Assignee: Thiruvel Thirumoolan Fix For: 0.11.0 Attachments: HIVE-2439_branch10.patch, HIVE-2439_branch9_2.patch, HIVE-2439_branch9_3.patch, HIVE-2439_branch9.patch,
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[
https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13553900#comment-13553900
]
Ashutosh Chauhan commented on HIVE-2439:
Note to other devs: Please do {{ant very-clean package}} once after upping your
repos to this version.
Upgrade antlr version to 3.4
Key: HIVE-2439
URL: https://issues.apache.org/jira/browse/HIVE-2439
Project: Hive
Issue Type: Improvement
Affects Versions: 0.8.0
Reporter: Ashutosh Chauhan
Assignee: Thiruvel Thirumoolan
Fix For: 0.11.0
Attachments: HIVE-2439_branch10.patch, HIVE-2439_branch9_2.patch,
HIVE-2439_branch9_3.patch, HIVE-2439_branch9.patch,
hive-2439_incomplete.patch, HIVE-2439_trunk_1.patch, HIVE-2439_trunk_2.patch,
HIVE-2439_trunk.patch
Upgrade antlr version to 3.4
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554053#comment-13554053 ] Thiruvel Thirumoolan commented on HIVE-2439: Thanks Ashutosh! Would it be possible to get this into 10 or 10.1? Given that HCatalog v5 has just been cut, it can depend on Hive 10. I am also working on Hive10 + Hadoop23 (0.23.x) unit tests and might have a patch to trunk and branch10 soon. So 10 has some more changes (at-least from my end). Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Assignee: Thiruvel Thirumoolan Fix For: 0.11.0 Attachments: HIVE-2439_branch10.patch, HIVE-2439_branch9_2.patch, HIVE-2439_branch9_3.patch, HIVE-2439_branch9.patch, hive-2439_incomplete.patch, HIVE-2439_trunk_1.patch, HIVE-2439_trunk_2.patch, HIVE-2439_trunk.patch Upgrade antlr version to 3.4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554645#comment-13554645 ] Hudson commented on HIVE-2439: -- Integrated in Hive-trunk-h0.21 #1914 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1914/]) HIVE-2439 : Upgrade antlr version to 3.4 (Thiruvel Thirumoolan via Ashutosh Chauhan) (Revision 1433458) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1433458 Files : * /hive/trunk/ivy/libraries.properties * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ASTErrorNode.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ASTNode.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java * /hive/trunk/ql/src/test/results/clientnegative/archive_partspec3.q.out * /hive/trunk/ql/src/test/results/clientnegative/clusterbyorderby.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename3.q.out * /hive/trunk/ql/src/test/results/clientnegative/lateral_view_join.q.out * /hive/trunk/ql/src/test/results/clientnegative/select_charliteral.q.out * /hive/trunk/ql/src/test/results/clientnegative/set_table_property.q.out * /hive/trunk/ql/src/test/results/clientnegative/show_columns2.q.out * /hive/trunk/ql/src/test/results/clientnegative/show_tables_bad1.q.out * /hive/trunk/ql/src/test/results/clientnegative/show_tables_bad2.q.out * /hive/trunk/ql/src/test/results/compiler/errors/invalid_select.q.out * /hive/trunk/ql/src/test/results/compiler/parse/case_sensitivity.q.out * /hive/trunk/ql/src/test/results/compiler/parse/cast1.q.out * /hive/trunk/ql/src/test/results/compiler/parse/groupby1.q.out * /hive/trunk/ql/src/test/results/compiler/parse/groupby2.q.out * /hive/trunk/ql/src/test/results/compiler/parse/groupby3.q.out * /hive/trunk/ql/src/test/results/compiler/parse/groupby4.q.out * /hive/trunk/ql/src/test/results/compiler/parse/groupby5.q.out * /hive/trunk/ql/src/test/results/compiler/parse/groupby6.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input1.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input2.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input20.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input3.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input4.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input5.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input6.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input7.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input8.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input9.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input_part1.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input_testsequencefile.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input_testxpath.q.out * /hive/trunk/ql/src/test/results/compiler/parse/input_testxpath2.q.out * /hive/trunk/ql/src/test/results/compiler/parse/join1.q.out * /hive/trunk/ql/src/test/results/compiler/parse/join2.q.out * /hive/trunk/ql/src/test/results/compiler/parse/join3.q.out * /hive/trunk/ql/src/test/results/compiler/parse/join4.q.out * /hive/trunk/ql/src/test/results/compiler/parse/join5.q.out * /hive/trunk/ql/src/test/results/compiler/parse/join6.q.out * /hive/trunk/ql/src/test/results/compiler/parse/join7.q.out * /hive/trunk/ql/src/test/results/compiler/parse/join8.q.out * /hive/trunk/ql/src/test/results/compiler/parse/sample1.q.out * /hive/trunk/ql/src/test/results/compiler/parse/sample2.q.out * /hive/trunk/ql/src/test/results/compiler/parse/sample3.q.out * /hive/trunk/ql/src/test/results/compiler/parse/sample4.q.out * /hive/trunk/ql/src/test/results/compiler/parse/sample5.q.out * /hive/trunk/ql/src/test/results/compiler/parse/sample6.q.out * /hive/trunk/ql/src/test/results/compiler/parse/sample7.q.out * /hive/trunk/ql/src/test/results/compiler/parse/subq.q.out * /hive/trunk/ql/src/test/results/compiler/parse/udf1.q.out * /hive/trunk/ql/src/test/results/compiler/parse/udf4.q.out * /hive/trunk/ql/src/test/results/compiler/parse/udf6.q.out * /hive/trunk/ql/src/test/results/compiler/parse/udf_case.q.out * /hive/trunk/ql/src/test/results/compiler/parse/udf_when.q.out * /hive/trunk/ql/src/test/results/compiler/parse/union.q.out Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Assignee: Thiruvel Thirumoolan Fix For: 0.11.0 Attachments: HIVE-2439_branch10.patch, HIVE-2439_branch9_2.patch, HIVE-2439_branch9_3.patch, HIVE-2439_branch9.patch,
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13553491#comment-13553491 ] Ashutosh Chauhan commented on HIVE-2439: Thanks Thiruvel for the update. Running tests again. Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Assignee: Thiruvel Thirumoolan Attachments: HIVE-2439_branch10.patch, HIVE-2439_branch9_2.patch, HIVE-2439_branch9_3.patch, HIVE-2439_branch9.patch, hive-2439_incomplete.patch, HIVE-2439_trunk_1.patch, HIVE-2439_trunk_2.patch, HIVE-2439_trunk.patch Upgrade antlr version to 3.4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552058#comment-13552058 ] Ashutosh Chauhan commented on HIVE-2439: All the tests passed, except for TestNegativeCliDriver.set_table_property.q which needs update to the .q.out file. Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Assignee: Thiruvel Thirumoolan Attachments: HIVE-2439_branch10.patch, HIVE-2439_branch9_2.patch, HIVE-2439_branch9_3.patch, HIVE-2439_branch9.patch, hive-2439_incomplete.patch, HIVE-2439_trunk_1.patch, HIVE-2439_trunk.patch Upgrade antlr version to 3.4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552059#comment-13552059 ] Ashutosh Chauhan commented on HIVE-2439: I ran tests on trunk. Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Assignee: Thiruvel Thirumoolan Attachments: HIVE-2439_branch10.patch, HIVE-2439_branch9_2.patch, HIVE-2439_branch9_3.patch, HIVE-2439_branch9.patch, hive-2439_incomplete.patch, HIVE-2439_trunk_1.patch, HIVE-2439_trunk.patch Upgrade antlr version to 3.4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13551439#comment-13551439 ] Ashutosh Chauhan commented on HIVE-2439: Thanks Thriuvel for addressing comments. Latest patch looks good. +1. Running tests now. Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Assignee: Thiruvel Thirumoolan Attachments: HIVE-2439_branch10.patch, HIVE-2439_branch9_2.patch, HIVE-2439_branch9_3.patch, HIVE-2439_branch9.patch, hive-2439_incomplete.patch, HIVE-2439_trunk_1.patch, HIVE-2439_trunk.patch Upgrade antlr version to 3.4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13549555#comment-13549555 ] Thiruvel Thirumoolan commented on HIVE-2439: I am also working on running HCatalog unit tests with 0.23 and it needs hive jars with this fix [as hcat depends on pig10 which in turn depends on antlr 3.4]. Currently I push hive jars locally for testing. But would be nice to see this in. Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Assignee: Thiruvel Thirumoolan Fix For: 0.10.0, 0.9.1, 0.11.0 Attachments: HIVE-2439_branch9_2.patch, HIVE-2439_branch9_3.patch, HIVE-2439_branch9.patch, hive-2439_incomplete.patch, HIVE-2439_trunk.patch Upgrade antlr version to 3.4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13550846#comment-13550846 ] Ashutosh Chauhan commented on HIVE-2439: Comments on https://reviews.facebook.net/D7527 Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Assignee: Thiruvel Thirumoolan Attachments: HIVE-2439_branch9_2.patch, HIVE-2439_branch9_3.patch, HIVE-2439_branch9.patch, hive-2439_incomplete.patch, HIVE-2439_trunk.patch Upgrade antlr version to 3.4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542136#comment-13542136 ] Thiruvel Thirumoolan commented on HIVE-2439: [~namit] This is intended to simplify life for users of Hive, HCatalog and Pig. As HCat/Pig use antlr 3.4, anyone using all the components have to workaround in unfriendly and complicated ways. Thomas Weise raised this issue before http://markmail.org/thread/xltnc5ak2saurdbu. Websearch for 'hive pig antlr' also brings up workarounds like using jarjar. While upgrading antlr, I also fixed problems in Hive.g that didn't surface with 3.0.1. [~ashutoshc] Feel free to add if I have missed anything. Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Assignee: Thiruvel Thirumoolan Fix For: 0.10.0, 0.9.1, 0.11.0 Attachments: HIVE-2439_branch9_2.patch, HIVE-2439_branch9_3.patch, HIVE-2439_branch9.patch, hive-2439_incomplete.patch, HIVE-2439_trunk.patch Upgrade antlr version to 3.4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13538843#comment-13538843 ] Namit Jain commented on HIVE-2439: -- What is the reason for upgrading antlr ? Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Assignee: Thiruvel Thirumoolan Fix For: 0.10.0, 0.9.1, 0.11 Attachments: HIVE-2439_branch9_2.patch, HIVE-2439_branch9_3.patch, HIVE-2439_branch9.patch, hive-2439_incomplete.patch, HIVE-2439_trunk.patch Upgrade antlr version to 3.4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528855#comment-13528855 ] Thiruvel Thirumoolan commented on HIVE-2439: Looks like Phabricator is on version 5 and arc is on version 6. Unable to post patch on phabricator. Phabricator doesnt seem to have any branches, so gets difficult trying to get it from one of their trees before the version bump. Will try posting couple of days later. Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Attachments: HIVE-2439_branch9_2.patch, HIVE-2439_branch9_3.patch, HIVE-2439_branch9.patch, hive-2439_incomplete.patch, HIVE-2439_trunk.patch Upgrade antlr version to 3.4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527248#comment-13527248 ] Ashutosh Chauhan commented on HIVE-2439: Thiruvel, We usually work on trunk. So, I will suggest you to use trunk for this work. From trunk, we can always backport patches. Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Attachments: HIVE-2439_branch9_2.patch, HIVE-2439_branch9_3.patch, HIVE-2439_branch9.patch, hive-2439_incomplete.patch Upgrade antlr version to 3.4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13512117#comment-13512117 ] Thiruvel Thirumoolan commented on HIVE-2439: There are two failures in TestCliDriver related to views which are a little weird (exception at the end). As per [1], during Semantic Analyzer, Hive expands a query [say replace with all columns if there is a *]. This is achieved using antlr TokenRewriteStream class. The inputs to this class from Hive hasn't changed because of the version bump (or updated Lexer/Parser), but TokenRewriteStream.toString() has undergone almost a rewrite when compared to 3.0.1 when comparing the sources. The IllegalArgumentException is due to the additional code in 3.4. This does not happen with all view related tests. Going by the test case failures, it happens when there is a join. Other test cases related to lateral views, UDF/UDTF all pass, but two tests related to join fail [a view being created from join of tables]. Failed test cases: join_view.q and ppd_union_view.q. Not sure if there is a problem in the way we are using this API. [1] - https://cwiki.apache.org/confluence/display/Hive/ViewDev#ViewDev-StoredViewDefinition Exception: ... create view v as select invites.bar, invites2.foo, invites2.ds from invites join invites2 on invites.ds=invites2.ds ... 2012-12-04 10:59:19,647 DEBUG parse.SemanticAnalyzer (SemanticAnalyzer.java:genPlan(6766)) - Created Plan for Query Block null 2012-12-04 10:59:19,648 ERROR ql.Driver (SessionState.java:printError(400)) - FAILED: Hive Internal Error: java.lang.IllegalArgumentException(replace op boundaries of ReplaceOp@[@41,138:139='ds',24,5:101]..[@41,138:139='ds',24,5:101]:`ds` overlap with previous ReplaceOp@[@39,130:136='invites',24,5:93]..[@41,138:139='ds',24,5:101]:`invites`.`ds`) java.lang.IllegalArgumentException: replace op boundaries of ReplaceOp@[@41,138:139='ds',24,5:101]..[@41,138:139='ds',24,5:101]:`ds` overlap with previous ReplaceOp@[@39,130:136='invites',24,5:93]..[@41,138:139='ds',24,5:101]:`invites`.`ds` at org.antlr.runtime.TokenRewriteStream.reduceToSingleOperationPerIndex(TokenRewriteStream.java:504) at org.antlr.runtime.TokenRewriteStream.toString(TokenRewriteStream.java:374) at org.antlr.runtime.TokenRewriteStream.toString(TokenRewriteStream.java:358) at org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.saveViewDefinition(SemanticAnalyzer.java:7602) at org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:7537) at org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:244) Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Attachments: HIVE-2439_branch9_2.patch, HIVE-2439_branch9.patch, hive-2439_incomplete.patch Upgrade antlr version to 3.4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13509110#comment-13509110 ] Thiruvel Thirumoolan commented on HIVE-2439: Took a shot at this one on branch 0.9. Faced the same problems as Ashutosh, but I was able compile cleanly using antlr 3.2 and 3.3 after I cleaned up the ivy cache or removed all antlr directories. The change in parse tree happens with 3.3 and the release notes don't help me. It looks like adding a token to one of the grammars was providing a consistent tree with 3.2 and 3.3/3.4. I have requested antlr group for clarification and hope to get to something working. I will try to post a patch for branch 0.9 that has been done based on Ashutosh's previous patch if my approach is correct. Here is an email that I sent along with the links of my experiments. In case someone has any thoughts or feedback, they are welcome. -- On 12/3/12 6:11 PM, Thiruvel Thirumoolan * wrote: Hi Jim, Thanks for your response, I guess the formatting was misleading. I have reformatted and this should help. After some poking around, a small change to the grammar provides a consistent tree between 3.2 and 3.3. Is this the original mistake we had? Suspected rule: destination: ... | KW_TABLE tableOrPartition - ^(tableOrPartition) Modified rule: destination: ... | KW_TABLE tableOrPartition - ^(TOK_TAB_OR_PART tableOrPartition) After adding a token to the rewrite rule, I was able to see a consistent tree. I will have to change AST parsing code in Hive obviously, a little involved. But is this the bug in the grammar? I could not find any incompatible change in ANTLR 3.3 release notes regarding this [1] [only debug related incompatible change]. [1] - http://www.antlr.org/wiki/display/ANTLR3/ANTLR+3.3+Release+Notes Thanks! Thiruvel On 12/3/12 7:43 AM, Jim Idle * wrote: With just a quick glance at your sample grammar I think that your issues is only that some of your rules are using rewrite rules ( - ) but they are only being used on say 1 out of 2 alts. IIRC, if you use rewrite rules on one alt of a rule, you must use them on all the others too. JIm On Fri, Nov 30, 2012 at 10:56 PM, Thiruvel Thirumoolan * wrote: Hello, I work on Apache Hive and it currently uses antlr 3.0.1. We would like to upgrade to antlr 3.4 so its easy to work with other Apache projects on Hadoop that use antlr 3.4. We found that the parse tree generated from Hive.g [1] is different with 3.0.1/3.1/3.2 and 3.3/3.4. I have stripped down the lengthy grammar and created a smaller version (Insert.g [2]). I have pushed a small mvn v3 project to https://github.com/thiruvel/HiveANTLR34Issue that uses ANTLR in a way Hive uses it. Here is the tree difference and the entire output is on github. One can run mvn test to simulate it. Antlr 3.0.1/3.1/3.2: ( TOK_DESTINATION( TOK_TAB( TOK_TABNAME( TABLE_X))( TOK_PARTSPEC( TOK_PARTVAL( DIM_1)( 'A'))( TOK_PARTVAL( DIM_2)( 'B') Antlr 3.3/3.4: ( TOK_DESTINATION( TOK_TAB)) Are we missing something in the grammar or is this a bug addressed in v4? I am afraid we can't move to v4 as that would mean moving all other projects to v4. Are there any workarounds that we can use with antlr 3.4 to ensure a similar Tree is generated? Any help is greatly appreciated. Thank You! Thiruvel [1] - http://svn.apache.org/repos/asf/hive/branches/branch-0.9/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g [2] - https://github.com/thiruvel/HiveANTLR34Issue/blob/master/src/main/antlr3/com/yahoo/antlr/Insert.g Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Attachments: hive-2439_incomplete.patch Upgrade antlr version to 3.4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13509142#comment-13509142 ] Ashutosh Chauhan commented on HIVE-2439: Thanks, Thiruvel for taking this up. I don't have any more insight into this issue at the moment, but I am certainly interested in getting this resolved. Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Attachments: hive-2439_incomplete.patch Upgrade antlr version to 3.4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149256#comment-13149256 ] Ashutosh Chauhan commented on HIVE-2439: If any one wants to pursue this further feel free to take over the patch. Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Attachments: hive-2439_incomplete.patch Upgrade antlr version to 3.4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13148079#comment-13148079 ] Alejandro Abdelnur commented on HIVE-2439: -- Using antlr 3.4 supposedly fixes the following issue: Exception in thread main java.lang.NoSuchFieldError: type However, with 3.4 I'm getting: Exception in thread main java.lang.NoSuchFieldError: channel Sticking to 3.0.1 things work. Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Upgrade antlr version to 3.4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[ https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13148158#comment-13148158 ] Ashutosh Chauhan commented on HIVE-2439: Alejandro, Which problem you are referring to? If you use hive as is, you should not see any such exception. Upgrade antlr version to 3.4 Key: HIVE-2439 URL: https://issues.apache.org/jira/browse/HIVE-2439 Project: Hive Issue Type: Improvement Affects Versions: 0.8.0 Reporter: Ashutosh Chauhan Upgrade antlr version to 3.4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2439) Upgrade antlr version to 3.4
[
https://issues.apache.org/jira/browse/HIVE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13148200#comment-13148200
]
Alejandro Abdelnur commented on HIVE-2439:
--
Running Hive from within Oozie, if using antlr 3.4, hive cli fails with:
{code}
Exception in thread main java.lang.NoSuchFieldError: channel
{code}
If I downgrade to 3.0.1 the hive cli invocation works OK.
Upgrade antlr version to 3.4
Key: HIVE-2439
URL: https://issues.apache.org/jira/browse/HIVE-2439
Project: Hive
Issue Type: Improvement
Affects Versions: 0.8.0
Reporter: Ashutosh Chauhan
Upgrade antlr version to 3.4
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
