[jira] [Commented] (HIVE-2503) HiveServer should provide per session configuration
[ https://issues.apache.org/jira/browse/HIVE-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13548077#comment-13548077 ] Hudson commented on HIVE-2503: -- Integrated in Hive-trunk-hadoop2 #54 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/54/]) HIVE-2503: HiveServer should provide per session configuration (navis via hashutosh) (Revision 1301568) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1301568 Files : * /hive/trunk/service/src/java/org/apache/hadoop/hive/service/HiveServer.java * /hive/trunk/service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java HiveServer should provide per session configuration --- Key: HIVE-2503 URL: https://issues.apache.org/jira/browse/HIVE-2503 Project: Hive Issue Type: Bug Components: CLI, Server Infrastructure Affects Versions: 0.9.0 Reporter: Navis Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2503.1.patch.txt Currently ThriftHiveProcessorFactory returns same HiveConf instance to HiveServerHandler, making impossible to use per sesssion configuration. Just wrapping 'conf' - 'new HiveConf(conf)' seemed to solve this problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2503) HiveServer should provide per session configuration
[ https://issues.apache.org/jira/browse/HIVE-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230949#comment-13230949 ] Ashutosh Chauhan commented on HIVE-2503: +1 Will commit if tests pass. Navis, can you also post the patch on jira granting license. HiveServer should provide per session configuration --- Key: HIVE-2503 URL: https://issues.apache.org/jira/browse/HIVE-2503 Project: Hive Issue Type: Bug Components: CLI, Server Infrastructure Affects Versions: 0.9.0 Reporter: Navis Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2503.1.patch.txt Currently ThriftHiveProcessorFactory returns same HiveConf instance to HiveServerHandler, making impossible to use per sesssion configuration. Just wrapping 'conf' - 'new HiveConf(conf)' seemed to solve this problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2503) HiveServer should provide per session configuration
[ https://issues.apache.org/jira/browse/HIVE-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231560#comment-13231560 ] Hudson commented on HIVE-2503: -- Integrated in Hive-trunk-h0.21 #1315 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1315/]) HIVE-2503: HiveServer should provide per session configuration (navis via hashutosh) (Revision 1301568) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1301568 Files : * /hive/trunk/service/src/java/org/apache/hadoop/hive/service/HiveServer.java * /hive/trunk/service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java HiveServer should provide per session configuration --- Key: HIVE-2503 URL: https://issues.apache.org/jira/browse/HIVE-2503 Project: Hive Issue Type: Bug Components: CLI, Server Infrastructure Affects Versions: 0.9.0 Reporter: Navis Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2503.1.patch.txt Currently ThriftHiveProcessorFactory returns same HiveConf instance to HiveServerHandler, making impossible to use per sesssion configuration. Just wrapping 'conf' - 'new HiveConf(conf)' seemed to solve this problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2503) HiveServer should provide per session configuration
[ https://issues.apache.org/jira/browse/HIVE-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13179213#comment-13179213 ] Carl Steinbach commented on HIVE-2503: -- @Navis: Is this ticket ready for a final review? HiveServer should provide per session configuration --- Key: HIVE-2503 URL: https://issues.apache.org/jira/browse/HIVE-2503 Project: Hive Issue Type: Bug Components: CLI, Server Infrastructure Affects Versions: 0.9.0 Reporter: Navis Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2503.1.patch.txt Currently ThriftHiveProcessorFactory returns same HiveConf instance to HiveServerHandler, making impossible to use per sesssion configuration. Just wrapping 'conf' - 'new HiveConf(conf)' seemed to solve this problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2503) HiveServer should provide per session configuration
[ https://issues.apache.org/jira/browse/HIVE-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13179275#comment-13179275 ] jirapos...@reviews.apache.org commented on HIVE-2503: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/ --- (Updated 2012-01-04 05:08:24.994913) Review request for hive and Carl Steinbach. Changes --- Added missing ASF header. Summary --- We uses multiple HiveClient connected to single HiveServer. After configuring connections, we've found the environment variables are different from expected. Current hive server uses single instance of HiveConf and this seemed to make the problem. This addresses bug HIVE-2503. https://issues.apache.org/jira/browse/HIVE-2503 Diffs (updated) - service/src/java/org/apache/hadoop/hive/service/HiveServer.java 854cc99 service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java PRE-CREATION Diff: https://reviews.apache.org/r/2820/diff Testing --- If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case. But it seemed to be 'false' which makes it more complex. Thanks, Navis HiveServer should provide per session configuration --- Key: HIVE-2503 URL: https://issues.apache.org/jira/browse/HIVE-2503 Project: Hive Issue Type: Bug Components: CLI, Server Infrastructure Affects Versions: 0.9.0 Reporter: Navis Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2503.1.patch.txt Currently ThriftHiveProcessorFactory returns same HiveConf instance to HiveServerHandler, making impossible to use per sesssion configuration. Just wrapping 'conf' - 'new HiveConf(conf)' seemed to solve this problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2503) HiveServer should provide per session configuration
[ https://issues.apache.org/jira/browse/HIVE-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13179279#comment-13179279 ] Navis commented on HIVE-2503: - @Carl: Yes, ready. HiveServer should provide per session configuration --- Key: HIVE-2503 URL: https://issues.apache.org/jira/browse/HIVE-2503 Project: Hive Issue Type: Bug Components: CLI, Server Infrastructure Affects Versions: 0.9.0 Reporter: Navis Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2503.1.patch.txt Currently ThriftHiveProcessorFactory returns same HiveConf instance to HiveServerHandler, making impossible to use per sesssion configuration. Just wrapping 'conf' - 'new HiveConf(conf)' seemed to solve this problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2503) HiveServer should provide per session configuration
[ https://issues.apache.org/jira/browse/HIVE-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172692#comment-13172692 ] jirapos...@reviews.apache.org commented on HIVE-2503: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/#review3986 --- bq. If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case. But it seemed to be 'false' which makes it more complex. Can you supply a version of this test so I can take a look. I'm curious to know why it doesn't work. Thanks. service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java https://reviews.apache.org/r/2820/#comment9025 Missing ASF header. - Carl On 2011-12-16 05:44:15, Navis Ryu wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/2820/ bq. --- bq. bq. (Updated 2011-12-16 05:44:15) bq. bq. bq. Review request for hive and Carl Steinbach. bq. bq. bq. Summary bq. --- bq. bq. We uses multiple HiveClient connected to single HiveServer. After configuring connections, we've found the environment variables are different from expected. bq. Current hive server uses single instance of HiveConf and this seemed to make the problem. bq. bq. bq. This addresses bug HIVE-2503. bq. https://issues.apache.org/jira/browse/HIVE-2503 bq. bq. bq. Diffs bq. - bq. bq.service/src/java/org/apache/hadoop/hive/service/HiveServer.java 854cc99 bq. service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java PRE-CREATION bq. bq. Diff: https://reviews.apache.org/r/2820/diff bq. bq. bq. Testing bq. --- bq. bq. If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case. But it seemed to be 'false' which makes it more complex. bq. bq. bq. Thanks, bq. bq. Navis bq. bq. HiveServer should provide per session configuration --- Key: HIVE-2503 URL: https://issues.apache.org/jira/browse/HIVE-2503 Project: Hive Issue Type: Bug Components: CLI, Server Infrastructure Affects Versions: 0.9.0 Reporter: Navis Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2503.1.patch.txt Currently ThriftHiveProcessorFactory returns same HiveConf instance to HiveServerHandler, making impossible to use per sesssion configuration. Just wrapping 'conf' - 'new HiveConf(conf)' seemed to solve this problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2503) HiveServer should provide per session configuration
[ https://issues.apache.org/jira/browse/HIVE-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172838#comment-13172838 ] jirapos...@reviews.apache.org commented on HIVE-2503: - bq. On 2011-12-19 22:35:46, Carl Steinbach wrote: bq.If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case. But it seemed to be 'false' which makes it more complex. bq. bq. Can you supply a version of this test so I can take a look. I'm curious to know why it doesn't work. Thanks. I think it cannot be tested by making two instance of client, cause SessionState is a ThreadLocal thing.. Is it right? - Navis --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/#review3986 --- On 2011-12-16 05:44:15, Navis Ryu wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/2820/ bq. --- bq. bq. (Updated 2011-12-16 05:44:15) bq. bq. bq. Review request for hive and Carl Steinbach. bq. bq. bq. Summary bq. --- bq. bq. We uses multiple HiveClient connected to single HiveServer. After configuring connections, we've found the environment variables are different from expected. bq. Current hive server uses single instance of HiveConf and this seemed to make the problem. bq. bq. bq. This addresses bug HIVE-2503. bq. https://issues.apache.org/jira/browse/HIVE-2503 bq. bq. bq. Diffs bq. - bq. bq.service/src/java/org/apache/hadoop/hive/service/HiveServer.java 854cc99 bq. service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java PRE-CREATION bq. bq. Diff: https://reviews.apache.org/r/2820/diff bq. bq. bq. Testing bq. --- bq. bq. If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case. But it seemed to be 'false' which makes it more complex. bq. bq. bq. Thanks, bq. bq. Navis bq. bq. HiveServer should provide per session configuration --- Key: HIVE-2503 URL: https://issues.apache.org/jira/browse/HIVE-2503 Project: Hive Issue Type: Bug Components: CLI, Server Infrastructure Affects Versions: 0.9.0 Reporter: Navis Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2503.1.patch.txt Currently ThriftHiveProcessorFactory returns same HiveConf instance to HiveServerHandler, making impossible to use per sesssion configuration. Just wrapping 'conf' - 'new HiveConf(conf)' seemed to solve this problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2503) HiveServer should provide per session configuration
[ https://issues.apache.org/jira/browse/HIVE-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170424#comment-13170424 ] jirapos...@reviews.apache.org commented on HIVE-2503: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/#review3926 --- We should include a test case for regression purposes. You can achieve this by playing with test.service.standalone.server. If that doesn't work out, then you can always extend TestHiveServer and setup the test the way you want. - Ashutosh On 2011-11-14 08:54:00, Navis Ryu wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/2820/ bq. --- bq. bq. (Updated 2011-11-14 08:54:00) bq. bq. bq. Review request for hive and Carl Steinbach. bq. bq. bq. Summary bq. --- bq. bq. We uses multiple HiveClient connected to single HiveServer. After configuring connections, we've found the environment variables are different from expected. bq. Current hive server uses single instance of HiveConf and this seemed to make the problem. bq. bq. bq. This addresses bug HIVE-2503. bq. https://issues.apache.org/jira/browse/HIVE-2503 bq. bq. bq. Diffs bq. - bq. bq.service/src/java/org/apache/hadoop/hive/service/HiveServer.java a2d599f bq. bq. Diff: https://reviews.apache.org/r/2820/diff bq. bq. bq. Testing bq. --- bq. bq. If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case. But it seemed to be 'false' which makes it more complex. bq. bq. bq. Thanks, bq. bq. Navis bq. bq. HiveServer should provide per session configuration --- Key: HIVE-2503 URL: https://issues.apache.org/jira/browse/HIVE-2503 Project: Hive Issue Type: Bug Components: CLI, Server Infrastructure Affects Versions: 0.9.0 Reporter: Navis Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2503.1.patch.txt Currently ThriftHiveProcessorFactory returns same HiveConf instance to HiveServerHandler, making impossible to use per sesssion configuration. Just wrapping 'conf' - 'new HiveConf(conf)' seemed to solve this problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2503) HiveServer should provide per session configuration
[ https://issues.apache.org/jira/browse/HIVE-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170793#comment-13170793 ] jirapos...@reviews.apache.org commented on HIVE-2503: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/ --- (Updated 2011-12-16 05:44:15.242903) Review request for hive and Carl Steinbach. Changes --- I know the test code is very awkward, but that was what I've expected from HiveServer. Summary --- We uses multiple HiveClient connected to single HiveServer. After configuring connections, we've found the environment variables are different from expected. Current hive server uses single instance of HiveConf and this seemed to make the problem. This addresses bug HIVE-2503. https://issues.apache.org/jira/browse/HIVE-2503 Diffs (updated) - service/src/java/org/apache/hadoop/hive/service/HiveServer.java 854cc99 service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java PRE-CREATION Diff: https://reviews.apache.org/r/2820/diff Testing --- If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case. But it seemed to be 'false' which makes it more complex. Thanks, Navis HiveServer should provide per session configuration --- Key: HIVE-2503 URL: https://issues.apache.org/jira/browse/HIVE-2503 Project: Hive Issue Type: Bug Components: CLI, Server Infrastructure Affects Versions: 0.9.0 Reporter: Navis Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2503.1.patch.txt Currently ThriftHiveProcessorFactory returns same HiveConf instance to HiveServerHandler, making impossible to use per sesssion configuration. Just wrapping 'conf' - 'new HiveConf(conf)' seemed to solve this problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2503) HiveServer should provide per session configuration
[ https://issues.apache.org/jira/browse/HIVE-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149504#comment-13149504 ] jirapos...@reviews.apache.org commented on HIVE-2503: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/ --- Review request for hive and Carl Steinbach. Summary --- We uses multiple HiveClient connected to single HiveServer. After configuring connections, we've found the environment variables are different from expected. Current hive server uses single instance of HiveConf and this seemed to make the problem. This addresses bug HIVE-2503. https://issues.apache.org/jira/browse/HIVE-2503 Diffs - service/src/java/org/apache/hadoop/hive/service/HiveServer.java a2d599f Diff: https://reviews.apache.org/r/2820/diff Testing --- If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case. But it seemed to be 'false' which makes it more complex. Thanks, Navis HiveServer should provide per session configuration --- Key: HIVE-2503 URL: https://issues.apache.org/jira/browse/HIVE-2503 Project: Hive Issue Type: Bug Components: CLI, Server Infrastructure Reporter: Navis Attachments: HIVE-2503.1.patch.txt Currently ThriftHiveProcessorFactory returns same HiveConf instance to HiveServerHandler, making impossible to use per sesssion configuration. Just wrapping 'conf' - 'new HiveConf(conf)' seemed to solve this problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2503) HiveServer should provide per session configuration
[ https://issues.apache.org/jira/browse/HIVE-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13127789#comment-13127789 ] Ashutosh Chauhan commented on HIVE-2503: @Navis, Can you elaborate bit more about the problem, which session you are referring to here? HiveServer should provide per session configuration --- Key: HIVE-2503 URL: https://issues.apache.org/jira/browse/HIVE-2503 Project: Hive Issue Type: Bug Components: CLI, Server Infrastructure Reporter: Navis Currently ThriftHiveProcessorFactory returns same HiveConf instance to HiveServerHandler, making impossible to use per sesssion configuration. Just wrapping 'conf' - 'new HiveConf(conf)' seemed to solve this problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2503) HiveServer should provide per session configuration
[
https://issues.apache.org/jira/browse/HIVE-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13128078#comment-13128078
]
Navis commented on HIVE-2503:
-
I'm using multiple ThriftHive.Client to single HiveServer.
For example :
{code}
client1 = factory.getCilent(~~~);
client2 = factory.getCilent(~~~);
client1.execute(set hiveconf:var=value1);
client2.execute(set hiveconf:var=value2);
client1.execute(set hiveconf:var); -- returns value2
{code}
HiveServer should provide per session configuration
---
Key: HIVE-2503
URL: https://issues.apache.org/jira/browse/HIVE-2503
Project: Hive
Issue Type: Bug
Components: CLI, Server Infrastructure
Reporter: Navis
Currently ThriftHiveProcessorFactory returns same HiveConf instance to
HiveServerHandler, making impossible to use per sesssion configuration. Just
wrapping 'conf' - 'new HiveConf(conf)' seemed to solve this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
