[jira] [Commented] (HIVE-2505) Update junit jar in testlibs
[ https://issues.apache.org/jira/browse/HIVE-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127999#comment-13127999 ] jirapos...@reviews.apache.org commented on HIVE-2505: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2391/ --- Review request for hive and Yongqiang He. Summary --- I updated the junit jar to the latest available in the maven repository. This addresses bug HIVE-2505. https://issues.apache.org/jira/browse/HIVE-2505 Diffs - trunk/ivy/libraries.properties 1183425 trunk/testlibs/junit-3.8.1.LICENSE.txt 1183425 trunk/testlibs/junit-3.8.1.jar UNKNOWN trunk/testlibs/junit-4.10.LICENSE.txt PRE-CREATION trunk/testlibs/junit-4.10.jar UNKNOWN Diff: https://reviews.apache.org/r/2391/diff Testing --- I ran ant test and the tests continued to pass. Thanks, Kevin > Update junit jar in testlibs > > > Key: HIVE-2505 > URL: https://issues.apache.org/jira/browse/HIVE-2505 > Project: Hive > Issue Type: Improvement >Reporter: Kevin Wilfong >Assignee: Kevin Wilfong > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2505) Update junit jar in testlibs
[ https://issues.apache.org/jira/browse/HIVE-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128004#comment-13128004 ] jirapos...@reviews.apache.org commented on HIVE-2505: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2391/ --- (Updated 2011-10-15 00:20:46.329179) Review request for hive and Yongqiang He. Summary --- I updated the junit jar to the latest available in the maven repository. This addresses bug HIVE-2505. https://issues.apache.org/jira/browse/HIVE-2505 Diffs - trunk/ivy/libraries.properties 1183425 trunk/pdk/build.xml 1183425 trunk/testlibs/junit-3.8.1.LICENSE.txt 1183425 trunk/testlibs/junit-3.8.1.jar UNKNOWN trunk/testlibs/junit-4.10.LICENSE.txt PRE-CREATION trunk/testlibs/junit-4.10.jar UNKNOWN Diff: https://reviews.apache.org/r/2391/diff Testing --- I ran ant test and the tests continued to pass. Thanks, Kevin > Update junit jar in testlibs > > > Key: HIVE-2505 > URL: https://issues.apache.org/jira/browse/HIVE-2505 > Project: Hive > Issue Type: Improvement >Reporter: Kevin Wilfong >Assignee: Kevin Wilfong > Attachments: HIVE-2505.1.patch.txt > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2505) Update junit jar in testlibs
[ https://issues.apache.org/jira/browse/HIVE-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130792#comment-13130792 ] He Yongqiang commented on HIVE-2505: looks good. running tests > Update junit jar in testlibs > > > Key: HIVE-2505 > URL: https://issues.apache.org/jira/browse/HIVE-2505 > Project: Hive > Issue Type: Improvement >Reporter: Kevin Wilfong >Assignee: Kevin Wilfong > Attachments: HIVE-2505.1.patch.txt > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2505) Update junit jar in testlibs
[ https://issues.apache.org/jira/browse/HIVE-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130862#comment-13130862 ] Kevin Wilfong commented on HIVE-2505: - After applying the patch junit-4.10.jar needs to be added to the directory trunk/testlibs/ The jar junit-3.8.1.jar needs to be removed from that same directory as well. > Update junit jar in testlibs > > > Key: HIVE-2505 > URL: https://issues.apache.org/jira/browse/HIVE-2505 > Project: Hive > Issue Type: Improvement >Reporter: Kevin Wilfong >Assignee: Kevin Wilfong > Attachments: HIVE-2505.1.patch.txt, junit-4.10.jar > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2505) Update junit jar in testlibs
[ https://issues.apache.org/jira/browse/HIVE-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130869#comment-13130869 ] Ashutosh Chauhan commented on HIVE-2505: Instead of checking in the jar we should pull it from maven repos via ivy. Its available on http://repo1.maven.org/maven/ > Update junit jar in testlibs > > > Key: HIVE-2505 > URL: https://issues.apache.org/jira/browse/HIVE-2505 > Project: Hive > Issue Type: Improvement >Reporter: Kevin Wilfong >Assignee: Kevin Wilfong > Attachments: HIVE-2505.1.patch.txt, junit-4.10.jar > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2505) Update junit jar in testlibs
[ https://issues.apache.org/jira/browse/HIVE-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131140#comment-13131140 ] John Sichi commented on HIVE-2505: -- +1 on what Ashutosh said; when upgrading something which is currently checked into lib but available in a maven repo, we should svn rm the old jar and add an ivy download to the build. > Update junit jar in testlibs > > > Key: HIVE-2505 > URL: https://issues.apache.org/jira/browse/HIVE-2505 > Project: Hive > Issue Type: Improvement >Reporter: Kevin Wilfong >Assignee: Kevin Wilfong > Attachments: HIVE-2505.1.patch.txt, junit-4.10.jar > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2505) Update junit jar in testlibs
[ https://issues.apache.org/jira/browse/HIVE-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131808#comment-13131808 ] He Yongqiang commented on HIVE-2505: committed, thanks Kevin! Will open a jira to fix the comments for John and Ashutosh's comments. > Update junit jar in testlibs > > > Key: HIVE-2505 > URL: https://issues.apache.org/jira/browse/HIVE-2505 > Project: Hive > Issue Type: Improvement >Reporter: Kevin Wilfong >Assignee: Kevin Wilfong > Attachments: HIVE-2505.1.patch.txt, junit-4.10.jar > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
