[jira] [Commented] (HIVE-2714) Lots of special characters are not handled in LIKE

[Phabricator (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227863#comment-13227863
 ] 

Phabricator commented on HIVE-2714:
---

kevinwilfong has accepted the revision HIVE-2714 [jira] Lots of special 
characters are not handled in LIKE.

  +1 Will commit if tests pass

REVISION DETAIL
  https://reviews.facebook.net/D1239

BRANCH
  like


 Lots of special characters are not handled in LIKE
 --

 Key: HIVE-2714
 URL: https://issues.apache.org/jira/browse/HIVE-2714
 Project: Hive
  Issue Type: Bug
Reporter: Jonathan Chang
Assignee: Jonathan Chang
 Attachments: HIVE-2714.D1239.1.patch


 Currently LIKE converts the string to a regular expression.  It tries to 
 handle special characters but many are not correctly handled, e.g. +, ?, |, 
 etc.  That code should just use Pattern.quote.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2714) Lots of special characters are not handled in LIKE

[Hudson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228188#comment-13228188
 ] 

Hudson commented on HIVE-2714:
--

Integrated in Hive-trunk-h0.21 #1307 (See 
[https://builds.apache.org/job/Hive-trunk-h0.21/1307/])
HIVE-2714. Lots of special characters are not handled in LIKE. (jonchang 
via kevinwilfong) (Revision 1299948)

 Result = FAILURE
kevinwilfong : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1299948
Files : 
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLike.java
* /hive/trunk/ql/src/test/queries/clientpositive/udf_like.q
* /hive/trunk/ql/src/test/results/clientpositive/udf_like.q.out


 Lots of special characters are not handled in LIKE
 --

 Key: HIVE-2714
 URL: https://issues.apache.org/jira/browse/HIVE-2714
 Project: Hive
  Issue Type: Bug
Reporter: Jonathan Chang
Assignee: Jonathan Chang
 Attachments: HIVE-2714.D1239.1.patch, HIVE-2714.D1239.1.patch


 Currently LIKE converts the string to a regular expression.  It tries to 
 handle special characters but many are not correctly handled, e.g. +, ?, |, 
 etc.  That code should just use Pattern.quote.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira