[jira] [Commented] (HIVE-2776) Setting test.silent=false has not effect

[Zhenxiao Luo (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-2776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286181#comment-13286181
 ] 

Zhenxiao Luo commented on HIVE-2776:


test.silent is set to be true by default, and there is no -nolog parameter 
passed to the hadoop command that submitted as a MapReduce Job.

When setting test.silent to be false, -nolog parameter is passed to the hadoop 
command, and configured the MapReduce Job.

This -nolog will only make effect when the MapReduce Job is failing. While, in 
most testcases, the MapReduce job succeeded, but the optimizer/compiler is 
doing wrong, so the result is different from the expected output.

My proposed solution:

1. Remove this "try "ant test ... -Dtest.silent=false" to get more logs." from 
QTestUtil, since this message does not make sense in the test context.
   Even if you set -Dtest.silent=false, you may get no detailed log(in most 
cases), since the MapReduce Job does not fail, the optimizer/compiler is doing 
things wrong.

2. Print these log info when a MapReduce Job is failing. while only happens in 
MapRedTask, should not be in MapRedLocalTask.

3. The property name is misleading, it seems like a test property, but 
actually, both MapRedTask and MapredLocalTask is using this property. We could 
either remove this property at all, and always print the log info when a 
MapReduce Job is failing as stated in #2, or choose another non-test related 
property name to determine the behavior of MapReduce Job failing logs.

> Setting test.silent=false has not effect
> 
>
> Key: HIVE-2776
> URL: https://issues.apache.org/jira/browse/HIVE-2776
> Project: Hive
>  Issue Type: Bug
>  Components: Testing Infrastructure
>Reporter: Carl Steinbach
>Assignee: Zhenxiao Luo
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2776) Setting test.silent=false has not effect

[Carl Steinbach (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-2776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199175#comment-13199175
 ] 

Carl Steinbach commented on HIVE-2776:
--

QTestUtil and the various CliDriver templates all print out the following help 
message:

{noformat}
try "ant test ... -Dtest.silent=false" to get more logs.
{noformat}

However, it turns out that test.silent=false by default, and you change the 
behavior of the tests only by setting test.silent=true.

>From MapredLocalTask:

{noformat}
  String isSilent = 
"true".equalsIgnoreCase(System.getProperty("test.silent")) ? "-nolog" : "";
{noformat}

>From MapRedTask:

{noformat}
  String isSilent = "true".equalsIgnoreCase(System
  .getProperty("test.silent")) ? "-nolog" : "";
{noformat}


> Setting test.silent=false has not effect
> 
>
> Key: HIVE-2776
> URL: https://issues.apache.org/jira/browse/HIVE-2776
> Project: Hive
>  Issue Type: Bug
>  Components: Testing Infrastructure
>Reporter: Carl Steinbach
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira