[jira] [Commented] (HIVE-2792) SUBSTR(CAST(string AS BINARY)) produces unexpected results
[ https://issues.apache.org/jira/browse/HIVE-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13547846#comment-13547846 ] Hudson commented on HIVE-2792: -- Integrated in Hive-trunk-hadoop2 #54 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/54/]) HIVE-2792: SUBSTR(CAST(string AS BINARY)) produces unexpected results (navis via hashutosh) (Revision 1291633) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1291633 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSubstr.java * /hive/trunk/ql/src/test/queries/clientpositive/ba_table_udfs.q * /hive/trunk/ql/src/test/queries/clientpositive/udf_substr.q * /hive/trunk/ql/src/test/results/clientpositive/ba_table_udfs.q.out * /hive/trunk/ql/src/test/results/clientpositive/udf_substr.q.out SUBSTR(CAST(string AS BINARY)) produces unexpected results Key: HIVE-2792 URL: https://issues.apache.org/jira/browse/HIVE-2792 Project: Hive Issue Type: Bug Components: UDF Affects Versions: 0.8.0, 0.8.1 Reporter: Carl Steinbach Assignee: Navis Fix For: 0.9.0 Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2792.D1797.1.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2792.D1797.2.patch, HIVE-2792.D1797.2.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2792) SUBSTR(CAST(string AS BINARY)) produces unexpected results
[ https://issues.apache.org/jira/browse/HIVE-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13212572#comment-13212572 ] Hudson commented on HIVE-2792: -- Integrated in Hive-trunk-h0.21 #1267 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1267/]) HIVE-2792: SUBSTR(CAST(string AS BINARY)) produces unexpected results (navis via hashutosh) (Revision 1291633) Result = SUCCESS hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1291633 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSubstr.java * /hive/trunk/ql/src/test/queries/clientpositive/ba_table_udfs.q * /hive/trunk/ql/src/test/queries/clientpositive/udf_substr.q * /hive/trunk/ql/src/test/results/clientpositive/ba_table_udfs.q.out * /hive/trunk/ql/src/test/results/clientpositive/udf_substr.q.out SUBSTR(CAST(string AS BINARY)) produces unexpected results Key: HIVE-2792 URL: https://issues.apache.org/jira/browse/HIVE-2792 Project: Hive Issue Type: Bug Components: UDF Affects Versions: 0.8.0, 0.8.1 Reporter: Carl Steinbach Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2792.D1797.1.patch, HIVE-2792.D1797.2.patch, HIVE-2792.D1797.2.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2792) SUBSTR(CAST(string AS BINARY)) produces unexpected results
[ https://issues.apache.org/jira/browse/HIVE-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13212985#comment-13212985 ] Hudson commented on HIVE-2792: -- Integrated in Hive-trunk-h0.21 #1268 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1268/]) HIVE-2792: SUBSTR(CAST(string AS BINARY)) produces unexpected results (navis via hashutosh) (Revision 1291633) Result = SUCCESS hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1291633 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSubstr.java * /hive/trunk/ql/src/test/queries/clientpositive/ba_table_udfs.q * /hive/trunk/ql/src/test/queries/clientpositive/udf_substr.q * /hive/trunk/ql/src/test/results/clientpositive/ba_table_udfs.q.out * /hive/trunk/ql/src/test/results/clientpositive/udf_substr.q.out SUBSTR(CAST(string AS BINARY)) produces unexpected results Key: HIVE-2792 URL: https://issues.apache.org/jira/browse/HIVE-2792 Project: Hive Issue Type: Bug Components: UDF Affects Versions: 0.8.0, 0.8.1 Reporter: Carl Steinbach Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2792.D1797.1.patch, HIVE-2792.D1797.2.patch, HIVE-2792.D1797.2.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2792) SUBSTR(CAST(string AS BINARY)) produces unexpected results
[ https://issues.apache.org/jira/browse/HIVE-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13211720#comment-13211720 ] Phabricator commented on HIVE-2792: --- navis has commented on the revision HIVE-2792 [jira] SUBSTR(CAST(string AS BINARY)) produces unexpected results. For substr() for binary type.. 1. Fixed length problem (dummy values at the end) 2. Changed to use 1-based index (like mysql) REVISION DETAIL https://reviews.facebook.net/D1797 SUBSTR(CAST(string AS BINARY)) produces unexpected results Key: HIVE-2792 URL: https://issues.apache.org/jira/browse/HIVE-2792 Project: Hive Issue Type: Bug Components: UDF Reporter: Carl Steinbach Attachments: HIVE-2792.D1797.1.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2792) SUBSTR(CAST(string AS BINARY)) produces unexpected results
[ https://issues.apache.org/jira/browse/HIVE-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13212268#comment-13212268 ] Phabricator commented on HIVE-2792: --- ashutoshc has requested changes to the revision HIVE-2792 [jira] SUBSTR(CAST(string AS BINARY)) produces unexpected results. Patch looks good. Can you update the testcase as I noted so that we have better coverage? INLINE COMMENTS ql/src/test/results/clientpositive/ba_table_udfs.q.out:28 For a better test so that it captures variance in the rows, modify the test in ba_tables_udfs.q to SUBSTR(src.value AS BINARY), 3), SUBSTR(src.value AS BINARY), -4,3) REVISION DETAIL https://reviews.facebook.net/D1797 BRANCH DPAL-848 SUBSTR(CAST(string AS BINARY)) produces unexpected results Key: HIVE-2792 URL: https://issues.apache.org/jira/browse/HIVE-2792 Project: Hive Issue Type: Bug Components: UDF Reporter: Carl Steinbach Attachments: HIVE-2792.D1797.1.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2792) SUBSTR(CAST(string AS BINARY)) produces unexpected results
[ https://issues.apache.org/jira/browse/HIVE-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13212296#comment-13212296 ] Phabricator commented on HIVE-2792: --- ashutoshc has accepted the revision HIVE-2792 [jira] SUBSTR(CAST(string AS BINARY)) produces unexpected results. +1 Will commit if tests pass. REVISION DETAIL https://reviews.facebook.net/D1797 BRANCH DPAL-848 SUBSTR(CAST(string AS BINARY)) produces unexpected results Key: HIVE-2792 URL: https://issues.apache.org/jira/browse/HIVE-2792 Project: Hive Issue Type: Bug Components: UDF Affects Versions: 0.8.0, 0.8.1 Reporter: Carl Steinbach Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2792.D1797.1.patch, HIVE-2792.D1797.2.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
