[jira] [Commented] (HIVE-2803) utc_from_timestamp and utc_to_timestamp returns incorrect results.

2012-04-23 Thread Phabricator (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260076#comment-13260076
 ] 

Phabricator commented on HIVE-2803:
---

tamtam180 has committed the revision HIVE-2803 [jira] utc_from_timestamp and 
utc_to_timestamp returns incorrect results..

  Change committed by cws.

REVISION DETAIL
  https://reviews.facebook.net/D1959

COMMIT
  https://reviews.facebook.net/rHIVE1329507


 utc_from_timestamp and utc_to_timestamp returns incorrect results.
 --

 Key: HIVE-2803
 URL: https://issues.apache.org/jira/browse/HIVE-2803
 Project: Hive
  Issue Type: Bug
  Components: UDF
Affects Versions: 0.8.0
Reporter: tamtam180
Assignee: tamtam180
 Fix For: 0.10.0

 Attachments: HIVE-2803.1.patch.txt, HIVE-2803.D1959.1.patch


 How to reproduce:
 {noformat}
 $ echo 2011-12-25 09:00:00.123456  /tmp/data5.txt
 hive create table ts1(t1 timestamp);
 hive load data local inpath '/tmp/data5.txt' overwrite into table ts1;
 hive select t1, from_utc_timestamp(t1, 'JST'), from_utc_timestamp(t1, 'JST') 
 from ts1 limit 1;
 {noformat}
 The following result is expected:
 {noformat}
  2011-12-25 09:00:00.123456  2011-12-25 18:00:00.123456  2011-12-25 
 18:00:00.123456
 {noformat}
 However, the above query return incorrect result like this:
 {noformat}
  2011-12-26 03:00:00.492456  2011-12-26 03:00:00.492456  2011-12-26 
 03:00:00.492456
 {noformat}
 This is because GenericUDFFromUtcTimestamp.applyOffset() does setTime() 
 improperly.
 On evaluating query, timestamp argument always returns the same instance.
 GenericUDFFromUtcTimestamp.applyOffset() does setTime() on the instance.
 That means it adds all offsets in the query.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HIVE-2803) utc_from_timestamp and utc_to_timestamp returns incorrect results.

2012-02-25 Thread tamtam180 (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13216361#comment-13216361
 ] 

tamtam180 commented on HIVE-2803:
-

Carl,
thanks your advice.
I tried use of Phabricator, and changed status to 'Patch Available'.


 utc_from_timestamp and utc_to_timestamp returns incorrect results.
 --

 Key: HIVE-2803
 URL: https://issues.apache.org/jira/browse/HIVE-2803
 Project: Hive
  Issue Type: Bug
  Components: UDF
Affects Versions: 0.8.0
Reporter: tamtam180
 Attachments: HIVE-2803.1.patch.txt, HIVE-2803.D1959.1.patch


 How to reproduce:
 {noformat}
 $ echo 2011-12-25 09:00:00.123456  /tmp/data5.txt
 hive create table ts1(t1 timestamp);
 hive load data local inpath '/tmp/data5.txt' overwrite into table ts1;
 hive select t1, from_utc_timestamp(t1, 'JST'), from_utc_timestamp(t1, 'JST') 
 from ts1 limit 1;
 {noformat}
 The following result is expected:
 {noformat}
  2011-12-25 09:00:00.123456  2011-12-25 18:00:00.123456  2011-12-25 
 18:00:00.123456
 {noformat}
 However, the above query return incorrect result like this:
 {noformat}
  2011-12-26 03:00:00.492456  2011-12-26 03:00:00.492456  2011-12-26 
 03:00:00.492456
 {noformat}
 This is because GenericUDFFromUtcTimestamp.applyOffset() does setTime() 
 improperly.
 On evaluating query, timestamp argument always returns the same instance.
 GenericUDFFromUtcTimestamp.applyOffset() does setTime() on the instance.
 That means it adds all offsets in the query.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HIVE-2803) utc_from_timestamp and utc_to_timestamp returns incorrect results.

2012-02-22 Thread Carl Steinbach (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13214221#comment-13214221
 ] 

Carl Steinbach commented on HIVE-2803:
--

@tamtam180: If this patch is ready for review can you please change the status 
to 'Patch Available' and submit a review request using Phabricator? 
Instructions are located here:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-ReviewProcess

Thanks!

 utc_from_timestamp and utc_to_timestamp returns incorrect results.
 --

 Key: HIVE-2803
 URL: https://issues.apache.org/jira/browse/HIVE-2803
 Project: Hive
  Issue Type: Bug
  Components: UDF
Affects Versions: 0.8.0
Reporter: tamtam180
 Attachments: HIVE-2803.1.patch.txt


 How to reproduce:
 {noformat}
 $ echo 2011-12-25 09:00:00.123456  /tmp/data5.txt
 hive create table ts1(t1 timestamp);
 hive load data local inpath '/tmp/data5.txt' overwrite into table ts1;
 hive select t1, from_utc_timestamp(t1, 'JST'), from_utc_timestamp(t1, 'JST') 
 from ts1 limit 1;
 {noformat}
 The following result is expected:
 {noformat}
  2011-12-25 09:00:00.123456  2011-12-25 18:00:00.123456  2011-12-25 
 18:00:00.123456
 {noformat}
 However, the above query return incorrect result like this:
 {noformat}
  2011-12-26 03:00:00.492456  2011-12-26 03:00:00.492456  2011-12-26 
 03:00:00.492456
 {noformat}
 This is because GenericUDFFromUtcTimestamp.applyOffset() does setTime() 
 improperly.
 On evaluating query, timestamp argument always returns the same instance.
 GenericUDFFromUtcTimestamp.applyOffset() does setTime() on the instance.
 That means it adds all offsets in the query.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira