[jira] [Commented] (HIVE-2810) Implement NULL-safe equality operator =
[ https://issues.apache.org/jira/browse/HIVE-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13548186#comment-13548186 ] Hudson commented on HIVE-2810: -- Integrated in Hive-trunk-hadoop2 #54 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/54/]) HIVE-2827 [jira] Implement nullsafe equi-join (Navis Ryu via Carl Steinbach) Summary: DPAL-873 Implement nullsafe equi-join was part of HIVE-2810, but separated because it affected more classes than expected. SELECT * FROM a JOIN b ON a.key = b.key Test Plan: EMPTY Reviewers: JIRA, cwsteinbach Reviewed By: cwsteinbach Differential Revision: https://reviews.facebook.net/D1971 (Revision 1297919) HIVE-2810 [jira] Implement NULL-safe equality operator = (Navis Ryu via Carl Steinbach) Summary: DPAL-843 Implement NULL-safe equality operator = Ref: http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html#operator_equal-to Test Plan: EMPTY Reviewers: JIRA, cwsteinbach Reviewed By: cwsteinbach Differential Revision: https://reviews.facebook.net/D1791 (Revision 1297677) Result = ABORTED cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1297919 Files : * /hive/trunk/data/files/in8.txt * /hive/trunk/data/files/in9.txt * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractMapJoinOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/AbstractMapJoinKey.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinDoubleKeys.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinObjectKey.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinSingleKey.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java * /hive/trunk/ql/src/test/queries/clientpositive/join_nullsafe.q * /hive/trunk/ql/src/test/results/clientpositive/join_nullsafe.q.out * /hive/trunk/ql/src/test/results/compiler/plan/join1.q.xml * /hive/trunk/ql/src/test/results/compiler/plan/join2.q.xml * /hive/trunk/ql/src/test/results/compiler/plan/join3.q.xml * /hive/trunk/ql/src/test/results/compiler/plan/join4.q.xml * /hive/trunk/ql/src/test/results/compiler/plan/join5.q.xml * /hive/trunk/ql/src/test/results/compiler/plan/join6.q.xml * /hive/trunk/ql/src/test/results/compiler/plan/join7.q.xml * /hive/trunk/ql/src/test/results/compiler/plan/join8.q.xml * /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1297677 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPEqualNS.java * /hive/trunk/ql/src/test/queries/clientpositive/udf_equal.q * /hive/trunk/ql/src/test/results/clientpositive/show_functions.q.out * /hive/trunk/ql/src/test/results/clientpositive/udf_equal.q.out Implement NULL-safe equality operator = - Key: HIVE-2810 URL: https://issues.apache.org/jira/browse/HIVE-2810 Project: Hive Issue Type: New Feature Components: Query Processor, UDF Reporter: Carl Steinbach Assignee: Navis Fix For: 0.9.0 Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2810.D1791.1.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2810.D1791.2.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2810.D1791.3.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2810.D1791.4.patch Ref: http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html#operator_equal-to -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2810) Implement NULL-safe equality operator =
[ https://issues.apache.org/jira/browse/HIVE-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13224440#comment-13224440 ] Hudson commented on HIVE-2810: -- Integrated in Hive-trunk-h0.21 #1295 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1295/]) HIVE-2827 [jira] Implement nullsafe equi-join (Navis Ryu via Carl Steinbach) Summary: DPAL-873 Implement nullsafe equi-join was part of HIVE-2810, but separated because it affected more classes than expected. SELECT * FROM a JOIN b ON a.key = b.key Test Plan: EMPTY Reviewers: JIRA, cwsteinbach Reviewed By: cwsteinbach Differential Revision: https://reviews.facebook.net/D1971 (Revision 1297919) Result = SUCCESS cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1297919 Files : * /hive/trunk/data/files/in8.txt * /hive/trunk/data/files/in9.txt * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractMapJoinOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/AbstractMapJoinKey.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinDoubleKeys.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinObjectKey.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinSingleKey.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java * /hive/trunk/ql/src/test/queries/clientpositive/join_nullsafe.q * /hive/trunk/ql/src/test/results/clientpositive/join_nullsafe.q.out * /hive/trunk/ql/src/test/results/compiler/plan/join1.q.xml * /hive/trunk/ql/src/test/results/compiler/plan/join2.q.xml * /hive/trunk/ql/src/test/results/compiler/plan/join3.q.xml * /hive/trunk/ql/src/test/results/compiler/plan/join4.q.xml * /hive/trunk/ql/src/test/results/compiler/plan/join5.q.xml * /hive/trunk/ql/src/test/results/compiler/plan/join6.q.xml * /hive/trunk/ql/src/test/results/compiler/plan/join7.q.xml * /hive/trunk/ql/src/test/results/compiler/plan/join8.q.xml * /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java Implement NULL-safe equality operator = - Key: HIVE-2810 URL: https://issues.apache.org/jira/browse/HIVE-2810 Project: Hive Issue Type: New Feature Components: Query Processor, UDF Reporter: Carl Steinbach Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2810.D1791.1.patch, HIVE-2810.D1791.2.patch, HIVE-2810.D1791.3.patch, HIVE-2810.D1791.4.patch Ref: http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html#operator_equal-to -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2810) Implement NULL-safe equality operator =
[ https://issues.apache.org/jira/browse/HIVE-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13223624#comment-13223624 ] Phabricator commented on HIVE-2810: --- navis has committed the revision HIVE-2810 [jira] Implement NULL-safe equality operator =. Change committed by cws. REVISION DETAIL https://reviews.facebook.net/D1791 COMMIT https://reviews.facebook.net/rHIVE1297677 Implement NULL-safe equality operator = - Key: HIVE-2810 URL: https://issues.apache.org/jira/browse/HIVE-2810 Project: Hive Issue Type: New Feature Components: Query Processor, UDF Reporter: Carl Steinbach Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2810.D1791.1.patch, HIVE-2810.D1791.2.patch, HIVE-2810.D1791.3.patch, HIVE-2810.D1791.4.patch Ref: http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html#operator_equal-to -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2810) Implement NULL-safe equality operator =
[ https://issues.apache.org/jira/browse/HIVE-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13222500#comment-13222500 ] Phabricator commented on HIVE-2810: --- cwsteinbach has accepted the revision HIVE-2810 [jira] Implement NULL-safe equality operator =. +1. Will commit if tests pass. REVISION DETAIL https://reviews.facebook.net/D1791 BRANCH DPAL-843 Implement NULL-safe equality operator = - Key: HIVE-2810 URL: https://issues.apache.org/jira/browse/HIVE-2810 Project: Hive Issue Type: New Feature Components: Query Processor, UDF Reporter: Carl Steinbach Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2810.D1791.1.patch, HIVE-2810.D1791.2.patch, HIVE-2810.D1791.3.patch, HIVE-2810.D1791.4.patch Ref: http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html#operator_equal-to -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2810) Implement NULL-safe equality operator =
[ https://issues.apache.org/jira/browse/HIVE-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13220504#comment-13220504 ] Phabricator commented on HIVE-2810: --- cwsteinbach has commented on the revision HIVE-2810 [jira] Implement NULL-safe equality operator =. INLINE COMMENTS ql/src/test/queries/clientpositive/udf_equal.q:7 Please add NULL comparisons for '=': NULL=NULL true=NULL NULL=true false=NULL NULL=false ql/src/test/queries/clientpositive/udf_equal.q:12 Please add the missing comparisons from above that were used to test '='. I realize that '=' is implemented in terms of '=', but the tests should treat both implementations like black boxes. Thanks. REVISION DETAIL https://reviews.facebook.net/D1791 BRANCH DPAL-843 Implement NULL-safe equality operator = - Key: HIVE-2810 URL: https://issues.apache.org/jira/browse/HIVE-2810 Project: Hive Issue Type: New Feature Components: Query Processor, UDF Affects Versions: 0.9.0 Reporter: Carl Steinbach Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2810.D1791.1.patch, HIVE-2810.D1791.2.patch, HIVE-2810.D1791.3.patch Ref: http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html#operator_equal-to -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2810) Implement NULL-safe equality operator =
[ https://issues.apache.org/jira/browse/HIVE-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13218958#comment-13218958 ] Phabricator commented on HIVE-2810: --- cwsteinbach has requested changes to the revision HIVE-2810 [jira] Implement NULL-safe equality operator =. Please update the testcase. Otherwise looks good, so I'll test and commit once this is done. Thanks. INLINE COMMENTS ql/src/test/queries/clientpositive/udf_equal.q:12 Please also check the comparisons true=true and false=false. REVISION DETAIL https://reviews.facebook.net/D1791 BRANCH DPAL-843 Implement NULL-safe equality operator = - Key: HIVE-2810 URL: https://issues.apache.org/jira/browse/HIVE-2810 Project: Hive Issue Type: New Feature Components: Query Processor, UDF Affects Versions: 0.9.0 Reporter: Carl Steinbach Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2810.D1791.1.patch, HIVE-2810.D1791.2.patch, HIVE-2810.D1791.3.patch Ref: http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html#operator_equal-to -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2810) Implement NULL-safe equality operator =
[ https://issues.apache.org/jira/browse/HIVE-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13217110#comment-13217110 ] Navis commented on HIVE-2810: - Separated nullsafe equi-join part to HIVE-2827. Implement NULL-safe equality operator = - Key: HIVE-2810 URL: https://issues.apache.org/jira/browse/HIVE-2810 Project: Hive Issue Type: New Feature Components: Query Processor, UDF Affects Versions: 0.9.0 Reporter: Carl Steinbach Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2810.D1791.1.patch Ref: http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html#operator_equal-to -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2810) Implement NULL-safe equality operator =
[ https://issues.apache.org/jira/browse/HIVE-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13217049#comment-13217049 ] Navis commented on HIVE-2810: - @Carl: Would it be better to separate this issue for briefness? Implement NULL-safe equality operator = - Key: HIVE-2810 URL: https://issues.apache.org/jira/browse/HIVE-2810 Project: Hive Issue Type: New Feature Components: Query Processor, UDF Affects Versions: 0.9.0 Reporter: Carl Steinbach Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2810.D1791.1.patch Ref: http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html#operator_equal-to -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2810) Implement NULL-safe equality operator =
[ https://issues.apache.org/jira/browse/HIVE-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13217081#comment-13217081 ] Carl Steinbach commented on HIVE-2810: -- I think it's fine to separate if there's a way to disable = from appearing in JOIN conditions. Otherwise, think it needs to be fixed here. Implement NULL-safe equality operator = - Key: HIVE-2810 URL: https://issues.apache.org/jira/browse/HIVE-2810 Project: Hive Issue Type: New Feature Components: Query Processor, UDF Affects Versions: 0.9.0 Reporter: Carl Steinbach Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2810.D1791.1.patch Ref: http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html#operator_equal-to -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2810) Implement NULL-safe equality operator =
[ https://issues.apache.org/jira/browse/HIVE-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13214286#comment-13214286 ] Phabricator commented on HIVE-2810: --- navis has commented on the revision HIVE-2810 [jira] Implement NULL-safe equality operator =. Null-safe equi-join in not relevant with null-safe eq operator. Join is hard-coded in JoinOperator under the assumption that equal operator is used, so it should modified separately. I'm trying but it's so hard.. -_-;; REVISION DETAIL https://reviews.facebook.net/D1791 BRANCH DPAL-843 Implement NULL-safe equality operator = - Key: HIVE-2810 URL: https://issues.apache.org/jira/browse/HIVE-2810 Project: Hive Issue Type: New Feature Components: Query Processor, UDF Affects Versions: 0.9.0 Reporter: Carl Steinbach Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2810.D1791.1.patch Ref: http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html#operator_equal-to -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2810) Implement NULL-safe equality operator =
[ https://issues.apache.org/jira/browse/HIVE-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13214381#comment-13214381 ] Carl Steinbach commented on HIVE-2810: -- Have you looked at the code changes made in HIVE-741? My understanding is that before that patch was committed Hive actually treated equi-joins as null-safe-equijoins, so it seems like the patch should give you a pretty good idea of what needs to be modified. Implement NULL-safe equality operator = - Key: HIVE-2810 URL: https://issues.apache.org/jira/browse/HIVE-2810 Project: Hive Issue Type: New Feature Components: Query Processor, UDF Affects Versions: 0.9.0 Reporter: Carl Steinbach Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2810.D1791.1.patch Ref: http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html#operator_equal-to -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2810) Implement NULL-safe equality operator =
[ https://issues.apache.org/jira/browse/HIVE-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13213224#comment-13213224 ] Phabricator commented on HIVE-2810: --- cwsteinbach has requested changes to the revision HIVE-2810 [jira] Implement NULL-safe equality operator =. Looks good. However, I have a hunch that this doesn't work with JOINs (e.g. see HIVE-741). Can you please add a testcase that uses the NULL-safe comparison operator in a JOIN condition? Thanks. REVISION DETAIL https://reviews.facebook.net/D1791 BRANCH DPAL-843 Implement NULL-safe equality operator = - Key: HIVE-2810 URL: https://issues.apache.org/jira/browse/HIVE-2810 Project: Hive Issue Type: New Feature Components: Query Processor, UDF Affects Versions: 0.9.0 Reporter: Carl Steinbach Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2810.D1791.1.patch Ref: http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html#operator_equal-to -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2810) Implement NULL-safe equality operator =
[ https://issues.apache.org/jira/browse/HIVE-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13213306#comment-13213306 ] Phabricator commented on HIVE-2810: --- navis has commented on the revision HIVE-2810 [jira] Implement NULL-safe equality operator =. You mean something like 'SELECT * FROM a JOIN b ON a.key = b.key' ? That seemed to be a huge work. (for me) REVISION DETAIL https://reviews.facebook.net/D1791 BRANCH DPAL-843 Implement NULL-safe equality operator = - Key: HIVE-2810 URL: https://issues.apache.org/jira/browse/HIVE-2810 Project: Hive Issue Type: New Feature Components: Query Processor, UDF Affects Versions: 0.9.0 Reporter: Carl Steinbach Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2810.D1791.1.patch Ref: http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html#operator_equal-to -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2810) Implement NULL-safe equality operator =
[ https://issues.apache.org/jira/browse/HIVE-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13213412#comment-13213412 ] Phabricator commented on HIVE-2810: --- cwsteinbach has commented on the revision HIVE-2810 [jira] Implement NULL-safe equality operator =. Yup, exactly. I tried running the query from HIVE-741: https://issues.apache.org/jira/browse/HIVE-741?focusedCommentId=12896789page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12896789 This works: select * from input1 a join input1 b on a.key=b.value; But I get the following error when I try to run this: select * from input1 a join input1 b on a.key = b.value; FAILED: Error in semantic analysis: Line 1:40 Both left and right aliases encountered in JOIN 'value' Looks like this may be a parsing issue? HIVE-741 added a join_nulls.q test to clientpositive. I think it would be a good idea to augment this testcase with null-safe equality queries. REVISION DETAIL https://reviews.facebook.net/D1791 BRANCH DPAL-843 Implement NULL-safe equality operator = - Key: HIVE-2810 URL: https://issues.apache.org/jira/browse/HIVE-2810 Project: Hive Issue Type: New Feature Components: Query Processor, UDF Affects Versions: 0.9.0 Reporter: Carl Steinbach Assignee: Navis Fix For: 0.9.0 Attachments: HIVE-2810.D1791.1.patch Ref: http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html#operator_equal-to -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
