[jira] [Commented] (HIVE-2881) Remove redundant key comparing in SMBMapJoinOperator
[ https://issues.apache.org/jira/browse/HIVE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13548241#comment-13548241 ] Hudson commented on HIVE-2881: -- Integrated in Hive-trunk-hadoop2 #54 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/54/]) HIVE-2881 Remove redundant key comparing in SMBMapJoinOperator (Navis via namit) (Revision 1308241) Result = ABORTED namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1308241 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java Remove redundant key comparing in SMBMapJoinOperator Key: HIVE-2881 URL: https://issues.apache.org/jira/browse/HIVE-2881 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: Navis Assignee: Navis Priority: Minor Fix For: 0.9.0 Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2881.D2379.1.patch Currently, SMBJoin compares keys twice in #findSmallestKey and #joinObject. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2881) Remove redundant key comparing in SMBMapJoinOperator
[ https://issues.apache.org/jira/browse/HIVE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244141#comment-13244141 ] Hudson commented on HIVE-2881: -- Integrated in Hive-trunk-h0.21 #1346 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1346/]) HIVE-2881 Remove redundant key comparing in SMBMapJoinOperator (Navis via namit) (Revision 1308241) Result = ABORTED namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1308241 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java Remove redundant key comparing in SMBMapJoinOperator Key: HIVE-2881 URL: https://issues.apache.org/jira/browse/HIVE-2881 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: Navis Assignee: Navis Priority: Minor Attachments: HIVE-2881.D2379.1.patch Currently, SMBJoin compares keys twice in #findSmallestKey and #joinObject. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2881) Remove redundant key comparing in SMBMapJoinOperator
[ https://issues.apache.org/jira/browse/HIVE-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243986#comment-13243986 ] Phabricator commented on HIVE-2881: --- njain has accepted the revision HIVE-2881 [jira] Remove redundant key comparing in SMBMapJoinOperator. Looks good - I know this did not have good comments to start with, but it would be great if you can add more comments for changes like this. It took me a very long time to go over the code and make sure we are not missing any boundary condition. An example would have really helped. REVISION DETAIL https://reviews.facebook.net/D2379 BRANCH DPAL-988 Remove redundant key comparing in SMBMapJoinOperator Key: HIVE-2881 URL: https://issues.apache.org/jira/browse/HIVE-2881 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: Navis Assignee: Navis Priority: Minor Attachments: HIVE-2881.D2379.1.patch Currently, SMBJoin compares keys twice in #findSmallestKey and #joinObject. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
