[jira] [Commented] (HIVE-2908) Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators
[ https://issues.apache.org/jira/browse/HIVE-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13548061#comment-13548061 ] Hudson commented on HIVE-2908: -- Integrated in Hive-trunk-hadoop2 #54 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/54/]) HIVE-2908. Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators. (sambavim via kevinwilfong) (Revision 1308427) Result = ABORTED kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1308427 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropTableDesc.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/PartitionSpec.java * /hive/trunk/ql/src/test/queries/clientnegative/drop_partition_filter_failure.q * /hive/trunk/ql/src/test/queries/clientpositive/drop_partitions_filter.q * /hive/trunk/ql/src/test/results/clientnegative/drop_partition_failure.q.out * /hive/trunk/ql/src/test/results/clientnegative/drop_partition_filter_failure.q.out * /hive/trunk/ql/src/test/results/clientpositive/drop_multi_partitions.q.out * /hive/trunk/ql/src/test/results/clientpositive/drop_partitions_filter.q.out * /hive/trunk/ql/src/test/results/clientpositive/escape1.q.out Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators - Key: HIVE-2908 URL: https://issues.apache.org/jira/browse/HIVE-2908 Project: Hive Issue Type: Improvement Components: Query Processor Affects Versions: 0.9.0 Reporter: Sambavi Muthukrishnan Assignee: Sambavi Muthukrishnan Priority: Minor Fix For: 0.9.0 Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2908.D2523.1.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2908.D2523.2.patch, HIVE-2908.final.patch.txt Original Estimate: 96h Remaining Estimate: 96h To drop a partition from a Hive table, this works: ALTER TABLE foo DROP PARTITION(ds = 'date') ...but it should also work to drop all partitions prior to date. ALTER TABLE foo DROP PARTITION(ds 'date') This task is to implement ALTER TABLE DROP PARTITION for all of the comparators, = = = != instead of just for =. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2908) Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators
[ https://issues.apache.org/jira/browse/HIVE-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244924#comment-13244924 ] Hudson commented on HIVE-2908: -- Integrated in Hive-trunk-h0.21 #1348 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1348/]) HIVE-2908. Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators. (sambavim via kevinwilfong) (Revision 1308427) Result = SUCCESS kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1308427 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropTableDesc.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/PartitionSpec.java * /hive/trunk/ql/src/test/queries/clientnegative/drop_partition_filter_failure.q * /hive/trunk/ql/src/test/queries/clientpositive/drop_partitions_filter.q * /hive/trunk/ql/src/test/results/clientnegative/drop_partition_failure.q.out * /hive/trunk/ql/src/test/results/clientnegative/drop_partition_filter_failure.q.out * /hive/trunk/ql/src/test/results/clientpositive/drop_multi_partitions.q.out * /hive/trunk/ql/src/test/results/clientpositive/drop_partitions_filter.q.out * /hive/trunk/ql/src/test/results/clientpositive/escape1.q.out Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators - Key: HIVE-2908 URL: https://issues.apache.org/jira/browse/HIVE-2908 Project: Hive Issue Type: Improvement Components: Query Processor Affects Versions: 0.9.0 Reporter: Sambavi Muthukrishnan Assignee: Sambavi Muthukrishnan Priority: Minor Fix For: 0.9.0 Attachments: HIVE-2908.D2523.1.patch, HIVE-2908.D2523.2.patch, HIVE-2908.final.patch.txt Original Estimate: 96h Remaining Estimate: 96h To drop a partition from a Hive table, this works: ALTER TABLE foo DROP PARTITION(ds = 'date') ...but it should also work to drop all partitions prior to date. ALTER TABLE foo DROP PARTITION(ds 'date') This task is to implement ALTER TABLE DROP PARTITION for all of the comparators, = = = != instead of just for =. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2908) Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators
[ https://issues.apache.org/jira/browse/HIVE-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242791#comment-13242791 ] Sambavi Muthukrishnan commented on HIVE-2908: - This patch includes the fix to the test log for escape1.q.out. Per discussion with Kevin included that fix and uploaded the svn patch. Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators - Key: HIVE-2908 URL: https://issues.apache.org/jira/browse/HIVE-2908 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: Sambavi Muthukrishnan Assignee: Sambavi Muthukrishnan Priority: Minor Attachments: HIVE-2908.D2523.1.patch, HIVE-2908.D2523.2.patch, HIVE-2908.final.patch.txt Original Estimate: 96h Remaining Estimate: 96h To drop a partition from a Hive table, this works: ALTER TABLE foo DROP PARTITION(ds = 'date') ...but it should also work to drop all partitions prior to date. ALTER TABLE foo DROP PARTITION(ds 'date') This task is to implement ALTER TABLE DROP PARTITION for all of the comparators, = = = != instead of just for =. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2908) Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators
[ https://issues.apache.org/jira/browse/HIVE-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242795#comment-13242795 ] Phabricator commented on HIVE-2908: --- kevinwilfong has accepted the revision HIVE-2908 [jira] Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators. +1 Looks good, and thanks for uploading the patch with all the files to the JIRA. Will commit if tests pass. Will let you know about the documentation. REVISION DETAIL https://reviews.facebook.net/D2523 BRANCH svn Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators - Key: HIVE-2908 URL: https://issues.apache.org/jira/browse/HIVE-2908 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: Sambavi Muthukrishnan Assignee: Sambavi Muthukrishnan Priority: Minor Attachments: HIVE-2908.D2523.1.patch, HIVE-2908.D2523.2.patch, HIVE-2908.final.patch.txt Original Estimate: 96h Remaining Estimate: 96h To drop a partition from a Hive table, this works: ALTER TABLE foo DROP PARTITION(ds = 'date') ...but it should also work to drop all partitions prior to date. ALTER TABLE foo DROP PARTITION(ds 'date') This task is to implement ALTER TABLE DROP PARTITION for all of the comparators, = = = != instead of just for =. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2908) Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators
[ https://issues.apache.org/jira/browse/HIVE-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241029#comment-13241029 ] Phabricator commented on HIVE-2908: --- sambavim has commented on the revision HIVE-2908 [jira] Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators. Note: The committer will need to run the below test with -Doverwrite=true due to a problem with arc diff loading the differential on the test results. ant test -Dtestcase=TestCliDriver -Dqfile=escape1.q -Doverwrite=true REVISION DETAIL https://reviews.facebook.net/D2523 Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators - Key: HIVE-2908 URL: https://issues.apache.org/jira/browse/HIVE-2908 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: Sambavi Muthukrishnan Assignee: Sambavi Muthukrishnan Priority: Minor Attachments: HIVE-2908.D2523.1.patch, HIVE-2908.D2523.2.patch Original Estimate: 96h Remaining Estimate: 96h To drop a partition from a Hive table, this works: ALTER TABLE foo DROP PARTITION(ds = 'date') ...but it should also work to drop all partitions prior to date. ALTER TABLE foo DROP PARTITION(ds 'date') This task is to implement ALTER TABLE DROP PARTITION for all of the comparators, = = = != instead of just for =. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2908) Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators
[ https://issues.apache.org/jira/browse/HIVE-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240823#comment-13240823 ] Phabricator commented on HIVE-2908: --- kevinwilfong has commented on the revision HIVE-2908 [jira] Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators. Looks good, just some cosmetic things. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/plan/PartitionSpec.java:61 Why do you change the != to , why not use whichever the user chose to use? ql/src/test/results/clientnegative/drop_partition_filter_failure.q.out:18 This error message seems confusing, the filter was 1, so it should not be surprising that the partition '1' was not found. (I know why this exception was thrown, I'm just saying the message could be improved) ql/src/test/queries/clientpositive/drop_partitions_filter.q:18 Out of curiosity, does the behavior change if you use d=2 vs. d='2'? REVISION DETAIL https://reviews.facebook.net/D2523 Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators - Key: HIVE-2908 URL: https://issues.apache.org/jira/browse/HIVE-2908 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: Sambavi Muthukrishnan Assignee: Sambavi Muthukrishnan Priority: Minor Attachments: HIVE-2908.D2523.1.patch Original Estimate: 96h Remaining Estimate: 96h To drop a partition from a Hive table, this works: ALTER TABLE foo DROP PARTITION(ds = 'date') ...but it should also work to drop all partitions prior to date. ALTER TABLE foo DROP PARTITION(ds 'date') This task is to implement ALTER TABLE DROP PARTITION for all of the comparators, = = = != instead of just for =. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2908) Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators
[ https://issues.apache.org/jira/browse/HIVE-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240860#comment-13240860 ] Phabricator commented on HIVE-2908: --- sambavim has commented on the revision HIVE-2908 [jira] Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators. Will update review once I make the change to the error message. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/plan/PartitionSpec.java:61 I found the != produced the unexpected side effect that it actually behaved like an =. That was obviously a problem, so I decided to just convert it to a for safety. I didn't debug why I got that behavior with a !=, but I suspect it is because != is not a valid operator on a filter against the database. What was surprising is the outcome of deleting the partition that was specified in the !=. ql/src/test/queries/clientpositive/drop_partitions_filter.q:18 I'll test it and report back. ql/src/test/results/clientnegative/drop_partition_filter_failure.q.out:18 Will fix. Good catch. REVISION DETAIL https://reviews.facebook.net/D2523 Hive: Extend ALTER TABLE DROP PARTITION syntax to use all comparators - Key: HIVE-2908 URL: https://issues.apache.org/jira/browse/HIVE-2908 Project: Hive Issue Type: Improvement Components: Query Processor Reporter: Sambavi Muthukrishnan Assignee: Sambavi Muthukrishnan Priority: Minor Attachments: HIVE-2908.D2523.1.patch Original Estimate: 96h Remaining Estimate: 96h To drop a partition from a Hive table, this works: ALTER TABLE foo DROP PARTITION(ds = 'date') ...but it should also work to drop all partitions prior to date. ALTER TABLE foo DROP PARTITION(ds 'date') This task is to implement ALTER TABLE DROP PARTITION for all of the comparators, = = = != instead of just for =. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
