[jira] [Commented] (HIVE-2948) HiveFileFormatUtils should use Path.SEPARATOR instead of File.Separator

2013-01-09 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13548234#comment-13548234
 ] 

Hudson commented on HIVE-2948:
--

Integrated in Hive-trunk-hadoop2 #54 (See 
[https://builds.apache.org/job/Hive-trunk-hadoop2/54/])
HIVE-2948 [jira] HiveFileFormatUtils should use Path.SEPARATOR instead of
File.Separator

Summary:
https://issues.apache.org/jira/browse/HIVE-2948

Simple patch which replaces File.separator to Path.SEPARATOR since separator for
hdfs path is Path.SEPARATOR not java's File.SEPARATOR

Because its munging hdfs paths and not OS paths.

Test Plan: EMPTY

Reviewers: JIRA, kevinwilfong

Reviewed By: kevinwilfong

Differential Revision: https://reviews.facebook.net/D2763 (Revision 1325615)

 Result = ABORTED
hashutosh : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1325615
Files : 
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java


 HiveFileFormatUtils should use Path.SEPARATOR instead of File.Separator
 ---

 Key: HIVE-2948
 URL: https://issues.apache.org/jira/browse/HIVE-2948
 Project: Hive
  Issue Type: Bug
Reporter: Ashutosh Chauhan
Assignee: Ashutosh Chauhan
 Fix For: 0.9.0

 Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2948.D2763.1.patch


 Because its munging hdfs paths and not OS paths.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-2948) HiveFileFormatUtils should use Path.SEPARATOR instead of File.Separator

2012-04-13 Thread Hudson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253357#comment-13253357
 ] 

Hudson commented on HIVE-2948:
--

Integrated in Hive-trunk-h0.21 #1371 (See 
[https://builds.apache.org/job/Hive-trunk-h0.21/1371/])
HIVE-2948 [jira] HiveFileFormatUtils should use Path.SEPARATOR instead of
File.Separator

Summary:
https://issues.apache.org/jira/browse/HIVE-2948

Simple patch which replaces File.separator to Path.SEPARATOR since separator for
hdfs path is Path.SEPARATOR not java's File.SEPARATOR

Because its munging hdfs paths and not OS paths.

Test Plan: EMPTY

Reviewers: JIRA, kevinwilfong

Reviewed By: kevinwilfong

Differential Revision: https://reviews.facebook.net/D2763 (Revision 1325615)

 Result = ABORTED
hashutosh : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1325615
Files : 
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java


 HiveFileFormatUtils should use Path.SEPARATOR instead of File.Separator
 ---

 Key: HIVE-2948
 URL: https://issues.apache.org/jira/browse/HIVE-2948
 Project: Hive
  Issue Type: Bug
Reporter: Ashutosh Chauhan
Assignee: Ashutosh Chauhan
 Attachments: HIVE-2948.D2763.1.patch


 Because its munging hdfs paths and not OS paths.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HIVE-2948) HiveFileFormatUtils should use Path.SEPARATOR instead of File.Separator

2012-04-12 Thread Ashutosh Chauhan (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253080#comment-13253080
 ] 

Ashutosh Chauhan commented on HIVE-2948:


All the tests passed.

 HiveFileFormatUtils should use Path.SEPARATOR instead of File.Separator
 ---

 Key: HIVE-2948
 URL: https://issues.apache.org/jira/browse/HIVE-2948
 Project: Hive
  Issue Type: Bug
Reporter: Ashutosh Chauhan
Assignee: Ashutosh Chauhan
 Attachments: HIVE-2948.D2763.1.patch


 Because its munging hdfs paths and not OS paths.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HIVE-2948) HiveFileFormatUtils should use Path.SEPARATOR instead of File.Separator

2012-04-12 Thread Phabricator (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253104#comment-13253104
 ] 

Phabricator commented on HIVE-2948:
---

kevinwilfong has accepted the revision HIVE-2948 [jira] HiveFileFormatUtils 
should use Path.SEPARATOR instead of File.Separator.

  +1

REVISION DETAIL
  https://reviews.facebook.net/D2763

BRANCH
  svn


 HiveFileFormatUtils should use Path.SEPARATOR instead of File.Separator
 ---

 Key: HIVE-2948
 URL: https://issues.apache.org/jira/browse/HIVE-2948
 Project: Hive
  Issue Type: Bug
Reporter: Ashutosh Chauhan
Assignee: Ashutosh Chauhan
 Attachments: HIVE-2948.D2763.1.patch


 Because its munging hdfs paths and not OS paths.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HIVE-2948) HiveFileFormatUtils should use Path.SEPARATOR instead of File.Separator

2012-04-12 Thread Phabricator (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253109#comment-13253109
 ] 

Phabricator commented on HIVE-2948:
---

ashutoshc has committed the revision HIVE-2948 [jira] HiveFileFormatUtils 
should use Path.SEPARATOR instead of File.Separator.

  Change committed by hashutosh.

REVISION DETAIL
  https://reviews.facebook.net/D2763

COMMIT
  https://reviews.facebook.net/rHIVE1325615


 HiveFileFormatUtils should use Path.SEPARATOR instead of File.Separator
 ---

 Key: HIVE-2948
 URL: https://issues.apache.org/jira/browse/HIVE-2948
 Project: Hive
  Issue Type: Bug
Reporter: Ashutosh Chauhan
Assignee: Ashutosh Chauhan
 Attachments: HIVE-2948.D2763.1.patch


 Because its munging hdfs paths and not OS paths.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira