[jira] [Commented] (HIVE-2959) TestRemoteHiveMetaStoreIpAddress always uses the same port
[ https://issues.apache.org/jira/browse/HIVE-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13548189#comment-13548189 ] Hudson commented on HIVE-2959: -- Integrated in Hive-trunk-hadoop2 #54 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/54/]) HIVE-2959 [jira] TestRemoteHiveMetaStoreIpAddress always uses the same port (Kevin Wilfong via Ashutosh Chauhan) Summary: https://issues.apache.org/jira/browse/HIVE-2959 TestRemoteHiveMetaStoreIpAddress now uses the standard way of finding a free port using Java's ServerSocket class. TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if another process happens to be using that port, the tests cannot succeed. There seems to be a standard way of finding a free port using Java's ServerSocket class, this should be used instead. Test Plan: Ran TestRemoteHiveMetaStoreIpAddress and TestRemoteUGIHiveMetaStoreIpAddress, the two tests which would be affected by this change. I verified they passed and did not use port 39083. Reviewers: JIRA, njain, ashutoshc Reviewed By: ashutoshc Differential Revision: https://reviews.facebook.net/D2841 (Revision 1327591) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1327591 Files : * /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java TestRemoteHiveMetaStoreIpAddress always uses the same port -- Key: HIVE-2959 URL: https://issues.apache.org/jira/browse/HIVE-2959 Project: Hive Issue Type: Test Reporter: Kevin Wilfong Assignee: Kevin Wilfong Fix For: 0.10.0 Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2959.D2841.1.patch TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if another process happens to be using that port, the tests cannot succeed. There seems to be a standard way of finding a free port using Java's ServerSocket class, this should be used instead. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2959) TestRemoteHiveMetaStoreIpAddress always uses the same port
[ https://issues.apache.org/jira/browse/HIVE-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256734#comment-13256734 ] Phabricator commented on HIVE-2959: --- kevinwilfong has committed the revision HIVE-2959 [jira] TestRemoteHiveMetaStoreIpAddress always uses the same port. Change committed by hashutosh. REVISION DETAIL https://reviews.facebook.net/D2841 COMMIT https://reviews.facebook.net/rHIVE1327591 TestRemoteHiveMetaStoreIpAddress always uses the same port -- Key: HIVE-2959 URL: https://issues.apache.org/jira/browse/HIVE-2959 Project: Hive Issue Type: Test Reporter: Kevin Wilfong Assignee: Kevin Wilfong Fix For: 0.10 Attachments: HIVE-2959.D2841.1.patch TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if another process happens to be using that port, the tests cannot succeed. There seems to be a standard way of finding a free port using Java's ServerSocket class, this should be used instead. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2959) TestRemoteHiveMetaStoreIpAddress always uses the same port
[ https://issues.apache.org/jira/browse/HIVE-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257148#comment-13257148 ] Hudson commented on HIVE-2959: -- Integrated in Hive-trunk-h0.21 #1382 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1382/]) HIVE-2959 [jira] TestRemoteHiveMetaStoreIpAddress always uses the same port (Kevin Wilfong via Ashutosh Chauhan) Summary: https://issues.apache.org/jira/browse/HIVE-2959 TestRemoteHiveMetaStoreIpAddress now uses the standard way of finding a free port using Java's ServerSocket class. TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if another process happens to be using that port, the tests cannot succeed. There seems to be a standard way of finding a free port using Java's ServerSocket class, this should be used instead. Test Plan: Ran TestRemoteHiveMetaStoreIpAddress and TestRemoteUGIHiveMetaStoreIpAddress, the two tests which would be affected by this change. I verified they passed and did not use port 39083. Reviewers: JIRA, njain, ashutoshc Reviewed By: ashutoshc Differential Revision: https://reviews.facebook.net/D2841 (Revision 1327591) Result = SUCCESS hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1327591 Files : * /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java TestRemoteHiveMetaStoreIpAddress always uses the same port -- Key: HIVE-2959 URL: https://issues.apache.org/jira/browse/HIVE-2959 Project: Hive Issue Type: Test Reporter: Kevin Wilfong Assignee: Kevin Wilfong Fix For: 0.10 Attachments: HIVE-2959.D2841.1.patch TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if another process happens to be using that port, the tests cannot succeed. There seems to be a standard way of finding a free port using Java's ServerSocket class, this should be used instead. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
