[jira] [Commented] (HIVE-2991) Integrate Clover with Hive
[ https://issues.apache.org/jira/browse/HIVE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706097#comment-13706097 ] Ashutosh Chauhan commented on HIVE-2991: [~iveselovsky] Seems like you have expanded the scope of this jira quite a bit. Your other changes (introducing targets in build system) are quite useful, but they are orthogonal to clover integration (as far as i understand). I would suggest to split the patch in three parts: one for clover integration, second for improvement in test infrastructure and third for improvements in build infra. > Integrate Clover with Hive > -- > > Key: HIVE-2991 > URL: https://issues.apache.org/jira/browse/HIVE-2991 > Project: Hive > Issue Type: Test > Components: Testing Infrastructure >Affects Versions: 0.9.0 >Reporter: Ashutosh Chauhan >Assignee: Ivan A. Veselovsky > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2991.D2985.1.patch, > hive.2991.1.branch-0.10.patch, hive.2991.1.branch-0.9.patch, > hive.2991.1.trunk.patch, hive.2991.2.branch-0.10.patch, > hive.2991.2.branch-0.9.patch, hive.2991.2.trunk.patch, > hive.2991.3.branch-0.10.patch, hive.2991.3.branch-0.9.patch, > hive.2991.3.trunk.patch, hive.2991.4.branch-0.10.patch, > hive.2991.4.branch-0.9.patch, hive.2991.4.trunk.patch, > HIVE-clover-branch-0.10--N1.patch, HIVE-clover-branch-0.11--N1.patch, > HIVE-clover-trunk--N1.patch, hive-trunk-clover-html-report.zip > > > Atlassian has donated license of their code coverage tool Clover to ASF. Lets > make use of it to generate code coverage report to figure out which areas of > Hive are well tested and which ones are not. More information about license > can be found in Hadoop jira HADOOP-1718 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2991) Integrate Clover with Hive
[ https://issues.apache.org/jira/browse/HIVE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554851#comment-13554851 ] Ilya Katsov commented on HIVE-2991: --- Indentations are fixed in hive.2991.2.* patches. Generated code is excluded in build.xml as a part of report generation (see clover.report.filest fileset). clover.jar property is used to enable clover, clover will be inactive if this property missed. clover.license.path is a clover's internal property and it is not mandatory if the license is placed in the clover's lib directory. If the license is missed, clover prints the error message itself. > Integrate Clover with Hive > -- > > Key: HIVE-2991 > URL: https://issues.apache.org/jira/browse/HIVE-2991 > Project: Hive > Issue Type: Test > Components: Testing Infrastructure >Affects Versions: 0.9.0 >Reporter: Ashutosh Chauhan > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2991.D2985.1.patch, > hive.2991.1.branch-0.10.patch, hive.2991.1.branch-0.9.patch, > hive.2991.1.trunk.patch, hive.2991.2.branch-0.10.patch, > hive.2991.2.branch-0.9.patch, hive.2991.2.trunk.patch, > hive-trunk-clover-html-report.zip > > > Atlassian has donated license of their code coverage tool Clover to ASF. Lets > make use of it to generate code coverage report to figure out which areas of > Hive are well tested and which ones are not. More information about license > can be found in Hadoop jira HADOOP-1718 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2991) Integrate Clover with Hive
[ https://issues.apache.org/jira/browse/HIVE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553399#comment-13553399 ] Ashutosh Chauhan commented on HIVE-2991: I am not actively working on this one. Ashish,Ilya or any one else whoever is interested, feel free to pick it up, if interested. > Integrate Clover with Hive > -- > > Key: HIVE-2991 > URL: https://issues.apache.org/jira/browse/HIVE-2991 > Project: Hive > Issue Type: Test > Components: Testing Infrastructure >Affects Versions: 0.9.0 >Reporter: Ashutosh Chauhan >Assignee: Ashutosh Chauhan > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2991.D2985.1.patch, > hive.2991.1.branch-0.10.patch, hive.2991.1.branch-0.9.patch, > hive.2991.1.trunk.patch, hive.2991.2.branch-0.10.patch, > hive.2991.2.branch-0.9.patch, hive.2991.2.trunk.patch, > hive-trunk-clover-html-report.zip > > > Atlassian has donated license of their code coverage tool Clover to ASF. Lets > make use of it to generate code coverage report to figure out which areas of > Hive are well tested and which ones are not. More information about license > can be found in Hadoop jira HADOOP-1718 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2991) Integrate Clover with Hive
[ https://issues.apache.org/jira/browse/HIVE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553295#comment-13553295 ] Ashish Vaidya commented on HIVE-2991: - I'm new to Ant/Ivy based builds. Please pardon my ignorance. Could someone please explain what's the rationale behind excluding com.cenqua.clover in ivy.xml and then using -Dclover.jar to pass in the Clover JAR location? I understand -Dclover.license.path to be configurable as each user is supposed to have his/her own Clover license. What could go wrong if we have in the ivy.xml instead of that 'exclude?' Is this JAR not compliant/compatible with Apache License? AFAIK, maven-clover-plugin uses this same JAR and is used in other Apache Hadoop projects. > Integrate Clover with Hive > -- > > Key: HIVE-2991 > URL: https://issues.apache.org/jira/browse/HIVE-2991 > Project: Hive > Issue Type: Test > Components: Testing Infrastructure >Affects Versions: 0.9.0 >Reporter: Ashutosh Chauhan >Assignee: Ashutosh Chauhan > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2991.D2985.1.patch, > hive.2991.1.branch-0.10.patch, hive.2991.1.branch-0.9.patch, > hive.2991.1.trunk.patch, hive.2991.2.branch-0.10.patch, > hive.2991.2.branch-0.9.patch, hive.2991.2.trunk.patch, > hive-trunk-clover-html-report.zip > > > Atlassian has donated license of their code coverage tool Clover to ASF. Lets > make use of it to generate code coverage report to figure out which areas of > Hive are well tested and which ones are not. More information about license > can be found in Hadoop jira HADOOP-1718 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2991) Integrate Clover with Hive
[ https://issues.apache.org/jira/browse/HIVE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552937#comment-13552937 ] Phabricator commented on HIVE-2991: --- cwsteinbach has requested changes to the revision "HIVE-2991 [jira] Integrate Clover with Hive". INLINE COMMENTS build-common.xml:112 indentation build-common.xml:125 indentation build-common.xml:118 We should exclude generated code (e.g. metastore/src/gen, metastore/src/model) from this list. build-common.xml:115 This should check to see if clover.license.path and clover.jar are set, and print an informative error message if they're missing. REVISION DETAIL https://reviews.facebook.net/D2985 BRANCH svn To: JIRA, cwsteinbach, ashutoshc > Integrate Clover with Hive > -- > > Key: HIVE-2991 > URL: https://issues.apache.org/jira/browse/HIVE-2991 > Project: Hive > Issue Type: Test > Components: Testing Infrastructure >Affects Versions: 0.9.0 >Reporter: Ashutosh Chauhan >Assignee: Ashutosh Chauhan > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2991.D2985.1.patch, > hive.2991.1.branch-0.10.patch, hive.2991.1.branch-0.9.patch, > hive.2991.1.trunk.patch, hive.2991.2.branch-0.10.patch, > hive.2991.2.branch-0.9.patch, hive.2991.2.trunk.patch, > hive-trunk-clover-html-report.zip > > > Atlassian has donated license of their code coverage tool Clover to ASF. Lets > make use of it to generate code coverage report to figure out which areas of > Hive are well tested and which ones are not. More information about license > can be found in Hadoop jira HADOOP-1718 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2991) Integrate Clover with Hive
[
https://issues.apache.org/jira/browse/HIVE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552887#comment-13552887
]
Andrey Klochkov commented on HIVE-2991:
---
Daisy, you need to use "clover.license.path" JVM parameter. This is how we
build:
{code}
ant clean package test clover-reports -Dtest.silent=false
-Dtest.ignore.failures=true -Dtest.junit.output.format=xml
-Dclover.jar=$CLOVER_HOME/lib/clover.jar
-Dclover.license.path=$HOME/.clover.license
{code}
> Integrate Clover with Hive
> --
>
> Key: HIVE-2991
> URL: https://issues.apache.org/jira/browse/HIVE-2991
> Project: Hive
> Issue Type: Test
> Components: Testing Infrastructure
>Affects Versions: 0.9.0
>Reporter: Ashutosh Chauhan
>Assignee: Ashutosh Chauhan
> Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2991.D2985.1.patch,
> hive.2991.1.branch-0.10.patch, hive.2991.1.branch-0.9.patch,
> hive.2991.1.trunk.patch, hive.2991.2.branch-0.10.patch,
> hive.2991.2.branch-0.9.patch, hive.2991.2.trunk.patch,
> hive-trunk-clover-html-report.zip
>
>
> Atlassian has donated license of their code coverage tool Clover to ASF. Lets
> make use of it to generate code coverage report to figure out which areas of
> Hive are well tested and which ones are not. More information about license
> can be found in Hadoop jira HADOOP-1718
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2991) Integrate Clover with Hive
[ https://issues.apache.org/jira/browse/HIVE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551869#comment-13551869 ] Daisy.Yuan commented on HIVE-2991: -- when run “ ant clean package test clover-reports -Dclover.jar=/opt/yoo/clover-2.6.2.jar”, it meets the following exception: /opt/trunk/build.xml:264: The following error occurred while executing this line: /opt/trunk/build-common.xml:126: java.lang.RuntimeException: Invalid or missing License.. Please visit http://my.atlassian.com to obtain a valid license. at com.cenqua.clover.CloverStartup.loadLicense(CloverStartup.java:58) at com.cenqua.clover.CloverStartup.loadLicense(CloverStartup.java:25) at com.cenqua.clover.tasks.AbstractCloverTask.execute(AbstractCloverTask.java:52) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) at org.apache.tools.ant.Task.perform(Task.java:348) at org.apache.tools.ant.Target.execute(Target.java:392) at org.apache.tools.ant.Target.performTasks(Target.java:413) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1399) at org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:38) at org.apache.tools.ant.Project.executeTargets(Project.java:1251) at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:442) at org.apache.tools.ant.taskdefs.SubAnt.execute(SubAnt.java:303) at org.apache.tools.ant.taskdefs.SubAnt.execute(SubAnt.java:221) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) at org.apache.tools.ant.Task.perform(Task.java:348) at org.apache.tools.ant.Target.execute(Target.java:392) at org.apache.tools.ant.Target.performTasks(Target.java:413) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1399) at org.apache.tools.ant.Project.executeTarget(Project.java:1368) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) at org.apache.tools.ant.Project.executeTargets(Project.java:1251) at org.apache.tools.ant.Main.runBuild(Main.java:811) at org.apache.tools.ant.Main.startAnt(Main.java:217) at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) Total time: 2 seconds The clover-2.6.x.jar needs license, and I get a try-it-free license, and add it to the Dclover.jar path. try it again, it still failed because of the above reason. Does it have any free jar to replace the clover.jar > Integrate Clover with Hive > -- > > Key: HIVE-2991 > URL: https://issues.apache.org/jira/browse/HIVE-2991 > Project: Hive > Issue Type: Test > Components: Testing Infrastructure >Affects Versions: 0.9.0 >Reporter: Ashutosh Chauhan >Assignee: Ashutosh Chauhan > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2991.D2985.1.patch, > hive.2991.1.branch-0.10.patch, hive.2991.1.branch-0.9.patch, > hive.2991.1.trunk.patch, hive.2991.2.branch-0.10.patch, > hive.2991.2.branch-0.9.patch, hive.2991.2.trunk.patch, > hive-trunk-clover-html-report.zip > > > Atlassian has donated license of their code coverage tool Clover to ASF. Lets > make use of it to generate code coverage report to figure out which areas of > Hive are well tested and which ones are not. More information about license > can be found in Hadoop jira HADOOP-1718 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2991) Integrate Clover with Hive
[ https://issues.apache.org/jira/browse/HIVE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527542#comment-13527542 ] Ashutosh Chauhan commented on HIVE-2991: [~ikatsov] Can you link the report that you got by running clover on recent hive trunk? > Integrate Clover with Hive > -- > > Key: HIVE-2991 > URL: https://issues.apache.org/jira/browse/HIVE-2991 > Project: Hive > Issue Type: Test > Components: Testing Infrastructure >Affects Versions: 0.9.0 >Reporter: Ashutosh Chauhan >Assignee: Ashutosh Chauhan > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2991.D2985.1.patch, > hive.2991.1.branch-0.10.patch, hive.2991.1.branch-0.9.patch, > hive.2991.1.trunk.patch > > > Atlassian has donated license of their code coverage tool Clover to ASF. Lets > make use of it to generate code coverage report to figure out which areas of > Hive are well tested and which ones are not. More information about license > can be found in Hadoop jira HADOOP-1718 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2991) Integrate Clover with Hive
[ https://issues.apache.org/jira/browse/HIVE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526169#comment-13526169 ] Ilya Katsov commented on HIVE-2991: --- Apparently it makes sense to exclude auto generated and sample code from the coverage reports to obtain realistic total coverage percentage. Updated patches has been attached. > Integrate Clover with Hive > -- > > Key: HIVE-2991 > URL: https://issues.apache.org/jira/browse/HIVE-2991 > Project: Hive > Issue Type: Test > Components: Testing Infrastructure >Affects Versions: 0.9.0 >Reporter: Ashutosh Chauhan >Assignee: Ashutosh Chauhan > Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2991.D2985.1.patch, > hive.2991.1.branch-0.10.patch, hive.2991.1.branch-0.9.patch, > hive.2991.1.trunk.patch > > > Atlassian has donated license of their code coverage tool Clover to ASF. Lets > make use of it to generate code coverage report to figure out which areas of > Hive are well tested and which ones are not. More information about license > can be found in Hadoop jira HADOOP-1718 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2991) Integrate Clover with Hive
[ https://issues.apache.org/jira/browse/HIVE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265795#comment-13265795 ] Edward Capriolo commented on HIVE-2991: --- It is a nice report, as I expected I am not sure the coverage accurately depicts reality http://people.apache.org/~hashutosh/hive-clover/ql/. You would think that all the clientpositive directory would give better coverage. Still a good thing to have and improve on. > Integrate Clover with Hive > -- > > Key: HIVE-2991 > URL: https://issues.apache.org/jira/browse/HIVE-2991 > Project: Hive > Issue Type: Test > Components: Testing Infrastructure >Reporter: Ashutosh Chauhan >Assignee: Ashutosh Chauhan > Attachments: HIVE-2991.D2985.1.patch > > > Atlassian has donated license of their code coverage tool Clover to ASF. Lets > make use of it to generate code coverage report to figure out which areas of > Hive are well tested and which ones are not. More information about license > can be found in Hadoop jira HADOOP-1718 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2991) Integrate Clover with Hive
[ https://issues.apache.org/jira/browse/HIVE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265621#comment-13265621 ] Ashutosh Chauhan commented on HIVE-2991: Here is the report I got by running it on hive trunk of last week: http://people.apache.org/~hashutosh/hive-clover/ > Integrate Clover with Hive > -- > > Key: HIVE-2991 > URL: https://issues.apache.org/jira/browse/HIVE-2991 > Project: Hive > Issue Type: Test > Components: Testing Infrastructure >Reporter: Ashutosh Chauhan >Assignee: Ashutosh Chauhan > Attachments: HIVE-2991.D2985.1.patch > > > Atlassian has donated license of their code coverage tool Clover to ASF. Lets > make use of it to generate code coverage report to figure out which areas of > Hive are well tested and which ones are not. More information about license > can be found in Hadoop jira HADOOP-1718 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2991) Integrate Clover with Hive
[ https://issues.apache.org/jira/browse/HIVE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265584#comment-13265584 ] Edward Capriolo commented on HIVE-2991: --- I would be interested to see this. The crazy way we use velocity templates to generate out unit tests had me thinking that clover would not work well. I would like to be pleasantly surprised. > Integrate Clover with Hive > -- > > Key: HIVE-2991 > URL: https://issues.apache.org/jira/browse/HIVE-2991 > Project: Hive > Issue Type: Test > Components: Testing Infrastructure >Reporter: Ashutosh Chauhan >Assignee: Ashutosh Chauhan > Attachments: HIVE-2991.D2985.1.patch > > > Atlassian has donated license of their code coverage tool Clover to ASF. Lets > make use of it to generate code coverage report to figure out which areas of > Hive are well tested and which ones are not. More information about license > can be found in Hadoop jira HADOOP-1718 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
