[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13450726#comment-13450726
]
Ashutosh Chauhan commented on HIVE-3323:
Thanks, Travis for updating the patch. I will run test and commit this soon.
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch,
HIVE-3323_enum_to_string.6.patch, HIVE-3323_enum_to_string.8.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449024#comment-13449024
]
Ashutosh Chauhan commented on HIVE-3323:
MultiKey stuff you added in OIcache doesn't look particularly clean. I think
motivation for making that change was if there are multiple ThriftDeserializer
in a job and for some reason they have different value for this new config key,
you wanted to return different OIs with correct config. Intention is benign,
but I am not sure if this really will work though. First of all its a rare
condition that you have more then one serde in a job, only place I can think of
is when you are reading two different tables in a same job (probably for
joining) this will come up. There since configuration object is same for whole
job, you are going to get only one value for whole job for your config key, not
for each serde. So, even if some comes up with this rare use case of having two
different ThriftSerDe which differs on this property, I doubt this will work.
Further, this introduces dependecy on commons-collections which implies we need
to package and ship this jar to backend. Thirdly, it introduces code
complexity. So, I think we should drop this Multi-Key stuff for OIcache and
keep it in original form. You might be able to make this work if you keep this
config key in Table properties instead of Configuration, but I think we are
introducing too much complexity for a rare case. At this point I will retract
from opening up this option of having structint. Lets always convert to
string going forward, keeping the code changes to minimal and avoiding
complexity.
Another feedback is I think for JavaStringObjectInspector. I think instead of
testing for type of object, you can always return o.toString() there, since if
it was Enum, thats what you are doing and if it were String, then toString() on
String returns {{this}} so we will get desired result for both cases and avoid
type-check test.
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch,
HIVE-3323_enum_to_string.6.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449063#comment-13449063
]
Travis Crawford commented on HIVE-3323:
---
Thanks for the feedback Ashutosh – I agree making this conversion optional
introduces complexity, and will remove the option + update the patch.
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch,
HIVE-3323_enum_to_string.6.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449416#comment-13449416
]
Ashutosh Chauhan commented on HIVE-3323:
+1
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch,
HIVE-3323_enum_to_string.6.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447975#comment-13447975
]
Ashutosh Chauhan commented on HIVE-3323:
I agree that enums as string (as oppose to structint) makes more sense in all
cases. So we can change the default behavior. But since functionality existed
in previous releases and folks might be using it, we should add a config param
in case folks already using thrift serde can fall back to old behavior in case
they want to. I dont think we need to add that option for Avro though since
there ever was only was one way of doing it for Avro data.
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448079#comment-13448079
]
Travis Crawford commented on HIVE-3323:
---
Sounds good [~ashutoshc]! I'm rebasing this patch against trunk and making
enum-to-string the default, and leaving a property in place to disable the
conversion. I'll open a reviewboard for the updated patch.
I'm excited to get MegaStruct in, so we can add test cases for some bizarre but
valid thrift structs we've come across :)
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448155#comment-13448155
]
Jakob Homan commented on HIVE-3323:
---
bq. MegaStruct
eh?
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448184#comment-13448184
]
Travis Crawford commented on HIVE-3323:
---
While making a number of thrift-related change, I've found testing has been a
challenge because we didn't have a really comprehensive thrift struct with all
the field types we wanted to test. Part of this change is a new struct that
actually has an enum field, but also stuff like a binary field (which we now
see has basically the same issue as enum, where the HeapByteBuffer is treated
like a struct rather than byte[]), set fields (which I didn't realize until
recently are not supported, etc. Now we'll have visibility into this stuff and
can fix.
{code}
struct MegaStruct {
1: optional bool my_bool,
2: optional byte my_byte,
3: optional i16 my_16bit_int,
4: optional i32 my_32bit_int,
5: optional i64 my_64bit_int,
6: optional double my_double,
7: optional string my_string,
8: optional binary my_binary,
9: optional mapstring, string my_string_string_map,
10: optional mapstring, MyEnum my_string_enum_map,
11: optional mapMyEnum, string my_enum_string_map,
12: optional mapMyEnum, MiniStruct my_enum_struct_map,
13: optional mapMyEnum, liststring my_enum_stringlist_map,
14: optional mapMyEnum, listMiniStruct my_enum_structlist_map,
15: optional liststring my_stringlist,
16: optional listMiniStruct my_structlist,
17: optional listMyEnum my_enumlist,
18: optional setstring my_stringset,
19: optional setMyEnum my_enumset,
20: optional setMiniStruct my_structset
}
{code}
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13445500#comment-13445500
]
Ashutosh Chauhan commented on HIVE-3323:
Travis,
Can you create a review request on reviews.apache.org ?
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13444247#comment-13444247
]
Travis Crawford commented on HIVE-3323:
---
Hey all, good discussion about this enum issue. After thinking about the
comments, I think it would be appropriate to always convert enum values to
strings, as the Avro serde does.
Here's why:
* Native Hive queries: enums-as-strings make the most sense
* Pig queries through HCat: enums-as-strings make the most sense
* MR jobs through HCat: enums-as-strings are reasonable, and if users actually
want the int value they can convert in their code.
Since enums-as-strings makes sense for scripting languages, and users do not
loose functionality in MR jobs, I think it makes sense to always convert enums
to strings.
Thoughts? If this sounds good I can update the patch.
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440713#comment-13440713
]
Jakob Homan commented on HIVE-3323:
---
One comment I have:
{noformat}
+CONVERT_ENUM_TO_STRING(hive.data.convert.enum.to.string, false),
{noformat}
since AvroSerde already does this and doesn't provide an option not to, can we
change option name to be thrift specific?
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440719#comment-13440719
]
Dmitriy V. Ryaboy commented on HIVE-3323:
-
Jakob, that sounds like something to fix in AvroSerde.
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440722#comment-13440722
]
Dmitriy V. Ryaboy commented on HIVE-3323:
-
Sorry, let me try a less snide reply :)
It doesn't make sense to me to have a situation where you are working with
Thrift and Avro, and you want to not convert from Thrift but you do want to
convert from Avro. What you really want is establish how Hive does serde type
conversions, not how it does them for individual encodings of data.
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440724#comment-13440724
]
Jakob Homan commented on HIVE-3323:
---
Right, but AvroSerde already does this conversion is what I'm saying. There's
never been an option not to do the conversion.
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440739#comment-13440739
]
Dmitriy V. Ryaboy commented on HIVE-3323:
-
How about if we (as in, me/feng/travis) make a patch for AvroSerde to respect
this property?
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440741#comment-13440741
]
Jakob Homan commented on HIVE-3323:
---
Is the current Thrift behavior worth keeping around? Maybe just convert it to
just do the string conversion? I can't come up with a use case where I would
want the struct Thrift provides.
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440748#comment-13440748
]
Dmitriy V. Ryaboy commented on HIVE-3323:
-
We are thinking of a situation where you are going through HCat but consuming
in something that speaks structs, your own service.
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440821#comment-13440821
]
Jakob Homan commented on HIVE-3323:
---
OK, but that sounds like a less frequently useful use case than converting to
strings. Should we make the default behavior convert-to-string and add
convert-to-struct as an option for thrift and avro?
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440838#comment-13440838
]
Dmitriy V. Ryaboy commented on HIVE-3323:
-
I am ok with making the default true. Don't think that would break anything.
Feng?
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3323) ThriftSerde: Enable enum to string conversions
[
https://issues.apache.org/jira/browse/HIVE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440844#comment-13440844
]
Feng Peng commented on HIVE-3323:
-
I think it is fine. The current behavior for thrift is false and that's why we
set it to false in the current patch. But I don't think people are using SerDe
to read complex thrift data, otherwise they would have complained about this
(and other problems we are having right now) already.
ThriftSerde: Enable enum to string conversions
--
Key: HIVE-3323
URL: https://issues.apache.org/jira/browse/HIVE-3323
Project: Hive
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: Travis Crawford
Assignee: Travis Crawford
Attachments: HIVE-3323_enum_to_string.1.patch,
HIVE-3323_enum_to_string.2.patch, HIVE-3323_enum_to_string.3.patch,
HIVE-3323_enum_to_string.4.patch, HIVE-3323_enum_to_string.5.patch
When using serde-reported schemas with the ThriftDeserializer, Enum fields
are presented as {{structvalue:int}}
Many users expect to work with the string values, which is both easier and
more meaningful as the string value communicates what is represented.
Hive should provide a mechanism to optionally convert enum values to strings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
