[jira] [Commented] (HIVE-3492) Provide ALTER for partition changing bucket number
[ https://issues.apache.org/jira/browse/HIVE-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13534070#comment-13534070 ] Hudson commented on HIVE-3492: -- Integrated in Hive-trunk-h0.21 #1860 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1860/]) HIVE-3492 Provide ALTER for partition changing bucket number (Navis via namit) (Revision 1422749) Result = SUCCESS namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1422749 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java * /hive/trunk/ql/src/test/queries/clientpositive/alter_numbuckets_partitioned_table.q * /hive/trunk/ql/src/test/results/clientpositive/alter_numbuckets_partitioned_table.q.out Provide ALTER for partition changing bucket number --- Key: HIVE-3492 URL: https://issues.apache.org/jira/browse/HIVE-3492 Project: Hive Issue Type: Improvement Reporter: Navis Assignee: Navis Priority: Trivial Fix For: 0.11 Attachments: HIVE-3492.1.patch.txt, HIVE-3492.2.patch.txt, HIVE-3492.D5589.2.patch, HIVE-3492.D5589.3.patch As a follow up of HIVE-3283, bucket number of a partition could be set/changed individually by query like 'ALTER table srcpart PARTIRION(ds='1999') SET BUCKETNUM 5'. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3492) Provide ALTER for partition changing bucket number
[ https://issues.apache.org/jira/browse/HIVE-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13534661#comment-13534661 ] Namit Jain commented on HIVE-3492: -- [~navis], please add documentation for this change. Provide ALTER for partition changing bucket number --- Key: HIVE-3492 URL: https://issues.apache.org/jira/browse/HIVE-3492 Project: Hive Issue Type: Improvement Reporter: Navis Assignee: Navis Priority: Trivial Fix For: 0.11 Attachments: HIVE-3492.1.patch.txt, HIVE-3492.2.patch.txt, HIVE-3492.D5589.2.patch, HIVE-3492.D5589.3.patch As a follow up of HIVE-3283, bucket number of a partition could be set/changed individually by query like 'ALTER table srcpart PARTIRION(ds='1999') SET BUCKETNUM 5'. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3492) Provide ALTER for partition changing bucket number
[ https://issues.apache.org/jira/browse/HIVE-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528649#comment-13528649 ] Phabricator commented on HIVE-3492: --- navis has commented on the revision HIVE-3492 [jira] Provide ALTER for partition changing bucket number. I tried to use 'alterStatementSuffixClusterbySortby' but it was not so simple. 1. cannot make 'tableBuckets' have optional cluster by clause, which is used by create DDL 2. 'alterStatementSuffixClusterbySortby' accept table name only. To make it accept table spec, still another definition would be needed REVISION DETAIL https://reviews.facebook.net/D5589 To: JIRA, navis Cc: njain Provide ALTER for partition changing bucket number --- Key: HIVE-3492 URL: https://issues.apache.org/jira/browse/HIVE-3492 Project: Hive Issue Type: Improvement Reporter: Navis Assignee: Navis Priority: Trivial Attachments: HIVE-3492.1.patch.txt, HIVE-3492.2.patch.txt, HIVE-3492.D5589.2.patch, HIVE-3492.D5589.3.patch As a follow up of HIVE-3283, bucket number of a partition could be set/changed individually by query like 'ALTER table srcpart PARTIRION(ds='1999') SET BUCKETNUM 5'. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3492) Provide ALTER for partition changing bucket number
[ https://issues.apache.org/jira/browse/HIVE-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461628#comment-13461628 ] Phabricator commented on HIVE-3492: --- navis has commented on the revision HIVE-3492 [jira] Provide ALTER for partition changing bucket number. INLINE COMMENTS ql/src/test/queries/clientpositive/alter_numbuckets_partitioned_table.q:25 Ok, your version (~ into ~ buckets) is way better. I'll update patch. ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:1881 There was so many hardcoded messages in this class and I just wanted to look consistent. Ok, Ill add an error code. REVISION DETAIL https://reviews.facebook.net/D5589 To: JIRA, navis Cc: njain Provide ALTER for partition changing bucket number --- Key: HIVE-3492 URL: https://issues.apache.org/jira/browse/HIVE-3492 Project: Hive Issue Type: Improvement Affects Versions: 0.10.0 Reporter: Navis Assignee: Navis Priority: Trivial Attachments: HIVE-3492.1.patch.txt As a follow up of HIVE-3283, bucket number of a partition could be set/changed individually by query like 'ALTER table srcpart PARTIRION(ds='1999') SET BUCKETNUM 5'. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3492) Provide ALTER for partition changing bucket number
[ https://issues.apache.org/jira/browse/HIVE-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461656#comment-13461656 ] Phabricator commented on HIVE-3492: --- njain has commented on the revision HIVE-3492 [jira] Provide ALTER for partition changing bucket number. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g:748 Why do you need this ? Cant you reuse alterStatementSuffixClusterbySortby ? ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:1881 error code REVISION DETAIL https://reviews.facebook.net/D5589 To: JIRA, navis Cc: njain Provide ALTER for partition changing bucket number --- Key: HIVE-3492 URL: https://issues.apache.org/jira/browse/HIVE-3492 Project: Hive Issue Type: Improvement Affects Versions: 0.10.0 Reporter: Navis Assignee: Navis Priority: Trivial Attachments: HIVE-3492.1.patch.txt, HIVE-3492.2.patch.txt, HIVE-3492.D5589.2.patch As a follow up of HIVE-3283, bucket number of a partition could be set/changed individually by query like 'ALTER table srcpart PARTIRION(ds='1999') SET BUCKETNUM 5'. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3492) Provide ALTER for partition changing bucket number
[ https://issues.apache.org/jira/browse/HIVE-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13462286#comment-13462286 ] Phabricator commented on HIVE-3492: --- navis has commented on the revision HIVE-3492 [jira] Provide ALTER for partition changing bucket number. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g:748 I just wanted to prevent using DDL like alter table table partition spec cluster by cols, which is not valid. It can be checked in DDLSemanticAnalyzer but I thought it's more safe. ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:1881 Sorry, missed. REVISION DETAIL https://reviews.facebook.net/D5589 To: JIRA, navis Cc: njain Provide ALTER for partition changing bucket number --- Key: HIVE-3492 URL: https://issues.apache.org/jira/browse/HIVE-3492 Project: Hive Issue Type: Improvement Affects Versions: 0.10.0 Reporter: Navis Assignee: Navis Priority: Trivial Attachments: HIVE-3492.1.patch.txt, HIVE-3492.2.patch.txt, HIVE-3492.D5589.2.patch As a follow up of HIVE-3283, bucket number of a partition could be set/changed individually by query like 'ALTER table srcpart PARTIRION(ds='1999') SET BUCKETNUM 5'. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3492) Provide ALTER for partition changing bucket number
[ https://issues.apache.org/jira/browse/HIVE-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461441#comment-13461441 ] Phabricator commented on HIVE-3492: --- njain has commented on the revision HIVE-3492 [jira] Provide ALTER for partition changing bucket number. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:1881 Add a new error in ErrorMsg.java ql/src/test/queries/clientpositive/alter_numbuckets_partitioned_table.q:25 Why do you want to introduce this new token ? Why not support??? alter table tst1 into 4 buckets; and alter table tst1 partition (ds='1') into 6 buckets; Basically, support the existing syntax alter table tst1 clustered by key into 4 buckets; without the clustered by REVISION DETAIL https://reviews.facebook.net/D5589 To: JIRA, navis Cc: njain Provide ALTER for partition changing bucket number --- Key: HIVE-3492 URL: https://issues.apache.org/jira/browse/HIVE-3492 Project: Hive Issue Type: Improvement Affects Versions: 0.10.0 Reporter: Navis Assignee: Navis Priority: Trivial Attachments: HIVE-3492.1.patch.txt As a follow up of HIVE-3283, bucket number of a partition could be set/changed individually by query like 'ALTER table srcpart PARTIRION(ds='1999') SET BUCKETNUM 5'. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
