[jira] [Commented] (HIVE-3772) Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by Reynold Xin)
[ https://issues.apache.org/jira/browse/HIVE-3772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510333#comment-13510333 ] Reynold Xin commented on HIVE-3772: --- Thanks for submitting this, Mikhail. Note that this was introduced in 0.9. In 0.7, this was not a problem ... > Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by > Reynold Xin) > - > > Key: HIVE-3772 > URL: https://issues.apache.org/jira/browse/HIVE-3772 > Project: Hive > Issue Type: Bug >Reporter: Mikhail Bautin > > Creating a JIRA for [~rxin]'s patch needed by the Shark project. > https://github.com/amplab/hive/commit/17e1c3dd2f6d8eca767115dc46d5a880aed8c765 > writeVLong should not use a static field due to concurrency concerns. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3772) Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by Reynold Xin)
[ https://issues.apache.org/jira/browse/HIVE-3772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534359#comment-13534359 ] Phabricator commented on HIVE-3772: --- dhruba has resigned from the revision "[jira] [HIVE-3772] Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by Reynold Xin)". REVISION DETAIL https://reviews.facebook.net/D7155 To: ashutoshc, njain, raghotham, JIRA, zshao, heyongqiang, nzhang, jsichi, pauly, amareshwarisr, cwsteinbach, mbautin > Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by > Reynold Xin) > - > > Key: HIVE-3772 > URL: https://issues.apache.org/jira/browse/HIVE-3772 > Project: Hive > Issue Type: Bug >Reporter: Mikhail Bautin > Attachments: D7155.1.patch, HIVE-3772-2012-12-04.patch > > > Creating a JIRA for [~rxin]'s patch needed by the Shark project. > https://github.com/amplab/hive/commit/17e1c3dd2f6d8eca767115dc46d5a880aed8c765 > writeVLong should not use a static field due to concurrency concerns. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3772) Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by Reynold Xin)
[ https://issues.apache.org/jira/browse/HIVE-3772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538354#comment-13538354 ] Phabricator commented on HIVE-3772: --- zshao has requested changes to the revision "[jira] [HIVE-3772] Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by Reynold Xin)". Please take this opportunity to fix all static variables in this file. By the way, a better way to fix is to use ThreadLocal. That's more effiicient because then we don't need to call new in these low-level functions. INLINE COMMENTS serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java:126 Is this a problem for multi-threaded access as well? REVISION DETAIL https://reviews.facebook.net/D7155 BRANCH HIVE-3772-static-vLongBytes To: ashutoshc, njain, raghotham, JIRA, zshao, heyongqiang, nzhang, jsichi, pauly, amareshwarisr, cwsteinbach, mbautin > Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by > Reynold Xin) > - > > Key: HIVE-3772 > URL: https://issues.apache.org/jira/browse/HIVE-3772 > Project: Hive > Issue Type: Bug >Reporter: Mikhail Bautin > Attachments: D7155.1.patch, HIVE-3772-2012-12-04.patch > > > Creating a JIRA for [~rxin]'s patch needed by the Shark project. > https://github.com/amplab/hive/commit/17e1c3dd2f6d8eca767115dc46d5a880aed8c765 > writeVLong should not use a static field due to concurrency concerns. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3772) Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by Reynold Xin)
[ https://issues.apache.org/jira/browse/HIVE-3772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651287#comment-13651287 ] Konstantin Boudnik commented on HIVE-3772: -- Is there any change of this get fixed in 0.11? > Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by > Reynold Xin) > - > > Key: HIVE-3772 > URL: https://issues.apache.org/jira/browse/HIVE-3772 > Project: Hive > Issue Type: Bug >Reporter: Mikhail Bautin > Attachments: D7155.1.patch, D7155.2.patch, HIVE-3772-2012-12-04.patch > > > Creating a JIRA for [~rxin]'s patch needed by the Shark project. > https://github.com/amplab/hive/commit/17e1c3dd2f6d8eca767115dc46d5a880aed8c765 > writeVLong should not use a static field due to concurrency concerns. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3772) Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by Reynold Xin)
[ https://issues.apache.org/jira/browse/HIVE-3772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13735537#comment-13735537 ] Konstantin Boudnik commented on HIVE-3772: -- The patch applies cleanly to the current 0.11 branch HEAD so it seems like a good candidate for maintenance 0.11.1 release? > Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by > Reynold Xin) > - > > Key: HIVE-3772 > URL: https://issues.apache.org/jira/browse/HIVE-3772 > Project: Hive > Issue Type: Bug > Components: Serializers/Deserializers >Affects Versions: 0.9.0 >Reporter: Mikhail Bautin > Attachments: D7155.1.patch, D7155.2.patch, HIVE-3772-2012-12-04.patch > > > Creating a JIRA for [~rxin]'s patch needed by the Shark project. > https://github.com/amplab/hive/commit/17e1c3dd2f6d8eca767115dc46d5a880aed8c765 > writeVLong should not use a static field due to concurrency concerns. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3772) Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by Reynold Xin)
[ https://issues.apache.org/jira/browse/HIVE-3772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13735709#comment-13735709 ] Edward Capriolo commented on HIVE-3772: --- Looking now. > Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by > Reynold Xin) > - > > Key: HIVE-3772 > URL: https://issues.apache.org/jira/browse/HIVE-3772 > Project: Hive > Issue Type: Bug > Components: Serializers/Deserializers >Affects Versions: 0.9.0 >Reporter: Mikhail Bautin > Attachments: D7155.1.patch, D7155.2.patch, HIVE-3772-2012-12-04.patch > > > Creating a JIRA for [~rxin]'s patch needed by the Shark project. > https://github.com/amplab/hive/commit/17e1c3dd2f6d8eca767115dc46d5a880aed8c765 > writeVLong should not use a static field due to concurrency concerns. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3772) Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by Reynold Xin)
[ https://issues.apache.org/jira/browse/HIVE-3772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13735717#comment-13735717 ] Edward Capriolo commented on HIVE-3772: --- I am +1. Thread local is not perfect but surely better then static. > Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by > Reynold Xin) > - > > Key: HIVE-3772 > URL: https://issues.apache.org/jira/browse/HIVE-3772 > Project: Hive > Issue Type: Bug > Components: Serializers/Deserializers >Affects Versions: 0.9.0 >Reporter: Mikhail Bautin > Attachments: D7155.1.patch, D7155.2.patch, HIVE-3772-2012-12-04.patch > > > Creating a JIRA for [~rxin]'s patch needed by the Shark project. > https://github.com/amplab/hive/commit/17e1c3dd2f6d8eca767115dc46d5a880aed8c765 > writeVLong should not use a static field due to concurrency concerns. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3772) Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by Reynold Xin)
[
https://issues.apache.org/jira/browse/HIVE-3772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13735894#comment-13735894
]
Hive QA commented on HIVE-3772:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12597250/HIVE-3772.1.patch.txt
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 2774 tests executed
*Failed tests:*
{noformat}
org.apache.hcatalog.mapreduce.TestHCatExternalDynamicPartitioned.testHCatDynamicPartitionedTable
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_script_broken_pipe1
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/381/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/381/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests failed with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
> Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by
> Reynold Xin)
> -
>
> Key: HIVE-3772
> URL: https://issues.apache.org/jira/browse/HIVE-3772
> Project: Hive
> Issue Type: Bug
> Components: Serializers/Deserializers
>Affects Versions: 0.9.0
>Reporter: Mikhail Bautin
> Attachments: D7155.1.patch, D7155.2.patch, HIVE-3772.1.patch.txt,
> HIVE-3772-2012-12-04.patch
>
>
> Creating a JIRA for [~rxin]'s patch needed by the Shark project.
> https://github.com/amplab/hive/commit/17e1c3dd2f6d8eca767115dc46d5a880aed8c765
> writeVLong should not use a static field due to concurrency concerns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
