[jira] [Commented] (HIVE-3981) Split up tests in ptf_general_queries.q
[ https://issues.apache.org/jira/browse/HIVE-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13570400#comment-13570400 ] Ashutosh Chauhan commented on HIVE-3981: [~rhbutani] Can you attach .rcfile and .seqfile here on jira, I can than generate the full patch. Split up tests in ptf_general_queries.q --- Key: HIVE-3981 URL: https://issues.apache.org/jira/browse/HIVE-3981 Project: Hive Issue Type: Task Components: PTF-Windowing Reporter: Ashutosh Chauhan Assignee: Ashutosh Chauhan Attachments: hive-3981.patch ptf_general_queries.q has 62 queries currently and it takes nearly 20 minutes on my laptop to finish. I think we should break it down in smaller .q files otherwise adding a new query and debugging it will be a pain. I have split out rcfile and seqfile tests from it to begin. Also, this test currently fails because original patch didn't had .rc and .seq files (they were binary). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3981) Split up tests in ptf_general_queries.q
[ https://issues.apache.org/jira/browse/HIVE-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13570485#comment-13570485 ] Harish Butani commented on HIVE-3981: - I attached the files. Several things: - the rc seq file were in the original patch. So why do you need them here - We have struggled with this issue. The reason to keep all tests in 1 file is we make sure all the ptf tests run before every commit. Can we have a junit suite for all these tests. I would request that developers continue to make sure all these tests run before a commit. - A hack we use to speed up running all the tests is to explicitly set 'runningViaChild = false' line 133 MapRedTask.java. The 70 tests run in under 5 minutes with this setting. Split up tests in ptf_general_queries.q --- Key: HIVE-3981 URL: https://issues.apache.org/jira/browse/HIVE-3981 Project: Hive Issue Type: Task Components: PTF-Windowing Reporter: Ashutosh Chauhan Assignee: Ashutosh Chauhan Attachments: hive-3981.patch, part.rc, part.seq ptf_general_queries.q has 62 queries currently and it takes nearly 20 minutes on my laptop to finish. I think we should break it down in smaller .q files otherwise adding a new query and debugging it will be a pain. I have split out rcfile and seqfile tests from it to begin. Also, this test currently fails because original patch didn't had .rc and .seq files (they were binary). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3981) Split up tests in ptf_general_queries.q
[ https://issues.apache.org/jira/browse/HIVE-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13570809#comment-13570809 ] Harish Butani commented on HIVE-3981: - Oh yes, I forgot. +1 Split up tests in ptf_general_queries.q --- Key: HIVE-3981 URL: https://issues.apache.org/jira/browse/HIVE-3981 Project: Hive Issue Type: Task Components: PTF-Windowing Reporter: Ashutosh Chauhan Assignee: Ashutosh Chauhan Attachments: hive-3981_2.patch, hive-3981.patch, part.rc, part.seq ptf_general_queries.q has 62 queries currently and it takes nearly 20 minutes on my laptop to finish. I think we should break it down in smaller .q files otherwise adding a new query and debugging it will be a pain. I have split out rcfile and seqfile tests from it to begin. Also, this test currently fails because original patch didn't had .rc and .seq files (they were binary). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
