[jira] [Commented] (HIVE-4141) InspectorFactories contains static HashMaps which can cause infinite loop
[ https://issues.apache.org/jira/browse/HIVE-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13623006#comment-13623006 ] Hudson commented on HIVE-4141: -- Integrated in Hive-trunk-hadoop2 #138 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/138/]) Hive-4141 InspectorFactories use static HashMaps which fail in concurrent modification (Brock Noland via egc) Submitted by: Brock Noland Reviewed by: Edward Capriolo Approved by: Edward Capriolo (Revision 1456756) Result = FAILURE InspectorFactories contains static HashMaps which can cause infinite loop - Key: HIVE-4141 URL: https://issues.apache.org/jira/browse/HIVE-4141 Project: Hive Issue Type: Sub-task Components: Server Infrastructure Reporter: Brock Noland Assignee: Brock Noland Priority: Blocker Fix For: 0.11.0 Attachments: HIVE-4141-1.patch, HIVE-4141-2.patch When many clients hit hs2, hs2 can get stuck in an infinite loop due to concurrent modification of the static maps here: https://github.com/apache/hive/blob/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java and in other ObjectFactories. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4141) InspectorFactories contains static HashMaps which can cause infinite loop
[ https://issues.apache.org/jira/browse/HIVE-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13604158#comment-13604158 ] Hudson commented on HIVE-4141: -- Integrated in Hive-trunk-h0.21 #2016 (See [https://builds.apache.org/job/Hive-trunk-h0.21/2016/]) Hive-4141 InspectorFactories use static HashMaps which fail in concurrent modification (Brock Noland via egc) Submitted by: Brock Noland Reviewed by: Edward Capriolo Approved by: Edward Capriolo (Revision 1456756) Result = ABORTED InspectorFactories contains static HashMaps which can cause infinite loop - Key: HIVE-4141 URL: https://issues.apache.org/jira/browse/HIVE-4141 Project: Hive Issue Type: Sub-task Components: Server Infrastructure Reporter: Brock Noland Assignee: Brock Noland Priority: Blocker Fix For: 0.11.0 Attachments: HIVE-4141-1.patch, HIVE-4141-2.patch When many clients hit hs2, hs2 can get stuck in an infinite loop due to concurrent modification of the static maps here: https://github.com/apache/hive/blob/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java and in other ObjectFactories. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4141) InspectorFactories contains static HashMaps which can cause infinite loop
[ https://issues.apache.org/jira/browse/HIVE-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1360#comment-1360 ] Brock Noland commented on HIVE-4141: Sorry looks like the first patch was committed. The differences were only style improvements over the original code so I don't think this is an issue. I'll file a follow up JIRA to implement the style improvements requested by Owen in the review. InspectorFactories contains static HashMaps which can cause infinite loop - Key: HIVE-4141 URL: https://issues.apache.org/jira/browse/HIVE-4141 Project: Hive Issue Type: Sub-task Components: Server Infrastructure Reporter: Brock Noland Priority: Blocker Fix For: 0.11.0 Attachments: HIVE-4141-1.patch, HIVE-4141-2.patch When many clients hit hs2, hs2 can get stuck in an infinite loop due to concurrent modification of the static maps here: https://github.com/apache/hive/blob/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java and in other ObjectFactories. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4141) InspectorFactories contains static HashMaps which can cause infinite loop
[ https://issues.apache.org/jira/browse/HIVE-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13603054#comment-13603054 ] Edward Capriolo commented on HIVE-4141: --- +1. Will try to get to this this weekend/ InspectorFactories contains static HashMaps which can cause infinite loop - Key: HIVE-4141 URL: https://issues.apache.org/jira/browse/HIVE-4141 Project: Hive Issue Type: Sub-task Components: Server Infrastructure Reporter: Brock Noland Priority: Blocker Fix For: 0.11.0 Attachments: HIVE-4141-1.patch When many clients hit hs2, hs2 can get stuck in an infinite loop due to concurrent modification of the static maps here: https://github.com/apache/hive/blob/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java and in other ObjectFactories. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4141) InspectorFactories contains static HashMaps which can cause infinite loop
[ https://issues.apache.org/jira/browse/HIVE-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13597991#comment-13597991 ] Jarek Jarcec Cecho commented on HIVE-4141: -- +1 (non-binding) InspectorFactories contains static HashMaps which can cause infinite loop - Key: HIVE-4141 URL: https://issues.apache.org/jira/browse/HIVE-4141 Project: Hive Issue Type: Sub-task Components: Server Infrastructure Reporter: Brock Noland Attachments: HIVE-4141-1.patch When many clients hit hs2, hs2 can get stuck in an infinite loop due to concurrent modification of the static maps here: https://github.com/apache/hive/blob/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java and in other ObjectFactories. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4141) InspectorFactories contains static HashMaps which can cause infinite loop
[ https://issues.apache.org/jira/browse/HIVE-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13597437#comment-13597437 ] Brock Noland commented on HIVE-4141: Two solutions, make the methods synchronizes or use ConcurrentHashMaps. CHM makes sense as these objects are stateless. InspectorFactories contains static HashMaps which can cause infinite loop - Key: HIVE-4141 URL: https://issues.apache.org/jira/browse/HIVE-4141 Project: Hive Issue Type: Sub-task Components: Server Infrastructure Reporter: Brock Noland When many clients hit hs2, hs2 can get stuck in an infinite loop due to concurrent modification of the static maps here: https://github.com/apache/hive/blob/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java and in other ObjectFactories. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
