[jira] [Commented] (HIVE-4549) JDBC compliance change TABLE_SCHEMA to TABLE_SCHEM
[ https://issues.apache.org/jira/browse/HIVE-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13680173#comment-13680173 ] Hudson commented on HIVE-4549: -- Integrated in Hive-trunk-h0.21 #2137 (See [https://builds.apache.org/job/Hive-trunk-h0.21/2137/]) HIVE-4549 : JDBC compliance change TABLE_SCHEMA to TABLE_SCHEM (Prasad Mujumdar via Navis) (Revision 1491676) Result = FAILURE navis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1491676 Files : * /hive/trunk/jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java * /hive/trunk/service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java JDBC compliance change TABLE_SCHEMA to TABLE_SCHEM -- Key: HIVE-4549 URL: https://issues.apache.org/jira/browse/HIVE-4549 Project: Hive Issue Type: Improvement Components: JDBC Affects Versions: 0.10.0 Environment: Hive 0.10 Reporter: Johndee Burks Assignee: Prasad Mujumdar Priority: Trivial Labels: newbie Fix For: 0.12.0 Attachments: HIVE-4549-1.patch The ResultSet returned by HiveDatabaseMetadata.getTables has the metadata columns TABLE_CAT, TABLE_SCHEMA, TABLE_NAME, TABLE_TYPE, REMARKS. The second column name is not compliant with the JDBC standard (http://docs.oracle.com/javase/6/docs/api/java/sql/DatabaseMetaData.html#getSchemas()): the column name should be TABLE_SCHEM instead of TABLE_SCHEMA. Suggested fix in Hive (org.apache.hive.service.cli.operation.GetTablesOperation.java) change from private static final TableSchema RESULT_SET_SCHEMA = new TableSchema() .addStringColumn(TABLE_CAT, Catalog name. NULL if not applicable.) .addStringColumn(TABLE_SCHEMA, Schema name.) .addStringColumn(TABLE_NAME, Table name.) .addStringColumn(TABLE_TYPE, The table type, e.g. \TABLE\, \VIEW\, etc.) .addStringColumn(REMARKS, Comments about the table.); to private static final TableSchema RESULT_SET_SCHEMA = new TableSchema() .addStringColumn(TABLE_CAT, Catalog name. NULL if not applicable.) .addStringColumn(TABLE_SCHEM, Schema name.) .addStringColumn(TABLE_NAME, Table name.) .addStringColumn(TABLE_TYPE, The table type, e.g. \TABLE\, \VIEW\, etc.) .addStringColumn(REMARKS, Comments about the table.); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4549) JDBC compliance change TABLE_SCHEMA to TABLE_SCHEM
[ https://issues.apache.org/jira/browse/HIVE-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13678217#comment-13678217 ] Shreepadma Venugopalan commented on HIVE-4549: -- +1 (non-committer). LGTM. JDBC compliance change TABLE_SCHEMA to TABLE_SCHEM -- Key: HIVE-4549 URL: https://issues.apache.org/jira/browse/HIVE-4549 Project: Hive Issue Type: Improvement Components: JDBC Affects Versions: 0.10.0 Environment: Hive 0.10 Reporter: Johndee Burks Assignee: Prasad Mujumdar Priority: Trivial Labels: newbie Fix For: 0.12.0 Attachments: HIVE-4549-1.patch The ResultSet returned by HiveDatabaseMetadata.getTables has the metadata columns TABLE_CAT, TABLE_SCHEMA, TABLE_NAME, TABLE_TYPE, REMARKS. The second column name is not compliant with the JDBC standard (http://docs.oracle.com/javase/6/docs/api/java/sql/DatabaseMetaData.html#getSchemas()): the column name should be TABLE_SCHEM instead of TABLE_SCHEMA. Suggested fix in Hive (org.apache.hive.service.cli.operation.GetTablesOperation.java) change from private static final TableSchema RESULT_SET_SCHEMA = new TableSchema() .addStringColumn(TABLE_CAT, Catalog name. NULL if not applicable.) .addStringColumn(TABLE_SCHEMA, Schema name.) .addStringColumn(TABLE_NAME, Table name.) .addStringColumn(TABLE_TYPE, The table type, e.g. \TABLE\, \VIEW\, etc.) .addStringColumn(REMARKS, Comments about the table.); to private static final TableSchema RESULT_SET_SCHEMA = new TableSchema() .addStringColumn(TABLE_CAT, Catalog name. NULL if not applicable.) .addStringColumn(TABLE_SCHEM, Schema name.) .addStringColumn(TABLE_NAME, Table name.) .addStringColumn(TABLE_TYPE, The table type, e.g. \TABLE\, \VIEW\, etc.) .addStringColumn(REMARKS, Comments about the table.); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4549) JDBC compliance change TABLE_SCHEMA to TABLE_SCHEM
[ https://issues.apache.org/jira/browse/HIVE-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13672214#comment-13672214 ] Ashutosh Chauhan commented on HIVE-4549: Hi [~johndee] would you like to format your suggested change as patch and submit ? JDBC compliance change TABLE_SCHEMA to TABLE_SCHEM -- Key: HIVE-4549 URL: https://issues.apache.org/jira/browse/HIVE-4549 Project: Hive Issue Type: Improvement Components: JDBC Affects Versions: 0.10.0 Environment: Hive 0.10 Reporter: Johndee Burks Priority: Trivial Labels: newbie The ResultSet returned by HiveDatabaseMetadata.getTables has the metadata columns TABLE_CAT, TABLE_SCHEMA, TABLE_NAME, TABLE_TYPE, REMARKS. The second column name is not compliant with the JDBC standard (http://docs.oracle.com/javase/6/docs/api/java/sql/DatabaseMetaData.html#getSchemas()): the column name should be TABLE_SCHEM instead of TABLE_SCHEMA. Suggested fix in Hive (org.apache.hive.service.cli.operation.GetTablesOperation.java) change from private static final TableSchema RESULT_SET_SCHEMA = new TableSchema() .addStringColumn(TABLE_CAT, Catalog name. NULL if not applicable.) .addStringColumn(TABLE_SCHEMA, Schema name.) .addStringColumn(TABLE_NAME, Table name.) .addStringColumn(TABLE_TYPE, The table type, e.g. \TABLE\, \VIEW\, etc.) .addStringColumn(REMARKS, Comments about the table.); to private static final TableSchema RESULT_SET_SCHEMA = new TableSchema() .addStringColumn(TABLE_CAT, Catalog name. NULL if not applicable.) .addStringColumn(TABLE_SCHEM, Schema name.) .addStringColumn(TABLE_NAME, Table name.) .addStringColumn(TABLE_TYPE, The table type, e.g. \TABLE\, \VIEW\, etc.) .addStringColumn(REMARKS, Comments about the table.); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
