[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708711#comment-13708711 ] Hudson commented on HIVE-4580: -- FAILURE: Integrated in Hive-trunk-hadoop2-ptest #14 (See [https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/14/]) HIVE-4580 : Change DDLTask to report errors using canonical error messages rather than http status codes (Eugene Koifman via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1501053) * /hive/trunk/contrib/src/test/results/clientnegative/serde_regex.q.out * /hive/trunk/contrib/src/test/results/clientnegative/url_hook.q.out * /hive/trunk/hcatalog/src/test/e2e/templeton/tests/ddl.conf * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/AppConfig.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/BadParam.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/BusyException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/CallbackFailedException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/CatchallExceptionMapper.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/HcatDelegator.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/HcatException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/JsonBuilder.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/Main.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/NotAuthorizedException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/QueueException.java * /hive/trunk/hcatalog/webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestWebHCatE2e.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskResult.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveException.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/InvalidTableException.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java * /hive/trunk/ql/src/test/results/clientnegative/add_partition_with_whitelist.q.out * /hive/trunk/ql/src/test/results/clientnegative/addpart1.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_partition_nodrop_table.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_partition_with_whitelist.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure2.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure3.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_table_wrong_regex.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_view_failure4.q.out * /hive/trunk/ql/src/test/results/clientnegative/altern1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive2.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi2.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi3.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi4.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi5.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi6.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi7.q.out * /hive/trunk/ql/src/test/results/clientnegative/authorization_fail_1.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename1.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename2.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename4.q.out * /hive/trunk/ql/src/test/results/clientnegative/create_table_failure3.q.out * /hive/trunk/ql/src/test/results/clientnegative/create_table_failure4.q.out *
[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703010#comment-13703010 ] Hudson commented on HIVE-4580: -- Integrated in Hive-trunk-hadoop1-ptest #49 (See [https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/49/]) HIVE-4580 : Change DDLTask to report errors using canonical error messages rather than http status codes (Eugene Koifman via Ashutosh Chauhan) (Revision 1501053) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1501053 Files : * /hive/trunk/contrib/src/test/results/clientnegative/serde_regex.q.out * /hive/trunk/contrib/src/test/results/clientnegative/url_hook.q.out * /hive/trunk/hcatalog/src/test/e2e/templeton/tests/ddl.conf * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/AppConfig.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/BadParam.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/BusyException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/CallbackFailedException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/CatchallExceptionMapper.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/HcatDelegator.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/HcatException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/JsonBuilder.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/Main.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/NotAuthorizedException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/QueueException.java * /hive/trunk/hcatalog/webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestWebHCatE2e.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskResult.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveException.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/InvalidTableException.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java * /hive/trunk/ql/src/test/results/clientnegative/add_partition_with_whitelist.q.out * /hive/trunk/ql/src/test/results/clientnegative/addpart1.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_partition_nodrop_table.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_partition_with_whitelist.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure2.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure3.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_table_wrong_regex.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_view_failure4.q.out * /hive/trunk/ql/src/test/results/clientnegative/altern1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive2.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi2.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi3.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi4.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi5.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi6.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi7.q.out * /hive/trunk/ql/src/test/results/clientnegative/authorization_fail_1.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename1.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename2.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename4.q.out * /hive/trunk/ql/src/test/results/clientnegative/create_table_failure3.q.out *
[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703239#comment-13703239 ] Brock Noland commented on HIVE-4580: Hey guys, it looks like this caused HIVE-4829 which results in all tests failing and the parallel test system filling it's drives. Change DDLTask to report errors using canonical error messages rather than http status codes Key: HIVE-4580 URL: https://issues.apache.org/jira/browse/HIVE-4580 Project: Hive Issue Type: Bug Components: HCatalog Affects Versions: 0.11.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 Attachments: HIVE-4580.1.patch, HIVE-4580.2.patch, HIVE-4580.3.patch, HIVE-4580.patch Original Estimate: 40h Remaining Estimate: 40h org.apache.hadoop.hive.ql.exec.DDLTask handles DDL operations in Hive. Some operations (those exposed as REST API by Templeton) in this class, write a JSON object to stdout (on failure) which includes error and errorCode fields. errorCode is set to values like 404, 500, etc. i.e. Http Status codes. I believe this was done to support Templeton REST API. This is not the right place to introduce Http codes. DDLTask should use canonical error messages defined in org.apache.hadoop.hive.ql.ErrorMsg and propagate it up to HCatCli which can decide how to encode the error and to which stream. In particular it can create a parseable JSON object which Templeton can then interpret. JSON object can also be generated here for errors from the parser/resolver (e.g. trying to describe a table which doesn't exist). Then Templeton can map the canonical error code to appropriate Http Code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703368#comment-13703368 ] Brock Noland commented on HIVE-4580: Sorry to be unclear...that was caused by a bug in ptest2 which I am fixing at present. Change DDLTask to report errors using canonical error messages rather than http status codes Key: HIVE-4580 URL: https://issues.apache.org/jira/browse/HIVE-4580 Project: Hive Issue Type: Bug Components: HCatalog Affects Versions: 0.11.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 Attachments: HIVE-4580.1.patch, HIVE-4580.2.patch, HIVE-4580.3.patch, HIVE-4580.patch Original Estimate: 40h Remaining Estimate: 40h org.apache.hadoop.hive.ql.exec.DDLTask handles DDL operations in Hive. Some operations (those exposed as REST API by Templeton) in this class, write a JSON object to stdout (on failure) which includes error and errorCode fields. errorCode is set to values like 404, 500, etc. i.e. Http Status codes. I believe this was done to support Templeton REST API. This is not the right place to introduce Http codes. DDLTask should use canonical error messages defined in org.apache.hadoop.hive.ql.ErrorMsg and propagate it up to HCatCli which can decide how to encode the error and to which stream. In particular it can create a parseable JSON object which Templeton can then interpret. JSON object can also be generated here for errors from the parser/resolver (e.g. trying to describe a table which doesn't exist). Then Templeton can map the canonical error code to appropriate Http Code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703363#comment-13703363 ] Eugene Koifman commented on HIVE-4580: -- I can fix the checkstyle issue. Why do you think this is causing disks to fill up. There is nothing in this change that writes anything to disk (that I know of). Change DDLTask to report errors using canonical error messages rather than http status codes Key: HIVE-4580 URL: https://issues.apache.org/jira/browse/HIVE-4580 Project: Hive Issue Type: Bug Components: HCatalog Affects Versions: 0.11.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 Attachments: HIVE-4580.1.patch, HIVE-4580.2.patch, HIVE-4580.3.patch, HIVE-4580.patch Original Estimate: 40h Remaining Estimate: 40h org.apache.hadoop.hive.ql.exec.DDLTask handles DDL operations in Hive. Some operations (those exposed as REST API by Templeton) in this class, write a JSON object to stdout (on failure) which includes error and errorCode fields. errorCode is set to values like 404, 500, etc. i.e. Http Status codes. I believe this was done to support Templeton REST API. This is not the right place to introduce Http codes. DDLTask should use canonical error messages defined in org.apache.hadoop.hive.ql.ErrorMsg and propagate it up to HCatCli which can decide how to encode the error and to which stream. In particular it can create a parseable JSON object which Templeton can then interpret. JSON object can also be generated here for errors from the parser/resolver (e.g. trying to describe a table which doesn't exist). Then Templeton can map the canonical error code to appropriate Http Code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703734#comment-13703734 ] Hudson commented on HIVE-4580: -- Integrated in Hive-trunk-h0.21 #2188 (See [https://builds.apache.org/job/Hive-trunk-h0.21/2188/]) HIVE-4580 : Change DDLTask to report errors using canonical error messages rather than http status codes (Eugene Koifman via Ashutosh Chauhan) (Revision 1501053) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1501053 Files : * /hive/trunk/contrib/src/test/results/clientnegative/serde_regex.q.out * /hive/trunk/contrib/src/test/results/clientnegative/url_hook.q.out * /hive/trunk/hcatalog/src/test/e2e/templeton/tests/ddl.conf * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/AppConfig.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/BadParam.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/BusyException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/CallbackFailedException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/CatchallExceptionMapper.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/HcatDelegator.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/HcatException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/JsonBuilder.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/Main.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/NotAuthorizedException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/QueueException.java * /hive/trunk/hcatalog/webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestWebHCatE2e.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskResult.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveException.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/InvalidTableException.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java * /hive/trunk/ql/src/test/results/clientnegative/add_partition_with_whitelist.q.out * /hive/trunk/ql/src/test/results/clientnegative/addpart1.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_partition_nodrop_table.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_partition_with_whitelist.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure2.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure3.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_table_wrong_regex.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_view_failure4.q.out * /hive/trunk/ql/src/test/results/clientnegative/altern1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive2.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi2.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi3.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi4.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi5.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi6.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi7.q.out * /hive/trunk/ql/src/test/results/clientnegative/authorization_fail_1.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename1.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename2.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename4.q.out * /hive/trunk/ql/src/test/results/clientnegative/create_table_failure3.q.out * /hive/trunk/ql/src/test/results/clientnegative/create_table_failure4.q.out *
[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13704225#comment-13704225 ] Hudson commented on HIVE-4580: -- Integrated in Hive-trunk-hadoop2 #280 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/280/]) HIVE-4580 : Change DDLTask to report errors using canonical error messages rather than http status codes (Eugene Koifman via Ashutosh Chauhan) (Revision 1501053) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1501053 Files : * /hive/trunk/contrib/src/test/results/clientnegative/serde_regex.q.out * /hive/trunk/contrib/src/test/results/clientnegative/url_hook.q.out * /hive/trunk/hcatalog/src/test/e2e/templeton/tests/ddl.conf * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/AppConfig.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/BadParam.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/BusyException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/CallbackFailedException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/CatchallExceptionMapper.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/HcatDelegator.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/HcatException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/JsonBuilder.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/Main.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/NotAuthorizedException.java * /hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/QueueException.java * /hive/trunk/hcatalog/webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestWebHCatE2e.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskResult.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveException.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/InvalidTableException.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java * /hive/trunk/ql/src/test/results/clientnegative/add_partition_with_whitelist.q.out * /hive/trunk/ql/src/test/results/clientnegative/addpart1.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_partition_nodrop_table.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_partition_with_whitelist.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure2.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure3.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_table_wrong_regex.q.out * /hive/trunk/ql/src/test/results/clientnegative/alter_view_failure4.q.out * /hive/trunk/ql/src/test/results/clientnegative/altern1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive2.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi1.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi2.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi3.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi4.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi5.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi6.q.out * /hive/trunk/ql/src/test/results/clientnegative/archive_multi7.q.out * /hive/trunk/ql/src/test/results/clientnegative/authorization_fail_1.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename1.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename2.q.out * /hive/trunk/ql/src/test/results/clientnegative/column_rename4.q.out * /hive/trunk/ql/src/test/results/clientnegative/create_table_failure3.q.out * /hive/trunk/ql/src/test/results/clientnegative/create_table_failure4.q.out *
[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701162#comment-13701162 ] Ashutosh Chauhan commented on HIVE-4580: +1 Change DDLTask to report errors using canonical error messages rather than http status codes Key: HIVE-4580 URL: https://issues.apache.org/jira/browse/HIVE-4580 Project: Hive Issue Type: Bug Components: HCatalog Affects Versions: 0.11.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 Attachments: HIVE-4580.1.patch, HIVE-4580.2.patch, HIVE-4580.patch Original Estimate: 40h Remaining Estimate: 40h org.apache.hadoop.hive.ql.exec.DDLTask handles DDL operations in Hive. Some operations (those exposed as REST API by Templeton) in this class, write a JSON object to stdout (on failure) which includes error and errorCode fields. errorCode is set to values like 404, 500, etc. i.e. Http Status codes. I believe this was done to support Templeton REST API. This is not the right place to introduce Http codes. DDLTask should use canonical error messages defined in org.apache.hadoop.hive.ql.ErrorMsg and propagate it up to HCatCli which can decide how to encode the error and to which stream. In particular it can create a parseable JSON object which Templeton can then interpret. JSON object can also be generated here for errors from the parser/resolver (e.g. trying to describe a table which doesn't exist). Then Templeton can map the canonical error code to appropriate Http Code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13699699#comment-13699699 ] Thejas M Nair commented on HIVE-4580: - +1 for HIVE-4580.2.patch (non binding) Change DDLTask to report errors using canonical error messages rather than http status codes Key: HIVE-4580 URL: https://issues.apache.org/jira/browse/HIVE-4580 Project: Hive Issue Type: Bug Components: HCatalog Affects Versions: 0.11.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 Attachments: HIVE-4580.1.patch, HIVE-4580.2.patch, HIVE-4580.patch Original Estimate: 40h Remaining Estimate: 40h org.apache.hadoop.hive.ql.exec.DDLTask handles DDL operations in Hive. Some operations (those exposed as REST API by Templeton) in this class, write a JSON object to stdout (on failure) which includes error and errorCode fields. errorCode is set to values like 404, 500, etc. i.e. Http Status codes. I believe this was done to support Templeton REST API. This is not the right place to introduce Http codes. DDLTask should use canonical error messages defined in org.apache.hadoop.hive.ql.ErrorMsg and propagate it up to HCatCli which can decide how to encode the error and to which stream. In particular it can create a parseable JSON object which Templeton can then interpret. JSON object can also be generated here for errors from the parser/resolver (e.g. trying to describe a table which doesn't exist). Then Templeton can map the canonical error code to appropriate Http Code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13698486#comment-13698486 ] Thejas M Nair commented on HIVE-4580: - [~ekoifman] I have added some minor comments regarding your patch in reviewboard. Looks good overall. Change DDLTask to report errors using canonical error messages rather than http status codes Key: HIVE-4580 URL: https://issues.apache.org/jira/browse/HIVE-4580 Project: Hive Issue Type: Bug Components: HCatalog Affects Versions: 0.11.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 Attachments: HIVE-4580.1.patch, HIVE-4580.patch Original Estimate: 40h Remaining Estimate: 40h org.apache.hadoop.hive.ql.exec.DDLTask handles DDL operations in Hive. Some operations (those exposed as REST API by Templeton) in this class, write a JSON object to stdout (on failure) which includes error and errorCode fields. errorCode is set to values like 404, 500, etc. i.e. Http Status codes. I believe this was done to support Templeton REST API. This is not the right place to introduce Http codes. DDLTask should use canonical error messages defined in org.apache.hadoop.hive.ql.ErrorMsg and propagate it up to HCatCli which can decide how to encode the error and to which stream. In particular it can create a parseable JSON object which Templeton can then interpret. JSON object can also be generated here for errors from the parser/resolver (e.g. trying to describe a table which doesn't exist). Then Templeton can map the canonical error code to appropriate Http Code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689467#comment-13689467 ] Eugene Koifman commented on HIVE-4580: -- List of files in HIVE-4580.1.patch git diff-tree --no-commit-id --name-only -r 91a702fd80f044a3d71efd3ba41a27b05f2a240a 8d0568474a8f734d59304c4d4165ae7fd8beeb75 contrib/src/test/results/clientnegative/serde_regex.q.out contrib/src/test/results/clientnegative/url_hook.q.out hcatalog/src/test/e2e/templeton/tests/ddl.conf hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/AppConfig.java hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/BadParam.java hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/BusyException.java hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/CallbackFailedException.java hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/CatchallExceptionMapper.java hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/HcatDelegator.java hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/HcatException.java hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/JsonBuilder.java hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/Main.java hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/NotAuthorizedException.java hcatalog/webhcat/svr/src/main/java/org/apache/hcatalog/templeton/QueueException.java hcatalog/webhcat/svr/src/test/java/org/apache/hcatalog/templeton/TestWebHCatE2e.java ql/src/java/org/apache/hadoop/hive/ql/Driver.java ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java ql/src/java/org/apache/hadoop/hive/ql/exec/TaskResult.java ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveException.java ql/src/java/org/apache/hadoop/hive/ql/metadata/InvalidTableException.java ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java ql/src/test/results/clientnegative/add_partition_with_whitelist.q.out ql/src/test/results/clientnegative/addpart1.q.out ql/src/test/results/clientnegative/alter_partition_nodrop_table.q.out ql/src/test/results/clientnegative/alter_partition_with_whitelist.q.out ql/src/test/results/clientnegative/alter_rename_partition_failure.q.out ql/src/test/results/clientnegative/alter_rename_partition_failure2.q.out ql/src/test/results/clientnegative/alter_rename_partition_failure3.q.out ql/src/test/results/clientnegative/alter_table_wrong_regex.q.out ql/src/test/results/clientnegative/alter_view_failure4.q.out ql/src/test/results/clientnegative/altern1.q.out ql/src/test/results/clientnegative/archive1.q.out ql/src/test/results/clientnegative/archive2.q.out ql/src/test/results/clientnegative/archive_multi1.q.out ql/src/test/results/clientnegative/archive_multi2.q.out ql/src/test/results/clientnegative/archive_multi3.q.out ql/src/test/results/clientnegative/archive_multi4.q.out ql/src/test/results/clientnegative/archive_multi5.q.out ql/src/test/results/clientnegative/archive_multi6.q.out ql/src/test/results/clientnegative/archive_multi7.q.out ql/src/test/results/clientnegative/authorization_fail_1.q.out ql/src/test/results/clientnegative/column_rename1.q.out ql/src/test/results/clientnegative/column_rename2.q.out ql/src/test/results/clientnegative/column_rename4.q.out ql/src/test/results/clientnegative/create_table_failure3.q.out ql/src/test/results/clientnegative/create_table_failure4.q.out ql/src/test/results/clientnegative/create_table_wrong_regex.q.out ql/src/test/results/clientnegative/create_view_failure1.q.out ql/src/test/results/clientnegative/create_view_failure2.q.out ql/src/test/results/clientnegative/create_view_failure4.q.out ql/src/test/results/clientnegative/database_create_already_exists.q.out ql/src/test/results/clientnegative/database_create_invalid_name.q.out ql/src/test/results/clientnegative/database_drop_does_not_exist.q.out ql/src/test/results/clientnegative/database_drop_not_empty.q.out ql/src/test/results/clientnegative/database_drop_not_empty_restrict.q.out ql/src/test/results/clientnegative/database_switch_does_not_exist.q.out ql/src/test/results/clientnegative/deletejar.q.out ql/src/test/results/clientnegative/describe_xpath1.q.out ql/src/test/results/clientnegative/describe_xpath2.q.out ql/src/test/results/clientnegative/describe_xpath3.q.out ql/src/test/results/clientnegative/describe_xpath4.q.out
[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13682499#comment-13682499 ] Eugene Koifman commented on HIVE-4580: -- https://reviews.apache.org/r/11865/ Change DDLTask to report errors using canonical error messages rather than http status codes Key: HIVE-4580 URL: https://issues.apache.org/jira/browse/HIVE-4580 Project: Hive Issue Type: Bug Components: HCatalog Affects Versions: 0.11.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 Attachments: HIVE-4580.patch Original Estimate: 40h Remaining Estimate: 40h org.apache.hadoop.hive.ql.exec.DDLTask handles DDL operations in Hive. Some operations (those exposed as REST API by Templeton) in this class, write a JSON object to stdout (on failure) which includes error and errorCode fields. errorCode is set to values like 404, 500, etc. i.e. Http Status codes. I believe this was done to support Templeton REST API. This is not the right place to introduce Http codes. DDLTask should use canonical error messages defined in org.apache.hadoop.hive.ql.ErrorMsg and propagate it up to HCatCli which can decide how to encode the error and to which stream. In particular it can create a parseable JSON object which Templeton can then interpret. JSON object can also be generated here for errors from the parser/resolver (e.g. trying to describe a table which doesn't exist). Then Templeton can map the canonical error code to appropriate Http Code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13681842#comment-13681842 ] Eugene Koifman commented on HIVE-4580: -- The HIVE-4580.patch includes the following: Some DDL operations in Hive (DDLTask) used to produce HTTP Status codes to support WebHCat (Templeton). These operations now produce canonical errors based on ErrorMsg. WebHCat then maps the canonical error code to appropriate HTTP Status. Due to this refactoring a number of .q.out files changed though the changes are cosmetic. A new set of unit tests TestWebHCatE2e is added. These tests start a WebHCat server and make REST calls to it. Unlike hcatalog/src/test/e2e/templeton e2e tests, these are JUnit test and don't require any set up. These are suitable for DLL operation tests. Change DDLTask to report errors using canonical error messages rather than http status codes Key: HIVE-4580 URL: https://issues.apache.org/jira/browse/HIVE-4580 Project: Hive Issue Type: Bug Components: HCatalog Affects Versions: 0.11.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 Attachments: HIVE-4580.patch Original Estimate: 40h Remaining Estimate: 40h org.apache.hadoop.hive.ql.exec.DDLTask handles DDL operations in Hive. Some operations (those exposed as REST API by Templeton) in this class, write a JSON object to stdout (on failure) which includes error and errorCode fields. errorCode is set to values like 404, 500, etc. i.e. Http Status codes. I believe this was done to support Templeton REST API. This is not the right place to introduce Http codes. DDLTask should use canonical error messages defined in org.apache.hadoop.hive.ql.ErrorMsg and propagate it up to HCatCli which can decide how to encode the error and to which stream. In particular it can create a parseable JSON object which Templeton can then interpret. JSON object can also be generated here for errors from the parser/resolver (e.g. trying to describe a table which doesn't exist). Then Templeton can map the canonical error code to appropriate Http Code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4580) Change DDLTask to report errors using canonical error messages rather than http status codes
[ https://issues.apache.org/jira/browse/HIVE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13662577#comment-13662577 ] Eugene Koifman commented on HIVE-4580: -- https://hortonworks.jira.com/browse/BUG-36 Change DDLTask to report errors using canonical error messages rather than http status codes Key: HIVE-4580 URL: https://issues.apache.org/jira/browse/HIVE-4580 Project: Hive Issue Type: Bug Components: HCatalog Affects Versions: 0.11.0 Reporter: Eugene Koifman Original Estimate: 40h Remaining Estimate: 40h org.apache.hadoop.hive.ql.exec.DDLTask handles DDL operations in Hive. Some operations (those exposed as REST API by Templeton) in this class, write a JSON object to stdout (on failure) which includes error and errorCode fields. errorCode is set to values like 404, 500, etc. i.e. Http Status codes. I believe this was done to support Templeton REST API. This is not the right place to introduce Http codes. DDLTask should use canonical error messages defined in org.apache.hadoop.hive.ql.ErrorMsg and propagate it up to HCatCli which can decide how to encode the error and to which stream. In particular it can create a parseable JSON object which Templeton can then interpret. JSON object can also be generated here for errors from the parser/resolver (e.g. trying to describe a table which doesn't exist). Then Templeton can map the canonical error code to appropriate Http Code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
