[jira] [Commented] (HIVE-4658) Make KW_OUTER optional in outer joins

2013-07-15 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13708716#comment-13708716
 ] 

Hudson commented on HIVE-4658:
--

FAILURE: Integrated in Hive-trunk-hadoop2-ptest #14 (See 
[https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/14/])
HIVE-4658 : Make KW_OUTER optional in outer joins (Edward Capriolo via Navis) 
(navis: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1502758)
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/FromClauseParser.g
* /hive/trunk/ql/src/test/queries/clientpositive/optional_outer.q
* /hive/trunk/ql/src/test/results/clientpositive/optional_outer.q.out


> Make KW_OUTER optional in outer joins
> -
>
> Key: HIVE-4658
> URL: https://issues.apache.org/jira/browse/HIVE-4658
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Reporter: Navis
>Assignee: Edward Capriolo
>Priority: Trivial
> Fix For: 0.12.0
>
> Attachments: hive-4658.2.patch.txt, HIVE-4658.D11091.1.patch
>
>
> For really trivial migration issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-4658) Make KW_OUTER optional in outer joins

2013-07-13 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707949#comment-13707949
 ] 

Hudson commented on HIVE-4658:
--

SUCCESS: Integrated in Hive-Test-Patch-trunk-hadoop1-ptest #10 (See 
[https://builds.apache.org/job/Hive-Test-Patch-trunk-hadoop1-ptest/10/])
HIVE-4658 : Make KW_OUTER optional in outer joins (Edward Capriolo via Navis) 
(navis: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1502758)
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/FromClauseParser.g
* /hive/trunk/ql/src/test/queries/clientpositive/optional_outer.q
* /hive/trunk/ql/src/test/results/clientpositive/optional_outer.q.out


> Make KW_OUTER optional in outer joins
> -
>
> Key: HIVE-4658
> URL: https://issues.apache.org/jira/browse/HIVE-4658
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Reporter: Navis
>Assignee: Edward Capriolo
>Priority: Trivial
> Fix For: 0.12.0
>
> Attachments: hive-4658.2.patch.txt, HIVE-4658.D11091.1.patch
>
>
> For really trivial migration issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-4658) Make KW_OUTER optional in outer joins

2013-07-13 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707853#comment-13707853
 ] 

Hudson commented on HIVE-4658:
--

ABORTED: Integrated in Hive-trunk-h0.21 #2196 (See 
[https://builds.apache.org/job/Hive-trunk-h0.21/2196/])
HIVE-4658 : Make KW_OUTER optional in outer joins (Edward Capriolo via Navis) 
(navis: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1502758)
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/FromClauseParser.g
* /hive/trunk/ql/src/test/queries/clientpositive/optional_outer.q
* /hive/trunk/ql/src/test/results/clientpositive/optional_outer.q.out


> Make KW_OUTER optional in outer joins
> -
>
> Key: HIVE-4658
> URL: https://issues.apache.org/jira/browse/HIVE-4658
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Reporter: Navis
>Assignee: Edward Capriolo
>Priority: Trivial
> Fix For: 0.12.0
>
> Attachments: hive-4658.2.patch.txt, HIVE-4658.D11091.1.patch
>
>
> For really trivial migration issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-4658) Make KW_OUTER optional in outer joins

2013-07-13 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707749#comment-13707749
 ] 

Hudson commented on HIVE-4658:
--

ABORTED: Integrated in Hive-trunk-hadoop1-ptest #74 (See 
[https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/74/])
HIVE-4658 : Make KW_OUTER optional in outer joins (Edward Capriolo via Navis) 
(navis: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1502758)
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/FromClauseParser.g
* /hive/trunk/ql/src/test/queries/clientpositive/optional_outer.q
* /hive/trunk/ql/src/test/results/clientpositive/optional_outer.q.out


> Make KW_OUTER optional in outer joins
> -
>
> Key: HIVE-4658
> URL: https://issues.apache.org/jira/browse/HIVE-4658
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Reporter: Navis
>Assignee: Edward Capriolo
>Priority: Trivial
> Fix For: 0.12.0
>
> Attachments: hive-4658.2.patch.txt, HIVE-4658.D11091.1.patch
>
>
> For really trivial migration issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-4658) Make KW_OUTER optional in outer joins

2013-07-12 Thread Navis (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707028#comment-13707028
 ] 

Navis commented on HIVE-4658:
-

Sorry, missed this. Running test.

> Make KW_OUTER optional in outer joins
> -
>
> Key: HIVE-4658
> URL: https://issues.apache.org/jira/browse/HIVE-4658
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Reporter: Navis
>Assignee: Edward Capriolo
>Priority: Trivial
> Attachments: hive-4658.2.patch.txt, HIVE-4658.D11091.1.patch
>
>
> For really trivial migration issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-4658) Make KW_OUTER optional in outer joins

2013-07-11 Thread Edward Capriolo (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706581#comment-13706581
 ] 

Edward Capriolo commented on HIVE-4658:
---

Can we go +1?

> Make KW_OUTER optional in outer joins
> -
>
> Key: HIVE-4658
> URL: https://issues.apache.org/jira/browse/HIVE-4658
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Reporter: Navis
>Assignee: Edward Capriolo
>Priority: Trivial
> Attachments: hive-4658.2.patch.txt, HIVE-4658.D11091.1.patch
>
>
> For really trivial migration issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-4658) Make KW_OUTER optional in outer joins

2013-07-09 Thread Edward Capriolo (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704249#comment-13704249
 ] 

Edward Capriolo commented on HIVE-4658:
---

Test randomly fail often. The chances of this change effecting those tests is 
very small.

> Make KW_OUTER optional in outer joins
> -
>
> Key: HIVE-4658
> URL: https://issues.apache.org/jira/browse/HIVE-4658
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Reporter: Navis
>Assignee: Edward Capriolo
>Priority: Trivial
> Attachments: hive-4658.2.patch.txt, HIVE-4658.D11091.1.patch
>
>
> For really trivial migration issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-4658) Make KW_OUTER optional in outer joins

2013-07-09 Thread Brock Noland (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704101#comment-13704101
 ] 

Brock Noland commented on HIVE-4658:


Navis, sorry I was unclear. My comment "Both appear to be flaky and unrelated 
to the change." meant that I think those two failures were unrelated. I have 
seen both fail before.

> Make KW_OUTER optional in outer joins
> -
>
> Key: HIVE-4658
> URL: https://issues.apache.org/jira/browse/HIVE-4658
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Reporter: Navis
>Assignee: Edward Capriolo
>Priority: Trivial
> Attachments: hive-4658.2.patch.txt, HIVE-4658.D11091.1.patch
>
>
> For really trivial migration issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-4658) Make KW_OUTER optional in outer joins

2013-07-09 Thread Navis (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704082#comment-13704082
 ] 

Navis commented on HIVE-4658:
-

Brock commented two test failed. 

org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_mapreduce_stack_trace_hadoop20
org.apache.hcatalog.fileformats.TestOrcDynamicPartitioned.testHCatDynamicPartitionedTable

Can you assert that? I cannot reproduce.

> Make KW_OUTER optional in outer joins
> -
>
> Key: HIVE-4658
> URL: https://issues.apache.org/jira/browse/HIVE-4658
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Reporter: Navis
>Assignee: Edward Capriolo
>Priority: Trivial
> Attachments: hive-4658.2.patch.txt, HIVE-4658.D11091.1.patch
>
>
> For really trivial migration issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-4658) Make KW_OUTER optional in outer joins

2013-07-08 Thread Edward Capriolo (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702783#comment-13702783
 ] 

Edward Capriolo commented on HIVE-4658:
---

going to add a q.test then [~navis] you can review and commit.

> Make KW_OUTER optional in outer joins
> -
>
> Key: HIVE-4658
> URL: https://issues.apache.org/jira/browse/HIVE-4658
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Reporter: Navis
>Assignee: Edward Capriolo
>Priority: Trivial
> Attachments: HIVE-4658.D11091.1.patch
>
>
> For really trivial migration issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-4658) Make KW_OUTER optional in outer joins

2013-06-15 Thread Phabricator (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13684567#comment-13684567
 ] 

Phabricator commented on HIVE-4658:
---

navis has commented on the revision "HIVE-4658 [jira] Make KW_OUTER optional in 
outer joins".

  Two test you've mentioned passed in my trial.

REVISION DETAIL
  https://reviews.facebook.net/D11091

To: JIRA, navis
Cc: brock


> Make KW_OUTER optional in outer joins
> -
>
> Key: HIVE-4658
> URL: https://issues.apache.org/jira/browse/HIVE-4658
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Reporter: Navis
>Assignee: Navis
>Priority: Trivial
> Attachments: HIVE-4658.D11091.1.patch
>
>
> For really trivial migration issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-4658) Make KW_OUTER optional in outer joins

2013-06-06 Thread Phabricator (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677435#comment-13677435
 ] 

Phabricator commented on HIVE-4658:
---

brock has commented on the revision "HIVE-4658 [jira] Make KW_OUTER optional in 
outer joins".

  Looks good from my perspective. I ran the full unit test framework and the 
following tests failed:

  
org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_mapreduce_stack_trace_hadoop20
  
org.apache.hcatalog.fileformats.TestOrcDynamicPartitioned.testHCatDynamicPartitionedTable

  Both appear to be flaky and unrelated to the change.

REVISION DETAIL
  https://reviews.facebook.net/D11091

To: JIRA, navis
Cc: brock


> Make KW_OUTER optional in outer joins
> -
>
> Key: HIVE-4658
> URL: https://issues.apache.org/jira/browse/HIVE-4658
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Processor
>Reporter: Navis
>Assignee: Navis
>Priority: Trivial
> Attachments: HIVE-4658.D11091.1.patch
>
>
> For really trivial migration issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira