[jira] [Commented] (HIVE-4750) Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23
[ https://issues.apache.org/jira/browse/HIVE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13757772#comment-13757772 ] Hudson commented on HIVE-4750: -- FAILURE: Integrated in Hive-trunk-hadoop2 #403 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/403/]) HIVE-4750 : Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23 (Prasanth J via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1519857) * /hive/trunk/ql/src/test/queries/clientpositive/list_bucket_dml_6.q * /hive/trunk/ql/src/test/results/clientpositive/list_bucket_dml_6.q.out Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23 --- Key: HIVE-4750 URL: https://issues.apache.org/jira/browse/HIVE-4750 Project: Hive Issue Type: Sub-task Affects Versions: 0.12.0 Reporter: Brock Noland Assignee: Prasanth J Fix For: 0.12.0 Attachments: HIVE-4750.2.patch, HIVE-4750.patch Removing 6,7,8 from the scope of HIVE-4746. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4750) Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23
[ https://issues.apache.org/jira/browse/HIVE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13757846#comment-13757846 ] Hudson commented on HIVE-4750: -- FAILURE: Integrated in Hive-trunk-hadoop2-ptest #83 (See [https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/83/]) HIVE-4750 : Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23 (Prasanth J via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1519857) * /hive/trunk/ql/src/test/queries/clientpositive/list_bucket_dml_6.q * /hive/trunk/ql/src/test/results/clientpositive/list_bucket_dml_6.q.out Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23 --- Key: HIVE-4750 URL: https://issues.apache.org/jira/browse/HIVE-4750 Project: Hive Issue Type: Sub-task Affects Versions: 0.12.0 Reporter: Brock Noland Assignee: Prasanth J Fix For: 0.12.0 Attachments: HIVE-4750.2.patch, HIVE-4750.patch Removing 6,7,8 from the scope of HIVE-4746. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4750) Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23
[ https://issues.apache.org/jira/browse/HIVE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13757949#comment-13757949 ] Hudson commented on HIVE-4750: -- FAILURE: Integrated in Hive-trunk-hadoop1-ptest #150 (See [https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/150/]) HIVE-4750 : Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23 (Prasanth J via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1519857) * /hive/trunk/ql/src/test/queries/clientpositive/list_bucket_dml_6.q * /hive/trunk/ql/src/test/results/clientpositive/list_bucket_dml_6.q.out Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23 --- Key: HIVE-4750 URL: https://issues.apache.org/jira/browse/HIVE-4750 Project: Hive Issue Type: Sub-task Affects Versions: 0.12.0 Reporter: Brock Noland Assignee: Prasanth J Fix For: 0.12.0 Attachments: HIVE-4750.2.patch, HIVE-4750.patch Removing 6,7,8 from the scope of HIVE-4746. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4750) Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23
[ https://issues.apache.org/jira/browse/HIVE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758020#comment-13758020 ] Hudson commented on HIVE-4750: -- SUCCESS: Integrated in Hive-trunk-h0.21 #2309 (See [https://builds.apache.org/job/Hive-trunk-h0.21/2309/]) HIVE-4750 : Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23 (Prasanth J via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1519857) * /hive/trunk/ql/src/test/queries/clientpositive/list_bucket_dml_6.q * /hive/trunk/ql/src/test/results/clientpositive/list_bucket_dml_6.q.out Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23 --- Key: HIVE-4750 URL: https://issues.apache.org/jira/browse/HIVE-4750 Project: Hive Issue Type: Sub-task Affects Versions: 0.12.0 Reporter: Brock Noland Assignee: Prasanth J Fix For: 0.12.0 Attachments: HIVE-4750.2.patch, HIVE-4750.patch Removing 6,7,8 from the scope of HIVE-4746. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4750) Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23
[ https://issues.apache.org/jira/browse/HIVE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13757092#comment-13757092 ] Ashutosh Chauhan commented on HIVE-4750: +1 Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23 --- Key: HIVE-4750 URL: https://issues.apache.org/jira/browse/HIVE-4750 Project: Hive Issue Type: Sub-task Affects Versions: 0.12.0 Reporter: Brock Noland Assignee: Prasanth J Fix For: 0.12.0 Attachments: HIVE-4750.2.patch, HIVE-4750.patch Removing 6,7,8 from the scope of HIVE-4746. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4750) Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23
[ https://issues.apache.org/jira/browse/HIVE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13757112#comment-13757112 ] Ashutosh Chauhan commented on HIVE-4750: Test 6,7,8 on both mac OS and ubuntu after patch. All 3 passed on both OS. Committed to trunk. Thanks, Prasanth! Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23 --- Key: HIVE-4750 URL: https://issues.apache.org/jira/browse/HIVE-4750 Project: Hive Issue Type: Sub-task Affects Versions: 0.12.0 Reporter: Brock Noland Assignee: Prasanth J Fix For: 0.12.0 Attachments: HIVE-4750.2.patch, HIVE-4750.patch Removing 6,7,8 from the scope of HIVE-4746. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4750) Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23
[ https://issues.apache.org/jira/browse/HIVE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750570#comment-13750570 ] Ashutosh Chauhan commented on HIVE-4750: Current patch passes on MacOS but fails on ubuntu. I think it is caused by order in which sub-dirs of a dir are returned by OS, which could vary. I guess we need to add order by on partition column for this to work consistently on all OS. Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23 --- Key: HIVE-4750 URL: https://issues.apache.org/jira/browse/HIVE-4750 Project: Hive Issue Type: Sub-task Affects Versions: 0.12.0 Reporter: Brock Noland Assignee: Prasanth J Fix For: 0.12.0 Attachments: HIVE-4750.patch Removing 6,7,8 from the scope of HIVE-4746. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4750) Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23
[ https://issues.apache.org/jira/browse/HIVE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750594#comment-13750594 ] Prasanth J commented on HIVE-4750: -- Added order by to make the test cases works consistently across OSes. I tested it on Mac and CentOS 6. Can you please test it on Ubuntu before committing it (I don't have an ubuntu installation)? Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23 --- Key: HIVE-4750 URL: https://issues.apache.org/jira/browse/HIVE-4750 Project: Hive Issue Type: Sub-task Affects Versions: 0.12.0 Reporter: Brock Noland Assignee: Prasanth J Fix For: 0.12.0 Attachments: HIVE-4750.2.patch, HIVE-4750.patch Removing 6,7,8 from the scope of HIVE-4746. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4750) Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23
[ https://issues.apache.org/jira/browse/HIVE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13749020#comment-13749020 ] Prasanth J commented on HIVE-4750: -- The issue is not related to inconsistent File.length() on Mac vs Linux. But it is related to FileInputFormat in map reduce. The map reduce JIRA for this https://issues.apache.org/jira/browse/MAPREDUCE-3193. The problem is when there is only one nested directory (under a partition directory in hive), the FileInputFormat considers it as a file and then returns the size of it (which apparently is a directory). Its true that Mac vs Linux returns different lengths for directories. But thats not the intended behavior. The intended behavior of this test is to recurse through the subdirectory of HIVE_DEFAULT_LIST_BUCKETING_DIR_NAME and get the total file lengths of all the files contained in the sub-directory. Since the golden file is generated with hadoop version that didn't contain MAPREDUCE-3193 fix, the results were wrong and were OS dependent. I regenerated the golden file for the failing test and tested it under Mac and CentOS 6. The test cases are passing with the expected results on both OSes. For further verification, the list_bucket_dml_6.q file has comments with the list of file structure/details which can be used to validate the results. Also, test cases list_bucket_dml_{7,8}.q are passing for me in the local setup. Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23 --- Key: HIVE-4750 URL: https://issues.apache.org/jira/browse/HIVE-4750 Project: Hive Issue Type: Sub-task Reporter: Brock Noland Assignee: Prasanth J Removing 6,7,8 from the scope of HIVE-4746. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4750) Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23
[ https://issues.apache.org/jira/browse/HIVE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13686755#comment-13686755 ] Brock Noland commented on HIVE-4750: The totalSize value that it doesn't like between MacOS and Linux is getting generated here https://github.com/apache/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java#L413 Fix TestCliDriver.list_bucket_dml_{6,7,8}.q on 0.23 --- Key: HIVE-4750 URL: https://issues.apache.org/jira/browse/HIVE-4750 Project: Hive Issue Type: Sub-task Reporter: Brock Noland Assignee: Brock Noland Removing 6,7,8 from the scope of HIVE-4746. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira