[jira] [Commented] (HIVE-4767) ObjectStore.getPMF has concurrency problems

2013-06-22 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13691121#comment-13691121
 ] 

Hudson commented on HIVE-4767:
--

Integrated in Hive-trunk-hadoop2 #252 (See 
[https://builds.apache.org/job/Hive-trunk-hadoop2/252/])
HIVE-4767 : ObjectStore.getPMF has concurrency problems (Brock Noland via 
Ashutosh Chauhan) (Revision 1495464)

 Result = ABORTED
hashutosh : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1495464
Files : 
* 
/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java


> ObjectStore.getPMF has concurrency problems
> ---
>
> Key: HIVE-4767
> URL: https://issues.apache.org/jira/browse/HIVE-4767
> Project: Hive
>  Issue Type: Sub-task
>Affects Versions: 0.11.0
>Reporter: Brock Noland
>Assignee: Brock Noland
> Fix For: 0.12.0
>
> Attachments: HIVE-4767.patch
>
>
> ObjectStore.getPMF is a static factory method but isn't thread safe.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-4767) ObjectStore.getPMF has concurrency problems

2013-06-21 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13690369#comment-13690369
 ] 

Hudson commented on HIVE-4767:
--

Integrated in Hive-trunk-h0.21 #2161 (See 
[https://builds.apache.org/job/Hive-trunk-h0.21/2161/])
HIVE-4767 : ObjectStore.getPMF has concurrency problems (Brock Noland via 
Ashutosh Chauhan) (Revision 1495464)

 Result = FAILURE
hashutosh : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1495464
Files : 
* 
/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java


> ObjectStore.getPMF has concurrency problems
> ---
>
> Key: HIVE-4767
> URL: https://issues.apache.org/jira/browse/HIVE-4767
> Project: Hive
>  Issue Type: Sub-task
>Affects Versions: 0.11.0
>Reporter: Brock Noland
>Assignee: Brock Noland
> Fix For: 0.12.0
>
> Attachments: HIVE-4767.patch
>
>
> ObjectStore.getPMF is a static factory method but isn't thread safe.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-4767) ObjectStore.getPMF has concurrency problems

2013-06-21 Thread Brock Noland (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13690312#comment-13690312
 ] 

Brock Noland commented on HIVE-4767:


Sounds good! Regarding the test case, that sounds good. I'll take that forward 
in HIVE-4780.

> ObjectStore.getPMF has concurrency problems
> ---
>
> Key: HIVE-4767
> URL: https://issues.apache.org/jira/browse/HIVE-4767
> Project: Hive
>  Issue Type: Sub-task
>Affects Versions: 0.11.0
>Reporter: Brock Noland
>Assignee: Brock Noland
> Fix For: 0.12.0
>
> Attachments: HIVE-4767.patch
>
>
> ObjectStore.getPMF is a static factory method but isn't thread safe.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-4767) ObjectStore.getPMF has concurrency problems

2013-06-20 Thread Ashutosh Chauhan (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13690021#comment-13690021
 ] 

Ashutosh Chauhan commented on HIVE-4767:


I see. Lets go ahead with patch, since there indeed is a race condition.  +1
Btw, if you can format your testcase of HIVE-4762 as a junit, it will be good 
to have that checked-in as well. 


> ObjectStore.getPMF has concurrency problems
> ---
>
> Key: HIVE-4767
> URL: https://issues.apache.org/jira/browse/HIVE-4767
> Project: Hive
>  Issue Type: Sub-task
>Affects Versions: 0.11.0
>Reporter: Brock Noland
>Assignee: Brock Noland
> Fix For: 0.12.0
>
> Attachments: HIVE-4767.patch
>
>
> ObjectStore.getPMF is a static factory method but isn't thread safe.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-4767) ObjectStore.getPMF has concurrency problems

2013-06-20 Thread Brock Noland (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689436#comment-13689436
 ] 

Brock Noland commented on HIVE-4767:


Hi,

I cannot say definitively I was impacted by this bug. I noted that this method 
has correctness issues while looking into HIVE-4762. My test was 50 client 
threads (HIVE-4762) -> HS2 -> HMS -> MySQL. I ran it overnight and this patch 
introduced no new issues.

Brock

> ObjectStore.getPMF has concurrency problems
> ---
>
> Key: HIVE-4767
> URL: https://issues.apache.org/jira/browse/HIVE-4767
> Project: Hive
>  Issue Type: Sub-task
>Affects Versions: 0.11.0
>Reporter: Brock Noland
>Assignee: Brock Noland
> Fix For: 0.12.0
>
> Attachments: HIVE-4767.patch
>
>
> ObjectStore.getPMF is a static factory method but isn't thread safe.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-4767) ObjectStore.getPMF has concurrency problems

2013-06-20 Thread Ashutosh Chauhan (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689414#comment-13689414
 ] 

Ashutosh Chauhan commented on HIVE-4767:


Patch looks alright and I can see the concurrency issue. But can you elaborate 
on what was your test setup where this was evident and after this patch problem 
went away.

> ObjectStore.getPMF has concurrency problems
> ---
>
> Key: HIVE-4767
> URL: https://issues.apache.org/jira/browse/HIVE-4767
> Project: Hive
>  Issue Type: Sub-task
>Affects Versions: 0.11.0
>Reporter: Brock Noland
>Assignee: Brock Noland
> Fix For: 0.12.0
>
> Attachments: HIVE-4767.patch
>
>
> ObjectStore.getPMF is a static factory method but isn't thread safe.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira