[jira] [Commented] (HIVE-4844) Add varchar data type
[
https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767724#comment-13767724
]
Hive QA commented on HIVE-4844:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12603206/HIVE-4844.19.patch
{color:green}SUCCESS:{color} +1 3124 tests passed
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/751/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/751/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
Add varchar data type
-
Key: HIVE-4844
URL: https://issues.apache.org/jira/browse/HIVE-4844
Project: Hive
Issue Type: New Feature
Components: Types
Reporter: Jason Dere
Assignee: Jason Dere
Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch,
HIVE-4844.12.patch, HIVE-4844.13.patch, HIVE-4844.14.patch,
HIVE-4844.15.patch, HIVE-4844.16.patch, HIVE-4844.17.patch,
HIVE-4844.18.patch, HIVE-4844.19.patch, HIVE-4844.1.patch.hack,
HIVE-4844.2.patch, HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch,
HIVE-4844.6.patch, HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch,
HIVE-4844.D12699.1.patch, HIVE-4844.D12891.1.patch, screenshot.png
Add new varchar data types which have support for more SQL-compliant
behavior, such as SQL string comparison semantics, max length, etc.
Char type will be added as another task.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4844) Add varchar data type
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767919#comment-13767919 ] Hudson commented on HIVE-4844: -- FAILURE: Integrated in Hive-trunk-hadoop2 #431 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/431/]) HIVE-4844 : Add varchar data type (Jason Dere via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1523463) * /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java * /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java * /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type * /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type/TestHiveVarchar.java * /hive/trunk/data/files/datatypes.txt * /hive/trunk/data/files/vc1.txt * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect2.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToDate.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java * /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_1.q * /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_2.q * /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_3.q * /hive/trunk/ql/src/test/queries/clientpositive/alter_varchar1.q * /hive/trunk/ql/src/test/queries/clientpositive/ctas_varchar.q * /hive/trunk/ql/src/test/queries/clientpositive/partition_varchar1.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_1.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_2.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_cast.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_comparison.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_join1.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_nested_types.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_udf1.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_union1.q * /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_1.q.out * /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_2.q.out * /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_3.q.out * /hive/trunk/ql/src/test/results/clientpositive/alter_varchar1.q.out * /hive/trunk/ql/src/test/results/clientpositive/ctas_varchar.q.out * /hive/trunk/ql/src/test/results/clientpositive/partition_varchar1.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_1.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_2.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_cast.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_comparison.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_join1.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_nested_types.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_udf1.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_union1.q.out * /hive/trunk/serde/if/serde.thrift * /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp * /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h * /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java * /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java * /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java *
[jira] [Commented] (HIVE-4844) Add varchar data type
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767936#comment-13767936 ] Hudson commented on HIVE-4844: -- FAILURE: Integrated in Hive-trunk-hadoop2-ptest #98 (See [https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/98/]) HIVE-4844 : Add varchar data type (Jason Dere via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1523463) * /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java * /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java * /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type * /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type/TestHiveVarchar.java * /hive/trunk/data/files/datatypes.txt * /hive/trunk/data/files/vc1.txt * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect2.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToDate.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java * /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_1.q * /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_2.q * /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_3.q * /hive/trunk/ql/src/test/queries/clientpositive/alter_varchar1.q * /hive/trunk/ql/src/test/queries/clientpositive/ctas_varchar.q * /hive/trunk/ql/src/test/queries/clientpositive/partition_varchar1.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_1.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_2.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_cast.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_comparison.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_join1.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_nested_types.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_udf1.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_union1.q * /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_1.q.out * /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_2.q.out * /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_3.q.out * /hive/trunk/ql/src/test/results/clientpositive/alter_varchar1.q.out * /hive/trunk/ql/src/test/results/clientpositive/ctas_varchar.q.out * /hive/trunk/ql/src/test/results/clientpositive/partition_varchar1.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_1.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_2.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_cast.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_comparison.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_join1.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_nested_types.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_udf1.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_union1.q.out * /hive/trunk/serde/if/serde.thrift * /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp * /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h * /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java * /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java * /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java *
[jira] [Commented] (HIVE-4844) Add varchar data type
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767937#comment-13767937 ] Hudson commented on HIVE-4844: -- FAILURE: Integrated in Hive-trunk-hadoop1-ptest #165 (See [https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/165/]) HIVE-4844 : Add varchar data type (Jason Dere via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1523463) * /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java * /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java * /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type * /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type/TestHiveVarchar.java * /hive/trunk/data/files/datatypes.txt * /hive/trunk/data/files/vc1.txt * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect2.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToDate.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java * /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java * /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_1.q * /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_2.q * /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_3.q * /hive/trunk/ql/src/test/queries/clientpositive/alter_varchar1.q * /hive/trunk/ql/src/test/queries/clientpositive/ctas_varchar.q * /hive/trunk/ql/src/test/queries/clientpositive/partition_varchar1.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_1.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_2.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_cast.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_comparison.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_join1.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_nested_types.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_udf1.q * /hive/trunk/ql/src/test/queries/clientpositive/varchar_union1.q * /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_1.q.out * /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_2.q.out * /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_3.q.out * /hive/trunk/ql/src/test/results/clientpositive/alter_varchar1.q.out * /hive/trunk/ql/src/test/results/clientpositive/ctas_varchar.q.out * /hive/trunk/ql/src/test/results/clientpositive/partition_varchar1.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_1.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_2.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_cast.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_comparison.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_join1.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_nested_types.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_udf1.q.out * /hive/trunk/ql/src/test/results/clientpositive/varchar_union1.q.out * /hive/trunk/serde/if/serde.thrift * /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp * /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h * /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java * /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java * /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java *
[jira] [Commented] (HIVE-4844) Add varchar data type
[
https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767433#comment-13767433
]
Hive QA commented on HIVE-4844:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12603075/HIVE-4844.17.patch
{color:green}SUCCESS:{color} +1 3124 tests passed
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/727/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/727/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
Add varchar data type
-
Key: HIVE-4844
URL: https://issues.apache.org/jira/browse/HIVE-4844
Project: Hive
Issue Type: New Feature
Components: Types
Reporter: Jason Dere
Assignee: Jason Dere
Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch,
HIVE-4844.12.patch, HIVE-4844.13.patch, HIVE-4844.14.patch,
HIVE-4844.15.patch, HIVE-4844.16.patch, HIVE-4844.17.patch,
HIVE-4844.1.patch.hack, HIVE-4844.2.patch, HIVE-4844.3.patch,
HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, HIVE-4844.7.patch,
HIVE-4844.8.patch, HIVE-4844.9.patch, HIVE-4844.D12699.1.patch,
HIVE-4844.D12891.1.patch, screenshot.png
Add new varchar data types which have support for more SQL-compliant
behavior, such as SQL string comparison semantics, max length, etc.
Char type will be added as another task.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4844) Add varchar data type
[
https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767534#comment-13767534
]
Hive QA commented on HIVE-4844:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12603075/HIVE-4844.17.patch
{color:green}SUCCESS:{color} +1 3124 tests passed
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/744/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/744/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
Add varchar data type
-
Key: HIVE-4844
URL: https://issues.apache.org/jira/browse/HIVE-4844
Project: Hive
Issue Type: New Feature
Components: Types
Reporter: Jason Dere
Assignee: Jason Dere
Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch,
HIVE-4844.12.patch, HIVE-4844.13.patch, HIVE-4844.14.patch,
HIVE-4844.15.patch, HIVE-4844.16.patch, HIVE-4844.17.patch,
HIVE-4844.18.patch, HIVE-4844.1.patch.hack, HIVE-4844.2.patch,
HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch,
HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch,
HIVE-4844.D12699.1.patch, HIVE-4844.D12891.1.patch, screenshot.png
Add new varchar data types which have support for more SQL-compliant
behavior, such as SQL string comparison semantics, max length, etc.
Char type will be added as another task.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4844) Add varchar data type
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767548#comment-13767548 ] Jason Dere commented on HIVE-4844: -- Just got the unit test results from v18 and one of the negative tests failed, will need to roll another patch to update the test output. Add varchar data type - Key: HIVE-4844 URL: https://issues.apache.org/jira/browse/HIVE-4844 Project: Hive Issue Type: New Feature Components: Types Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch, HIVE-4844.12.patch, HIVE-4844.13.patch, HIVE-4844.14.patch, HIVE-4844.15.patch, HIVE-4844.16.patch, HIVE-4844.17.patch, HIVE-4844.18.patch, HIVE-4844.1.patch.hack, HIVE-4844.2.patch, HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch, HIVE-4844.D12699.1.patch, HIVE-4844.D12891.1.patch, screenshot.png Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc. Char type will be added as another task. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4844) Add varchar data type
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766095#comment-13766095 ] Ashutosh Chauhan commented on HIVE-4844: +1 Add varchar data type - Key: HIVE-4844 URL: https://issues.apache.org/jira/browse/HIVE-4844 Project: Hive Issue Type: New Feature Components: Types Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch, HIVE-4844.12.patch, HIVE-4844.13.patch, HIVE-4844.14.patch, HIVE-4844.15.patch, HIVE-4844.1.patch.hack, HIVE-4844.2.patch, HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch, HIVE-4844.D12699.1.patch, screenshot.png Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc. Char type will be added as another task. NO PRECOMMIT TESTS - now dependent on HIVE-5203/5204/5206 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4844) Add varchar data type
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766149#comment-13766149 ] Phabricator commented on HIVE-4844: --- ashutoshc has commented on the revision HIVE-4844 [jira] Add varchar data type. Sorry.. missed while previewing earlier. INLINE COMMENTS serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java:34 You need to add no-arg constructor for Kryo to correctly serialize this. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java:32 Need to add no-arg constructor for Kryo to work correctly. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java:33 no-arg constructor. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java:35 no-arg ctor. REVISION DETAIL https://reviews.facebook.net/D12699 To: JIRA, jdere Cc: ashutoshc Add varchar data type - Key: HIVE-4844 URL: https://issues.apache.org/jira/browse/HIVE-4844 Project: Hive Issue Type: New Feature Components: Types Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch, HIVE-4844.12.patch, HIVE-4844.13.patch, HIVE-4844.14.patch, HIVE-4844.15.patch, HIVE-4844.1.patch.hack, HIVE-4844.2.patch, HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch, HIVE-4844.D12699.1.patch, screenshot.png Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc. Char type will be added as another task. NO PRECOMMIT TESTS - now dependent on HIVE-5203/5204/5206 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4844) Add varchar data type
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765858#comment-13765858 ] Ashutosh Chauhan commented on HIVE-4844: [~jdere] Left some comments on phabricator. Add varchar data type - Key: HIVE-4844 URL: https://issues.apache.org/jira/browse/HIVE-4844 Project: Hive Issue Type: New Feature Components: Types Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch, HIVE-4844.12.patch, HIVE-4844.13.patch, HIVE-4844.14.patch, HIVE-4844.1.patch.hack, HIVE-4844.2.patch, HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch, HIVE-4844.D12699.1.patch, screenshot.png Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc. Char type will be added as another task. NO PRECOMMIT TESTS - now dependent on HIVE-5203/5204/5206 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4844) Add varchar data type
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766216#comment-13766216 ] Phabricator commented on HIVE-4844: --- jdere has commented on the revision HIVE-4844 [jira] Add varchar data type. Most of the SerDe support has been broken out into HIVE-5161. The SerDe's I'm testing there are RegexSerDe, LazyBinarySerDe, LazySimpleSerDe, ColumnarSerDe, LazyBinaryColumnarSerDe, OrcSerDe. I'll need to take a look again, but if HBase/Avro SerDe's use reflection-based methods to get their Types/ObjectInspectors, then they won't be able to support varchars properly. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:629 will change in the next patch ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:160 will change in next patch ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:169 will change in next patch ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java:48 sure, will change ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java:56 will change this message too ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java:36 whoops forgot to add that .. will do ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java:39-40 Actually, my latest patch did mark these fields as transient .. I'll need to update this review with the updated patch. serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java:34 Do we need to serialize object inspectors? my impression is that should always have been transient, at least when they're used in UDFs since they can be set during initialize(). serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java:401 Yeah, this comment is gone in the updated patch. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java:474 2011 SQL Standard (6.13 cast specification) does say that the value should be TRUE/FALSE. This also matches what we're doing with the string type. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java:33 ok, will change serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java:35 will change REVISION DETAIL https://reviews.facebook.net/D12699 To: JIRA, jdere Cc: ashutoshc Add varchar data type - Key: HIVE-4844 URL: https://issues.apache.org/jira/browse/HIVE-4844 Project: Hive Issue Type: New Feature Components: Types Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch, HIVE-4844.12.patch, HIVE-4844.13.patch, HIVE-4844.14.patch, HIVE-4844.15.patch, HIVE-4844.16.patch, HIVE-4844.1.patch.hack, HIVE-4844.2.patch, HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch, HIVE-4844.D12699.1.patch, screenshot.png Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc. Char type will be added as another task. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4844) Add varchar data type
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766271#comment-13766271 ] Phabricator commented on HIVE-4844: --- ashutoshc has accepted the revision HIVE-4844 [jira] Add varchar data type. +1 Thanks, Jason for making changes. REVISION DETAIL https://reviews.facebook.net/D12891 BRANCH HIVE-4844.2 ARCANIST PROJECT hive To: JIRA, ashutoshc, jdere Add varchar data type - Key: HIVE-4844 URL: https://issues.apache.org/jira/browse/HIVE-4844 Project: Hive Issue Type: New Feature Components: Types Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch, HIVE-4844.12.patch, HIVE-4844.13.patch, HIVE-4844.14.patch, HIVE-4844.15.patch, HIVE-4844.16.patch, HIVE-4844.1.patch.hack, HIVE-4844.2.patch, HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch, HIVE-4844.D12699.1.patch, HIVE-4844.D12891.1.patch, screenshot.png Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc. Char type will be added as another task. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4844) Add varchar data type
[
https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767064#comment-13767064
]
Xuefu Zhang commented on HIVE-4844:
---
Thanks for making so much progress in such a short time. I have some comments
while reading the patch.
1. TypeInfoUtils.addParamsToTypeName() seems having duplicated code with
VarcharTypeParam.toString().I also saw this in FunctionRegistry, which also has
some duplicated logic here. It's nice if we can consolidate and have single
point of reference for this.
{code}
+String typeName =
+
PrimitiveObjectInspectorUtils.getTypeEntryFromPrimitiveCategory(typeCategory).typeName
++ varcharParams.toString();
{code}
2. DDLSemanticAnalyzer.getTypeName() tries to get a list of Strings from the
ASTNode by using ParseUtils.getCharParams(), in which only a subset of checks
are performed. (For instance, it doesn't validate the MAX allowed length.)
Instead, I think it's probably better to get VarcharTypeParams instance from
the ASTNode and let the instance perform all the checks.
I haven't gone thru the patch yet, but I'd like to share my thoughts.
Add varchar data type
-
Key: HIVE-4844
URL: https://issues.apache.org/jira/browse/HIVE-4844
Project: Hive
Issue Type: New Feature
Components: Types
Reporter: Jason Dere
Assignee: Jason Dere
Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch,
HIVE-4844.12.patch, HIVE-4844.13.patch, HIVE-4844.14.patch,
HIVE-4844.15.patch, HIVE-4844.16.patch, HIVE-4844.17.patch,
HIVE-4844.1.patch.hack, HIVE-4844.2.patch, HIVE-4844.3.patch,
HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, HIVE-4844.7.patch,
HIVE-4844.8.patch, HIVE-4844.9.patch, HIVE-4844.D12699.1.patch,
HIVE-4844.D12891.1.patch, screenshot.png
Add new varchar data types which have support for more SQL-compliant
behavior, such as SQL string comparison semantics, max length, etc.
Char type will be added as another task.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4844) Add varchar data type
[
https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767104#comment-13767104
]
Xuefu Zhang commented on HIVE-4844:
---
Also in ParseUtils.getCharParams(), checking NumberFormatException and child
count is probably not needed. This attributes to the grammar rule.
{code}
+| KW_VARCHAR LPAREN length=Number RPAREN -^(TOK_VARCHAR $length)
{code}
This is a minor thing that probably makes the code cleaner.
Add varchar data type
-
Key: HIVE-4844
URL: https://issues.apache.org/jira/browse/HIVE-4844
Project: Hive
Issue Type: New Feature
Components: Types
Reporter: Jason Dere
Assignee: Jason Dere
Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch,
HIVE-4844.12.patch, HIVE-4844.13.patch, HIVE-4844.14.patch,
HIVE-4844.15.patch, HIVE-4844.16.patch, HIVE-4844.17.patch,
HIVE-4844.1.patch.hack, HIVE-4844.2.patch, HIVE-4844.3.patch,
HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, HIVE-4844.7.patch,
HIVE-4844.8.patch, HIVE-4844.9.patch, HIVE-4844.D12699.1.patch,
HIVE-4844.D12891.1.patch, screenshot.png
Add new varchar data types which have support for more SQL-compliant
behavior, such as SQL string comparison semantics, max length, etc.
Char type will be added as another task.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4844) Add varchar data type
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765866#comment-13765866 ] Ashutosh Chauhan commented on HIVE-4844: And few more : ) Add varchar data type - Key: HIVE-4844 URL: https://issues.apache.org/jira/browse/HIVE-4844 Project: Hive Issue Type: New Feature Components: Types Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch, HIVE-4844.12.patch, HIVE-4844.13.patch, HIVE-4844.14.patch, HIVE-4844.1.patch.hack, HIVE-4844.2.patch, HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch, HIVE-4844.D12699.1.patch, screenshot.png Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc. Char type will be added as another task. NO PRECOMMIT TESTS - now dependent on HIVE-5203/5204/5206 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4844) Add varchar data type
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764989#comment-13764989 ] Jason Dere commented on HIVE-4844: -- Sure, I'll bump the max down to 65535, though it won't matter much for Hive since a Java short only goes up to 32K, so we need an int to hold the value either way. I need to rebase this patch yet again due to review changes from HIVE-5206, so I'll add this change when I roll a new patch. Add varchar data type - Key: HIVE-4844 URL: https://issues.apache.org/jira/browse/HIVE-4844 Project: Hive Issue Type: New Feature Components: Types Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch, HIVE-4844.12.patch, HIVE-4844.13.patch, HIVE-4844.1.patch.hack, HIVE-4844.2.patch, HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch, HIVE-4844.D12699.1.patch, screenshot.png Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc. Char type will be added as another task. NO PRECOMMIT TESTS - now dependent on HIVE-5203/5204/5206 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4844) Add varchar data type
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763739#comment-13763739 ] Jason Dere commented on HIVE-4844: -- Ok, 64K sounds good then. As it turns out there was nothing checking if varchar was defined with too large of a length, so that needed to be added in. Will post new patch shortly Add varchar data type - Key: HIVE-4844 URL: https://issues.apache.org/jira/browse/HIVE-4844 Project: Hive Issue Type: New Feature Components: Types Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch, HIVE-4844.12.patch, HIVE-4844.1.patch.hack, HIVE-4844.2.patch, HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch, HIVE-4844.D12699.1.patch, screenshot.png Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc. Char type will be added as another task. NO PRECOMMIT TESTS - now dependent on HIVE-5203/5204/5206 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4844) Add varchar data type
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763958#comment-13763958 ] Xuefu Zhang commented on HIVE-4844: --- Yeah. 64K is good. Just minor thought. Instead of 64K (65556), MYSQL chooses 65535, 1 less than 64K. I don't know if there is any pitfall there. I also saw instead of 256, 255 used for length in other DBs. Anyone has any idea? Add varchar data type - Key: HIVE-4844 URL: https://issues.apache.org/jira/browse/HIVE-4844 Project: Hive Issue Type: New Feature Components: Types Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch, HIVE-4844.12.patch, HIVE-4844.13.patch, HIVE-4844.1.patch.hack, HIVE-4844.2.patch, HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch, HIVE-4844.D12699.1.patch, screenshot.png Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc. Char type will be added as another task. NO PRECOMMIT TESTS - now dependent on HIVE-5203/5204/5206 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4844) Add varchar data type
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13762007#comment-13762007 ] Xuefu Zhang commented on HIVE-4844: --- I think people use varchar in Hive probably because of legacy data from DBs. Thus, a number at a scale of major DBs would be good. Yes, it's arbitrary. 64K would be good, but 64M or 64G might not be as good. Add varchar data type - Key: HIVE-4844 URL: https://issues.apache.org/jira/browse/HIVE-4844 Project: Hive Issue Type: New Feature Components: Types Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch, HIVE-4844.12.patch, HIVE-4844.1.patch.hack, HIVE-4844.2.patch, HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch, HIVE-4844.D12699.1.patch, screenshot.png Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc. Char type will be added as another task. NO PRECOMMIT TESTS - now dependent on HIVE-5203/5204/5206 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4844) Add varchar data type
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760721#comment-13760721 ] Xuefu Zhang commented on HIVE-4844: --- [~jdere] Looking at your latest patch, I'm wondering if you have given thought on the max on varchar length. Right now you put Integer.MAX_VALUE as the max, but majority of DBs has a smaller limit than that. (Mysql chose 65,535, for instance.) Having a smaller max might leave room for optimization. I understand that there is no standard regarding this, but I'm curious if we made a conscious decision on that. Add varchar data type - Key: HIVE-4844 URL: https://issues.apache.org/jira/browse/HIVE-4844 Project: Hive Issue Type: New Feature Components: Types Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch, HIVE-4844.12.patch, HIVE-4844.1.patch.hack, HIVE-4844.2.patch, HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch, HIVE-4844.D12699.1.patch, screenshot.png Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc. Char type will be added as another task. NO PRECOMMIT TESTS - now dependent on HIVE-5203/5204/5206 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4844) Add varchar data type
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760823#comment-13760823 ] Jason Dere commented on HIVE-4844: -- The max varchar length setting was pretty arbitrary, sure we can have it set to a lower value. Any ideas on what value to initially set? 32,767 (small enough to fit within a short), or maybe something even smaller like 1024, just to make the point that we don't want enormous varchar columns that require checking the string length? Add varchar data type - Key: HIVE-4844 URL: https://issues.apache.org/jira/browse/HIVE-4844 Project: Hive Issue Type: New Feature Components: Types Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch, HIVE-4844.12.patch, HIVE-4844.1.patch.hack, HIVE-4844.2.patch, HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch, HIVE-4844.D12699.1.patch, screenshot.png Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc. Char type will be added as another task. NO PRECOMMIT TESTS - now dependent on HIVE-5203/5204/5206 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4844) Add varchar data type
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755136#comment-13755136 ] Jason Dere commented on HIVE-4844: -- All three failures mentioned above (TestHCatStorerMulti, TestNegativeMinimrCliDriver, TestHCatLoaderComplexSchema) appear to pass when I run these tests myself. Add varchar data type - Key: HIVE-4844 URL: https://issues.apache.org/jira/browse/HIVE-4844 Project: Hive Issue Type: New Feature Components: Types Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch, HIVE-4844.1.patch.hack, HIVE-4844.2.patch, HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch, screenshot.png Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc. Char type will be added as another task. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4844) Add varchar data type
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755294#comment-13755294 ] Jason Dere commented on HIVE-4844: -- ashutoshc, like Xuefu, has suggested that this patch be split into different subtasks where appropriate, to make review/tracking easier. I'll take a look at what I can do here. At first glance, looks like this can be done as the following set of changes: 1. getMethodInternal() should prefer evaluate() signatures with more similar arguments 2. Change getCommonClass/implicitConvertible to use PrimitiveCategory rather than TypeInfo 3. Cast operators need to be set with type-specific data prior to initialization 4. varchar work (will be done in this Jira) 5. Thrift/JDBC changes for varchar Add varchar data type - Key: HIVE-4844 URL: https://issues.apache.org/jira/browse/HIVE-4844 Project: Hive Issue Type: New Feature Components: Types Reporter: Jason Dere Assignee: Jason Dere Attachments: HIVE-4844.10.patch, HIVE-4844.11.patch, HIVE-4844.1.patch.hack, HIVE-4844.2.patch, HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch, screenshot.png Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc. Char type will be added as another task. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
