[jira] [Commented] (HIVE-4895) Move all HCatalog classes to org.apache.hive.hcatalog
[ https://issues.apache.org/jira/browse/HIVE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758835#comment-13758835 ] Hudson commented on HIVE-4895: -- FAILURE: Integrated in Hive-trunk-hadoop2 #406 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/406/]) HIVE-4895 : Move all HCatalog classes to org.apache.hive.hcatalog - Part 2/2 - file modifications renaming packages (Eugene Koifman via Sushanth Sowmyan) (khorgath: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1520202) * /hive/trunk/hcatalog/bin/hcat * /hive/trunk/hcatalog/bin/hcat.py * /hive/trunk/hcatalog/build-support/ant/deploy.xml * /hive/trunk/hcatalog/build.xml * /hive/trunk/hcatalog/conf/proto-hive-site.xml * /hive/trunk/hcatalog/core/pom.xml * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/HCatCli.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/HCatDriver.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/CreateDatabaseHook.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/CreateTableHook.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzerBase.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/ErrorType.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatConstants.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatContext.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatException.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/DataType.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/DefaultHCatRecord.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/HCatRecord.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/HCatRecordObjectInspector.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/HCatRecordObjectInspectorFactory.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/HCatRecordSerDe.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/HCatRecordable.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/JsonSerDe.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/LazyHCatRecord.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/Pair.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/ReaderWriter.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/schema/HCatFieldSchema.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/schema/HCatSchema.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/schema/HCatSchemaUtils.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/transfer/DataTransferFactory.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/transfer/EntityBase.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/transfer/HCatReader.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/transfer/HCatWriter.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/transfer/ReadEntity.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/transfer/ReaderContext.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/transfer/WriteEntity.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/transfer/WriterContext.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/transfer/impl/HCatInputFormatReader.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/transfer/impl/HCatOutputFormatWriter.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/transfer/state/DefaultStateProvider.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/transfer/state/StateProvider.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/har/HarOutputCommitterPostProcessor.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DefaultOutputCommitterContainer.java * /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DefaultOutputFormatContainer.java *
[jira] [Commented] (HIVE-4895) Move all HCatalog classes to org.apache.hive.hcatalog
[ https://issues.apache.org/jira/browse/HIVE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13759194#comment-13759194 ] Eugene Koifman commented on HIVE-4895: -- The 1st build error (JavaDoc) looks like it caught the repo in between the 2 commits for this bug. 2nd is framework issue. https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/84/consoleFull is funning and past the javadoc issue. Move all HCatalog classes to org.apache.hive.hcatalog - Key: HIVE-4895 URL: https://issues.apache.org/jira/browse/HIVE-4895 Project: Hive Issue Type: Sub-task Components: HCatalog Affects Versions: 0.12.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 Attachments: 4895.move, 4895.rename, HIVE-4895.2.patch, HIVE-4895.patch Original Estimate: 24h Time Spent: 12h Remaining Estimate: 12h make sure to preserve history in SCM -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4895) Move all HCatalog classes to org.apache.hive.hcatalog
[ https://issues.apache.org/jira/browse/HIVE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758152#comment-13758152 ] Eugene Koifman commented on HIVE-4895: -- Latest patches attached Move all HCatalog classes to org.apache.hive.hcatalog - Key: HIVE-4895 URL: https://issues.apache.org/jira/browse/HIVE-4895 Project: Hive Issue Type: Sub-task Components: HCatalog Affects Versions: 0.12.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 Attachments: HIVE-4895.move.patch, HIVE-4895.patch, HIVE-4895.rename.patch Original Estimate: 24h Time Spent: 12h Remaining Estimate: 12h make sure to preserve history in SCM -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4895) Move all HCatalog classes to org.apache.hive.hcatalog
[ https://issues.apache.org/jira/browse/HIVE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758378#comment-13758378 ] Sushanth Sowmyan commented on HIVE-4895: Thanks for the patches, Eugene. I'm having a look at them. Move all HCatalog classes to org.apache.hive.hcatalog - Key: HIVE-4895 URL: https://issues.apache.org/jira/browse/HIVE-4895 Project: Hive Issue Type: Sub-task Components: HCatalog Affects Versions: 0.12.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 Attachments: HIVE-4895.move.patch, HIVE-4895.patch, HIVE-4895.rename.patch Original Estimate: 24h Time Spent: 12h Remaining Estimate: 12h make sure to preserve history in SCM -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4895) Move all HCatalog classes to org.apache.hive.hcatalog
[ https://issues.apache.org/jira/browse/HIVE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758436#comment-13758436 ] Sushanth Sowmyan commented on HIVE-4895: So far, I have verified the following: * The move patch + the rename patch = the unified patch * The move patch is correct, and moves all the required classes to the respective correct locations. I am yet to verify the rename patch fully, and will update when I do. Move all HCatalog classes to org.apache.hive.hcatalog - Key: HIVE-4895 URL: https://issues.apache.org/jira/browse/HIVE-4895 Project: Hive Issue Type: Sub-task Components: HCatalog Affects Versions: 0.12.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 Attachments: HIVE-4895.move.patch, HIVE-4895.patch, HIVE-4895.rename.patch Original Estimate: 24h Time Spent: 12h Remaining Estimate: 12h make sure to preserve history in SCM -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4895) Move all HCatalog classes to org.apache.hive.hcatalog
[ https://issues.apache.org/jira/browse/HIVE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758443#comment-13758443 ] Eugene Koifman commented on HIVE-4895: -- I think the easiest way to verify combined changes is to compile + run unit tests (I also ran webhcat e2e). I can't imagine this won't catch some error. Move all HCatalog classes to org.apache.hive.hcatalog - Key: HIVE-4895 URL: https://issues.apache.org/jira/browse/HIVE-4895 Project: Hive Issue Type: Sub-task Components: HCatalog Affects Versions: 0.12.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 Attachments: HIVE-4895.move.patch, HIVE-4895.patch, HIVE-4895.rename.patch Original Estimate: 24h Time Spent: 12h Remaining Estimate: 12h make sure to preserve history in SCM -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4895) Move all HCatalog classes to org.apache.hive.hcatalog
[
https://issues.apache.org/jira/browse/HIVE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758500#comment-13758500
]
Sushanth Sowmyan commented on HIVE-4895:
That's what I'm running in the background. :)
But it doesn't hurt to be more thorough. I've now gone through the rename patch
also, trying to make sure that the only diffs in place are those that are
changing the package name. I found a couple others as well:
* Changes in pom.xml to suppress extra specification of the groupId after the
parent's groupId has already been specified. I guess that makes sense from the
perspective of honouring the parent groupId, and that works.
* Commenting out some parameters in
hcatalog/src/test/e2e/templeton/build.xml. Why are these parameters being
commented out here?
{code}
-arg value=${basedir}/tests/serverstatus.conf/
-arg value=${basedir}/tests/ddl.conf/
-arg value=${basedir}/tests/jobsubmission.conf/
-arg value=${basedir}/tests/jobsubmission2.conf/
+!--arg value=${basedir}/tests/serverstatus.conf/
+arg value=${basedir}/tests/ddl.conf/--
+ arg value=${basedir}/tests/jobsubmission.conf/
+!--arg value=${basedir}/tests/jobsubmission2.conf/--
{code}
Move all HCatalog classes to org.apache.hive.hcatalog
-
Key: HIVE-4895
URL: https://issues.apache.org/jira/browse/HIVE-4895
Project: Hive
Issue Type: Sub-task
Components: HCatalog
Affects Versions: 0.12.0
Reporter: Eugene Koifman
Assignee: Eugene Koifman
Fix For: 0.12.0
Attachments: 4895.move, 4895.rename, HIVE-4895.patch
Original Estimate: 24h
Time Spent: 12h
Remaining Estimate: 12h
make sure to preserve history in SCM
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4895) Move all HCatalog classes to org.apache.hive.hcatalog
[ https://issues.apache.org/jira/browse/HIVE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758510#comment-13758510 ] Sushanth Sowmyan commented on HIVE-4895: All hcatalog tests pass. I'm okay with going ahead with this patch once I understand what these commented out parameters do and why it was needed. Move all HCatalog classes to org.apache.hive.hcatalog - Key: HIVE-4895 URL: https://issues.apache.org/jira/browse/HIVE-4895 Project: Hive Issue Type: Sub-task Components: HCatalog Affects Versions: 0.12.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 Attachments: 4895.move, 4895.rename, HIVE-4895.patch Original Estimate: 24h Time Spent: 12h Remaining Estimate: 12h make sure to preserve history in SCM -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4895) Move all HCatalog classes to org.apache.hive.hcatalog
[ https://issues.apache.org/jira/browse/HIVE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758511#comment-13758511 ] Eugene Koifman commented on HIVE-4895: -- You are right, and this proves that point :) there should not be any changes in this build.xml Move all HCatalog classes to org.apache.hive.hcatalog - Key: HIVE-4895 URL: https://issues.apache.org/jira/browse/HIVE-4895 Project: Hive Issue Type: Sub-task Components: HCatalog Affects Versions: 0.12.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 Attachments: 4895.move, 4895.rename, HIVE-4895.patch Original Estimate: 24h Time Spent: 12h Remaining Estimate: 12h make sure to preserve history in SCM -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4895) Move all HCatalog classes to org.apache.hive.hcatalog
[ https://issues.apache.org/jira/browse/HIVE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758521#comment-13758521 ] Sushanth Sowmyan commented on HIVE-4895: Although I've marked it for the precommit build to pick up, I'm +1 on this, and have verified it locally. I'll try to start getting the massive svn mv required working and ready before I commit. Move all HCatalog classes to org.apache.hive.hcatalog - Key: HIVE-4895 URL: https://issues.apache.org/jira/browse/HIVE-4895 Project: Hive Issue Type: Sub-task Components: HCatalog Affects Versions: 0.12.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 Attachments: 4895.move, 4895.rename, HIVE-4895.2.patch, HIVE-4895.patch Original Estimate: 24h Time Spent: 12h Remaining Estimate: 12h make sure to preserve history in SCM -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4895) Move all HCatalog classes to org.apache.hive.hcatalog
[ https://issues.apache.org/jira/browse/HIVE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758726#comment-13758726 ] Sushanth Sowmyan commented on HIVE-4895: Committed to svn trunk. (Had to commit as two patches to make sure svn could differentiate between the move and the modify) Thanks, Eugene! Move all HCatalog classes to org.apache.hive.hcatalog - Key: HIVE-4895 URL: https://issues.apache.org/jira/browse/HIVE-4895 Project: Hive Issue Type: Sub-task Components: HCatalog Affects Versions: 0.12.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 Attachments: 4895.move, 4895.rename, HIVE-4895.2.patch, HIVE-4895.patch Original Estimate: 24h Time Spent: 12h Remaining Estimate: 12h make sure to preserve history in SCM -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4895) Move all HCatalog classes to org.apache.hive.hcatalog
[
https://issues.apache.org/jira/browse/HIVE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758769#comment-13758769
]
Hive QA commented on HIVE-4895:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12601505/HIVE-4895.2.patch
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 2909 tests executed
*Failed tests:*
{noformat}
org.apache.hive.hcatalog.mapreduce.TestHCatExternalPartitioned.testHCatPartitionedTable
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/619/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/619/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests failed with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
Move all HCatalog classes to org.apache.hive.hcatalog
-
Key: HIVE-4895
URL: https://issues.apache.org/jira/browse/HIVE-4895
Project: Hive
Issue Type: Sub-task
Components: HCatalog
Affects Versions: 0.12.0
Reporter: Eugene Koifman
Assignee: Eugene Koifman
Fix For: 0.12.0
Attachments: 4895.move, 4895.rename, HIVE-4895.2.patch,
HIVE-4895.patch
Original Estimate: 24h
Time Spent: 12h
Remaining Estimate: 12h
make sure to preserve history in SCM
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4895) Move all HCatalog classes to org.apache.hive.hcatalog
[ https://issues.apache.org/jira/browse/HIVE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750809#comment-13750809 ] Eugene Koifman commented on HIVE-4895: -- HCat unit tests and webhcat e2e tests passed Move all HCatalog classes to org.apache.hive.hcatalog - Key: HIVE-4895 URL: https://issues.apache.org/jira/browse/HIVE-4895 Project: Hive Issue Type: Sub-task Components: HCatalog Affects Versions: 0.12.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 Attachments: HIVE-4895.move.patch, HIVE-4895.patch, HIVE-4895.update.patch Original Estimate: 24h Remaining Estimate: 24h make sure to preserve history in SCM -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-4895) Move all HCatalog classes to org.apache.hive.hcatalog
[ https://issues.apache.org/jira/browse/HIVE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750811#comment-13750811 ] Eugene Koifman commented on HIVE-4895: -- groupid in pom.xml was also changed from org.apache.hcatalog to org.apache.hive.hcatalog Move all HCatalog classes to org.apache.hive.hcatalog - Key: HIVE-4895 URL: https://issues.apache.org/jira/browse/HIVE-4895 Project: Hive Issue Type: Sub-task Components: HCatalog Affects Versions: 0.12.0 Reporter: Eugene Koifman Assignee: Eugene Koifman Fix For: 0.12.0 Attachments: HIVE-4895.move.patch, HIVE-4895.patch, HIVE-4895.update.patch Original Estimate: 24h Remaining Estimate: 24h make sure to preserve history in SCM -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
