[jira] [Commented] (HIVE-5160) HS2 should support .hiverc
[ https://issues.apache.org/jira/browse/HIVE-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207821#comment-14207821 ] Lefty Leverenz commented on HIVE-5160: -- bq. ... how do you generate a link to a specific configuration property ... Take the link to any heading in Configuration Properties and substitute the property name. (This works because each property is a level-5 heading.) For example, for a link to hive.server2.global.init.file.location go to the Configuration Properties page, click the Tez link in the table of contents (Tez because it's nice and short, so easy to delete) and copy the URL at the top of the window: https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-Tez Then replace -Tez with -hive.server2.global.init.file.location: https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-hive.server2.global.init.file.location The process is a kludge but it's easier than remembering the link syntax for headings. I should add a section about wiki links in [About This Wiki| https://cwiki.apache.org/confluence/display/Hive/AboutThisWiki]. HS2 should support .hiverc -- Key: HIVE-5160 URL: https://issues.apache.org/jira/browse/HIVE-5160 Project: Hive Issue Type: Improvement Components: HiveServer2 Reporter: Thejas M Nair Assignee: Dong Chen Fix For: 0.14.0 Attachments: HIVE-5160.1.patch, HIVE-5160.patch It would be useful to support the .hiverc functionality with hive server2 as well. .hiverc is processed by CliDriver, so it works only with hive cli. It would be useful to be able to do things like register a standard set of jars and functions for all users. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-5160) HS2 should support .hiverc
[ https://issues.apache.org/jira/browse/HIVE-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144081#comment-14144081 ] Lefty Leverenz commented on HIVE-5160: -- Doc note: HIVE-8138 alters the behavior of *hive.server2.global.init.file.location* (originally *hive.global.init.file.location*), so use the description in that patch when documenting the parameter in these two wikidocs: * [Configuration Properties -- HiveServer2 | https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-HiveServer2] * [Setting Up HiveServer2 -- How to Configure | https://cwiki.apache.org/confluence/display/Hive/Setting+Up+HiveServer2#SettingUpHiveServer2-HowtoConfigure] HS2 should support .hiverc -- Key: HIVE-5160 URL: https://issues.apache.org/jira/browse/HIVE-5160 Project: Hive Issue Type: Improvement Components: HiveServer2 Reporter: Thejas M Nair Assignee: Dong Chen Labels: TODOC14 Fix For: 0.14.0 Attachments: HIVE-5160.1.patch, HIVE-5160.patch It would be useful to support the .hiverc functionality with hive server2 as well. .hiverc is processed by CliDriver, so it works only with hive cli. It would be useful to be able to do things like register a standard set of jars and functions for all users. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-5160) HS2 should support .hiverc
[ https://issues.apache.org/jira/browse/HIVE-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14072884#comment-14072884 ] Szehon Ho commented on HIVE-5160: - Brock's scenario of generating a wrong hive-default-template during build is possible (now the template is generated). As of now it would show up during review, but it seems that the template is pending to be removed from source-control, so we probably should fix that. Also I think Lefty has a nice suggestion about renaming the property for consistency. Dong Chen, what do you think? HS2 should support .hiverc -- Key: HIVE-5160 URL: https://issues.apache.org/jira/browse/HIVE-5160 Project: Hive Issue Type: Improvement Components: HiveServer2 Reporter: Thejas M Nair Assignee: Dong Chen Labels: TODOC14 Fix For: 0.14.0 Attachments: HIVE-5160.1.patch, HIVE-5160.patch It would be useful to support the .hiverc functionality with hive server2 as well. .hiverc is processed by CliDriver, so it works only with hive cli. It would be useful to be able to do things like register a standard set of jars and functions for all users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-5160) HS2 should support .hiverc
[
https://issues.apache.org/jira/browse/HIVE-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14072987#comment-14072987
]
Dong Chen commented on HIVE-5160:
-
Hi Brock, Lefty, Szehon, thanks for your comments and nice suggestion.
1. The wrong generated hive-default-template during build (HIVE-7497) has been
fixed. I also found we might need use $\{env:xxx\} for properties related to
env variable. The details were commented in that Jira. Could you please help to
take a look at it?
2. Renaming the property to hive.server2.* is a nice suggestion. I did the
change in HIVE-7497, instead of filing a new Jira or continuing in this Jira.
In case that there might be conflict when merging code. Do you think putting
this change in HIVE-7497 is OK?
HS2 should support .hiverc
--
Key: HIVE-5160
URL: https://issues.apache.org/jira/browse/HIVE-5160
Project: Hive
Issue Type: Improvement
Components: HiveServer2
Reporter: Thejas M Nair
Assignee: Dong Chen
Labels: TODOC14
Fix For: 0.14.0
Attachments: HIVE-5160.1.patch, HIVE-5160.patch
It would be useful to support the .hiverc functionality with hive server2 as
well.
.hiverc is processed by CliDriver, so it works only with hive cli. It would
be useful to be able to do things like register a standard set of jars and
functions for all users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-5160) HS2 should support .hiverc
[ https://issues.apache.org/jira/browse/HIVE-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073353#comment-14073353 ] Lefty Leverenz commented on HIVE-5160: -- bq. 2. Renaming the property to hive.server2.* ... putting this change in HIVE-7497 is OK? Yes, that's the best place for it. Thanks [~dongc]. HS2 should support .hiverc -- Key: HIVE-5160 URL: https://issues.apache.org/jira/browse/HIVE-5160 Project: Hive Issue Type: Improvement Components: HiveServer2 Reporter: Thejas M Nair Assignee: Dong Chen Labels: TODOC14 Fix For: 0.14.0 Attachments: HIVE-5160.1.patch, HIVE-5160.patch It would be useful to support the .hiverc functionality with hive server2 as well. .hiverc is processed by CliDriver, so it works only with hive cli. It would be useful to be able to do things like register a standard set of jars and functions for all users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-5160) HS2 should support .hiverc
[
https://issues.apache.org/jira/browse/HIVE-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071976#comment-14071976
]
Hive QA commented on HIVE-5160:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12657092/HIVE-5160.1.patch
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 5754 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_dynpart_sort_optimization
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_ql_rewrite_gbtoidx
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/21/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/21/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-21/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12657092
HS2 should support .hiverc
--
Key: HIVE-5160
URL: https://issues.apache.org/jira/browse/HIVE-5160
Project: Hive
Issue Type: Improvement
Components: HiveServer2
Reporter: Thejas M Nair
Attachments: HIVE-5160.1.patch, HIVE-5160.patch
It would be useful to support the .hiverc functionality with hive server2 as
well.
.hiverc is processed by CliDriver, so it works only with hive cli. It would
be useful to be able to do things like register a standard set of jars and
functions for all users.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-5160) HS2 should support .hiverc
[ https://issues.apache.org/jira/browse/HIVE-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14072691#comment-14072691 ] Brock Noland commented on HIVE-5160: Nice work Dong Chen! Thank you much for the contribution! I think we should change one *small* item (in HiveConf related specifically to the Hive build) and thus I have filed HIVE-7497. HS2 should support .hiverc -- Key: HIVE-5160 URL: https://issues.apache.org/jira/browse/HIVE-5160 Project: Hive Issue Type: Improvement Components: HiveServer2 Reporter: Thejas M Nair Assignee: Dong Chen Fix For: 0.14.0 Attachments: HIVE-5160.1.patch, HIVE-5160.patch It would be useful to support the .hiverc functionality with hive server2 as well. .hiverc is processed by CliDriver, so it works only with hive cli. It would be useful to be able to do things like register a standard set of jars and functions for all users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-5160) HS2 should support .hiverc
[ https://issues.apache.org/jira/browse/HIVE-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14072779#comment-14072779 ] Lefty Leverenz commented on HIVE-5160: -- This adds *hive.global.init.file.location* to HiveConf.java and the template file, so it needs to be included in two wikidocs: * [Configuration Properties -- HiveServer2 | https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-HiveServer2] * [Setting Up HiveServer2 -- How to Configure | https://cwiki.apache.org/confluence/display/Hive/Setting+Up+HiveServer2#SettingUpHiveServer2-HowtoConfigure] Questions: # Does this parameter only apply to HiveServer2? # If so, why isn't it named hive.server2.* like the other HS2 parameters? (Sorry for asking after the commit.) # Is any other doc needed, such as usage notes or examples? HS2 should support .hiverc -- Key: HIVE-5160 URL: https://issues.apache.org/jira/browse/HIVE-5160 Project: Hive Issue Type: Improvement Components: HiveServer2 Reporter: Thejas M Nair Assignee: Dong Chen Labels: TODOC14 Fix For: 0.14.0 Attachments: HIVE-5160.1.patch, HIVE-5160.patch It would be useful to support the .hiverc functionality with hive server2 as well. .hiverc is processed by CliDriver, so it works only with hive cli. It would be useful to be able to do things like register a standard set of jars and functions for all users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-5160) HS2 should support .hiverc
[ https://issues.apache.org/jira/browse/HIVE-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070008#comment-14070008 ] Dong Chen commented on HIVE-5160: - Hi Szehon, Lefty, thanks very much for your comments. They are very helpful. I have updated the code in the review board. The change lists are: 1. clear typo. I should be more careful on spelling and grammar. ^_^ 2. rebase my local trunk and use new HiveConf.java. 3. rework the initialization order so that we use proxy Session. HS2 should support .hiverc -- Key: HIVE-5160 URL: https://issues.apache.org/jira/browse/HIVE-5160 Project: Hive Issue Type: Improvement Components: HiveServer2 Reporter: Thejas M Nair Attachments: HIVE-5160.patch It would be useful to support the .hiverc functionality with hive server2 as well. .hiverc is processed by CliDriver, so it works only with hive cli. It would be useful to be able to do things like register a standard set of jars and functions for all users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-5160) HS2 should support .hiverc
[ https://issues.apache.org/jira/browse/HIVE-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071020#comment-14071020 ] Szehon Ho commented on HIVE-5160: - +1 pending tests, thanks for making these changes. It seems Lefty also approved on the review-board. [~brocknoland] can we add Dong Chen to contributor list so that he can get the credit? HS2 should support .hiverc -- Key: HIVE-5160 URL: https://issues.apache.org/jira/browse/HIVE-5160 Project: Hive Issue Type: Improvement Components: HiveServer2 Reporter: Thejas M Nair Attachments: HIVE-5160.1.patch, HIVE-5160.patch It would be useful to support the .hiverc functionality with hive server2 as well. .hiverc is processed by CliDriver, so it works only with hive cli. It would be useful to be able to do things like register a standard set of jars and functions for all users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-5160) HS2 should support .hiverc
[ https://issues.apache.org/jira/browse/HIVE-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071073#comment-14071073 ] Lefty Leverenz commented on HIVE-5160: -- Yes, +1 as far as docs go. (I'm not qualified to judge the code, but pushing the Ship It button was fun.) HS2 should support .hiverc -- Key: HIVE-5160 URL: https://issues.apache.org/jira/browse/HIVE-5160 Project: Hive Issue Type: Improvement Components: HiveServer2 Reporter: Thejas M Nair Attachments: HIVE-5160.1.patch, HIVE-5160.patch It would be useful to support the .hiverc functionality with hive server2 as well. .hiverc is processed by CliDriver, so it works only with hive cli. It would be useful to be able to do things like register a standard set of jars and functions for all users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-5160) HS2 should support .hiverc
[ https://issues.apache.org/jira/browse/HIVE-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068540#comment-14068540 ] Dong Chen commented on HIVE-5160: - A patch which supports global .hiverc file in HS2 is attached. In this patch, the global .hiverc file will be loaded and parsed when a session is created. RB entry: https://reviews.apache.org/r/23738/ HS2 should support .hiverc -- Key: HIVE-5160 URL: https://issues.apache.org/jira/browse/HIVE-5160 Project: Hive Issue Type: Improvement Components: HiveServer2 Reporter: Thejas M Nair It would be useful to support the .hiverc functionality with hive server2 as well. .hiverc is processed by CliDriver, so it works only with hive cli. It would be useful to be able to do things like register a standard set of jars and functions for all users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-5160) HS2 should support .hiverc
[ https://issues.apache.org/jira/browse/HIVE-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14069546#comment-14069546 ] Szehon Ho commented on HIVE-5160: - Hi Dong, thanks for looking at this, it is pretty useful. I left comments on the review board. HS2 should support .hiverc -- Key: HIVE-5160 URL: https://issues.apache.org/jira/browse/HIVE-5160 Project: Hive Issue Type: Improvement Components: HiveServer2 Reporter: Thejas M Nair Attachments: HIVE-5160.patch It would be useful to support the .hiverc functionality with hive server2 as well. .hiverc is processed by CliDriver, so it works only with hive cli. It would be useful to be able to do things like register a standard set of jars and functions for all users. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-5160) HS2 should support .hiverc
[ https://issues.apache.org/jira/browse/HIVE-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13751777#comment-13751777 ] Thejas M Nair commented on HIVE-5160: - I mean a global .hiverc file is going to be useful with hive server2. HS2 should support .hiverc -- Key: HIVE-5160 URL: https://issues.apache.org/jira/browse/HIVE-5160 Project: Hive Issue Type: Improvement Components: HiveServer2 Reporter: Thejas M Nair It would be useful to support the .hiverc functionality with hive server2 as well. .hiverc is processed by CliDriver, so it works only with hive cli. It would be useful to be able to do things like register a standard set of jars and functions for all users. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-5160) HS2 should support .hiverc
[ https://issues.apache.org/jira/browse/HIVE-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13751776#comment-13751776 ] Thejas M Nair commented on HIVE-5160: - I am not sure if a user specific .hiverc would be of value in case of hive server2. HS2 should support .hiverc -- Key: HIVE-5160 URL: https://issues.apache.org/jira/browse/HIVE-5160 Project: Hive Issue Type: Improvement Components: HiveServer2 Reporter: Thejas M Nair It would be useful to support the .hiverc functionality with hive server2 as well. .hiverc is processed by CliDriver, so it works only with hive cli. It would be useful to be able to do things like register a standard set of jars and functions for all users. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
