[jira] [Commented] (HIVE-5636) Introduce getPartitionColumns() functionality from HCatInputFormat
[ https://issues.apache.org/jira/browse/HIVE-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906253#comment-13906253 ] Sushanth Sowmyan commented on HIVE-5636: Committed to trunk. Thanks for the review, Daniel. > Introduce getPartitionColumns() functionality from HCatInputFormat > -- > > Key: HIVE-5636 > URL: https://issues.apache.org/jira/browse/HIVE-5636 > Project: Hive > Issue Type: Bug > Components: HCatalog >Affects Versions: 0.12.0 >Reporter: Sushanth Sowmyan >Assignee: Sushanth Sowmyan > Attachments: HIVE-5636.2.patch, HIVE-5636.patch > > > As of HCat 0.5, we made the class InputJobInfo private for hcatalog use only, > and we made it so that setInput would not modify the InputJobInfo being > passed in. > However, if a user of HCatInputFormat wants to get what Partitioning columns > or Data columns exist for the job, they are not able to do so directly from > HCatInputFormat and are forced to use InputJobInfo, which currently does not > work. Thus, we need to expose this functionality. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-5636) Introduce getPartitionColumns() functionality from HCatInputFormat
[ https://issues.apache.org/jira/browse/HIVE-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906251#comment-13906251 ] Sushanth Sowmyan commented on HIVE-5636: Note : None of the reported failures are due to this patch. With Daniel's +1, I'm going to go ahead and commit. > Introduce getPartitionColumns() functionality from HCatInputFormat > -- > > Key: HIVE-5636 > URL: https://issues.apache.org/jira/browse/HIVE-5636 > Project: Hive > Issue Type: Bug > Components: HCatalog >Affects Versions: 0.12.0 >Reporter: Sushanth Sowmyan >Assignee: Sushanth Sowmyan > Attachments: HIVE-5636.2.patch, HIVE-5636.patch > > > As of HCat 0.5, we made the class InputJobInfo private for hcatalog use only, > and we made it so that setInput would not modify the InputJobInfo being > passed in. > However, if a user of HCatInputFormat wants to get what Partitioning columns > or Data columns exist for the job, they are not able to do so directly from > HCatInputFormat and are forced to use InputJobInfo, which currently does not > work. Thus, we need to expose this functionality. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-5636) Introduce getPartitionColumns() functionality from HCatInputFormat
[
https://issues.apache.org/jira/browse/HIVE-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13902787#comment-13902787
]
Hive QA commented on HIVE-5636:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12629157/HIVE-5636.2.patch
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 5121 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_auto_sortmerge_join_16
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucketmapjoin6
{noformat}
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1343/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1343/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12629157
> Introduce getPartitionColumns() functionality from HCatInputFormat
> --
>
> Key: HIVE-5636
> URL: https://issues.apache.org/jira/browse/HIVE-5636
> Project: Hive
> Issue Type: Bug
> Components: HCatalog
>Affects Versions: 0.12.0
>Reporter: Sushanth Sowmyan
>Assignee: Sushanth Sowmyan
> Attachments: HIVE-5636.2.patch, HIVE-5636.patch
>
>
> As of HCat 0.5, we made the class InputJobInfo private for hcatalog use only,
> and we made it so that setInput would not modify the InputJobInfo being
> passed in.
> However, if a user of HCatInputFormat wants to get what Partitioning columns
> or Data columns exist for the job, they are not able to do so directly from
> HCatInputFormat and are forced to use InputJobInfo, which currently does not
> work. Thus, we need to expose this functionality.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HIVE-5636) Introduce getPartitionColumns() functionality from HCatInputFormat
[ https://issues.apache.org/jira/browse/HIVE-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13902270#comment-13902270 ] Daniel Dai commented on HIVE-5636: -- +1 > Introduce getPartitionColumns() functionality from HCatInputFormat > -- > > Key: HIVE-5636 > URL: https://issues.apache.org/jira/browse/HIVE-5636 > Project: Hive > Issue Type: Bug > Components: HCatalog >Affects Versions: 0.12.0 >Reporter: Sushanth Sowmyan >Assignee: Sushanth Sowmyan > Attachments: HIVE-5636.2.patch, HIVE-5636.patch > > > As of HCat 0.5, we made the class InputJobInfo private for hcatalog use only, > and we made it so that setInput would not modify the InputJobInfo being > passed in. > However, if a user of HCatInputFormat wants to get what Partitioning columns > or Data columns exist for the job, they are not able to do so directly from > HCatInputFormat and are forced to use InputJobInfo, which currently does not > work. Thus, we need to expose this functionality. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-5636) Introduce getPartitionColumns() functionality from HCatInputFormat
[ https://issues.apache.org/jira/browse/HIVE-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13902164#comment-13902164 ] Sushanth Sowmyan commented on HIVE-5636: (I've created https://issues.apache.org/jira/browse/HIVE-6432 to track removal of all deprecations, and is something we can do right after we fork off 0.13 and trunk becomes 0.14) > Introduce getPartitionColumns() functionality from HCatInputFormat > -- > > Key: HIVE-5636 > URL: https://issues.apache.org/jira/browse/HIVE-5636 > Project: Hive > Issue Type: Bug > Components: HCatalog >Affects Versions: 0.12.0 >Reporter: Sushanth Sowmyan >Assignee: Sushanth Sowmyan > Attachments: HIVE-5636.2.patch, HIVE-5636.patch > > > As of HCat 0.5, we made the class InputJobInfo private for hcatalog use only, > and we made it so that setInput would not modify the InputJobInfo being > passed in. > However, if a user of HCatInputFormat wants to get what Partitioning columns > or Data columns exist for the job, they are not able to do so directly from > HCatInputFormat and are forced to use InputJobInfo, which currently does not > work. Thus, we need to expose this functionality. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-5636) Introduce getPartitionColumns() functionality from HCatInputFormat
[ https://issues.apache.org/jira/browse/HIVE-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13902137#comment-13902137 ] Sushanth Sowmyan commented on HIVE-5636: Reviewboard link : https://reviews.apache.org/r/18151/ [~thejas]/[~daijy] , can I bug either of you for a review? > Introduce getPartitionColumns() functionality from HCatInputFormat > -- > > Key: HIVE-5636 > URL: https://issues.apache.org/jira/browse/HIVE-5636 > Project: Hive > Issue Type: Bug > Components: HCatalog >Affects Versions: 0.12.0 >Reporter: Sushanth Sowmyan >Assignee: Sushanth Sowmyan > Attachments: HIVE-5636.2.patch, HIVE-5636.patch > > > As of HCat 0.5, we made the class InputJobInfo private for hcatalog use only, > and we made it so that setInput would not modify the InputJobInfo being > passed in. > However, if a user of HCatInputFormat wants to get what Partitioning columns > or Data columns exist for the job, they are not able to do so directly from > HCatInputFormat and are forced to use InputJobInfo, which currently does not > work. Thus, we need to expose this functionality. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-5636) Introduce getPartitionColumns() functionality from HCatInputFormat
[ https://issues.apache.org/jira/browse/HIVE-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13902133#comment-13902133 ] Sushanth Sowmyan commented on HIVE-5636: In my previous patch, I'd removed some of the older deprecated methods, but I've avoided doing that in this current patch given that it's so late in this release cycle - I think it's better to approach that after our next release. > Introduce getPartitionColumns() functionality from HCatInputFormat > -- > > Key: HIVE-5636 > URL: https://issues.apache.org/jira/browse/HIVE-5636 > Project: Hive > Issue Type: Bug > Components: HCatalog >Affects Versions: 0.12.0 >Reporter: Sushanth Sowmyan >Assignee: Sushanth Sowmyan > Attachments: HIVE-5636.2.patch, HIVE-5636.patch > > > As of HCat 0.5, we made the class InputJobInfo private for hcatalog use only, > and we made it so that setInput would not modify the InputJobInfo being > passed in. > However, if a user of HCatInputFormat wants to get what Partitioning columns > or Data columns exist for the job, they are not able to do so directly from > HCatInputFormat and are forced to use InputJobInfo, which currently does not > work. Thus, we need to expose this functionality. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-5636) Introduce getPartitionColumns() functionality from HCatInputFormat
[ https://issues.apache.org/jira/browse/HIVE-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804649#comment-13804649 ] Sushanth Sowmyan commented on HIVE-5636: (Note to self : https://issues.apache.org/jira/browse/HIVE-5454 just got committed, and modifies some of this, and this patch will need regeneration) > Introduce getPartitionColumns() functionality from HCatInputFormat > -- > > Key: HIVE-5636 > URL: https://issues.apache.org/jira/browse/HIVE-5636 > Project: Hive > Issue Type: Bug > Components: HCatalog >Affects Versions: 0.12.0 >Reporter: Sushanth Sowmyan >Assignee: Sushanth Sowmyan > Attachments: HIVE-5636.patch > > > As of HCat 0.5, we made the class InputJobInfo private for hcatalog use only, > and we made it so that setInput would not modify the InputJobInfo being > passed in. > However, if a user of HCatInputFormat wants to get what Partitioning columns > or Data columns exist for the job, they are not able to do so directly from > HCatInputFormat and are forced to use InputJobInfo, which currently does not > work. Thus, we need to expose this functionality. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5636) Introduce getPartitionColumns() functionality from HCatInputFormat
[
https://issues.apache.org/jira/browse/HIVE-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804457#comment-13804457
]
Hive QA commented on HIVE-5636:
---
{color:red}Overall{color}: -1 no tests executed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12609966/HIVE-5636.patch
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1229/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1229/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Tests failed with: NonZeroExitCodeException: Command 'bash
/data/hive-ptest/working/scratch/source-prep.sh' failed with exit status 1 and
output '+ [[ -n '' ]]
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost
-Dhttp.proxyPort=3128'
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost
-Dhttp.proxyPort=3128'
+ export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ M2_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ cd /data/hive-ptest/working/
+ tee /data/hive-ptest/logs/PreCommit-HIVE-Build-1229/source-prep.txt
+ [[ true == \t\r\u\e ]]
+ rm -rf ivy maven
+ mkdir -p maven ivy
+ [[ svn = \s\v\n ]]
+ [[ -n '' ]]
+ [[ -d apache-svn-trunk-source ]]
+ [[ ! -d apache-svn-trunk-source/.svn ]]
+ [[ ! -d apache-svn-trunk-source ]]
+ cd apache-svn-trunk-source
+ svn revert -R .
Reverted
'metastore/src/test/org/apache/hadoop/hive/metastore/TestMetastoreVersion.java'
Reverted 'ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java'
++ awk '{print $2}'
++ egrep -v '^X|^Performing status on external'
++ svn status --no-ignore
+ rm -rf build
metastore/src/test/org/apache/hadoop/hive/metastore/TestMetastoreVersion.java.orig
hcatalog/build hcatalog/core/build hcatalog/storage-handlers/hbase/build
hcatalog/server-extensions/build hcatalog/webhcat/svr/build
hcatalog/webhcat/java-client/build hcatalog/hcatalog-pig-adapter/build
common/src/gen
+ svn update
Fetching external item into 'hcatalog/src/test/e2e/harness'
External at revision 1535452.
At revision 1535452.
+ patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hive-ptest/working/scratch/build.patch
+ [[ -f /data/hive-ptest/working/scratch/build.patch ]]
+ chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh
+ /data/hive-ptest/working/scratch/smart-apply-patch.sh
/data/hive-ptest/working/scratch/build.patch
The patch does not appear to apply with p0, p1, or p2
+ exit 1
'
{noformat}
This message is automatically generated.
> Introduce getPartitionColumns() functionality from HCatInputFormat
> --
>
> Key: HIVE-5636
> URL: https://issues.apache.org/jira/browse/HIVE-5636
> Project: Hive
> Issue Type: Bug
> Components: HCatalog
>Affects Versions: 0.12.0
>Reporter: Sushanth Sowmyan
>Assignee: Sushanth Sowmyan
> Attachments: HIVE-5636.patch
>
>
> As of HCat 0.5, we made the class InputJobInfo private for hcatalog use only,
> and we made it so that setInput would not modify the InputJobInfo being
> passed in.
> However, if a user of HCatInputFormat wants to get what Partitioning columns
> or Data columns exist for the job, they are not able to do so directly from
> HCatInputFormat and are forced to use InputJobInfo, which currently does not
> work. Thus, we need to expose this functionality.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
