[jira] [Commented] (HIVE-5652) Improve JavaDoc of UDF class
[
https://issues.apache.org/jira/browse/HIVE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944683#comment-13944683
]
Hive QA commented on HIVE-5652:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12636192/HIVE-5652.4.patch
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 5442 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_auto_sortmerge_join_16
{noformat}
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1933/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1933/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12636192
Improve JavaDoc of UDF class
Key: HIVE-5652
URL: https://issues.apache.org/jira/browse/HIVE-5652
Project: Hive
Issue Type: Improvement
Components: Documentation
Reporter: Lars Francke
Assignee: Lars Francke
Priority: Trivial
Attachments: HIVE-5652.1.patch, HIVE-5652.2.patch, HIVE-5652.3.patch,
HIVE-5652.4.patch
I think the JavaDoc for the UDF class can be improved. I'll attach a patch
shortly.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-5652) Improve JavaDoc of UDF class
[ https://issues.apache.org/jira/browse/HIVE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944210#comment-13944210 ] Lefty Leverenz commented on HIVE-5652: -- +1 Thanks Lars. Improve JavaDoc of UDF class Key: HIVE-5652 URL: https://issues.apache.org/jira/browse/HIVE-5652 Project: Hive Issue Type: Improvement Components: Documentation Reporter: Lars Francke Assignee: Lars Francke Priority: Trivial Attachments: HIVE-5652.1.patch, HIVE-5652.2.patch, HIVE-5652.3.patch, HIVE-5652.4.patch I think the JavaDoc for the UDF class can be improved. I'll attach a patch shortly. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-5652) Improve JavaDoc of UDF class
[ https://issues.apache.org/jira/browse/HIVE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13943268#comment-13943268 ] Lefty Leverenz commented on HIVE-5652: -- Except the period. (I hate to be a stickler, though. So if you really want it there, I'll let it pass). [sic] Improve JavaDoc of UDF class Key: HIVE-5652 URL: https://issues.apache.org/jira/browse/HIVE-5652 Project: Hive Issue Type: Improvement Components: Documentation Reporter: Lars Francke Assignee: Lars Francke Priority: Trivial Attachments: HIVE-5652.1.patch, HIVE-5652.2.patch, HIVE-5652.3.patch I think the JavaDoc for the UDF class can be improved. I'll attach a patch shortly. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-5652) Improve JavaDoc of UDF class
[
https://issues.apache.org/jira/browse/HIVE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13942067#comment-13942067
]
Lefty Leverenz commented on HIVE-5652:
--
Punctuation police say: The added period belongs before ) because the entire
sentence is within parentheses.
{noformat}
. . . (Note that Hive Arrays
are represented as
+ * {@link java.util.List Lists} in Hive.
+ * So an {@code ARRAYint} column would be passed in as a {@code
ListInteger}).
{noformat}
Improve JavaDoc of UDF class
Key: HIVE-5652
URL: https://issues.apache.org/jira/browse/HIVE-5652
Project: Hive
Issue Type: Improvement
Components: Documentation
Reporter: Lars Francke
Assignee: Lars Francke
Priority: Trivial
Attachments: HIVE-5652.1.patch, HIVE-5652.2.patch
I think the JavaDoc for the UDF class can be improved. I'll attach a patch
shortly.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-5652) Improve JavaDoc of UDF class
[ https://issues.apache.org/jira/browse/HIVE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13942200#comment-13942200 ] Swarnim Kulkarni commented on HIVE-5652: Some minor comments: 1. Add return on getRequiredJars and getRequiredFiles method. Could would be nice to specify that the default implementation returns null. 2. GenericUDF - link(GenericUDF) for getRequiredJars and getRequiredFiles methods 3. Nit: A simple description of what required jars and required files are would be very helpful(atleast from a perspective of a newbie attempting to write a brand new UDF implementation). Improve JavaDoc of UDF class Key: HIVE-5652 URL: https://issues.apache.org/jira/browse/HIVE-5652 Project: Hive Issue Type: Improvement Components: Documentation Reporter: Lars Francke Assignee: Lars Francke Priority: Trivial Attachments: HIVE-5652.1.patch, HIVE-5652.2.patch I think the JavaDoc for the UDF class can be improved. I'll attach a patch shortly. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-5652) Improve JavaDoc of UDF class
[
https://issues.apache.org/jira/browse/HIVE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885987#comment-13885987
]
Hive QA commented on HIVE-5652:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12625857/HIVE-5652.2.patch
{color:green}SUCCESS:{color} +1 4972 tests passed
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1102/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1102/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12625857
Improve JavaDoc of UDF class
Key: HIVE-5652
URL: https://issues.apache.org/jira/browse/HIVE-5652
Project: Hive
Issue Type: Improvement
Components: Documentation
Reporter: Lars Francke
Assignee: Lars Francke
Priority: Trivial
Attachments: HIVE-5652.1.patch, HIVE-5652.2.patch
I think the JavaDoc for the UDF class can be improved. I'll attach a patch
shortly.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HIVE-5652) Improve JavaDoc of UDF class
[
https://issues.apache.org/jira/browse/HIVE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806065#comment-13806065
]
Hive QA commented on HIVE-5652:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12610319/HIVE-5652.1.patch
{color:green}SUCCESS:{color} +1 4483 tests passed
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1245/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1245/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
Improve JavaDoc of UDF class
Key: HIVE-5652
URL: https://issues.apache.org/jira/browse/HIVE-5652
Project: Hive
Issue Type: Improvement
Components: Documentation
Reporter: Lars Francke
Assignee: Lars Francke
Priority: Trivial
Attachments: HIVE-5652.1.patch
I think the JavaDoc for the UDF class can be improved. I'll attach a patch
shortly.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
