[jira] [Commented] (HIVE-5700) enforce single date format for partition column storage
[ https://issues.apache.org/jira/browse/HIVE-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287701#comment-14287701 ] Brock Noland commented on HIVE-5700: [~sershe] [~ashutoshc] - please see HIVE-9445 where I plan to revert this commit. > enforce single date format for partition column storage > --- > > Key: HIVE-5700 > URL: https://issues.apache.org/jira/browse/HIVE-5700 > Project: Hive > Issue Type: Improvement >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Fix For: 0.13.0 > > Attachments: HIVE-5700.01.patch, HIVE-5700.02.patch, HIVE-5700.patch > > > "inspired" by HIVE-5286. > Partition column for dates should be stored as either integer, or as fixed > representation e.g. -mm-dd. External representation can remain varied as > is. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-5700) enforce single date format for partition column storage
[
https://issues.apache.org/jira/browse/HIVE-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287111#comment-14287111
]
Brock Noland commented on HIVE-5700:
[~sershe] - in my setup, I have a pre-upgrade table with date partitions in the
form of {{20141218}}. Sure enough after upgrading {{PARTITION.PART_NAME}} is
not updated and as such I cannot do operations like modify the partitions
location. If I manually fix {{PARTITION.PART_NAME}} I am able to use the
partition.
Furthermore we get even more interesting results on postgres. I am setting up
an environment to reproduce this and will share additional details tomorrow.
> enforce single date format for partition column storage
> ---
>
> Key: HIVE-5700
> URL: https://issues.apache.org/jira/browse/HIVE-5700
> Project: Hive
> Issue Type: Improvement
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Fix For: 0.13.0
>
> Attachments: HIVE-5700.01.patch, HIVE-5700.02.patch, HIVE-5700.patch
>
>
> "inspired" by HIVE-5286.
> Partition column for dates should be stored as either integer, or as fixed
> representation e.g. -mm-dd. External representation can remain varied as
> is.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-5700) enforce single date format for partition column storage
[
https://issues.apache.org/jira/browse/HIVE-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286954#comment-14286954
]
Brock Noland commented on HIVE-5700:
There is a similar problem to HIVE-8730 on postgres. [~sershe] - I noticed that
this change does not update {{PARTITION.PART_NAME}}. It seems that should be
done as well?
> enforce single date format for partition column storage
> ---
>
> Key: HIVE-5700
> URL: https://issues.apache.org/jira/browse/HIVE-5700
> Project: Hive
> Issue Type: Improvement
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Fix For: 0.13.0
>
> Attachments: HIVE-5700.01.patch, HIVE-5700.02.patch, HIVE-5700.patch
>
>
> "inspired" by HIVE-5286.
> Partition column for dates should be stored as either integer, or as fixed
> representation e.g. -mm-dd. External representation can remain varied as
> is.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-5700) enforce single date format for partition column storage
[ https://issues.apache.org/jira/browse/HIVE-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818166#comment-13818166 ] Ashutosh Chauhan commented on HIVE-5700: +1 > enforce single date format for partition column storage > --- > > Key: HIVE-5700 > URL: https://issues.apache.org/jira/browse/HIVE-5700 > Project: Hive > Issue Type: Improvement >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-5700.01.patch, HIVE-5700.02.patch, HIVE-5700.patch > > > "inspired" by HIVE-5286. > Partition column for dates should be stored as either integer, or as fixed > representation e.g. -mm-dd. External representation can remain varied as > is. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5700) enforce single date format for partition column storage
[
https://issues.apache.org/jira/browse/HIVE-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818110#comment-13818110
]
Hive QA commented on HIVE-5700:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12612963/HIVE-5700.02.patch
{color:green}SUCCESS:{color} +1 4599 tests passed
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/227/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/227/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12612963
> enforce single date format for partition column storage
> ---
>
> Key: HIVE-5700
> URL: https://issues.apache.org/jira/browse/HIVE-5700
> Project: Hive
> Issue Type: Improvement
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: HIVE-5700.01.patch, HIVE-5700.02.patch, HIVE-5700.patch
>
>
> "inspired" by HIVE-5286.
> Partition column for dates should be stored as either integer, or as fixed
> representation e.g. -mm-dd. External representation can remain varied as
> is.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HIVE-5700) enforce single date format for partition column storage
[ https://issues.apache.org/jira/browse/HIVE-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817604#comment-13817604 ] Sergey Shelukhin commented on HIVE-5700: I was hoping to avoid writing Derby upgrade script... it;s not DB structure - do people really need to upgrade derby? Hmm. As for negative tests, the problem is that date validation on JDK6 is going to kick in first and reject the date literal before this code executes... the only way to allow it is to run JDK7, for example. Let me think about more isolated test > enforce single date format for partition column storage > --- > > Key: HIVE-5700 > URL: https://issues.apache.org/jira/browse/HIVE-5700 > Project: Hive > Issue Type: Improvement >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-5700.01.patch, HIVE-5700.patch > > > "inspired" by HIVE-5286. > Partition column for dates should be stored as either integer, or as fixed > representation e.g. -mm-dd. External representation can remain varied as > is. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5700) enforce single date format for partition column storage
[ https://issues.apache.org/jira/browse/HIVE-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817579#comment-13817579 ] Ashutosh Chauhan commented on HIVE-5700: You also need to add script for derby. Also, if you can test your Oracle script, that will be good. Also, a -ve test case which rejects date like 2013-1-1 as partitioning column will be good to include. > enforce single date format for partition column storage > --- > > Key: HIVE-5700 > URL: https://issues.apache.org/jira/browse/HIVE-5700 > Project: Hive > Issue Type: Improvement >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-5700.01.patch, HIVE-5700.patch > > > "inspired" by HIVE-5286. > Partition column for dates should be stored as either integer, or as fixed > representation e.g. -mm-dd. External representation can remain varied as > is. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5700) enforce single date format for partition column storage
[ https://issues.apache.org/jira/browse/HIVE-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817559#comment-13817559 ] Sergey Shelukhin commented on HIVE-5700: https://reviews.apache.org/r/15359/ > enforce single date format for partition column storage > --- > > Key: HIVE-5700 > URL: https://issues.apache.org/jira/browse/HIVE-5700 > Project: Hive > Issue Type: Improvement >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-5700.01.patch, HIVE-5700.patch > > > "inspired" by HIVE-5286. > Partition column for dates should be stored as either integer, or as fixed > representation e.g. -mm-dd. External representation can remain varied as > is. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5700) enforce single date format for partition column storage
[ https://issues.apache.org/jira/browse/HIVE-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817507#comment-13817507 ] Ashutosh Chauhan commented on HIVE-5700: Can you create a RB entry for this ? > enforce single date format for partition column storage > --- > > Key: HIVE-5700 > URL: https://issues.apache.org/jira/browse/HIVE-5700 > Project: Hive > Issue Type: Improvement >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-5700.01.patch, HIVE-5700.patch > > > "inspired" by HIVE-5286. > Partition column for dates should be stored as either integer, or as fixed > representation e.g. -mm-dd. External representation can remain varied as > is. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5700) enforce single date format for partition column storage
[
https://issues.apache.org/jira/browse/HIVE-5700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817106#comment-13817106
]
Hive QA commented on HIVE-5700:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12612776/HIVE-5700.01.patch
{color:green}SUCCESS:{color} +1 4594 tests passed
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/205/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/205/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12612776
> enforce single date format for partition column storage
> ---
>
> Key: HIVE-5700
> URL: https://issues.apache.org/jira/browse/HIVE-5700
> Project: Hive
> Issue Type: Improvement
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: HIVE-5700.01.patch, HIVE-5700.patch
>
>
> "inspired" by HIVE-5286.
> Partition column for dates should be stored as either integer, or as fixed
> representation e.g. -mm-dd. External representation can remain varied as
> is.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
