[jira] [Commented] (HIVE-5722) Skip generating vectorization code if possible
[
https://issues.apache.org/jira/browse/HIVE-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818384#comment-13818384
]
Hive QA commented on HIVE-5722:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12613024/HIVE-5722.3.patch.txt
{color:green}SUCCESS:{color} +1 4600 tests passed
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/232/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/232/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12613024
> Skip generating vectorization code if possible
> --
>
> Key: HIVE-5722
> URL: https://issues.apache.org/jira/browse/HIVE-5722
> Project: Hive
> Issue Type: Improvement
> Components: Build Infrastructure
>Reporter: Navis
>Assignee: Navis
>Priority: Minor
> Attachments: D13941.1.patch, HIVE-5722.1.patch.txt,
> HIVE-5722.3.patch.txt
>
>
> Currently, ql module always generates new vectorization code, which might not
> be changed so frequently.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HIVE-5722) Skip generating vectorization code if possible
[
https://issues.apache.org/jira/browse/HIVE-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816150#comment-13816150
]
Hive QA commented on HIVE-5722:
---
{color:red}Overall{color}: -1 no tests executed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12612535/D13941.1.patch
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/178/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/178/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Tests failed with: NonZeroExitCodeException: Command 'bash
/data/hive-ptest/working/scratch/source-prep.sh' failed with exit status 1 and
output '+ [[ -n '' ]]
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost
-Dhttp.proxyPort=3128'
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost
-Dhttp.proxyPort=3128'
+ export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost
-Dhttp.proxyPort=3128'
+ M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost
-Dhttp.proxyPort=3128'
+ cd /data/hive-ptest/working/
+ tee /data/hive-ptest/logs/PreCommit-HIVE-Build-178/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ svn = \s\v\n ]]
+ [[ -n '' ]]
+ [[ -d apache-svn-trunk-source ]]
+ [[ ! -d apache-svn-trunk-source/.svn ]]
+ [[ ! -d apache-svn-trunk-source ]]
+ cd apache-svn-trunk-source
+ svn revert -R .
Reverted 'beeline/src/java/org/apache/hive/beeline/BeeLine.java'
Reverted 'beeline/src/java/org/apache/hive/beeline/Commands.java'
Reverted 'beeline/src/main/resources/BeeLine.properties'
++ awk '{print $2}'
++ egrep -v '^X|^Performing status on external'
++ svn status --no-ignore
+ rm -rf target datanucleus.log ant/target shims/0.20/target
shims/assembly/target shims/0.20S/target shims/0.23/target shims/common/target
shims/common-secure/target metastore/target common/target common/src/gen
serde/target beeline/src/java/org/apache/hive/beeline/Commands.java.orig
+ svn update
Fetching external item into 'hcatalog/src/test/e2e/harness'
External at revision 1539724.
At revision 1539724.
+ patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hive-ptest/working/scratch/build.patch
+ [[ -f /data/hive-ptest/working/scratch/build.patch ]]
+ chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh
+ /data/hive-ptest/working/scratch/smart-apply-patch.sh
/data/hive-ptest/working/scratch/build.patch
Going to apply patch with: patch -p0
patching file ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java
patching file ant/src/org/apache/hadoop/hive/ant/GenVectorTestCode.java
+ [[ maven == \m\a\v\e\n ]]
+ rm -rf /data/hive-ptest/working/maven/org/apache/hive
+ mvn -B clean install -DskipTests
-Dmaven.repo.local=/data/hive-ptest/working/maven
[INFO] Scanning for projects...
[INFO]
[INFO] Reactor Build Order:
[INFO]
[INFO] Hive
[INFO] Hive Ant Utilities
[INFO] Hive Shims Common
[INFO] Hive Shims 0.20
[INFO] Hive Shims Secure Common
[INFO] Hive Shims 0.20S
[INFO] Hive Shims 0.23
[INFO] Hive Shims
[INFO] Hive Common
[INFO] Hive Serde
[INFO] Hive Metastore
[INFO] Hive Query Language
[INFO] Hive Service
[INFO] Hive JDBC
[INFO] Hive Beeline
[INFO] Hive CLI
[INFO] Hive Contrib
[INFO] Hive HBase Handler
[INFO] Hive HCatalog
[INFO] Hive HCatalog Core
[INFO] Hive HCatalog Pig Adapter
[INFO] Hive HCatalog Server Extensions
[INFO] Hive HCatalog Webhcat Java Client
[INFO] Hive HCatalog Webhcat
[INFO] Hive HCatalog HBase Storage Handler
[INFO] Hive HWI
[INFO] Hive ODBC
[INFO] Hive Shims Aggregator
[INFO] Hive TestUtils
[INFO] Hive Packaging
[INFO]
[INFO]
[INFO] Building Hive 0.13.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ hive ---
[INFO] Deleting /data/hive-ptest/working/apache-svn-trunk-source (includes =
[datanucleus.log, derby.log], excludes = [])
[INFO]
[INFO] --- maven-antrun-plugin:1.7:run (define-classpath) @ hive ---
[INFO] Executing tasks
main:
[INFO] Executed tasks
[INFO]
[INFO] --- maven-antrun-plugin:1.7:run (setup-test-dirs) @ hive ---
[INFO] Executing tasks
main:
[mkdir] Created dir:
/data/hive-ptest/working/apache-svn-trunk-source/target/tmp
[mkdir] Created dir:
/data/hive-ptest/working/apache-svn-trunk-source/target/warehouse
[mkdir] Created dir:
/data/hive-ptest/working/apache-svn-trunk-source/target/tmp/conf
[copy] Copying 4 files to
/data/hive-ptest/working/apache-svn-trunk-source/target/tmp/conf
[INFO] Executed tasks
[INFO]
[INFO] --- maven-install-plugin:2.4:install (default-install) @ hiv
[jira] [Commented] (HIVE-5722) Skip generating vectorization code if possible
[ https://issues.apache.org/jira/browse/HIVE-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816107#comment-13816107 ] Brock Noland commented on HIVE-5722: Thanks Navis! +1 > Skip generating vectorization code if possible > -- > > Key: HIVE-5722 > URL: https://issues.apache.org/jira/browse/HIVE-5722 > Project: Hive > Issue Type: Improvement > Components: Build Infrastructure >Reporter: Navis >Assignee: Navis >Priority: Minor > Attachments: D13941.1.patch, HIVE-5722.1.patch.txt > > > Currently, ql module always generates new vectorization code, which might not > be changed so frequently. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-5722) Skip generating vectorization code if possible
[
https://issues.apache.org/jira/browse/HIVE-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812899#comment-13812899
]
Brock Noland commented on HIVE-5722:
Hey Navis,
This looks good, but I think we just have the following args turned around.
{noformat}
- GenVectorCode.writeFile(outputFile, templateString);
+ GenVectorCode.writeFile(outputFile, new File(templateString));
{noformat}
meaning it should be:
{noformat}
GenVectorCode.writeFile(templateString, new File(outputFile));
{noformat}
correct?
> Skip generating vectorization code if possible
> --
>
> Key: HIVE-5722
> URL: https://issues.apache.org/jira/browse/HIVE-5722
> Project: Hive
> Issue Type: Improvement
> Components: Build Infrastructure
>Reporter: Navis
>Assignee: Navis
>Priority: Minor
> Attachments: HIVE-5722.1.patch.txt
>
>
> NO PRECOMMIT TESTS
> Currently, ql module always generates new vectorization code, which might not
> be changed so frequently.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HIVE-5722) Skip generating vectorization code if possible
[ https://issues.apache.org/jira/browse/HIVE-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811313#comment-13811313 ] Brock Noland commented on HIVE-5722: +1, lgtm > Skip generating vectorization code if possible > -- > > Key: HIVE-5722 > URL: https://issues.apache.org/jira/browse/HIVE-5722 > Project: Hive > Issue Type: Improvement > Components: Build Infrastructure >Reporter: Navis >Assignee: Navis >Priority: Minor > Attachments: HIVE-5722.1.patch.txt > > > NO PRECOMMIT TESTS > Currently, ql module always generates new vectorization code, which might not > be changed so frequently. -- This message was sent by Atlassian JIRA (v6.1#6144)
