[jira] [Commented] (HIVE-6010) create a test that would ensure vectorization produces same results as non-vectorized execution
[
https://issues.apache.org/jira/browse/HIVE-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13851073#comment-13851073
]
Hive QA commented on HIVE-6010:
---
{color:red}Overall{color}: -1 no tests executed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12619183/HIVE-6010.03.patch
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/674/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/674/console
Messages:
{noformat}
This message was trimmed, see log for full details
[INFO] Deleting /data/hive-ptest/working/apache-svn-trunk-source/itests
(includes = [datanucleus.log, derby.log], excludes = [])
[INFO]
[INFO] --- maven-antrun-plugin:1.7:run (define-classpath) @ hive-it ---
[INFO] Executing tasks
main:
[INFO] Executed tasks
[INFO]
[INFO] --- maven-antrun-plugin:1.7:run (setup-test-dirs) @ hive-it ---
[INFO] Executing tasks
main:
[mkdir] Created dir:
/data/hive-ptest/working/apache-svn-trunk-source/itests/target/tmp
[mkdir] Created dir:
/data/hive-ptest/working/apache-svn-trunk-source/itests/target/warehouse
[mkdir] Created dir:
/data/hive-ptest/working/apache-svn-trunk-source/itests/target/tmp/conf
[copy] Copying 4 files to
/data/hive-ptest/working/apache-svn-trunk-source/itests/target/tmp/conf
[INFO] Executed tasks
[INFO]
[INFO] --- maven-install-plugin:2.4:install (default-install) @ hive-it ---
[INFO] Installing
/data/hive-ptest/working/apache-svn-trunk-source/itests/pom.xml to
/data/hive-ptest/working/maven/org/apache/hive/hive-it/0.13.0-SNAPSHOT/hive-it-0.13.0-SNAPSHOT.pom
[INFO]
[INFO]
[INFO] Building Hive Integration - Custom Serde 0.13.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ hive-it-custom-serde
---
[INFO] Deleting
/data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde (includes
= [datanucleus.log, derby.log], excludes = [])
[INFO]
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @
hive-it-custom-serde ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
/data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/src/main/resources
[INFO]
[INFO] --- maven-antrun-plugin:1.7:run (define-classpath) @
hive-it-custom-serde ---
[INFO] Executing tasks
main:
[INFO] Executed tasks
[INFO]
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @
hive-it-custom-serde ---
[INFO] Compiling 8 source files to
/data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/classes
[INFO]
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @
hive-it-custom-serde ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
/data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/src/test/resources
[INFO]
[INFO] --- maven-antrun-plugin:1.7:run (setup-test-dirs) @ hive-it-custom-serde
---
[INFO] Executing tasks
main:
[mkdir] Created dir:
/data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/tmp
[mkdir] Created dir:
/data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/warehouse
[mkdir] Created dir:
/data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/tmp/conf
[copy] Copying 4 files to
/data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/tmp/conf
[INFO] Executed tasks
[INFO]
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @
hive-it-custom-serde ---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-surefire-plugin:2.16:test (default-test) @
hive-it-custom-serde ---
[INFO] Tests are skipped.
[INFO]
[INFO] --- maven-jar-plugin:2.2:jar (default-jar) @ hive-it-custom-serde ---
[INFO] Building jar:
/data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/hive-it-custom-serde-0.13.0-SNAPSHOT.jar
[INFO]
[INFO] --- maven-install-plugin:2.4:install (default-install) @
hive-it-custom-serde ---
[INFO] Installing
/data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/hive-it-custom-serde-0.13.0-SNAPSHOT.jar
to
/data/hive-ptest/working/maven/org/apache/hive/hive-it-custom-serde/0.13.0-SNAPSHOT/hive-it-custom-serde-0.13.0-SNAPSHOT.jar
[INFO] Installing
/data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/pom.xml to
/data/hive-ptest/working/maven/org/apache/hive/hive-it-custom-serde/0.13.0-SNAPSHOT/hive-it-custom-serde-0.13.0-SNAPSHOT.pom
[INFO]
[jira] [Commented] (HIVE-6010) create a test that would ensure vectorization produces same results as non-vectorized execution
[
https://issues.apache.org/jira/browse/HIVE-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13851263#comment-13851263
]
Hive QA commented on HIVE-6010:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12619193/HIVE-6010.04.patch
{color:green}SUCCESS:{color} +1 4791 tests passed
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/676/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/676/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12619193
create a test that would ensure vectorization produces same results as
non-vectorized execution
---
Key: HIVE-6010
URL: https://issues.apache.org/jira/browse/HIVE-6010
Project: Hive
Issue Type: Test
Components: Tests, Vectorization
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Attachments: HIVE-6010.01.patch, HIVE-6010.02.patch,
HIVE-6010.03.patch, HIVE-6010.04.patch, HIVE-6010.patch
So as to ensure that vectorization is not forgotten when changes are made to
things. Obviously it would not be viable to have a bulletproof test, but at
least a subset of operations can be verified.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HIVE-6010) create a test that would ensure vectorization produces same results as non-vectorized execution
[ https://issues.apache.org/jira/browse/HIVE-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849926#comment-13849926 ] Jitendra Nath Pandey commented on HIVE-6010: +1 create a test that would ensure vectorization produces same results as non-vectorized execution --- Key: HIVE-6010 URL: https://issues.apache.org/jira/browse/HIVE-6010 Project: Hive Issue Type: Test Components: Tests, Vectorization Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Attachments: HIVE-6010.01.patch, HIVE-6010.02.patch, HIVE-6010.patch So as to ensure that vectorization is not forgotten when changes are made to things. Obviously it would not be viable to have a bulletproof test, but at least a subset of operations can be verified. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HIVE-6010) create a test that would ensure vectorization produces same results as non-vectorized execution
[ https://issues.apache.org/jira/browse/HIVE-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847761#comment-13847761 ] Sergey Shelukhin commented on HIVE-6010: Hmm, this code was not touched by this patch, and the failure doesn't repro for me. Let's try again... create a test that would ensure vectorization produces same results as non-vectorized execution --- Key: HIVE-6010 URL: https://issues.apache.org/jira/browse/HIVE-6010 Project: Hive Issue Type: Test Components: Tests, Vectorization Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Attachments: HIVE-6010.01.patch, HIVE-6010.patch So as to ensure that vectorization is not forgotten when changes are made to things. Obviously it would not be viable to have a bulletproof test, but at least a subset of operations can be verified. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HIVE-6010) create a test that would ensure vectorization produces same results as non-vectorized execution
[
https://issues.apache.org/jira/browse/HIVE-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847785#comment-13847785
]
Hive QA commented on HIVE-6010:
---
{color:red}Overall{color}: -1 no tests executed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12618654/HIVE-6010.01.patch
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/632/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/632/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hive-ptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ [[ -n '' ]]
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost
-Dhttp.proxyPort=3128'
+ M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost
-Dhttp.proxyPort=3128'
+ cd /data/hive-ptest/working/
+ tee /data/hive-ptest/logs/PreCommit-HIVE-Build-632/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ svn = \s\v\n ]]
+ [[ -n '' ]]
+ [[ -d apache-svn-trunk-source ]]
+ [[ ! -d apache-svn-trunk-source/.svn ]]
+ [[ ! -d apache-svn-trunk-source ]]
+ cd apache-svn-trunk-source
+ svn revert -R .
Reverted 'ql/src/test/results/clientnegative/dyn_part4.q.out'
Reverted 'ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java'
++ egrep -v '^X|^Performing status on external'
++ awk '{print $2}'
++ svn status --no-ignore
+ rm -rf target datanucleus.log ant/target shims/target shims/0.20/target
shims/assembly/target shims/0.20S/target shims/0.23/target shims/common/target
shims/common-secure/target packaging/target hbase-handler/target
testutils/target jdbc/target metastore/target itests/target
itests/hcatalog-unit/target itests/test-serde/target itests/qtest/target
itests/hive-unit/target itests/custom-serde/target itests/util/target
hcatalog/target hcatalog/storage-handlers/hbase/target
hcatalog/server-extensions/target hcatalog/core/target
hcatalog/webhcat/svr/target hcatalog/webhcat/java-client/target
hcatalog/hcatalog-pig-adapter/target hwi/target common/target common/src/gen
contrib/target service/target serde/target beeline/target odbc/target
cli/target ql/dependency-reduced-pom.xml ql/target
ql/src/test/results/clientpositive/loadpart2.q.out
ql/src/test/queries/clientpositive/loadpart2.q
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java.orig
+ svn update
Uitests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java
Uql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog10.java
Ujdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java
Fetching external item into 'hcatalog/src/test/e2e/harness'
Updated external to revision 1550809.
Updated to revision 1550809.
+ patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hive-ptest/working/scratch/build.patch
+ [[ -f /data/hive-ptest/working/scratch/build.patch ]]
+ chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh
+ /data/hive-ptest/working/scratch/smart-apply-patch.sh
/data/hive-ptest/working/scratch/build.patch
The patch does not appear to apply with p0, p1, or p2
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12618654
create a test that would ensure vectorization produces same results as
non-vectorized execution
---
Key: HIVE-6010
URL: https://issues.apache.org/jira/browse/HIVE-6010
Project: Hive
Issue Type: Test
Components: Tests, Vectorization
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Attachments: HIVE-6010.01.patch, HIVE-6010.patch
So as to ensure that vectorization is not forgotten when changes are made to
things. Obviously it would not be viable to have a bulletproof test, but at
least a subset of operations can be verified.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HIVE-6010) create a test that would ensure vectorization produces same results as non-vectorized execution
[
https://issues.apache.org/jira/browse/HIVE-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847895#comment-13847895
]
Hive QA commented on HIVE-6010:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12618662/HIVE-6010.02.patch
{color:green}SUCCESS:{color} +1 4787 tests passed
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/634/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/634/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12618662
create a test that would ensure vectorization produces same results as
non-vectorized execution
---
Key: HIVE-6010
URL: https://issues.apache.org/jira/browse/HIVE-6010
Project: Hive
Issue Type: Test
Components: Tests, Vectorization
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Attachments: HIVE-6010.01.patch, HIVE-6010.02.patch, HIVE-6010.patch
So as to ensure that vectorization is not forgotten when changes are made to
things. Obviously it would not be viable to have a bulletproof test, but at
least a subset of operations can be verified.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HIVE-6010) create a test that would ensure vectorization produces same results as non-vectorized execution
[ https://issues.apache.org/jira/browse/HIVE-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846954#comment-13846954 ] Sergey Shelukhin commented on HIVE-6010: https://reviews.apache.org/r/16229/ create a test that would ensure vectorization produces same results as non-vectorized execution --- Key: HIVE-6010 URL: https://issues.apache.org/jira/browse/HIVE-6010 Project: Hive Issue Type: Test Components: Tests, Vectorization Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Attachments: HIVE-6010.patch So as to ensure that vectorization is not forgotten when changes are made to things. Obviously it would not be viable to have a bulletproof test, but at least a subset of operations can be verified. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HIVE-6010) create a test that would ensure vectorization produces same results as non-vectorized execution
[
https://issues.apache.org/jira/browse/HIVE-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847002#comment-13847002
]
Hive QA commented on HIVE-6010:
---
{color:red}Overall{color}: -1 no tests executed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12618503/HIVE-6010.patch
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/626/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/626/console
Messages:
{noformat}
This message was trimmed, see log for full details
[ERROR]
/data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:[2399,49]
cannot find symbol
symbol : class UnlockDatabaseDesc
location: class org.apache.hadoop.hive.ql.parse.DDLSemanticAnalyzer
[ERROR]
/data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:[2431,35]
reference to DDLWork is ambiguous, both method
DDLWork(java.util.HashSetorg.apache.hadoop.hive.ql.hooks.ReadEntity,java.util.HashSetorg.apache.hadoop.hive.ql.hooks.WriteEntity,LockDatabaseDesc)
in org.apache.hadoop.hive.ql.plan.DDLWork and method
DDLWork(java.util.HashSetorg.apache.hadoop.hive.ql.hooks.ReadEntity,java.util.HashSetorg.apache.hadoop.hive.ql.hooks.WriteEntity,UnlockDatabaseDesc)
in org.apache.hadoop.hive.ql.plan.DDLWork match
[ERROR]
/data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:[2443,35]
reference to DDLWork is ambiguous, both method
DDLWork(java.util.HashSetorg.apache.hadoop.hive.ql.hooks.ReadEntity,java.util.HashSetorg.apache.hadoop.hive.ql.hooks.WriteEntity,LockDatabaseDesc)
in org.apache.hadoop.hive.ql.plan.DDLWork and method
DDLWork(java.util.HashSetorg.apache.hadoop.hive.ql.hooks.ReadEntity,java.util.HashSetorg.apache.hadoop.hive.ql.hooks.WriteEntity,UnlockDatabaseDesc)
in org.apache.hadoop.hive.ql.plan.DDLWork match
[ERROR]
/data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:[2493,35]
reference to DDLWork is ambiguous, both method
DDLWork(java.util.HashSetorg.apache.hadoop.hive.ql.hooks.ReadEntity,java.util.HashSetorg.apache.hadoop.hive.ql.hooks.WriteEntity,LockDatabaseDesc)
in org.apache.hadoop.hive.ql.plan.DDLWork and method
DDLWork(java.util.HashSetorg.apache.hadoop.hive.ql.hooks.ReadEntity,java.util.HashSetorg.apache.hadoop.hive.ql.hooks.WriteEntity,UnlockDatabaseDesc)
in org.apache.hadoop.hive.ql.plan.DDLWork match
[ERROR]
/data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:[2513,35]
reference to DDLWork is ambiguous, both method
DDLWork(java.util.HashSetorg.apache.hadoop.hive.ql.hooks.ReadEntity,java.util.HashSetorg.apache.hadoop.hive.ql.hooks.WriteEntity,LockDatabaseDesc)
in org.apache.hadoop.hive.ql.plan.DDLWork and method
DDLWork(java.util.HashSetorg.apache.hadoop.hive.ql.hooks.ReadEntity,java.util.HashSetorg.apache.hadoop.hive.ql.hooks.WriteEntity,UnlockDatabaseDesc)
in org.apache.hadoop.hive.ql.plan.DDLWork match
[ERROR]
/data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:[2529,35]
reference to DDLWork is ambiguous, both method
DDLWork(java.util.HashSetorg.apache.hadoop.hive.ql.hooks.ReadEntity,java.util.HashSetorg.apache.hadoop.hive.ql.hooks.WriteEntity,LockDatabaseDesc)
in org.apache.hadoop.hive.ql.plan.DDLWork and method
DDLWork(java.util.HashSetorg.apache.hadoop.hive.ql.hooks.ReadEntity,java.util.HashSetorg.apache.hadoop.hive.ql.hooks.WriteEntity,UnlockDatabaseDesc)
in org.apache.hadoop.hive.ql.plan.DDLWork match
[ERROR]
/data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:[2541,35]
reference to DDLWork is ambiguous, both method
DDLWork(java.util.HashSetorg.apache.hadoop.hive.ql.hooks.ReadEntity,java.util.HashSetorg.apache.hadoop.hive.ql.hooks.WriteEntity,LockDatabaseDesc)
in org.apache.hadoop.hive.ql.plan.DDLWork and method
DDLWork(java.util.HashSetorg.apache.hadoop.hive.ql.hooks.ReadEntity,java.util.HashSetorg.apache.hadoop.hive.ql.hooks.WriteEntity,UnlockDatabaseDesc)
in org.apache.hadoop.hive.ql.plan.DDLWork match
[ERROR]
/data/hive-ptest/working/apache-svn-trunk-source/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:[2589,35]
reference to DDLWork is ambiguous, both method
DDLWork(java.util.HashSetorg.apache.hadoop.hive.ql.hooks.ReadEntity,java.util.HashSetorg.apache.hadoop.hive.ql.hooks.WriteEntity,LockDatabaseDesc)
in org.apache.hadoop.hive.ql.plan.DDLWork and method
DDLWork(java.util.HashSetorg.apache.hadoop.hive.ql.hooks.ReadEntity,java.util.HashSetorg.apache.hadoop.hive.ql.hooks.WriteEntity,UnlockDatabaseDesc)
in
[jira] [Commented] (HIVE-6010) create a test that would ensure vectorization produces same results as non-vectorized execution
[ https://issues.apache.org/jira/browse/HIVE-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13845783#comment-13845783 ] Sergey Shelukhin commented on HIVE-6010: I will likely take it later this week if noone else takes it before. create a test that would ensure vectorization produces same results as non-vectorized execution --- Key: HIVE-6010 URL: https://issues.apache.org/jira/browse/HIVE-6010 Project: Hive Issue Type: Test Reporter: Sergey Shelukhin So as to ensure that vectorization is not forgotten when changes are made to things. Obviously it would not be viable to have a bulletproof test, but at least a subset of operations can be verified. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HIVE-6010) create a test that would ensure vectorization produces same results as non-vectorized execution
[ https://issues.apache.org/jira/browse/HIVE-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846029#comment-13846029 ] Sergey Shelukhin commented on HIVE-6010: I looked at CliDriver generation/code/flow... the plan is as such (this can also be used for other stuff later if needed). There will be new CliDriver template, called TestCompareCliDriver, with separate set of .q files. Unlike normal CliDriver, it will not use .out files; instead, there will be multiple .qv (query version) initialization files; I haven't decided yet whether these should be a set per query (q file), or a set applied to all queries. The latter is simpler and solves the problem for vectorization, but the former may make sense for other things, esp. if we need to compare more things, Nqv x Nq combinations to run will quickly become ugly. Perhaps per-query qv files can be added when needed. The test, for each of its q files, will concatenate all the requisite qv files in turn with the q file, run each of the resulting queries w/different output files, and diff the outputs with each other. It will fail if they don't match. So, for vectorization we can have some simple queries (arithmetics, functions, etc.), with qv files being one-liners to enable and disable vectorization. [~ehans] [~jnp] opinions? create a test that would ensure vectorization produces same results as non-vectorized execution --- Key: HIVE-6010 URL: https://issues.apache.org/jira/browse/HIVE-6010 Project: Hive Issue Type: Test Components: Tests, Vectorization Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin So as to ensure that vectorization is not forgotten when changes are made to things. Obviously it would not be viable to have a bulletproof test, but at least a subset of operations can be verified. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HIVE-6010) create a test that would ensure vectorization produces same results as non-vectorized execution
[ https://issues.apache.org/jira/browse/HIVE-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846030#comment-13846030 ] Sergey Shelukhin commented on HIVE-6010: Actually, this can also be used instead of VerifyingObjectStore to verify MetaStoreDirectSql matches JDO, come thing of it. Will reduce the coverage but also remove the crutch from that part of code. create a test that would ensure vectorization produces same results as non-vectorized execution --- Key: HIVE-6010 URL: https://issues.apache.org/jira/browse/HIVE-6010 Project: Hive Issue Type: Test Components: Tests, Vectorization Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin So as to ensure that vectorization is not forgotten when changes are made to things. Obviously it would not be viable to have a bulletproof test, but at least a subset of operations can be verified. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
