[jira] [Commented] (HIVE-6241) Remove direct reference of Hadoop23Shims inQTestUtil
[ https://issues.apache.org/jira/browse/HIVE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942844#comment-13942844 ] Ashutosh Chauhan commented on HIVE-6241: +1 > Remove direct reference of Hadoop23Shims inQTestUtil > > > Key: HIVE-6241 > URL: https://issues.apache.org/jira/browse/HIVE-6241 > Project: Hive > Issue Type: Wish > Components: Tests >Reporter: Navis >Assignee: Navis >Priority: Trivial > Attachments: HIVE-6241.1.patch.txt, HIVE-6241.2.patch.txt > > > {code} > if (clusterType == MiniClusterType.tez) { > if (!(shims instanceof Hadoop23Shims)) { > throw new Exception("Cannot run tez on hadoop-1, Version: > "+this.hadoopVer); > } > mr = ((Hadoop23Shims)shims).getMiniTezCluster(conf, 4, > getHdfsUriString(fs.getUri().toString()), 1); > } else { > mr = shims.getMiniMrCluster(conf, 4, > getHdfsUriString(fs.getUri().toString()), 1); > } > {code} > Not important but a little annoying when the shims is not in classpath. And I > think hadoop24shims or later might support tez. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6241) Remove direct reference of Hadoop23Shims inQTestUtil
[ https://issues.apache.org/jira/browse/HIVE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877351#comment-13877351 ] Hive QA commented on HIVE-6241: --- {color:green}Overall{color}: +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12624047/HIVE-6241.1.patch.txt {color:green}SUCCESS:{color} +1 4943 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/970/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/970/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12624047 > Remove direct reference of Hadoop23Shims inQTestUtil > > > Key: HIVE-6241 > URL: https://issues.apache.org/jira/browse/HIVE-6241 > Project: Hive > Issue Type: Wish > Components: Tests >Reporter: Navis >Assignee: Navis >Priority: Trivial > Attachments: HIVE-6241.1.patch.txt > > > {code} > if (clusterType == MiniClusterType.tez) { > if (!(shims instanceof Hadoop23Shims)) { > throw new Exception("Cannot run tez on hadoop-1, Version: > "+this.hadoopVer); > } > mr = ((Hadoop23Shims)shims).getMiniTezCluster(conf, 4, > getHdfsUriString(fs.getUri().toString()), 1); > } else { > mr = shims.getMiniMrCluster(conf, 4, > getHdfsUriString(fs.getUri().toString()), 1); > } > {code} > Not important but a little annoying when the shims is not in classpath. And I > think hadoop24shims or later might support tez. -- This message was sent by Atlassian JIRA (v6.1.5#6160)