[jira] [Commented] (HIVE-6305) test use of quoted identifiers in user/role names
[
https://issues.apache.org/jira/browse/HIVE-6305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071387#comment-14071387
]
Lefty Leverenz commented on HIVE-6305:
--
Another question: If hive.support.quoted.identifiers is set to none, can
back-ticks be used for regular expressions in user & role names? I'll try to
dodge the issue in the doc, for now.
Presumably quoted user/role names can have Unicode characters, since the test's
role name has a space (create role `src Role2`). But the SQL Std Auth doc says
user names are managed outside of Hive, so maybe Unicode doesn't work for them.
And presumably this applies to both SQL standard based and default
authorization, so I updated both docs with identical information:
* [SQL Standard Based Hive Authorization -- Names of Users and Roles |
https://cwiki.apache.org/confluence/display/Hive/SQL+Standard+Based+Hive+Authorization#SQLStandardBasedHiveAuthorization-NamesofUsersandRoles]
* [Hive Authorization -- Names of Users and Roles |
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Authorization#LanguageManualAuthorization-NamesofUsersandRoles]
But if Unicode is permitted in user/role names, then the description of
hive.support.quoted.identifiers should be revised to include them. Or even if
Unicode isn't permitted, the parameter should mention user and role names.
* [Configuration Properties -- hive.support.quoted.identifiers |
https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-hive.support.quoted.identifiers]
> test use of quoted identifiers in user/role names
> -
>
> Key: HIVE-6305
> URL: https://issues.apache.org/jira/browse/HIVE-6305
> Project: Hive
> Issue Type: Bug
> Components: Authorization
>Reporter: Thejas M Nair
>Assignee: Jason Dere
> Labels: TODOC13
> Fix For: 0.14.0
>
> Attachments: HIVE-6305.1.patch
>
>
> Tests need to be added to verify that quoted identifiers can be used with
> user and role names.
> For example -
> {code}
> grant all on x to user `user-qa`;
> show grant user `user-qa` on table x;
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6305) test use of quoted identifiers in user/role names
[
https://issues.apache.org/jira/browse/HIVE-6305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065502#comment-14065502
]
Lefty Leverenz commented on HIVE-6305:
--
Good, HIVE-6013 is already documented so it's easy to add this to the wiki.
Thanks, Thejas.
One question: why don't these tests specify hive.support.quoted.identifiers?
Oh, nevermind, its default setting is column.
> test use of quoted identifiers in user/role names
> -
>
> Key: HIVE-6305
> URL: https://issues.apache.org/jira/browse/HIVE-6305
> Project: Hive
> Issue Type: Bug
> Components: Authorization
>Reporter: Thejas M Nair
>Assignee: Jason Dere
> Labels: TODOC13
> Fix For: 0.14.0
>
> Attachments: HIVE-6305.1.patch
>
>
> Tests need to be added to verify that quoted identifiers can be used with
> user and role names.
> For example -
> {code}
> grant all on x to user `user-qa`;
> show grant user `user-qa` on table x;
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6305) test use of quoted identifiers in user/role names
[
https://issues.apache.org/jira/browse/HIVE-6305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065332#comment-14065332
]
Thejas M Nair commented on HIVE-6305:
-
The quoted identifier support was added as part HIVE-6013 by [~rhbutani] . This
is just testing that it works with role names as well. If i remember right,
HIVE-6013 talks only about column names because only that was tested as that
part of the patch.
Yes, we should document that role names can also be quoted identifier.
> test use of quoted identifiers in user/role names
> -
>
> Key: HIVE-6305
> URL: https://issues.apache.org/jira/browse/HIVE-6305
> Project: Hive
> Issue Type: Bug
> Components: Authorization
>Reporter: Thejas M Nair
>Assignee: Jason Dere
> Fix For: 0.14.0
>
> Attachments: HIVE-6305.1.patch
>
>
> Tests need to be added to verify that quoted identifiers can be used with
> user and role names.
> For example -
> {code}
> grant all on x to user `user-qa`;
> show grant user `user-qa` on table x;
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6305) test use of quoted identifiers in user/role names
[
https://issues.apache.org/jira/browse/HIVE-6305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064517#comment-14064517
]
Lefty Leverenz commented on HIVE-6305:
--
This jira just adds tests so it doesn't need any user doc, but quoted
identifiers for names should be documented. Which jira would that be?
> test use of quoted identifiers in user/role names
> -
>
> Key: HIVE-6305
> URL: https://issues.apache.org/jira/browse/HIVE-6305
> Project: Hive
> Issue Type: Bug
> Components: Authorization
>Reporter: Thejas M Nair
>Assignee: Jason Dere
> Fix For: 0.14.0
>
> Attachments: HIVE-6305.1.patch
>
>
> Tests need to be added to verify that quoted identifiers can be used with
> user and role names.
> For example -
> {code}
> grant all on x to user `user-qa`;
> show grant user `user-qa` on table x;
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6305) test use of quoted identifiers in user/role names
[
https://issues.apache.org/jira/browse/HIVE-6305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062949#comment-14062949
]
Thejas M Nair commented on HIVE-6305:
-
+1
> test use of quoted identifiers in user/role names
> -
>
> Key: HIVE-6305
> URL: https://issues.apache.org/jira/browse/HIVE-6305
> Project: Hive
> Issue Type: Bug
> Components: Authorization
>Reporter: Thejas M Nair
>Assignee: Jason Dere
> Attachments: HIVE-6305.1.patch
>
>
> Tests need to be added to verify that quoted identifiers can be used with
> user and role names.
> For example -
> {code}
> grant all on x to user `user-qa`;
> show grant user `user-qa` on table x;
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6305) test use of quoted identifiers in user/role names
[
https://issues.apache.org/jira/browse/HIVE-6305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062913#comment-14062913
]
Jason Dere commented on HIVE-6305:
--
Patch only added new q file tests, the other failures are not related.
> test use of quoted identifiers in user/role names
> -
>
> Key: HIVE-6305
> URL: https://issues.apache.org/jira/browse/HIVE-6305
> Project: Hive
> Issue Type: Bug
> Components: Authorization
>Reporter: Thejas M Nair
>Assignee: Jason Dere
> Attachments: HIVE-6305.1.patch
>
>
> Tests need to be added to verify that quoted identifiers can be used with
> user and role names.
> For example -
> {code}
> grant all on x to user `user-qa`;
> show grant user `user-qa` on table x;
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6305) test use of quoted identifiers in user/role names
[
https://issues.apache.org/jira/browse/HIVE-6305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062901#comment-14062901
]
Hive QA commented on HIVE-6305:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12655851/HIVE-6305.1.patch
{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 5718 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_temp_table
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_tez_join_hash
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_ql_rewrite_gbtoidx
org.apache.hive.hcatalog.pig.TestHCatLoader.testReadDataPrimitiveTypes
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/800/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/800/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-Build-800/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12655851
> test use of quoted identifiers in user/role names
> -
>
> Key: HIVE-6305
> URL: https://issues.apache.org/jira/browse/HIVE-6305
> Project: Hive
> Issue Type: Bug
> Components: Authorization
>Reporter: Thejas M Nair
>Assignee: Jason Dere
> Attachments: HIVE-6305.1.patch
>
>
> Tests need to be added to verify that quoted identifiers can be used with
> user and role names.
> For example -
> {code}
> grant all on x to user `user-qa`;
> show grant user `user-qa` on table x;
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
