[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328026#comment-14328026 ] david serafini commented on HIVE-7100: -- Looks ok to me. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement > Components: Query Processor >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: david serafini > Labels: TODOC14 > Fix For: 0.14.0 > > Attachments: HIVE-7100.1.patch, HIVE-7100.10.patch, > HIVE-7100.11.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, HIVE-7100.4.patch, > HIVE-7100.5.patch, HIVE-7100.8.patch, HIVE-7100.9.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327190#comment-14327190 ] Lefty Leverenz commented on HIVE-7100: -- Doc note: This is documented in the wiki for DROP TABLE and ALTER TABLE DROP PARTITION. * [Drop Table | https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-DropTable] * [Drop Partitions | https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-DropPartitions] I included DROP PARTITION based on deletePartitionData() in the patch -- please review my changes and correct anything that's not right. If it's okay, the TODOC14 label can be removed. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement > Components: Query Processor >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: david serafini > Labels: TODOC14 > Fix For: 0.14.0 > > Attachments: HIVE-7100.1.patch, HIVE-7100.10.patch, > HIVE-7100.11.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, HIVE-7100.4.patch, > HIVE-7100.5.patch, HIVE-7100.8.patch, HIVE-7100.9.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144138#comment-14144138 ] Lefty Leverenz commented on HIVE-7100: -- Doc note: This belongs in the DROP TABLE section of the DDL wikidoc, with version information and a JIRA link: * [DDL -- Drop Table | https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-DropTable] > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement > Components: Query Processor >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: david serafini > Labels: TODOC14 > Fix For: 0.14.0 > > Attachments: HIVE-7100.1.patch, HIVE-7100.10.patch, > HIVE-7100.11.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, HIVE-7100.4.patch, > HIVE-7100.5.patch, HIVE-7100.8.patch, HIVE-7100.9.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143636#comment-14143636 ] Hive QA commented on HIVE-7100: --- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12670435/HIVE-7100.11.patch {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 6302 tests executed *Failed tests:* {noformat} org.apache.hive.hcatalog.pig.TestOrcHCatLoader.testReadDataPrimitiveTypes {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/923/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/923/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-923/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12670435 > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: david serafini > Attachments: HIVE-7100.1.patch, HIVE-7100.10.patch, > HIVE-7100.11.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, HIVE-7100.4.patch, > HIVE-7100.5.patch, HIVE-7100.8.patch, HIVE-7100.9.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14142360#comment-14142360 ] Lefty Leverenz commented on HIVE-7100: -- bq. Purge is an option for dropping, Thus, there shouldn't be any relationship between "immutable" and "purge". That makes sense. Thanks, [~xuefuz]. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: david serafini > Attachments: HIVE-7100.1.patch, HIVE-7100.10.patch, > HIVE-7100.2.patch, HIVE-7100.3.patch, HIVE-7100.4.patch, HIVE-7100.5.patch, > HIVE-7100.8.patch, HIVE-7100.9.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14142003#comment-14142003 ] Xuefu Zhang commented on HIVE-7100: --- [~dbsalti] The patch needs to be rebased as it doesn't apply to latest trunk any more. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: david serafini > Attachments: HIVE-7100.1.patch, HIVE-7100.10.patch, > HIVE-7100.2.patch, HIVE-7100.3.patch, HIVE-7100.4.patch, HIVE-7100.5.patch, > HIVE-7100.8.patch, HIVE-7100.9.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14142002#comment-14142002 ] Xuefu Zhang commented on HIVE-7100: --- {quote} What should the behavior of drop table be for an immutable table? With and without the purge option? {quote} There should be no difference in dropping table behavior regarding immutable tables, accordingly HIVE-6406. Being "immutable" doesn't prevents "droping". It only blocks "updating" when content exisits. Purge is an option for dropping, Thus, there shouldn't be any relationship between "immutable" and "purge". > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: david serafini > Attachments: HIVE-7100.1.patch, HIVE-7100.10.patch, > HIVE-7100.2.patch, HIVE-7100.3.patch, HIVE-7100.4.patch, HIVE-7100.5.patch, > HIVE-7100.8.patch, HIVE-7100.9.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140786#comment-14140786 ] david serafini commented on HIVE-7100: -- No. It hasn't. I've looked at the code a little, but I haven't found an answer yet. I'm a novice with the hive code, and I didn't do the original work on this ticket - I'm just trying to get it finished. I'll probably need to find time to find or write a test case to verify the behavior. On Wed, Sep 17, 2014 at 10:27 PM, Lefty Leverenz (JIRA) > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: david serafini > Attachments: HIVE-7100.1.patch, HIVE-7100.10.patch, > HIVE-7100.2.patch, HIVE-7100.3.patch, HIVE-7100.4.patch, HIVE-7100.5.patch, > HIVE-7100.8.patch, HIVE-7100.9.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140006#comment-14140006 ] Xuefu Zhang commented on HIVE-7100: --- [~dbsalti], would you like to address the above question/concern? Thanks. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: david serafini > Attachments: HIVE-7100.1.patch, HIVE-7100.10.patch, > HIVE-7100.2.patch, HIVE-7100.3.patch, HIVE-7100.4.patch, HIVE-7100.5.patch, > HIVE-7100.8.patch, HIVE-7100.9.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14138531#comment-14138531 ] Lefty Leverenz commented on HIVE-7100: -- bq. What should the behavior of drop table be for an immutable table? With and without the purge option? Has this been answered yet? > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: david serafini > Attachments: HIVE-7100.1.patch, HIVE-7100.10.patch, > HIVE-7100.2.patch, HIVE-7100.3.patch, HIVE-7100.4.patch, HIVE-7100.5.patch, > HIVE-7100.8.patch, HIVE-7100.9.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14138523#comment-14138523 ] Hive QA commented on HIVE-7100: --- {color:green}Overall{color}: +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12669271/HIVE-7100.10.patch {color:green}SUCCESS:{color} +1 6283 tests passed Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/852/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/852/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-852/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12669271 > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: david serafini > Attachments: HIVE-7100.1.patch, HIVE-7100.10.patch, > HIVE-7100.2.patch, HIVE-7100.3.patch, HIVE-7100.4.patch, HIVE-7100.5.patch, > HIVE-7100.8.patch, HIVE-7100.9.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136572#comment-14136572 ] Xuefu Zhang commented on HIVE-7100: --- +1 pending on test result. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: david serafini > Attachments: HIVE-7100.1.patch, HIVE-7100.10.patch, > HIVE-7100.2.patch, HIVE-7100.3.patch, HIVE-7100.4.patch, HIVE-7100.5.patch, > HIVE-7100.8.patch, HIVE-7100.9.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134155#comment-14134155 ] david serafini commented on HIVE-7100: -- I don't understand why patch #9 didn't apply. It has only a couple minor changes from patch#8, to fix typos. Does this indicate that the code I'm diff'ing against is too far behind trunk? Or did something significant change in the repo in the past few days? thanks. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: david serafini > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.5.patch, HIVE-7100.8.patch, HIVE-7100.9.patch, > HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132632#comment-14132632 ] Hive QA commented on HIVE-7100: --- {color:red}Overall{color}: -1 no tests executed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12668474/HIVE-7100.9.patch Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/777/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/777/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-777/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hive-ptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ [[ -n /usr/java/jdk1.7.0_45-cloudera ]] + export JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera + JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera + export PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/java/jdk1.6.0_34/bin:/usr/local/apache-maven-3.0.5/bin:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.6.0_34/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin + PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/java/jdk1.6.0_34/bin:/usr/local/apache-maven-3.0.5/bin:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.6.0_34/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + cd /data/hive-ptest/working/ + tee /data/hive-ptest/logs/PreCommit-HIVE-TRUNK-Build-777/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ svn = \s\v\n ]] + [[ -n '' ]] + [[ -d apache-svn-trunk-source ]] + [[ ! -d apache-svn-trunk-source/.svn ]] + [[ ! -d apache-svn-trunk-source ]] + cd apache-svn-trunk-source + svn revert -R . Reverted 'ql/src/test/results/clientpositive/drop_index.q.out' Reverted 'ql/src/test/queries/clientpositive/drop_index.q' Reverted 'ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java' ++ awk '{print $2}' ++ egrep -v '^X|^Performing status on external' ++ svn status --no-ignore + rm -rf target datanucleus.log ant/target shims/target shims/0.20/target shims/0.20S/target shims/0.23/target shims/aggregator/target shims/common/target shims/common-secure/target packaging/target hbase-handler/target testutils/target jdbc/target metastore/target itests/target itests/hcatalog-unit/target itests/test-serde/target itests/qtest/target itests/hive-unit-hadoop2/target itests/hive-minikdc/target itests/hive-unit/target itests/custom-serde/target itests/util/target hcatalog/target hcatalog/core/target hcatalog/streaming/target hcatalog/server-extensions/target hcatalog/webhcat/svr/target hcatalog/webhcat/java-client/target hcatalog/hcatalog-pig-adapter/target accumulo-handler/target hwi/target common/target common/src/gen service/target contrib/target serde/target beeline/target odbc/target cli/target ql/dependency-reduced-pom.xml ql/target + svn update Fetching external item into 'hcatalog/src/test/e2e/harness' External at revision 1624721. At revision 1624721. + patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hive-ptest/working/scratch/build.patch + [[ -f /data/hive-ptest/working/scratch/build.patch ]] + chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh + /data/hive-ptest/working/scratch/smart-apply-patch.sh /data/hive-ptest/working/scratch/build.patch The patch does not appear to apply with p0, p1, or p2 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12668474 > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: david serafini > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.5.patch, HIVE-7100.8.patch, HIVE-7100.9.patch, > HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping t
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128907#comment-14128907 ] Xuefu Zhang commented on HIVE-7100: --- Patch looks good to me. I have a minor comment on RB. BTW, could you please fill in the review request a title reflecting this JIRA and also JIRA number for "Bugs" field for easy navigation? > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.5.patch, HIVE-7100.8.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127387#comment-14127387 ] david serafini commented on HIVE-7100: -- done. HIVE-7100.8.patch uploaded to RB. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.5.patch, HIVE-7100.8.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127313#comment-14127313 ] Xuefu Zhang commented on HIVE-7100: --- [~dbsalti] Could you please update RB with your latest patch? > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.5.patch, HIVE-7100.8.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127298#comment-14127298 ] Mithun Radhakrishnan commented on HIVE-7100: [~dbsalti], [~xuefuz], I agree. Another JIRA for dropPartitions(). > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.5.patch, HIVE-7100.8.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126278#comment-14126278 ] Hive QA commented on HIVE-7100: --- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12667253/HIVE-7100.8.patch {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 6188 tests executed *Failed tests:* {noformat} org.apache.hive.jdbc.miniHS2.TestHiveServer2.testConnection {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/697/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/697/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-697/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12667253 > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.5.patch, HIVE-7100.8.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14125895#comment-14125895 ] Xuefu Zhang commented on HIVE-7100: --- [~dbsalti] I agree that same option when dropping partition can be done via a different JIRA. However, the comments on RB about the APIs seems valid. and what's your thought on that. I'd prefer we add new APIs to make the param passing consistent. The old API can be gradually deprecated. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.5.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14125831#comment-14125831 ] david serafini commented on HIVE-7100: -- I think both of these ideas are good, but beyond the scope of this ticket. dropPartitions is certainly worth doing, but is different from the use case for dropTable. And changing the table configuration should be discussed first to make sure it's a good idea. I'd prefer to finish this ticket as-is and open a new ticket for each of the other ideas. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.5.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14122135#comment-14122135 ] Mithun Radhakrishnan commented on HIVE-7100: Hey, David, et al. I've taken a look at the patch you have so far. (You should see some comments on RB.) Thanks for working on solving this. In its current form, patch(.5) attempts to solve the problem for dropTable(), and leaves a TODO for dropPartitions(). I'd like very much to see the solution extended to dropPartitions(). Did you run into something hard in the partitions-case? (The {{HCatClient}} API would need to expose PURGE as an option. That won't be difficult.) Question: Would it be possible to introduce a PURGE.default parameter to TBLPROPERTIES for a table? I have users that face the same problem as the one you're solving, but in the context of dropPartitions. While I approve of the ability to dropPartitions(purge=true) on a per-call basis, I'd also like the ability to choose the default drop-action (if ifPurge isn't set), on a per table-level. This way: # Table-owners can decide whether to spam their ~/.Trash on drop. # The user wouldn't need to change their Hive script (or Oozie action, or HCatClient call), to be able to skipTrash. # AFAICT, it'll not conflict with Sushanth's work on HIVE-6465, which might just store the new table-semantics in TBLPROPERTIES. I don't know if the protocol need be complicated: || Use-case || {{dropTable(purge=)}} || {{dropTable(purge=true)}} || | Default (e.g. pre-existing tables) | Dropped data goes to ~/.Trash | Trash skipped | | Tables with PURGE.default=true | Trash skipped | Trash skipped | When HiveQL language support is added, {{DROP TABLE my_table PURGE}} will call {{dropTable(purge=true)}}, and behave identically. {{dropPartitions()}} would work in similar fashion. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.5.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120958#comment-14120958 ] Lefty Leverenz commented on HIVE-7100: -- Thanks [~dbsalti], the javadoc comments look good. I hope you'll get a code review soon. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.5.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119293#comment-14119293 ] Hive QA commented on HIVE-7100: --- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12666077/HIVE-7100.5.patch {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 6145 tests executed *Failed tests:* {noformat} org.apache.hive.service.TestHS2ImpersonationWithRemoteMS.testImpersonation {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/609/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/609/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-609/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12666077 > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.5.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118929#comment-14118929 ] david serafini commented on HIVE-7100: -- Done. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118906#comment-14118906 ] Lefty Leverenz commented on HIVE-7100: -- Yes, you got it. Congratulations. Now there's one more step -- create a link between this JIRA ticket and the review board item. At the top of this JIRA page, use "More" > "Link" (near the bottom of the list) > "Web Link" (left side of the Link window). > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118758#comment-14118758 ] david serafini commented on HIVE-7100: -- I tried to add group hive and put back the diffs. Is that better? > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118715#comment-14118715 ] Lefty Leverenz commented on HIVE-7100: -- Did you follow these instructions? https://www.reviewboard.org/docs/manual/2.0/users/review-requests/creating/ > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118594#comment-14118594 ] Lefty Leverenz commented on HIVE-7100: -- > The RB UI is very difficult to use. Agreed, the RB confuses me frequently so I'm not the best person to help you with it. That said, your review request still isn't available except for the summary -- no diff appears. On the right side of the summary page, there's an area for Information and Reviewers. Under Reviewers, Groups should say "hive". Here's a recent example: https://reviews.apache.org/r/25179/. But I don't know how you do that. I'll poke around in the UI and see if I can figure it out. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118555#comment-14118555 ] david serafini commented on HIVE-7100: -- Did that work? The RB UI is very difficult to use. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118501#comment-14118501 ] Xuefu Zhang commented on HIVE-7100: --- [~dbsalti] Could you please make your RB request public so that people can access? > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118444#comment-14118444 ] Xuefu Zhang commented on HIVE-7100: --- Please give me a couple of days and I will get to it. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118426#comment-14118426 ] david serafini commented on HIVE-7100: -- Could somebody please review this? We have a pressing need for this functionality and would much prefer to use an accepted solution. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114672#comment-14114672 ] david serafini commented on HIVE-7100: -- https://reviews.apache.org/r/25178/ > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114317#comment-14114317 ] Lefty Leverenz commented on HIVE-7100: -- You can set up a review board account here: https://reviews.apache.org/account/register/. RB documentation: https://www.reviewboard.org/docs/manual/2.0/ Hive review requests: https://reviews.apache.org/groups/hive/ > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114292#comment-14114292 ] david serafini commented on HIVE-7100: -- No. I'm not set up to use RB. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113209#comment-14113209 ] Xuefu Zhang commented on HIVE-7100: --- Can we have a RB entry for the changes? > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107698#comment-14107698 ] david serafini commented on HIVE-7100: -- I don't think these failures are from my changes. I updated my trunk and cant reproduce them locally, and when I rebased my branch to trunk I can't reproduce them either. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106795#comment-14106795 ] Hive QA commented on HIVE-7100: --- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12663513/HIVE-7100.4.patch {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 6118 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_8 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_parquet_join org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_dynpart_sort_opt_vectorization {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/457/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/457/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-457/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12663513 > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.4.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104975#comment-14104975 ] Hive QA commented on HIVE-7100: --- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12663154/HIVE-7100.3.patch {color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 6101 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_drop_table_purge org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_parquet_join org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_dynpart_sort_opt_vectorization org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_stats_counter org.apache.hive.jdbc.miniHS2.TestHiveServer2.testConnection {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/422/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/422/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-422/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 5 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12663154 > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.3.patch, > HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098135#comment-14098135 ] Hive QA commented on HIVE-7100: --- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12661903/HIVE-7100.2.patch {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 5899 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_drop_table_purge org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_dynpart_sort_opt_vectorization {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/317/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/317/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-317/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12661903 > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.2.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059486#comment-14059486 ] Ravi Prakash commented on HIVE-7100: What should the behavior of drop table be for an immutable table? With and without the purge option? > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047408#comment-14047408 ] Ashutosh Chauhan commented on HIVE-7100: I think this should be considered in conjunction with HIVE-6465 cc: [~sushanth] > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14043889#comment-14043889 ] Jayesh commented on HIVE-7100: -- Sure, created HIVE-7289 for reverting patch. I ll updated this patch accordingly once we have HIVE-7289 committed. Thanks! > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14043703#comment-14043703 ] Xuefu Zhang commented on HIVE-7100: --- I think it might be better if we revert HIVE-6469 separately and mark it as not valid. Then, we can commit a patch here to add the purge option at syntax level. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.1.patch, HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031582#comment-14031582 ] Xuefu Zhang commented on HIVE-7100: --- [~ashutoshc] Since you voiced opinion before, do you have any thoughts on the above proposal? > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14030351#comment-14030351 ] Ravi Prakash commented on HIVE-7100: Purge is an acceptable option for us. Thanks > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029927#comment-14029927 ] Xuefu Zhang commented on HIVE-7100: --- [~jhsenjaliya] This seems just getting more and more complicated. I'd like to hear other's opinion, but I'm open to: 1. Revert HIVE-6469. 2. Expand the drop table syntax to: DROP TABLE table_name [PURGE] skipTrash is a no-go because it's too implementation specific, but PURGE seems more generic and acceptable, which hides the implementation. Let's wait for others to chime in. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029867#comment-14029867 ] Jayesh commented on HIVE-7100: -- Proposal 2: we keep HIVE-6469 (hive.warehouse.data.skipTrash=true/false) and introduce new hive.warehouse.skipTrash.control=client/admin which enables client to override default or admin setting for hive.warehouse.data.skipTrash if set to "client" and vice versa if set to "admin". Please let us know what do you think? suggestion? Thanks Jay > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017134#comment-14017134 ] Jayesh commented on HIVE-7100: -- {quote} If your concern was being unable to read the the global hive.warehouse.data.skipTrash option value from client code, this seems to be a bug that can be fixed. But the patch seems to abandon whatever HIVE-6469 provides and provide the functionality thru a client API. {quote} sorry, my earlier comment about this was bit misleading. I wanted to say following, In local metastore mode: If user set hive.warehouse.data.skipTrash to true from hive client, It also updates the configuration on metastore side, ( essentially communicating the configuration change) I believe this is due to metastore running on same JVM as client driver. In remote metastore mode: If user set hive.warehouse.data.skipTrash to true from hive client, It does not updates the configuration on metastore side,(i.e. it still remains false) I believe this is due to metastore running on separate JVM, and not communicating configuration set by hive client driver which could be right behavior by design. so Yes, The purpose of the patch is to provide a way for client to specify whether to skip trash while dropping the table. (by setting configuration hive.warehouse.data.skipTrash from hive client driver) . Please also note that this configuration can also be set by admin to make required default behavior but client ultimately controls the configuration. Is this right behavior ? Thanks Jay > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016217#comment-14016217 ] Xuefu Zhang commented on HIVE-7100: --- If I understand correctly, the patch provides a metastore client API that can take a skipTrash option when droppring a table/partition. While this doesn't change SQL syntax, it seems creating a backdoor to allow a client to drop table with skipTrash on/off regardless of the admin option, thus defeating the purpose of an admin option. This doesn't seem to be a config driven, but rather a security concern. If your concern was being unable to read the the global hive.warehouse.data.skipTrash option value from client code, this seems to be a bug that can be fixed. But the patch seems to abandon whatever HIVE-6469 provides and provide the functionality thru a client API. Did I miss anything? > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > Attachments: HIVE-7100.patch > > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004116#comment-14004116 ] Xuefu Zhang commented on HIVE-7100: --- Please share the proposal when it's ready. > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash >Assignee: Jayesh > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-7100) Users of hive should be able to specify skipTrash when dropping tables.
[ https://issues.apache.org/jira/browse/HIVE-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003927#comment-14003927 ] Ravi Prakash commented on HIVE-7100: This is a follow on from HIVE-6469, which went only half-way in providing the required functionality > Users of hive should be able to specify skipTrash when dropping tables. > --- > > Key: HIVE-7100 > URL: https://issues.apache.org/jira/browse/HIVE-7100 > Project: Hive > Issue Type: Improvement >Affects Versions: 0.13.0 >Reporter: Ravi Prakash > > Users of our clusters are often running up against their quota limits because > of Hive tables. When they drop tables, they have to then manually delete the > files from HDFS using skipTrash. This is cumbersome and unnecessary. We > should enable users to skipTrash directly when dropping tables. > We should also be able to provide this functionality without polluting SQL > syntax. -- This message was sent by Atlassian JIRA (v6.2#6252)